@exodus/bitcoin-api 2.26.1 → 2.27.0

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.27.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.26.1...@exodus/bitcoin-api@2.27.0) (2024-10-17)
+
+
+### Features
+
+* **bitcoin-api:** remove bn.js dep ([#4150](https://github.com/ExodusMovement/assets/issues/4150)) ([70082ff](https://github.com/ExodusMovement/assets/commit/70082ffd5f1ffbd5537c7978f6fa1c4333cb8bc9))
+* **bitcoin-api:** use 'sig' keychain enc ([#4154](https://github.com/ExodusMovement/assets/issues/4154)) ([4c9fe45](https://github.com/ExodusMovement/assets/commit/4c9fe454fdf9a1bda3bd683ccde2359ecdabf584))
+* btc-like unconfirmed received ([#4277](https://github.com/ExodusMovement/assets/issues/4277)) ([70d4b73](https://github.com/ExodusMovement/assets/commit/70d4b73811acd87265ad2c1fcf984afb5a89df73))
+* cleaner dogecoin bitcoinjs-lib ([#4111](https://github.com/ExodusMovement/assets/issues/4111)) ([5f21273](https://github.com/ExodusMovement/assets/commit/5f212734d9ea732fdf74f9affafb10facdc6a828))
+
+
+### Bug Fixes
+
+* harden derivation path map with null prototype ([#4067](https://github.com/ExodusMovement/assets/issues/4067)) ([6c900cf](https://github.com/ExodusMovement/assets/commit/6c900cf1e285d129f66c4aa98fdeb811d13a23c4))
+* reduce max pubkeys for multisig to 16 ([#4108](https://github.com/ExodusMovement/assets/issues/4108)) ([8c4c33b](https://github.com/ExodusMovement/assets/commit/8c4c33b08c5dc0786d601887e08b413a780b32a7))
+* remove stray direct dependencies ([#4176](https://github.com/ExodusMovement/assets/issues/4176)) ([c4f93fa](https://github.com/ExodusMovement/assets/commit/c4f93fad5a930b40d326d7add1093b2d4f243f2a))
+
+
+
 ## [2.26.1](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.26.0...@exodus/bitcoin-api@2.26.1) (2024-09-30)
 
 **Note:** Version bump only for package @exodus/bitcoin-api

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/bitcoin-api",
-  "version": "2.26.1",
+  "version": "2.27.0",
   "description": "Exodus bitcoin-api",
   "type": "module",
   "main": "src/index.js",
@@ -22,21 +22,19 @@
   "dependencies": {
     "@exodus/asset-lib": "^5.0.0",
     "@exodus/basic-utils": "^3.0.1",
-    "@exodus/bip32": "^3.1.0",
+    "@exodus/bip32": "^3.3.0",
     "@exodus/bip322-js": "^1.1.0",
     "@exodus/bip44-constants": "^195.0.0",
     "@exodus/bitcoin-lib": "^2.4.2",
     "@exodus/bitcoinjs": "^1.1.0",
-    "@exodus/crypto": "^1.0.0-rc.12",
+    "@exodus/crypto": "^1.0.0-rc.13",
     "@exodus/currency": "^5.0.2",
-    "@exodus/key-identifier": "^1.1.1",
+    "@exodus/key-identifier": "^1.3.0",
     "@exodus/models": "^12.0.1",
     "@exodus/simple-retry": "^0.0.6",
     "bech32": "^1.1.3",
     "bip32-path": "^0.4.2",
-    "bn.js": "^4.12.0",
     "bs58check": "^2.1.2",
-    "coininfo": "^5.1.0",
     "delay": "^4.0.1",
     "lodash": "^4.17.21",
     "minimalistic-assert": "^1.0.1",
@@ -47,7 +45,6 @@
     "wif": "^2.0.6"
   },
   "devDependencies": {
-    "@exodus/assets-testing": "^1.0.0",
     "@exodus/bitcoin-meta": "^2.0.0",
     "jest-when": "^3.5.1"
   },
@@ -59,5 +56,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "3258bee267b1a1d64ddf62bc17f66a9fc07c9329"
+  "gitHead": "3218754fdfad087b6d789eb81f7fe9f21b636fef"
 }

package/src/balances.js

@@ -1,6 +1,7 @@
+import { getUnconfirmedSentBalance } from '@exodus/asset-lib'
 import assert from 'minimalistic-assert'
 
-import { getUtxos } from './utxos-utils.js'
+import { getUnconfirmedUtxos, getUtxos } from './utxos-utils.js'
 
 // known issue!! fee data is static here!
 // Hydra's balances's module does not provide it when calling asset.api.getBalances
@@ -40,9 +41,14 @@ export const getBalancesFactory = ({ feeData, getSpendableBalance, ordinalsEnabl
       txSet: txLog,
       feeData,
     })
+
+    const unconfirmedUtxos = getUnconfirmedUtxos({ utxos })
+    const unconfirmedSent = getUnconfirmedSentBalance({ asset, txLog })
     return {
       total: balance,
       spendable: spendableBalance,
+      unconfirmedReceived: unconfirmedUtxos.value,
+      unconfirmedSent,
       // legacy
       balance,
       spendableBalance,

package/src/fee/can-bump-tx.js

@@ -3,7 +3,7 @@ import assert from 'minimalistic-assert'
 
 import { findUnconfirmedSentRbfTxs } from '../tx-utils.js'
 import { getUnconfirmedTxAncestorMap } from '../unconfirmed-ancestor-data.js'
-import { getUsableUtxos, getUtxos } from '../utxos-utils.js'
+import { getUsableUtxos, getUtxos, isUtxoConfirmed } from '../utxos-utils.js'
 import { selectUtxos } from './utxo-selector.js'
 
 export const ASSET_NAMES = ['bitcoin', 'bitcoinregtest', 'bitcointestnet']
@@ -76,7 +76,7 @@ const _canBumpTx = ({
   // Can't bump a non-rbf tx with no change
   if (!bumpTx && changeUtxos.size === 0) return { errorMessage: 'no change' }
   // Can't bump a confirmed tx
-  if (!bumpTx && changeUtxos.toArray().every(({ confirmations }) => confirmations > 0))
+  if (!bumpTx && changeUtxos.toArray().every(isUtxoConfirmed))
     return { errorMessage: 'already confirmed' }
   // Can't bump an rbf tx if change is already spent
   if (bumpTx && bumpTx.data.changeAddress && changeUtxos.size === 0)

package/src/fee/fee-utils.js

@@ -3,6 +3,7 @@ import { UtxoCollection } from '@exodus/models'
 import assert from 'minimalistic-assert'
 
 import { resolveExtraFeeOfTx } from '../unconfirmed-ancestor-data.js'
+import { isUtxoConfirmed } from '../utxos-utils.js'
 
 export const isHex = (s) => typeof s === 'string' && /[\da-f]*/.test(s.toLowerCase())
 
@@ -14,7 +15,7 @@ export function getExtraFee({ asset, inputs, feePerKB, unconfirmedTxAncestor })
     (inputs instanceof UtxoCollection || !Array.isArray(inputs))
   ) {
     const feeRate = feePerKB.toBaseNumber() / 1000
-    const utxos = [...inputs].filter(({ confirmations }) => !confirmations || confirmations <= 0)
+    const utxos = [...inputs].filter((utxo) => !isUtxoConfirmed(utxo))
     const txIds = new Set(utxos.map(({ txId }) => txId))
     for (const txId of txIds) {
       extraFee += resolveExtraFeeOfTx({

package/src/multisig-address.js

@@ -13,7 +13,7 @@ const DUMMY_TAPROOT_PUBKEY = Buffer.from(
 const LEAF_VERSION_TAPSCRIPT = 192
 
 // Limit multisig keys to 16 for now
-const MAX_PUBKEYS = 20
+const MAX_PUBKEYS = 16
 
 export const createEncodeMultisigContract =
   ({ bitcoinjsLib = defaultBitcoinjsLib, network = bitcoinjsLib.Network.bitcoin, ecc }) =>

package/src/parse-unsigned-tx.js

@@ -1,6 +1,5 @@
 import { Transaction as BitcoinTransactionClass } from '@exodus/bitcoinjs'
 import BIPPath from 'bip32-path'
-import BN from 'bn.js'
 import lodash from 'lodash'
 import assert from 'minimalistic-assert'
 
@@ -10,8 +9,8 @@ export const parseUnsignedTxFactory =
     const assetName = asset.name
 
     const toNumberUnit = (value) => {
-      const parsedValue = Buffer.isBuffer(value) ? new BN(value, 10, 'le') : value // handle Dogecoin buffer values
-      return asset.currency.baseUnit(parsedValue).toDefault()
+      const parsed = Buffer.isBuffer(value) ? BigInt('0x' + value.reverse().toString('hex')) : value // handle Dogecoin buffer values
+      return asset.currency.baseUnit(parsed)
     }
 
     const parseAddress = assetName === 'bcash' ? asset.address.toCashAddress : (address) => address
@@ -33,7 +32,7 @@ export const parseUnsignedTxFactory =
     inputs.forEach(({ txId, vout, value }) => {
       const tx = inputTxsById.get(txId)
       const output = tx.outs[vout]
-      const expected = assetName === 'dogecoin' ? output.valueBuffer : output.value
+      const expected = output.value
       assert(
         lodash.isEqual(expected, value),
         `${txId} tx input has invalid value. Expected: ${expected} , Actual: ${value}`

package/src/tx-sign/create-get-key-and-purpose.js

@@ -30,11 +30,11 @@ export const createGetKeyWithMetadata = ({
   })
 
 function getPrivateKeyFromMap(privateKeysAddressMap, networkInfo, purpose, address) {
-  const privateKey = getOwnProperty(privateKeysAddressMap, address, 'string')
-  assert(privateKey, `there is no private key for address ${address}`)
-  const key = ECPair.fromWIF(privateKey, networkInfo)
-  const publicKey = privateKeyToPublicKey({ privateKey: key.privateKey, format: 'buffer' })
-  return { key, purpose, publicKey }
+  const privateWif = getOwnProperty(privateKeysAddressMap, address, 'string')
+  assert(privateWif, `there is no private key for address ${address}`)
+  const { privateKey } = ECPair.fromWIF(privateWif, networkInfo)
+  const publicKey = privateKeyToPublicKey({ privateKey, format: 'buffer' })
+  return { privateKey, publicKey, purpose }
 }
 
 function getPrivateKeyFromHDKeys(hdkeys, addressPathsMap, networkInfo, purpose, address) {
@@ -44,9 +44,9 @@ function getPrivateKeyFromHDKeys(hdkeys, addressPathsMap, networkInfo, purpose,
   const hdkey = hdkeys[purpose]
   assert(hdkey, `hdkey for purpose for ${purpose} and address ${address} could not be resolved`)
   const derivedhdkey = hdkey.derive(path)
-  const key = ECPair.fromPrivateKey(derivedhdkey.privateKey, { network: networkInfo })
+  const { privateKey } = ECPair.fromPrivateKey(derivedhdkey.privateKey, { network: networkInfo })
   const publicKey = derivedhdkey.publicKey
-  return { key, publicKey, purpose }
+  return { privateKey, publicKey, purpose }
 }
 
 async function getPublicKeyFromSigner(signer, addressPathsMap, purpose, address, getKeyIdentifier) {
@@ -55,5 +55,5 @@ async function getPublicKeyFromSigner(signer, addressPathsMap, purpose, address,
   const [chainIndex, addressIndex] = BipPath.fromString(addressPath).toPathArray()
   const keyId = new KeyIdentifier(getKeyIdentifier({ purpose, chainIndex, addressIndex }))
   const publicKey = await signer.getPublicKey({ keyId })
-  return { purpose, keyId, publicKey }
+  return { keyId, publicKey, purpose }
 }

package/src/tx-sign/create-sign-with-wallet.js

@@ -11,7 +11,6 @@ export function createSignWithWallet({
   privateKeysAddressMap,
   addressPathsMap,
   coinInfo,
-  network,
   getKeyIdentifier,
 }) {
   const getKeyWithMetadata = createGetKeyWithMetadata({
@@ -42,7 +41,7 @@ export function createSignWithWallet({
         sigHash === undefined
           ? undefined // `SIGHASH_DEFAULT` is a default safe sig hash, always allow it.
           : [sigHash, Transaction.SIGHASH_ALL]
-      const { key, purpose, keyId, publicKey } = await getKeyWithMetadata(address)
+      const { keyId, privateKey, publicKey, purpose } = await getKeyWithMetadata(address)
 
       const isTaprootInput = bip371.isTaprootInput(input)
       const isTapLeafScriptSpend = input.tapLeafScript && input.tapLeafScript.length > 0
@@ -74,8 +73,8 @@ export function createSignWithWallet({
       }
 
       const asyncSigner = signer
-        ? await toAsyncBufferSigner({ signer, isTaprootKeySpend, purpose, keyId })
-        : toAsyncSigner({ keyPair: key, isTaprootKeySpend, network })
+        ? await toAsyncBufferSigner({ signer, isTaprootKeySpend, keyId })
+        : toAsyncSigner({ privateKey, isTaprootKeySpend })
 
       // desktop / BE / mobile with bip-schnorr signing
       signingPromises.push(psbt.signInputAsync(index, asyncSigner, allowedSigHashTypes))

package/src/tx-sign/default-create-tx.js

@@ -1,3 +1,4 @@
+import { Psbt as DefaultPsbt, Transaction as DefaultTransaction } from '@exodus/bitcoinjs'
 import assert from 'minimalistic-assert'
 
 import { extractTransaction } from './common.js'
@@ -10,6 +11,8 @@ export const signTxFactory = ({
   coinInfo,
   network,
   getKeyIdentifier,
+  Psbt = DefaultPsbt,
+  Transaction = DefaultTransaction,
 }) => {
   assert(assetName, 'assetName is required')
   assert(resolvePurpose, 'resolvePurpose is required')
@@ -19,6 +22,8 @@ export const signTxFactory = ({
     assetName,
     resolvePurpose,
     coinInfo,
+    Psbt,
+    Transaction,
   })
 
   return async ({ unsignedTx, hdkeys, privateKeysAddressMap, signer }) => {

package/src/tx-sign/default-prepare-for-signing.js

@@ -1,4 +1,4 @@
-import { Psbt, Transaction } from '@exodus/bitcoinjs'
+import { Psbt as DefaultPsbt, Transaction as DefaultTransaction } from '@exodus/bitcoinjs'
 import assert from 'minimalistic-assert'
 
 const _MAXIMUM_FEE_RATES = {
@@ -11,7 +11,13 @@ const _MAXIMUM_FEE_RATES = {
  * @param { assetName, resolvePurpose, coinInfo} dependencies
  * @returns A prepareForSigning function that returns a PSBTv1 as buffer
  */
-export function createPrepareForSigning({ assetName, resolvePurpose, coinInfo }) {
+export function createPrepareForSigning({
+  assetName,
+  resolvePurpose,
+  coinInfo,
+  Psbt = DefaultPsbt,
+  Transaction = DefaultTransaction,
+}) {
   assert(assetName, 'assetName is required')
   assert(resolvePurpose, 'resolvePurpose is required')
   assert(coinInfo, 'coinInfo is required')
@@ -26,6 +32,7 @@ export function createPrepareForSigning({ assetName, resolvePurpose, coinInfo })
     if (isPsbtBufferPassed) {
       // PSBT created externally (Web3, etc..)
       return createPsbtFromBuffer({
+        Psbt,
         psbtBuffer: unsignedTx.txData.psbtBuffer,
         networkInfo,
       })
@@ -37,6 +44,8 @@ export function createPrepareForSigning({ assetName, resolvePurpose, coinInfo })
       ...unsignedTx.txMeta,
       resolvePurpose,
       networkInfo,
+      Psbt,
+      Transaction,
     })
     if (!['bitcoin', 'bitcoinregtest', 'bitcointestnet'].includes(assetName)) psbt.setVersion(1)
 
@@ -45,12 +54,21 @@ export function createPrepareForSigning({ assetName, resolvePurpose, coinInfo })
 }
 
 // Creates a PSBT instance from the passed transaction buffer provided by 3rd parties (e.g. dApps).
-function createPsbtFromBuffer({ psbtBuffer, ecc, networkInfo }) {
+function createPsbtFromBuffer({ Psbt, psbtBuffer, ecc, networkInfo }) {
   return Psbt.fromBuffer(psbtBuffer, { eccLib: ecc, network: networkInfo })
 }
 
 // Creates a PSBT instance from the passed inputs, outputs etc. The wallet itself provides this data.
-function createPsbtFromTxData({ inputs, outputs, rawTxs, networkInfo, resolvePurpose, assetName }) {
+function createPsbtFromTxData({
+  inputs,
+  outputs,
+  rawTxs,
+  networkInfo,
+  resolvePurpose,
+  assetName,
+  Psbt,
+  Transaction,
+}) {
   // use harcoded max fee rates for specific assets
   // if undefined, will be set to default value by PSBT (2500)
   const maximumFeeRate = _MAXIMUM_FEE_RATES[assetName]
@@ -79,7 +97,7 @@ function createPsbtFromTxData({ inputs, outputs, rawTxs, networkInfo, resolvePur
       // non-witness outptus require the full transaction
       assert(!!rawTx, 'Non-witness outputs require the full previous transaction.')
       const rawTxBuffer = Buffer.from(rawTx.rawData, 'hex')
-      if (canParseTx(rawTxBuffer)) {
+      if (canParseTx(Transaction, rawTxBuffer)) {
         txIn.nonWitnessUtxo = rawTxBuffer
       } else {
         // temp fix for https://exodusio.slack.com/archives/CP202D90Q/p1671014704829939 until bitcoinjs could parse a mweb tx without failing
@@ -99,7 +117,7 @@ function createPsbtFromTxData({ inputs, outputs, rawTxs, networkInfo, resolvePur
   return psbt
 }
 
-const canParseTx = (rawTxBuffer) => {
+const canParseTx = (Transaction, rawTxBuffer) => {
   try {
     Transaction.fromBuffer(rawTxBuffer)
     return true

package/src/tx-sign/default-sign-hardware.js

@@ -76,7 +76,7 @@ function createSignWithHardwareWallet({ assetName, resolvePurpose }) {
 }
 
 function getDerivationPathsMap({ resolvePurpose, accountIndex, addressPathsMap }) {
-  const derivationPathsMap = {}
+  const derivationPathsMap = Object.create(null)
   for (const [address, path] of Object.entries(addressPathsMap)) {
     const purpose = resolvePurpose(address)
     const derivationPath = `m/${purpose}'/0'/${accountIndex}'/${path.slice(2)}` // TODO: coinindex

package/src/tx-sign/taproot.js

@@ -1,67 +1,60 @@
-import { crypto, ECPair } from '@exodus/bitcoinjs'
-import { tiny_secp256k1_compat as ecc } from '@exodus/crypto/secp256k1'
+import { crypto } from '@exodus/bitcoinjs'
+import * as secp256k1 from '@exodus/crypto/secp256k1'
 import assert from 'minimalistic-assert'
 
 import defaultEntropy from './default-entropy.cjs'
 
-function tweakSigner({ signer, tweakHash, network }) {
-  assert(signer, 'signer is required')
-
-  let privateKey = signer.privateKey
-  if (!privateKey) {
-    throw new Error('Private key is required for tweaking signer!')
-  }
-
-  if (signer.publicKey[0] === 3) {
-    privateKey = ecc.privateNegate(privateKey)
-  }
-
-  const tweakedPrivateKey = ecc.privateAdd(privateKey, tapTweakHash(signer.publicKey, tweakHash))
-  if (!tweakedPrivateKey) {
-    throw new Error('Invalid tweaked private key!')
-  }
-
-  return ECPair.fromPrivateKey(Buffer.from(tweakedPrivateKey), {
-    network,
-  })
+function tweakPrivateKey({ privateKey, tweakHash }) {
+  assert(privateKey, 'Private key is required for tweaking signer!')
+  const publicKey = secp256k1.privateKeyToPublicKey({ privateKey, format: 'buffer' })
+  if (publicKey[0] === 3) privateKey = secp256k1.privateKeyTweakNegate({ privateKey })
+  const tweak = tapTweakHash(publicKey, tweakHash)
+  return secp256k1.privateKeyTweakAdd({ privateKey, tweak, format: 'buffer' })
 }
 
 export const tweakPublicKey = ({ publicKey, tweak }) => {
-  const xOnlyPub = ecc.xOnlyPointFromPoint(publicKey)
-  const { parity, xOnlyPubkey } = ecc.xOnlyPointAddTweak(xOnlyPub, tweak)
-
-  return Buffer.from([parity ? 0x03 : 0x02, ...xOnlyPubkey])
+  // This is different from secp256k1.publicKeyTweakAddScalar when publicKey[0] is 3
+  const xOnly = secp256k1.publicKeyToX({ publicKey })
+  return secp256k1.xOnlyTweakAdd({ xOnly, tweak, format: 'buffer' })
 }
 
 export const tapTweakHash = (publicKey, h) => {
-  const xOnlyPoint = ecc.xOnlyPointFromPoint(publicKey)
-  return crypto.taggedHash('TapTweak', Buffer.concat(h ? [xOnlyPoint, h] : [xOnlyPoint]))
+  const xOnly = secp256k1.publicKeyToX({ publicKey })
+  return crypto.taggedHash('TapTweak', Buffer.concat(h ? [xOnly, h] : [xOnly]))
 }
 
-/**
- * Take a sync signer and make it async.
- */
-export function toAsyncSigner({ keyPair, isTaprootKeySpend, network }) {
-  assert(keyPair, 'keyPair is required')
-
-  if (isTaprootKeySpend) {
-    keyPair = tweakSigner({ signer: keyPair, network })
+export function toAsyncSigner({ keyPair, privateKey, isTaprootKeySpend }) {
+  if (keyPair && !privateKey) {
+    // compat mode to avoid a breaking change
+    // TODO: remove in semver-major
+    privateKey = keyPair.privateKey
+    keyPair = null
   }
 
-  // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
-  keyPair.sign = async (h) => {
-    const sig = ecc.sign(h, keyPair.privateKey)
-    return Buffer.from(sig)
-  }
+  assert(privateKey, 'privateKey is required')
+  assert(!keyPair, 'keyPair is not supported, use privateKey')
 
-  // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
-  keyPair.signSchnorr = async (h) => {
-    // defaultEntropy.getSchnorrEntropy() is mockable with jest.spyOn
-    const sig = ecc.signSchnorr(h, keyPair.privateKey, defaultEntropy.getSchnorrEntropy())
-    return Buffer.from(sig)
-  }
+  if (isTaprootKeySpend) privateKey = tweakPrivateKey({ privateKey })
+  const publicKey = secp256k1.privateKeyToPublicKey({ privateKey, format: 'buffer' })
 
-  return keyPair
+  return {
+    sign: async (hash) =>
+      secp256k1.ecdsaSignHash({
+        hash,
+        privateKey,
+        extraEntropy: null, // TODO: can we flip this to true?
+        format: 'buffer',
+      }),
+    signSchnorr: async (data) =>
+      secp256k1.schnorrSign({
+        data,
+        privateKey,
+        extraEntropy: defaultEntropy.getSchnorrEntropy(), // mockable with jest.spyOn
+        format: 'buffer',
+      }),
+    publicKey,
+    privateKey,
+  }
 }
 
 // signer: {
@@ -69,7 +62,7 @@ export function toAsyncSigner({ keyPair, isTaprootKeySpend, network }) {
 //   getPublicKey: ({ keyId }) => Promise<Buffer>
 // }
 //
-export async function toAsyncBufferSigner({ signer, purpose, keyId, isTaprootKeySpend }) {
+export async function toAsyncBufferSigner({ signer, keyId, isTaprootKeySpend }) {
   let tweak
   let publicKey = await signer.getPublicKey({ keyId })
   if (isTaprootKeySpend) {
@@ -79,12 +72,7 @@ export async function toAsyncBufferSigner({ signer, purpose, keyId, isTaprootKey
 
   return {
     sign: async (data) => {
-      const ecOptions = { canonical: true }
-      const sig = await signer.sign({ data, keyId, ecOptions, enc: 'raw', signatureType: 'ecdsa' })
-      const signature = new Uint8Array(64)
-      signature.set(sig.r.toArrayLike(Uint8Array, 'be', 32), 0)
-      signature.set(sig.s.toArrayLike(Uint8Array, 'be', 32), 32)
-      return Buffer.from(signature)
+      return signer.sign({ data, keyId, enc: 'sig', signatureType: 'ecdsa' })
     },
     signSchnorr: async (data) => {
       return signer.sign({

package/src/utxos-utils.js

@@ -200,9 +200,16 @@ export function partitionUtxos({
   }
 }
 
+export const isUtxoConfirmed = (utxo) => utxo.confirmations > 0
+
 export function getConfirmedUtxos({ utxos }) {
   assert(utxos, 'utxos is required')
-  return utxos.filter(({ confirmations }) => confirmations > 0)
+  return utxos.filter(isUtxoConfirmed)
+}
+
+export function getUnconfirmedUtxos({ utxos }) {
+  assert(utxos, 'utxos is required')
+  return utxos.filter((utxo) => !isUtxoConfirmed(utxo))
 }
 
 export function getConfirmedOrRfbDisabledUtxos({ utxos, allowUnconfirmedRbfEnabledUtxos }) {