@exodus/bitcoin-api 2.15.1 → 2.17.0

package/CHANGELOG.md

@@ -0,0 +1,172 @@
+# Change Log
+
+All notable changes to this project will be documented in this file.
+See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+
+## [2.17.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.16.0...@exodus/bitcoin-api@2.17.0) (2024-06-12)
+
+
+### Features
+
+* allow signSchnorr for non-taproot ([#2545](https://github.com/ExodusMovement/assets/issues/2545)) ([5f459fd](https://github.com/ExodusMovement/assets/commit/5f459fd89e571a8e880a52dda93e8a7ead0012a5))
+
+
+
+## [2.16.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.15.1...@exodus/bitcoin-api@2.16.0) (2024-05-28)
+
+
+### Features
+
+* allow address mocking in bitcoin monitor ([#2347](https://github.com/ExodusMovement/assets/issues/2347)) ([e11800d](https://github.com/ExodusMovement/assets/commit/e11800d2e8592580f837b4b272e44238230e8709))
+* use asset config to override gap limit ([#2410](https://github.com/ExodusMovement/assets/issues/2410)) ([47f2840](https://github.com/ExodusMovement/assets/commit/47f2840e51c4f157a5bdbb72fce9423c2b733660))
+
+
+
+## [2.15.1](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.15.0...@exodus/bitcoin-api@2.15.1) (2024-05-22)
+
+
+### Bug Fixes
+
+* async signing of bitcoin transaction ([#2343](https://github.com/ExodusMovement/assets/issues/2343)) ([6924e83](https://github.com/ExodusMovement/assets/commit/6924e832090737abce600393129e7e5b4f278f40))
+
+
+
+## [2.15.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.14.1...@exodus/bitcoin-api@2.15.0) (2024-05-10)
+
+
+### Features
+
+* buffer signing for BTC ([#2059](https://github.com/ExodusMovement/assets/issues/2059)) ([4616324](https://github.com/ExodusMovement/assets/commit/46163247b24d130318b4cd69814a3b4863e89ce1)), closes [#2234](https://github.com/ExodusMovement/assets/issues/2234)
+
+
+
+## [2.14.1](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.14.0...@exodus/bitcoin-api@2.14.1) (2024-05-09)
+
+
+### Bug Fixes
+
+* brc20 fee estimation ([#2229](https://github.com/ExodusMovement/assets/issues/2229)) ([191c997](https://github.com/ExodusMovement/assets/commit/191c997dcd39fea82d4d79780eff200d8d81bc10))
+
+
+
+## [2.14.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.13.0...@exodus/bitcoin-api@2.14.0) (2024-05-07)
+
+
+### Features
+
+* **bitcoin-plugin:** add `web3.simulateTransaction` API ([#2220](https://github.com/ExodusMovement/assets/issues/2220)) ([a3f66bb](https://github.com/ExodusMovement/assets/commit/a3f66bb4e1ee2565a5cdf370de22577521944403))
+
+
+
+## [2.13.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.12.1...@exodus/bitcoin-api@2.13.0) (2024-04-25)
+
+
+### Features
+
+* **bitcoin:** taproot multisig address creation and signing ([#2132](https://github.com/ExodusMovement/assets/issues/2132)) ([179a6e4](https://github.com/ExodusMovement/assets/commit/179a6e4fc875cfe1e616dcc67478ae473706e7c1))
+* replace custom ecc with bitcoinerlab fork ([#1926](https://github.com/ExodusMovement/assets/issues/1926)) ([312374f](https://github.com/ExodusMovement/assets/commit/312374f350cabd46e460d5fa1790ee83b4b8d38b))
+
+
+
+## [2.12.1](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.12.0...@exodus/bitcoin-api@2.12.1) (2024-04-22)
+
+
+### Bug Fixes
+
+* bitcoin ordinals and brc20 fee calculation ([#2130](https://github.com/ExodusMovement/assets/issues/2130)) ([f43e7d3](https://github.com/ExodusMovement/assets/commit/f43e7d35030b8e093b8f9247b469377d53bc9ca8))
+
+
+
+## [2.12.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.10.1...@exodus/bitcoin-api@2.12.0) (2024-04-16)
+
+
+### Features
+
+* add getPrepareSendTransaction and make it available in bitcoin api ([#2060](https://github.com/ExodusMovement/assets/issues/2060)) ([4891835](https://github.com/ExodusMovement/assets/commit/489183511f20e5bff59c4d3babe198d08e1bbef1))
+* **bitcoin:** add `asset.api.signMessage` ([#1993](https://github.com/ExodusMovement/assets/issues/1993)) ([a3c53c8](https://github.com/ExodusMovement/assets/commit/a3c53c808bc68c524122e88c433083ccbb8691c2))
+
+
+### Bug Fixes
+
+* add exodus user agent to headers in bitcoin websocket ([#1996](https://github.com/ExodusMovement/assets/issues/1996)) ([d553881](https://github.com/ExodusMovement/assets/commit/d553881a572847c787025d9ce92c73e52128e6a3))
+* btc send refactoring missing params ([#2063](https://github.com/ExodusMovement/assets/issues/2063)) ([9d2ea7f](https://github.com/ExodusMovement/assets/commit/9d2ea7fcf6d322a121c83e4aed863eb13f89faa9))
+
+
+
+## [2.11.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.10.1...@exodus/bitcoin-api@2.11.0) (2024-04-15)
+
+
+### Features
+
+* add getPrepareSendTransaction and make it available in bitcoin api ([#2060](https://github.com/ExodusMovement/assets/issues/2060)) ([4891835](https://github.com/ExodusMovement/assets/commit/489183511f20e5bff59c4d3babe198d08e1bbef1))
+
+
+### Bug Fixes
+
+* add exodus user agent to headers in bitcoin websocket ([#1996](https://github.com/ExodusMovement/assets/issues/1996)) ([d553881](https://github.com/ExodusMovement/assets/commit/d553881a572847c787025d9ce92c73e52128e6a3))
+* btc send refactoring missing params ([#2063](https://github.com/ExodusMovement/assets/issues/2063)) ([9d2ea7f](https://github.com/ExodusMovement/assets/commit/9d2ea7fcf6d322a121c83e4aed863eb13f89faa9))
+
+
+
+## [2.10.1](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.10.0...@exodus/bitcoin-api@2.10.1) (2024-04-01)
+
+
+### Bug Fixes
+
+* doge number unit private access ([#1929](https://github.com/ExodusMovement/assets/issues/1929)) ([9ebb009](https://github.com/ExodusMovement/assets/commit/9ebb009fd730659a14877dd3f7af709868e7bdac))
+
+
+
+## [2.10.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.9.6...@exodus/bitcoin-api@2.10.0) (2024-03-28)
+
+
+### Features
+
+* **bitcoin:** Port priority fee sorting ([#1885](https://github.com/ExodusMovement/assets/issues/1885)) ([e217547](https://github.com/ExodusMovement/assets/commit/e217547b0b4dbc92bf3e908acd42a6f26d4be1c6))
+
+
+### Bug Fixes
+
+* Revert "fix: @noble/secp256k1 to use @noble/hashes ([#1850](https://github.com/ExodusMovement/assets/issues/1850))" ([#1915](https://github.com/ExodusMovement/assets/issues/1915)) ([a2d89ad](https://github.com/ExodusMovement/assets/commit/a2d89ad7892c33382c3754fe8a8eab247d311fb1))
+
+
+
+## [2.9.6](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.9.5...@exodus/bitcoin-api@2.9.6) (2024-03-22)
+
+
+### Bug Fixes
+
+* @noble/secp256k1 to use @noble/hashes ([#1850](https://github.com/ExodusMovement/assets/issues/1850)) ([c7d64be](https://github.com/ExodusMovement/assets/commit/c7d64be1a3aca822d039572c9b89068777758643))
+
+
+
+## [2.9.5](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.9.3...@exodus/bitcoin-api@2.9.5) (2024-03-18)
+
+
+### Performance Improvements
+
+* remove bip-schnorr custom implementation ([#1783](https://github.com/ExodusMovement/assets/issues/1783)) ([f07a177](https://github.com/ExodusMovement/assets/commit/f07a17740cf21b0945dd487ad37ee76c9a0ac2ac))
+
+
+## [2.9.4](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.9.3...@exodus/bitcoin-api@2.9.4) (2024-03-18)
+
+
+### Performance Improvements
+
+* bitcoin unfork bitcoinjs and bolt11 dependencies ([#1730](https://github.com/ExodusMovement/assets/issues/1730)) ([94fd0b9](https://github.com/ExodusMovement/assets/commit/94fd0b94fab17a7876dac7fdf0b708bcda115403))
+
+
+
+
+
+## [2.9.3](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.9.2...@exodus/bitcoin-api@2.9.3) (2024-02-28)
+
+
+### Bug Fixes
+
+* do not expose bitcoin private key in error message ([#1596](https://github.com/ExodusMovement/assets/issues/1596)) ([ea247b4](https://github.com/ExodusMovement/assets/commit/ea247b4295b9f96e379406c7574245a9934fd1b1))
+
+
+### Reverts
+
+* Revert "Publish" ([adb8015](https://github.com/ExodusMovement/assets/commit/adb8015efd51a4fa36ad0c86c28cb2d94c52a578))

package/package.json

@@ -1,20 +1,21 @@
 {
   "name": "@exodus/bitcoin-api",
-  "version": "2.15.1",
+  "version": "2.17.0",
   "description": "Exodus bitcoin-api",
   "main": "src/index.js",
   "files": [
     "src",
+    "CHANGELOG.md",
     "!src/**/__tests__"
   ],
-  "author": "Exodus",
+  "author": "Exodus Movement, Inc.",
   "license": "ISC",
   "publishConfig": {
     "access": "restricted"
   },
   "scripts": {
     "test": "run -T jest",
-    "lint": "run -T eslint ./src",
+    "lint": "run -T eslint .",
     "lint:fix": "yarn lint --fix"
   },
   "dependencies": {
@@ -22,30 +23,30 @@
     "@exodus/basic-utils": "^2.1.0",
     "@exodus/bip322-js": "^1.1.0-exodus.4",
     "@exodus/bip44-constants": "^195.0.0",
-    "@exodus/bitcoin-lib": "2.3.0",
+    "@exodus/bitcoin-lib": "^2.3.0",
     "@exodus/bitcoinerlab-secp256k1": "^1.0.5-exodus.1",
     "@exodus/bitcoinjs-lib": "^6.1.5-exodus.1",
     "@exodus/currency": "^2.3.2",
     "@exodus/fetch": "^1.3.0",
     "@exodus/key-identifier": "^1.1.1",
     "@exodus/models": "^11.0.0",
-    "@exodus/simple-retry": "0.0.6",
+    "@exodus/simple-retry": "^0.0.6",
     "@exodus/timer": "^1.0.0",
     "bech32": "^1.1.3",
     "bip32-path": "^0.4.2",
-    "bn.js": "4.12.0",
+    "bn.js": "^4.12.0",
     "bs58check": "^2.1.2",
-    "coininfo": "5.1.0",
+    "coininfo": "^5.1.0",
     "create-hash": "^1.2.0",
-    "delay": "4.0.1",
-    "ecpair": "2.0.1",
+    "delay": "^4.0.1",
+    "ecpair": "^2.0.1",
     "lodash": "^4.17.21",
     "minimalistic-assert": "^1.0.1",
     "ms": "^2.1.1",
     "secp256k1": "^3.0.1",
-    "socket.io-client": "2.1.1",
-    "tiny-secp256k1": "1.1.3",
-    "url-join": "4.0.0",
+    "socket.io-client": "^2.1.1",
+    "tiny-secp256k1": "^1.1.3",
+    "url-join": "^4.0.0",
     "varuint-bitcoin": "^1.1.0",
     "wif": "^2.0.6"
   },
@@ -58,5 +59,13 @@
     "jest-when": "^3.5.1",
     "safe-buffer": "^5.2.1"
   },
-  "gitHead": "19c4a56008f41bfc7001a6b7b8d2e4849b345d93"
+  "bugs": {
+    "url": "https://github.com/ExodusMovement/assets/issues?q=is%3Aissue+is%3Aopen+label%3Abitcoin-api"
+  },
+  "homepage": "https://github.com/ExodusMovement/assets/tree/master/bitcoin/bitcoin-api",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/ExodusMovement/assets.git"
+  },
+  "gitHead": "f815266bc50384027d966f37e44e9166c87ca938"
 }

package/src/btc-like-keys.js

@@ -4,7 +4,7 @@ import * as bech32 from 'bech32'
 import assert from 'minimalistic-assert'
 import { identity, pickBy } from 'lodash'
 import * as defaultBitcoinjsLib from '@exodus/bitcoinjs-lib'
-import secp256k1 from 'secp256k1'
+import * as secp256k1 from 'secp256k1'
 import { hash160 } from './hash-utils'
 import { toXOnly } from './bitcoinjs-lib/ecc-utils'
 import { eccFactory } from './bitcoinjs-lib/ecc'

package/src/move-funds.js

@@ -2,7 +2,7 @@ import wif from 'wif'
 import { UtxoCollection, Address } from '@exodus/models'
 import { createInputs, createOutput, getNonWitnessTxs } from './tx-send'
 import assert from 'minimalistic-assert'
-import secp256k1 from 'secp256k1'
+import * as secp256k1 from 'secp256k1'
 
 const isValidPrivateKey = (privateKey) => {
   try {

package/src/tx-log/bitcoin-monitor-scanner.js

@@ -54,6 +54,15 @@ export class BitcoinMonitorScanner {
     this.#refreshGapLimit = refreshGapLimit
   }
 
+  async #getGapLimit({ walletAccount, assetName, refresh }) {
+    const assetConfig = await this.#assetClientInterface.getAssetConfig?.({
+      assetName,
+      walletAccount,
+    })
+    if (typeof assetConfig?.gapLimit === 'number') return assetConfig.gapLimit
+    return refresh ? this.#refreshGapLimit : this.#gapLimit
+  }
+
   async rescanBlockchainInsight({ walletAccount, refresh }) {
     const asset = this.#asset
     const assetClientInterface = this.#assetClientInterface
@@ -100,6 +109,8 @@ export class BitcoinMonitorScanner {
       assetName,
       walletAccount,
     })
+
+    const resolvedGapLimit = await this.#getGapLimit({ walletAccount, assetName, refresh })
     /*
      * The chain fields/variables are number arrays of size 2
      *
@@ -153,13 +164,23 @@ export class BitcoinMonitorScanner {
                 addressIndex,
               })
               .then((address) => {
+                const addressObject = this.#asset.address.toLegacyAddress
+                  ? Address.create(
+                      this.#asset.address.toLegacyAddress(String(address)),
+                      address.meta
+                    )
+                  : address
+
+                const addressString = String(addressObject)
+
+                if (addrMap[addressString]) {
+                  return null
+                }
+
+                addrMap[addressString] = addressObject
+
                 return {
-                  address: this.#asset.address.toLegacyAddress
-                    ? Address.create(
-                        this.#asset.address.toLegacyAddress(String(address)),
-                        address.meta
-                      )
-                    : address,
+                  address: addressObject,
                   purpose,
                 }
               })
@@ -168,9 +189,9 @@ export class BitcoinMonitorScanner {
       }
 
       const addresses = []
-      const result = await Promise.all(promises)
+      const allAddresses = await Promise.all(promises)
+      const result = allAddresses.filter(Boolean)
       result.forEach(({ address, purpose }) => {
-        addrMap[String(address)] = address
         purposeMap[String(address)] = purpose
         addresses.push(String(address))
       })
@@ -185,8 +206,9 @@ export class BitcoinMonitorScanner {
 
       const fetchAddressesSize = 25
       for (let i = 0; i < addresses.length; i += fetchAddressesSize) {
+        const fetchAddresses = addresses.slice(i, i + fetchAddressesSize)
         const promise = insightClient.fetchAllTxData(
-          addresses.slice(i, i + fetchAddressesSize),
+          fetchAddresses,
           txFetchLimit,
           fetchTimeout,
           shouldStop
@@ -224,8 +246,8 @@ export class BitcoinMonitorScanner {
         purpose,
         chain,
         startAddressIndexes: chain.map(() => 0),
-        endAddressIndexes: chain.map(
-          (addressIndex) => (refresh ? this.#refreshGapLimit : addressIndex + this.#gapLimit) // right of the || should never happen
+        endAddressIndexes: chain.map((addressIndex) =>
+          refresh ? resolvedGapLimit : addressIndex + resolvedGapLimit
         ),
       }
     })
@@ -336,7 +358,6 @@ export class BitcoinMonitorScanner {
         indexData.startAddressIndexes = [...indexData.endAddressIndexes]
         // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
         indexData.endAddressIndexes = indexData.chain.map((addressIndex) => {
-          const resolvedGapLimit = refresh ? this.#refreshGapLimit : this.#gapLimit
           return addressIndex + resolvedGapLimit
         })
       })

package/src/tx-sign/create-get-key-and-purpose.js

@@ -6,7 +6,7 @@ import KeyIdentifier from '@exodus/key-identifier'
 
 import { getECPair } from '../bitcoinjs-lib'
 
-import secp256k1 from 'secp256k1'
+import * as secp256k1 from 'secp256k1'
 
 const ECPair = getECPair()
 

package/src/tx-sign/taproot.js

@@ -94,10 +94,6 @@ export async function toAsyncBufferSigner({ signer, purpose, keyId, isTaprootKey
       return Buffer.from(signature)
     },
     signSchnorr: async (data) => {
-      assert(
-        isTaprootPurpose(purpose),
-        `signSchnorr: invalid purpose for schnorr signing: ${purpose}`
-      )
       return signer.sign({
         data,
         keyId,