@exodus/bip322-js 3.2.0 → 3.2.2

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [3.2.2](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/bip322-js@3.2.1...@exodus/bip322-js@3.2.2) (2026-06-29)
+
+### Bug Fixes
+
+- **bip322-js:** BIP137 segwit-flag signature verification ([#16085](https://github.com/ExodusMovement/exodus-hydra/issues/16085)) ([9363135](https://github.com/ExodusMovement/exodus-hydra/commit/9363135c13cef1a7b632d133adddb4fde8a28f04))
+
+## [3.2.1](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/bip322-js@3.2.0...@exodus/bip322-js@3.2.1) (2026-04-22)
+
+### Bug Fixes
+
+- fix(bip322-js): reject oversized DER R/S lengths (ECDSA malleability) (#16083)
+
 ## [3.2.0](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/bip322-js@3.1.0...@exodus/bip322-js@3.2.0) (2025-12-26)
 
 ### Features

package/dist/Address.d.ts

@@ -5,7 +5,7 @@ declare class Address {
     static isP2TR(address: string): boolean;
     static isP2WPKHWitness(witness: Buffer[]): boolean;
     static isSingleKeyP2TRWitness(witness: Buffer[]): boolean;
-    static convertAdressToScriptPubkey(address: string): Buffer;
+    static convertAdressToScriptPubkey(address: string): Buffer<ArrayBufferLike>;
     static convertPubKeyIntoAddress(publicKey: Buffer, addressType: 'p2pkh' | 'p2sh-p2wpkh' | 'p2wpkh' | 'p2tr'): {
         mainnet: string | undefined;
         testnet: string | undefined;

package/dist/BIP322.d.ts

@@ -1,6 +1,6 @@
 import * as bitcoin from '@exodus/bitcoinjs';
 declare class BIP322 {
-    static TAG: Buffer;
+    static TAG: Buffer<ArrayBuffer>;
     static hashMessage(message: string): any;
     static buildToSpendTx(message: string, scriptPublicKey: Buffer): bitcoin.Transaction;
     static buildToSignTx(toSpendTxId: string, witnessScript: Buffer, isRedeemScript?: boolean, tapInternalKey?: Buffer): bitcoin.Psbt;

package/dist/Signer.d.ts

@@ -1,5 +1,5 @@
 import * as bitcoin from '@exodus/bitcoinjs';
-import type { Signer as AssetSigner } from '@exodus/asset-types/src/signer';
+import type { Signer as AssetSigner } from '@exodus/asset-types';
 export declare const createSigner: (encodedKey: string | Buffer, network: bitcoin.Network) => {
     signer: {
         getPublicKey: () => Promise<any>;
@@ -15,7 +15,6 @@ export declare const createSigner: (encodedKey: string | Buffer, network: bitcoi
 };
 declare class Signer {
     #private;
-    static signAsync(signerOrKey: string | Buffer | AssetSigner, address: string, message: string, network?: bitcoin.Network): Promise<any>;
-    private static checkPubKeyCorrespondToAddress;
+    static signAsync(signerOrKey: string | Buffer | AssetSigner, address: string, message: string, network?: bitcoin.Network): Promise<string | Buffer<ArrayBufferLike>>;
 }
 export default Signer;

package/dist/Signer.js

@@ -63,7 +63,7 @@ class Signer {
     }
     static async #signAsyncInternal(signer, address, message, network = bitcoin.networks.bitcoin, compressed) {
         const publicKey = await signer.getPublicKey();
-        assert(this.checkPubKeyCorrespondToAddress(publicKey, address), `Invalid signer for address "${address}".`);
+        assert(this.#checkPubKeyCorrespondToAddress(publicKey, address), `Invalid signer for address "${address}".`);
         if (Address.isP2PKH(address)) {
             const asyncSigner = {
                 sign(hash, extraEntropy) {
@@ -103,7 +103,7 @@ class Signer {
         ]);
         return BIP322.encodeWitness(toSignTx.finalizeAllInputs());
     }
-    static checkPubKeyCorrespondToAddress(publicKey, claimedAddress) {
+    static #checkPubKeyCorrespondToAddress(publicKey, claimedAddress) {
         let derivedAddresses;
         if (Address.isP2PKH(claimedAddress)) {
             derivedAddresses = Address.convertPubKeyIntoAddress(publicKey, 'p2pkh');

package/dist/Verifier.d.ts

@@ -1,8 +1,5 @@
 declare class Verifier {
+    #private;
     static verifySignature(signerAddress: string, message: string, signature: Buffer): Promise<boolean>;
-    private static verifyBIP137Signature;
-    private static getHashForSigP2WPKH;
-    private static getHashForSigP2SHInP2WPKH;
-    private static getHashForSigP2TR;
 }
 export default Verifier;

package/dist/Verifier.js

@@ -11,7 +11,7 @@ class Verifier {
             throw new TypeError('signature must be a Buffer');
         }
         if (Address.isP2PKH(signerAddress) || BIP137.isBIP137Signature(signature)) {
-            return this.verifyBIP137Signature(signerAddress, message, signature);
+            return this.#verifyBIP137Signature(signerAddress, message, signature);
         }
         const scriptPubKey = Address.convertAdressToScriptPubkey(signerAddress);
         const toSpendTx = BIP322.buildToSpendTx(message, scriptPubKey);
@@ -27,7 +27,7 @@ class Verifier {
             const hashedPubkey = bitcoin.crypto.hash160(publicKey);
             let hashToSign;
             if (Address.isP2SH(signerAddress)) {
-                hashToSign = this.getHashForSigP2SHInP2WPKH(toSignTx, hashedPubkey);
+                hashToSign = this.#getHashForSigP2SHInP2WPKH(toSignTx, hashedPubkey);
                 const lockingScript = Buffer.concat([Buffer.from([0x00, 0x14]), hashedPubkey]);
                 const hashedLockingScript = bitcoin.crypto.hash160(lockingScript);
                 const hashedLockingScriptInScriptPubKey = scriptPubKey.subarray(2, -1);
@@ -36,7 +36,7 @@ class Verifier {
                 }
             }
             else {
-                hashToSign = this.getHashForSigP2WPKH(toSignTx);
+                hashToSign = this.#getHashForSigP2WPKH(toSignTx);
                 const hashedPubkeyInScriptPubkey = scriptPubKey.subarray(2);
                 if (Buffer.compare(hashedPubkey, hashedPubkeyInScriptPubkey) !== 0) {
                     return false;
@@ -52,11 +52,11 @@ class Verifier {
             let hashToSign;
             let signature;
             if (encodedSignature.byteLength === 64) {
-                hashToSign = this.getHashForSigP2TR(toSignTx, 0x00);
+                hashToSign = this.#getHashForSigP2TR(toSignTx, 0x00);
                 signature = encodedSignature;
             }
             else if (encodedSignature.byteLength === 65) {
-                hashToSign = this.getHashForSigP2TR(toSignTx, encodedSignature[64]);
+                hashToSign = this.#getHashForSigP2TR(toSignTx, encodedSignature[64]);
                 signature = encodedSignature.subarray(0, -1);
             }
             else {
@@ -66,12 +66,11 @@ class Verifier {
         }
         throw new Error('Only P2WPKH, P2SH-P2WPKH, and single-key-spend P2TR BIP-322 verification is supported. Unsupported address is provided.');
     }
-    static verifyBIP137Signature(signerAddress, message, signature) {
+    static #verifyBIP137Signature(signerAddress, message, signature) {
         if (Address.isP2PKH(signerAddress)) {
             return bitcoinMessage.verify(message, signerAddress, signature);
         }
         const publicKeySigned = BIP137.derivePubKey(message, signature);
-        const legacySigningAddress = Address.convertPubKeyIntoAddress(publicKeySigned, 'p2pkh').mainnet;
         if (Address.isP2SH(signerAddress)) {
             const p2shAddressDerived = Address.convertPubKeyIntoAddress(publicKeySigned, 'p2sh-p2wpkh');
             if (p2shAddressDerived.mainnet !== signerAddress &&
@@ -96,9 +95,9 @@ class Verifier {
         else {
             return false;
         }
-        return bitcoinMessage.verify(message, legacySigningAddress, signature);
+        return true;
     }
-    static getHashForSigP2WPKH(toSignTx) {
+    static #getHashForSigP2WPKH(toSignTx) {
         const signingScript = bitcoin.payments.p2pkh({
             hash: toSignTx.data.inputs[0].witnessUtxo.script.subarray(2),
         }).output;
@@ -106,7 +105,7 @@ class Verifier {
             .extractTransaction()
             .hashForWitnessV0(0, signingScript, 0, bitcoin.Transaction.SIGHASH_ALL);
     }
-    static getHashForSigP2SHInP2WPKH(toSignTx, hashedPubkey) {
+    static #getHashForSigP2SHInP2WPKH(toSignTx, hashedPubkey) {
         const signingScript = bitcoin.payments.p2pkh({
             hash: hashedPubkey,
         }).output;
@@ -114,7 +113,7 @@ class Verifier {
             .extractTransaction()
             .hashForWitnessV0(0, signingScript, 0, bitcoin.Transaction.SIGHASH_ALL);
     }
-    static getHashForSigP2TR(toSignTx, hashType) {
+    static #getHashForSigP2TR(toSignTx, hashType) {
         if (hashType !== bitcoin.Transaction.SIGHASH_DEFAULT &&
             hashType !== bitcoin.Transaction.SIGHASH_ALL) {
             throw new Error('Invalid SIGHASH used in signature. Must be either SIGHASH_ALL or SIGHASH_DEFAULT.');

package/dist/bitcoinjs/DecodeScriptSignature.js

@@ -12,8 +12,10 @@ export function decodeScriptSignature(buffer) {
 function fromDER(x) {
     if (x[0] === 0x00)
         x = x.slice(1);
+    if (x.length > 32)
+        throw new Error('Value length is too long');
     const buffer = Buffer.alloc(32, 0);
-    const bstart = Math.max(0, 32 - x.length);
+    const bstart = 32 - x.length;
     x.copy(buffer, bstart);
     return buffer;
 }
@@ -33,6 +35,8 @@ function decode2(buffer) {
         throw new Error('R length is zero');
     if (5 + lenR >= buffer.length)
         throw new Error('R length is too long');
+    if (lenR > 33)
+        throw new Error('R length is too long');
     if (buffer[4 + lenR] !== 0x02)
         throw new Error('Expected DER integer (2)');
     const lenS = buffer[5 + lenR];
@@ -40,6 +44,8 @@ function decode2(buffer) {
         throw new Error('S length is zero');
     if (6 + lenR + lenS !== buffer.length)
         throw new Error('S length is invalid');
+    if (lenS > 33)
+        throw new Error('S length is too long');
     if (buffer[4] & 0x80)
         throw new Error('R value is negative');
     if (lenR > 1 && buffer[4] === 0x00 && !(buffer[5] & 0x80)) {

package/dist/bitcoinjs-message-verify.d.ts

@@ -1 +1 @@
-export declare function verify(message: string, address: string, signature: Buffer, messagePrefix?: string, checkSegwitAlways?: boolean): boolean;
+export declare function verify(message: string, address: string, signature: Buffer | string, messagePrefix?: string, checkSegwitAlways?: boolean): boolean;

package/dist/helpers/BIP137.d.ts

@@ -1,6 +1,6 @@
 declare class BIP137 {
+    #private;
     static isBIP137Signature(signature: Buffer): boolean;
-    static derivePubKey(message: string, signature: Buffer): Buffer;
-    private static decodeSignature;
+    static derivePubKey(message: string, signature: Buffer): Buffer<ArrayBuffer>;
 }
 export default BIP137;

package/dist/helpers/BIP137.js

@@ -6,15 +6,15 @@ class BIP137 {
     }
     static derivePubKey(message, signature) {
         const messageHash = bitcoinMessage.magicHash(message);
-        const signatureDecoded = this.decodeSignature(signature);
+        const signatureDecoded = this.#decodeSignature(signature);
         const recoveredPublicKey = recoverPublicKey(messageHash, signatureDecoded.signature, signatureDecoded.recovery, signatureDecoded.compressed);
         return Buffer.from(recoveredPublicKey);
     }
-    static decodeSignature(signature) {
+    static #decodeSignature(signature) {
         if (signature.length !== 65)
             throw new Error('Invalid signature length');
         const flagByte = signature.readUInt8(0) - 27;
-        if (flagByte > 19 || flagByte < 0) {
+        if (flagByte > 15 || flagByte < 0) {
             throw new Error('Invalid signature parameter');
         }
         return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/bip322-js",
-  "version": "3.2.0",
+  "version": "3.2.2",
   "description": "A Javascript library that provides utility functions related to the BIP-322 signature scheme",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -15,12 +15,13 @@
     "!**/__tests__/**"
   ],
   "scripts": {
-    "build": "run -T tsc -p tsconfig.build.json",
-    "lint": "run -T eslint",
-    "lint:fix": "yarn lint --fix",
+    "build": "pnpm exec tsc -p tsconfig.build.json",
+    "lint": "pnpm exec eslint",
+    "lint:fix": "pnpm run lint --fix",
     "doc": "typedoc src/index.ts",
-    "test": "run -T exodus-test --jest --esbuild",
-    "prepublishOnly": "yarn run -T build --scope @exodus/bip322-js"
+    "test": "pnpm exec exodus-test --jest --esbuild",
+    "typecheck": "pnpm exec tsc -p tsconfig.json --noEmit",
+    "prepublishOnly": "pnpm -w run build --scope @exodus/bip322-js"
   },
   "keywords": [
     "bip322",
@@ -37,13 +38,13 @@
   "license": "MIT",
   "devDependencies": {
     "@types/minimalistic-assert": "^1.0.1",
-    "@types/node": "^20.2.5",
+    "@types/node": "^22.7.4",
     "ecpair": "^2.0.1",
     "typedoc": "^0.24.8",
     "typescript": "^5.1.3"
   },
   "dependencies": {
-    "@exodus/asset-types": "^0.3.0",
+    "@exodus/asset-types": "^0.5.0",
     "@exodus/bitcoinjs": "^2.0.0",
     "@exodus/bytes": "^1.0.0-rc.8",
     "@exodus/crypto": "^1.0.0-rc.26",
@@ -57,5 +58,5 @@
   "bugs": {
     "url": "https://github.com/ExodusMovement/exodus-hydra/issues?q=is%3Aissue+is%3Aopen+label%3Abip322-js"
   },
-  "gitHead": "dab4f446f30bf73babe598463627eaad6e14fa4b"
+  "gitHead": "8c91cf6b4dc913de523a9cc7dbb56ff871fefb14"
 }