@exodus/balances 13.5.0 → 13.5.2

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.5.2](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/balances@13.5.1...@exodus/balances@13.5.2) (2025-01-03)
+
+### Bug Fixes
+
+- fix: only compute balances for available assets (#10958)
+
+## [13.5.1](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/balances@13.5.0...@exodus/balances@13.5.1) (2024-11-29)
+
+### Bug Fixes
+
+- fix: balances map equality check (#10620)
+
 ## [13.5.0](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/balances@13.4.0...@exodus/balances@13.5.0) (2024-11-29)
 
 ### Features

package/atoms/asset-total-wallet-amounts.js

@@ -1,12 +1,13 @@
 import { compute, dedupe } from '@exodus/atoms'
 
-const mapsAreEqual = (mapA, mapB) => {
+const numberUnitMapsAreEqual = (mapA, mapB) => {
   if (mapA.size !== mapB.size) {
     return false
   }
 
-  for (const item of mapA) {
-    if (!mapB.has(item)) {
+  for (const [key, val] of mapA) {
+    const itemB = mapB.get(key)
+    if (!itemB || !itemB.equals(val)) {
       return false
     }
   }
@@ -21,19 +22,19 @@ const createAssetTotalWalletAmountsAtom = ({ balancesAtom }) => {
 
     Object.values(balances).forEach((accountBalances) => {
       Object.keys(accountBalances).forEach((assetName) => {
-        if (assetsWithBalances.has(assetName)) {
-          const currentAssetBalance = assetsWithBalances.get(assetName)
-          assetsWithBalances.set(
-            assetName,
-            accountBalances[assetName]?.balance.add(currentAssetBalance)
-          )
-        } else {
-          assetsWithBalances.set(assetName, accountBalances[assetName]?.balance)
+        const accountAssetBalance = accountBalances[assetName] && accountBalances[assetName].balance
+        if (accountAssetBalance) {
+          if (assetsWithBalances.has(assetName)) {
+            const currentAssetBalance = assetsWithBalances.get(assetName)
+            assetsWithBalances.set(assetName, accountAssetBalance.add(currentAssetBalance))
+          } else {
+            assetsWithBalances.set(assetName, accountAssetBalance)
+          }
         }
       })
     })
 
-    if (!mapsAreEqual(assetsWithBalances, previousValue)) {
+    if (!numberUnitMapsAreEqual(assetsWithBalances, previousValue)) {
       previousValue = assetsWithBalances
     }
 

package/module/index.js

@@ -1,6 +1,7 @@
 import { isNumberUnit } from '@exodus/currency'
 import { TxSet } from '@exodus/models'
 import lodash from 'lodash'
+import { difference as getChanges } from '@exodus/atoms'
 import { difference, flattenToPaths, pick, set } from '@exodus/basic-utils'
 import makeConcurrent from 'make-concurrent'
 import { processAssetBalances, validateBalances } from './balances-utils.js'
@@ -22,7 +23,7 @@ const zipNonNull = (keys, values) =>
 class Balances {
   #logger
   #assetsModule
-  #assetsAtom
+  #availableAssetNamesAtom
   #balanceFieldsConfig
   #balanceFields
   #walletAccounts = [] // string[]
@@ -38,7 +39,7 @@ class Balances {
 
   constructor({
     assetsModule,
-    assetsAtom,
+    availableAssetNamesAtom,
     enabledWalletAccountsAtom,
     config,
     logger,
@@ -48,7 +49,7 @@ class Balances {
   }) {
     this.#logger = logger
     this.#assetsModule = assetsModule
-    this.#assetsAtom = assetsAtom
+    this.#availableAssetNamesAtom = availableAssetNamesAtom
     this.#balanceFieldsConfig = config?.balanceFieldsConfig || defaultConfig.balanceFieldsConfig
     this.#balanceFields = config?.balanceFields || defaultConfig.balanceFields
     this.#balancesAtom = balancesAtom
@@ -101,10 +102,9 @@ class Balances {
           this.#handleTxLogUpdate({ walletAccount, assetName, txLog })
         )
       ),
-      this.#assetsAtom.observe(({ added }) => {
-        if (added.length > 0) {
-          this.#onAssetsChanged(added)
-        }
+      getChanges(this.#availableAssetNamesAtom).observe(({ previous = [], current }) => {
+        const added = difference(current, previous)
+        if (added.length > 0) this.#onAssetsChanged(added)
       })
     )
   }
@@ -217,7 +217,7 @@ class Balances {
 
   #onAssetsChanged = async (added) => {
     if (
-      added.every(({ name }) =>
+      added.every((name) =>
         this.#walletAccounts.every((walletAccount) => !!this.#balances?.[walletAccount]?.[name])
       )
     ) {
@@ -362,13 +362,13 @@ const balancesDefinition = {
   factory: createBalances,
   dependencies: [
     'assetsModule',
+    'availableAssetNamesAtom',
     'enabledWalletAccountsAtom',
     'config',
     'logger',
     'balancesAtom',
     'txLogsAtom',
     'accountStatesAtom',
-    'assetsAtom',
   ],
   public: true,
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/balances",
-  "version": "13.5.0",
+  "version": "13.5.2",
   "description": "Tracks crypto balances across enabled wallet accounts.",
   "author": "Exodus Movement, Inc.",
   "license": "MIT",
@@ -51,19 +51,19 @@
   "devDependencies": {
     "@exodus/assets": "^11.0.0",
     "@exodus/assets-base": "^10.0.0",
-    "@exodus/assets-feature": "^5.14.1",
+    "@exodus/assets-feature": "^6.0.1",
     "@exodus/available-assets": "^8.7.0",
     "@exodus/bitcoin-meta": "^2.0.0",
-    "@exodus/blockchain-metadata": "^15.7.0",
+    "@exodus/blockchain-metadata": "^15.7.1",
     "@exodus/ethereum-meta": "^2.0.0",
-    "@exodus/fee-data-monitors": "^5.0.2",
+    "@exodus/fee-data-monitors": "^5.0.3",
     "@exodus/storage-memory": "^2.2.2",
-    "@exodus/wallet-accounts": "^17.1.1",
+    "@exodus/wallet-accounts": "^17.1.3",
     "events": "^3.3.0",
     "redux": "^4.2.1"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "d979dacecad62ad66a5761afc08d6ea362ca05a5"
+  "gitHead": "2b30d69ddf8f4d0ebd3bcc4d4280d3ea12906673"
 }

package/plugins/analytics.js

@@ -27,7 +27,7 @@ const createBalancesAnalyticsPlugin = ({
       const assetBalances = assetsToTrackForBalances.reduce((acc, obj) => {
         acc[obj.analyticsName] = getAssetAmountFromNumberUnit(balances.get(obj.assetName))
         return acc
-      }, {})
+      }, Object.create(null))
       analytics.setDefaultEventProperties(assetBalances)
     })