@exodus/balances 13.0.1 → 13.1.1

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.1.1](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/balances@13.1.0...@exodus/balances@13.1.1) (2024-04-09)
+
+### Bug Fixes
+
+- don't recompute if asset already exist in balances ([#6410](https://github.com/ExodusMovement/exodus-hydra/issues/6410)) ([f7160cc](https://github.com/ExodusMovement/exodus-hydra/commit/f7160ccf90deb046a12f23f9f42bd78e74bb2859))
+
+## [13.1.0](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/balances@13.0.1...@exodus/balances@13.1.0) (2024-04-09)
+
+### Features
+
+- asset-names-with-balance atom ([#6406](https://github.com/ExodusMovement/exodus-hydra/issues/6406)) ([f006357](https://github.com/ExodusMovement/exodus-hydra/commit/f006357b81478fcb443d478d626cec89196f57cf))
+
+### Bug Fixes
+
+- use `assetNamesWithBalanceAtomDefinition` ([#6425](https://github.com/ExodusMovement/exodus-hydra/issues/6425)) ([9b65a23](https://github.com/ExodusMovement/exodus-hydra/commit/9b65a2367778d50c877a5c235784ee47938d101a))
+
 ## [13.0.1](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/balances@13.0.0...@exodus/balances@13.0.1) (2024-04-05)
 
 ### Bug Fixes

package/atoms/asset-names-with-balance.js

@@ -0,0 +1,40 @@
+import { compute, dedupe } from '@exodus/atoms'
+
+const setsAreEqual = (setA, setB) => {
+  if (setA.size !== setB.size) {
+    return false
+  }
+
+  for (const item of setA) {
+    if (!setB.has(item)) {
+      return false
+    }
+  }
+
+  return true
+}
+
+const createAssetNamesWithBalanceAtom = ({ balancesAtom }) => {
+  let previousValue = new Set()
+  const selector = ({ balances }) => {
+    const assetsWithBalances = new Set()
+
+    Object.values(balances).forEach((accountBalances) => {
+      Object.keys(accountBalances).forEach((assetName) => {
+        if (!accountBalances[assetName]?.balance.isZero) {
+          assetsWithBalances.add(assetName)
+        }
+      })
+    })
+
+    if (!setsAreEqual(assetsWithBalances, previousValue)) {
+      previousValue = assetsWithBalances
+    }
+
+    return previousValue
+  }
+
+  return dedupe(compute({ atom: balancesAtom, selector }))
+}
+
+export default createAssetNamesWithBalanceAtom

package/atoms/assets-with-balance-count.js

@@ -1,21 +1,8 @@
 import { compute } from '@exodus/atoms'
 
-const createAssetsWithBalanceCountAtom = ({ balancesAtom }) => {
-  const selector = ({ balances }) => {
-    const assetsWithBalances = new Set()
-
-    Object.values(balances).forEach((accountBalances) => {
-      Object.keys(accountBalances).forEach((assetName) => {
-        if (!accountBalances[assetName]?.balance.isZero) {
-          assetsWithBalances.add(assetName)
-        }
-      })
-    })
-
-    return assetsWithBalances.size
-  }
-
-  return compute({ atom: balancesAtom, selector })
+const createAssetsWithBalanceCountAtom = ({ assetNamesWithBalanceAtom }) => {
+  const selector = (assetNamesWithBalance) => assetNamesWithBalance.size
+  return compute({ atom: assetNamesWithBalanceAtom, selector })
 }
 
 export default createAssetsWithBalanceCountAtom

package/atoms/index.js

@@ -1,3 +1,4 @@
+import createAssetNamesWithBalanceAtom from './asset-names-with-balance'
 import createAssetsWithBalanceCountAtom from './assets-with-balance-count'
 import createBalancesAtom from './balances'
 import createFundedWalletAccountsAtom from './funded-wallet-accounts'
@@ -24,9 +25,16 @@ export const fundedWalletAccountsAtomDefinition = {
   dependencies: ['balancesAtom', 'enabledWalletAccountsAtom'],
 }
 
+export const assetNamesWithBalanceAtomDefinition = {
+  id: 'assetNamesWithBalanceAtom',
+  type: 'atom',
+  factory: createAssetNamesWithBalanceAtom,
+  dependencies: ['balancesAtom'],
+}
+
 export const assetsWithBalanceCountAtomDefinition = {
   id: 'assetsWithBalanceCountAtom',
   type: 'atom',
   factory: createAssetsWithBalanceCountAtom,
-  dependencies: ['balancesAtom'],
+  dependencies: ['assetNamesWithBalanceAtom'],
 }

package/index.js

@@ -4,6 +4,7 @@ import {
   hasBalanceAtomDefinition,
   fundedWalletAccountsAtomDefinition,
   assetsWithBalanceCountAtomDefinition,
+  assetNamesWithBalanceAtomDefinition,
 } from './atoms'
 import balancesReportDefinition from './report'
 import { balancesLifecyclePluginDefinition, balancesAnalyticsPluginDefinition } from './plugins'
@@ -32,6 +33,7 @@ const balances = (walletConfig) => {
         config,
       },
       { definition: balancesAtomDefinition },
+      { definition: assetNamesWithBalanceAtomDefinition },
       { definition: assetsWithBalanceCountAtomDefinition },
       {
         definition: hasBalanceAtomDefinition,

package/module/index.js

@@ -82,6 +82,7 @@ class Balances extends ExodusModule {
     this.#updateAssetSource = shareQueue(this.#updateAssetSource)
     this.#handleTxLogUpdate = shareQueue(this.#handleTxLogUpdate)
     this.#recompute = shareQueue(this.#recompute)
+    this.#onAssetsChanged = shareQueue(this.#onAssetsChanged)
     this.#getBalancesForAssetSource = captureErrors({
       fn: this.#getBalancesForAssetSource,
       name: 'getBalancesForAssetSource',
@@ -231,8 +232,15 @@ class Balances extends ExodusModule {
     }
   }
 
-  #onAssetsChanged = async () => {
-    // TODO: make this more efficient
+  #onAssetsChanged = async (added) => {
+    if (
+      added.every(({ name }) =>
+        this.#walletAccounts.every((walletAccount) => !!this.#balances?.[walletAccount]?.[name])
+      )
+    ) {
+      return
+    }
+
     this._logger.log('recomputing based on new assets list')
     this.#recompute()
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/balances",
-  "version": "13.0.1",
+  "version": "13.1.1",
   "description": "Tracks crypto balances across enabled wallet accounts.",
   "author": "Exodus Movement Inc.",
   "license": "UNLICENSED",
@@ -58,5 +58,5 @@
     "events": "^3.3.0",
     "redux": "^4.2.1"
   },
-  "gitHead": "06d142f0b1d195bc7e0a13805becad04a1da5c52"
+  "gitHead": "09df4e0ee6f7185f8d715c6db5a64f1e5a8efd76"
 }

package/plugins/analytics.js

@@ -6,14 +6,14 @@ const createBalancesAnalyticsPlugin = ({
   let subscriptions = []
 
   const onStart = () => {
-    analytics.requireDefaultProperties(['hasBalance', 'numberOfAssets'])
+    analytics.requireDefaultEventProperties(['hasBalance', 'numberOfAssets'])
 
     const unsubscribeBalanceAtom = hasBalanceAtom.observe((hasBalance) =>
-      analytics.setDefaultProperties({ hasBalance })
+      analytics.setDefaultEventProperties({ hasBalance })
     )
 
     const unsubscribeBalanceCountAtom = assetsWithBalanceCountAtom.observe((numberOfAssets) =>
-      analytics.setDefaultProperties({ numberOfAssets })
+      analytics.setDefaultEventProperties({ numberOfAssets })
     )
 
     subscriptions = [unsubscribeBalanceAtom, unsubscribeBalanceCountAtom]