@exodus/assets-feature 7.3.0 → 7.4.1

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.4.1](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/assets-feature@7.4.0...@exodus/assets-feature@7.4.1) (2025-05-15)
+
+### Bug Fixes
+
+- fix: stop assets-feature monitor on stop (#12460)
+
+## [7.4.0](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/assets-feature@7.3.0...@exodus/assets-feature@7.4.0) (2025-04-17)
+
+### Features
+
+- feat: validate tokens using asset-schema-validation (#12011)
+
 ## [7.3.0](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/assets-feature@7.2.2...@exodus/assets-feature@7.3.0) (2025-04-16)
 
 ### Features

package/client/asset-client-interface.js

@@ -118,6 +118,11 @@ class AssetClientInterface {
     accountState,
     batch = this.#blockchainMetadata.batch(),
   }) => {
+    const asset = this.#assetsModule.getAsset(assetName)
+    if (!asset.baseAsset.api.features.accountState) {
+      return batch
+    }
+
     // merge mem to keep the previous accountMem behavior
     if (!isEmpty(newData?.mem) && (!accountState || accountState.mem)) {
       newData = { ...newData, mem: { ...accountState?.mem, ...newData.mem } }
@@ -166,12 +171,8 @@ class AssetClientInterface {
     assert(asset, `assetName ${assetName} is not supported`)
     assert(walletAccountInstance, `walletAccountInstance ${walletAccount} is not available`)
 
-    const baseAsset = asset.baseAsset
-    const out = {
-      confirmationsNumber: baseAsset.api?.getConfirmationsNumber
-        ? baseAsset.api.getConfirmationsNumber()
-        : 1,
-    }
+    const confirmationsNumber = await this.getConfirmationsNumber({ assetName })
+    const out = { confirmationsNumber }
 
     const gapLimit =
       this.#config?.compatibilityModeGapLimits?.[walletAccountInstance.compatibilityMode]
@@ -223,12 +224,17 @@ class AssetClientInterface {
     addressIndex = 0,
     chainIndex = 0,
   }) => {
+    const [walletAccountInstance, defaultPurpose] = await Promise.all([
+      this.#getWalletAccount(walletAccount),
+      purpose === undefined
+        ? this.#assetSources.getDefaultPurpose({ assetName, walletAccount })
+        : undefined,
+    ])
     if (purpose === undefined) {
-      ;[purpose] = await this.getSupportedPurposes({ assetName, walletAccount })
+      purpose = defaultPurpose
     }
 
     const asset = this.#assetsModule.getAsset(assetName)
-    const walletAccountInstance = await this.#getWalletAccount(walletAccount)
     const keyIdentifier = asset.baseAsset.api.getKeyIdentifier({
       purpose,
       accountIndex: walletAccountInstance.index,
@@ -244,18 +250,18 @@ class AssetClientInterface {
   }
 
   getExtendedPublicKey = async ({ assetName, walletAccount, purpose }) => {
-    const asset = this.#assetsModule.getAsset(assetName)
-    const [walletAccountInstance, purposes] = await Promise.all([
+    const [walletAccountInstance, defaultPurpose] = await Promise.all([
       this.#getWalletAccount(walletAccount),
       purpose === undefined
-        ? await this.getSupportedPurposes({ assetName, walletAccount })
+        ? this.#assetSources.getDefaultPurpose({ assetName, walletAccount })
         : undefined,
     ])
 
     if (purpose === undefined) {
-      ;[purpose] = purposes
+      purpose = defaultPurpose
     }
 
+    const asset = this.#assetsModule.getAsset(assetName)
     const keyIdentifier = asset.baseAsset.api.getKeyIdentifier({
       purpose,
       accountIndex: walletAccountInstance.index,
@@ -322,7 +328,7 @@ class AssetClientInterface {
     })
   }
 
-  saveUnusedAddressIndexes = async () => {
+  saveUnusedAddressIndexes = async ({ assetName, walletAccount, changedUnusedAddressIndexes }) => {
     // no op!! getUnusedAddressIndexes loads from tx log, not from storage
   }
 

package/module/assets-module.js

@@ -17,6 +17,7 @@ import {
 } from './constants.js'
 import { getAssetFromAssetId, getFetchErrorMessage, isDisabledCustomToken } from './utils.js'
 import createFetchival from '@exodus/fetch/create-fetchival'
+import { validateCustomToken, isValidCustomToken } from '@exodus/asset-schema-validation'
 
 const { get, isEmpty, once, uniq } = lodash
 
@@ -78,7 +79,7 @@ export class AssetsModule {
   #customTokensServerUrl
   #updateableProps
   #iconsStorage
-  #validateCustomToken
+  #shouldValidateCustomToken
   #assetPlugins
   #combinedAssetsList
   #storageDataKey
@@ -100,7 +101,6 @@ export class AssetsModule {
     assetPlugins,
     assetsAtom,
     combinedAssetsList = [],
-    validateCustomToken = () => true,
     config = {},
     fetch,
     logger,
@@ -115,7 +115,7 @@ export class AssetsModule {
     this.#customTokensServerUrl = config.customTokensServerUrl || CT_DEFAULT_SERVER
     this.#updateableProps = [...CT_UPDATEABLE_PROPERTIES, 'version']
     this.#iconsStorage = iconsStorage
-    this.#validateCustomToken = validateCustomToken
+    this.#shouldValidateCustomToken = config.shouldValidateCustomToken ?? true
     this.#storageDataKey = config.storageDataKey || CT_DATA_KEY
     this.#storageTimestampKey = config.storageTimestampKey || CT_TIMESTAMP_KEY
     this.#customTokenUpdateInterval = config.customTokenUpdateInterval || CT_UPDATE_INTERVAL
@@ -223,11 +223,17 @@ export class AssetsModule {
     }
 
     const _token = await fetchTokenAndCacheError()
-    if (!this.#validateCustomToken(_token)) {
-      this.#logger.warn('Invalid Custom Token schema')
-      const err = new Error('Token did not pass validation')
-      this.#setCache(key, { cachedError: err })
-      throw err
+    if (this.#shouldValidateCustomToken) {
+      try {
+        validateCustomToken(_token)
+      } catch (e) {
+        this.#logger.warn(
+          `Token did not pass validation ${baseAssetName} ${assetId}. Error: ${e.message}`
+        )
+        const err = new Error('Token did not pass validation')
+        this.#setCache(key, { cachedError: err })
+        throw err
+      }
     }
 
     const token = normalizeToken(_token)
@@ -319,7 +325,7 @@ export class AssetsModule {
         ? await this.#fetch('tokens', { tokenNames: tokenNamesToFetch }, 'tokens')
         : []
 
-    const validTokens = fetchedTokens.filter(this.#validateCustomToken).map(normalizeToken)
+    const validTokens = fetchedTokens.filter(this.#isValidCustomToken).map(normalizeToken)
     if (validTokens.length !== fetchedTokens.length)
       this.#logger.warn('Invalid Custom Token schema')
 
@@ -402,7 +408,7 @@ export class AssetsModule {
       { baseAssetName: baseAssetNames, lifecycleStatus, query, excludeTags, pageNumber, pageSize },
       'tokens'
     )
-    const validTokens = tokens.filter(this.#validateCustomToken)
+    const validTokens = tokens.filter(this.#isValidCustomToken)
 
     if (validTokens.length !== tokens.length) this.#logger.warn('Invalid Custom Token schema')
 
@@ -419,7 +425,7 @@ export class AssetsModule {
 
   #fetchUpdates = async (assetVersions) => {
     const updatedTokens = await this.#fetch('updates', assetVersions, 'tokens')
-    const validatedTokens = updatedTokens.filter(this.#validateCustomToken).map(normalizeToken)
+    const validatedTokens = updatedTokens.filter(this.#isValidCustomToken).map(normalizeToken)
     if (validatedTokens.length !== updatedTokens.length) {
       this.#logger.warn('Invalid Custom Token schema')
     }
@@ -626,6 +632,14 @@ export class AssetsModule {
     return !lastUpdateDate || Date.now() - lastUpdateDate > this.#customTokenUpdateInterval
   }
 
+  #isValidCustomToken = (token) => {
+    if (!this.#shouldValidateCustomToken) {
+      return true
+    }
+
+    return isValidCustomToken(token)
+  }
+
   clear = async () =>
     this.#storage &&
     Promise.all([

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "@exodus/assets-feature",
-  "version": "7.3.0",
+  "version": "7.4.1",
   "license": "MIT",
   "description": "This Exodus SDK feature provides access to instances of all blockchain asset adapters supported by the wallet, and enables you to search for and add custom tokens at runtime.",
   "type": "module",
   "main": "index.js",
   "author": "Exodus Movement, Inc.",
   "scripts": {
-    "test": "run -T exodus-test --jest --esbuild",
+    "test": "run -T exodus-test --jest",
     "lint": "run -T eslint .",
     "lint:fix": "yarn lint --fix"
   },
@@ -36,6 +36,7 @@
   },
   "dependencies": {
     "@exodus/asset-lib": "^5.3.0",
+    "@exodus/asset-schema-validation": "^1.0.1",
     "@exodus/assets": "^11.3.0",
     "@exodus/atoms": "^9.0.0",
     "@exodus/basic-utils": "^4.0.0",
@@ -64,12 +65,12 @@
     "@exodus/fusion-local": "^2.1.0",
     "@exodus/keychain": "^7.3.0",
     "@exodus/logger": "^1.2.3",
-    "@exodus/models": "^12.8.2",
+    "@exodus/models": "^12.12.0",
     "@exodus/osmosis-plugin": "^1.3.3",
     "@exodus/public-key-provider": "^4.1.1",
     "@exodus/redux-dependency-injection": "^4.1.1",
     "@exodus/storage-memory": "^2.2.2",
-    "@exodus/wallet-accounts": "^17.5.1",
+    "@exodus/wallet-accounts": "^17.5.2",
     "@exodus/wild-emitter": "^1.0.0",
     "bip39": "^3.1.0",
     "events": "^3.3.0",
@@ -79,5 +80,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "272804211316a2713c003e48672dc60d8fb919f0"
+  "gitHead": "45dd4907f5d65078978854be2eb397e479730c85"
 }

package/plugin/index.js

@@ -80,6 +80,7 @@ const createAssetsPlugin = ({
   const onStop = () => {
     observers.forEach((observer) => observer.unregister())
     subscribers.forEach((unsubscribe) => unsubscribe())
+    customTokensMonitor?.stop()
   }
 
   const onClear = async () => {