@exodus/assets-feature 3.1.0 → 3.1.2

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [3.1.2](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/assets-feature@3.1.1...@exodus/assets-feature@3.1.2) (2023-09-28)
+
+### Bug Fixes
+
+- factory does not pass all parameters to module ([#4264](https://github.com/ExodusMovement/exodus-hydra/issues/4264)) ([9267fdd](https://github.com/ExodusMovement/exodus-hydra/commit/9267fddeb6e0e53ba519273c6c7d48fb2d574305))
+
+## [3.1.1](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/assets-feature@3.1.0...@exodus/assets-feature@3.1.1) (2023-09-20)
+
+### Bug Fixes
+
+- not all assets have api.hasFeature ([#4161](https://github.com/ExodusMovement/exodus-hydra/issues/4161)) ([1b60147](https://github.com/ExodusMovement/exodus-hydra/commit/1b601478423b7d288593809f1046649dd3b265c6))
+
 ## [3.1.0](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/assets-feature@3.0.0...@exodus/assets-feature@3.1.0) (2023-09-20)
 
 ### Features

package/client/asset-client-interface.js

@@ -32,6 +32,8 @@ class AssetClientInterface {
     }
   }
 
+  // txHistory interface
+
   getTxHistory = async ({ assetName, walletAccount }) => {
     return this.blockchainMetadata.getTxLog({ assetName, walletAccount })
   }
@@ -53,6 +55,21 @@ class AssetClientInterface {
     return batch.updateTxs({ assetName, walletAccount, txs })
   }
 
+  removeTxLog = async (params) => {
+    return this.removeTxLogBatch(params).commit()
+  }
+
+  removeTxLogBatch = ({
+    assetName,
+    walletAccount,
+    txs,
+    batch = this.blockchainMetadata.batch(),
+  }) => {
+    return batch.removeTxs({ assetName, walletAccount, txs })
+  }
+
+  // accountState interface
+
   async getAccountState({ assetName, walletAccount }) {
     return this.blockchainMetadata.getAccountState({ assetName, walletAccount })
   }
@@ -74,18 +91,7 @@ class AssetClientInterface {
     return batch
   }
 
-  removeTxLog = async (params) => {
-    return this.removeTxLogBatch(params).commit()
-  }
-
-  removeTxLogBatch = ({
-    assetName,
-    walletAccount,
-    txs,
-    batch = this.blockchainMetadata.batch(),
-  }) => {
-    return batch.removeTxs({ assetName, walletAccount, txs })
-  }
+  // walletAccounts interface
 
   async getWalletAccounts({ assetName }) {
     // In the future, the list of wallets may be different based on the provided assets
@@ -94,6 +100,8 @@ class AssetClientInterface {
     return Object.keys(await this.#enabledWalletAccountsAtom.get())
   }
 
+  // assets interface
+
   async getAssetsForNetwork({ baseAssetName }) {
     const availableAssetNames = new Set(await this.#availableAssetNamesAtom.get())
     return pickBy(
@@ -102,6 +110,8 @@ class AssetClientInterface {
     )
   }
 
+  // configParams interface
+
   async getConfirmationsNumber({ assetName }) {
     const baseAsset = this.assetsModule.getAsset(assetName).baseAsset
     return baseAsset.api?.getConfirmationsNumber ? baseAsset.api.getConfirmationsNumber() : 1
@@ -116,12 +126,20 @@ class AssetClientInterface {
     return this.feeMonitors.getFeeData({ assetName: baseAssetName })
   }
 
+  getFeeConfig = async ({ assetName }) => {
+    return this.feeMonitors.getFeeData({ assetName })
+  }
+
+  // batch interface
+
   // The interface consumer does not need to know the structure of the returned batch object, just
   // that it needs to be passed along wherever operations need to be batched.
   createOperationsBatch = () => this.blockchainMetadata.batch()
 
   executeOperationsBatch = async (batch) => batch.commit()
 
+  // addresses interface
+
   getPublicKey = async ({ assetName, walletAccount, addressIndex = 0, chainIndex = 0 }) => {
     const walletAccountInstance = await this.#getWalletAccount(walletAccount)
     return this.wallet.getPublicKey({
@@ -159,6 +177,7 @@ class AssetClientInterface {
 
     return [...addresses].map((address) => address.toString())
   }
+
   getChangeAddresses = async (opts) => {
     const addresses = await this.addressProvider.getChangeAddresses({
       ...opts,
@@ -191,13 +210,6 @@ class AssetClientInterface {
     // no op!! getUnusedAddressIndexes loads from tx log, not from storage
   }
 
-  signTransaction = async ({ assetName, unsignedTx, walletAccount }) => {
-    // eslint-disable-next-line unicorn/no-await-expression-member
-    const accountIndex = (await this.#getWalletAccount(walletAccount)).index
-    const baseAssetName = this.assetsModule.getAsset(assetName).baseAsset.name
-    return this.wallet.signTransaction({ baseAssetName, unsignedTx, accountIndex })
-  }
-
   getNextChangeAddress = async ({ assetName, walletAccount }) => {
     return this.addressProvider.getUnusedAddress({
       assetName,
@@ -206,8 +218,13 @@ class AssetClientInterface {
     })
   }
 
-  getFeeConfig = async ({ assetName }) => {
-    return this.feeMonitors.getFeeData({ assetName })
+  // wallet interface
+
+  signTransaction = async ({ assetName, unsignedTx, walletAccount }) => {
+    // eslint-disable-next-line unicorn/no-await-expression-member
+    const accountIndex = (await this.#getWalletAccount(walletAccount)).index
+    const baseAssetName = this.assetsModule.getAsset(assetName).baseAsset.name
+    return this.wallet.signTransaction({ baseAssetName, unsignedTx, accountIndex })
   }
 }
 

package/module/assets-module.js

@@ -74,12 +74,13 @@ export class AssetsModule extends ExodusModule {
     iconsStorage,
     assetRegistry, // temporary
     assetPlugins,
-    combinedAssetsList,
+    combinedAssetsList = [],
     globalAssetRegistry, // temporary
     validateCustomToken = () => true,
     config = {},
   }) {
     super({ name: 'AssetsModule' })
+
     this.#storage = storage
     this.#isExternalRegistry = !!assetRegistry
     this.#registry = this.#isExternalRegistry ? assetRegistry : initialAssetRegistry

package/module/index.js

@@ -2,23 +2,7 @@
 import globalAssetRegistry from '@exodus/assets' // this is deprecated, do not use for any other purpose. Remove when we have @exodus/models v10.
 import AssetsModule from './assets-module'
 
-const createAssetsModule = ({
-  storage,
-  iconsStorage,
-  assetPlugins,
-  combinedAssetsList = [],
-  validateCustomToken,
-  config,
-}) =>
-  new AssetsModule({
-    storage,
-    iconsStorage,
-    globalAssetRegistry,
-    assetPlugins,
-    combinedAssetsList,
-    validateCustomToken,
-    config,
-  })
+const createAssetsModule = (props) => new AssetsModule({ ...props, globalAssetRegistry })
 
 const assetsModuleDefinition = {
   id: 'assetsModule',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/assets-feature",
-  "version": "3.1.0",
+  "version": "3.1.2",
   "license": "UNLICENSED",
   "description": "Assets module, clients and apis",
   "main": "index.js",
@@ -41,8 +41,8 @@
   },
   "devDependencies": {
     "@exodus/assets": "^8.0.95",
-    "@exodus/atoms": "^5.7.0",
-    "@exodus/available-assets": "^5.1.1",
+    "@exodus/atoms": "^5.7.1",
+    "@exodus/available-assets": "^6.0.0",
     "@exodus/bitcoin-meta": "^1.0.1",
     "@exodus/bitcoin-plugin": "^1.0.3",
     "@exodus/bitcoinregtest-plugin": "^1.0.3",
@@ -55,12 +55,12 @@
     "@exodus/osmosis-plugin": "^1.0.0",
     "@exodus/redux-dependency-injection": "^3.0.0",
     "@exodus/storage-memory": "^2.1.1",
-    "@exodus/wallet-accounts": "^14.0.0",
+    "@exodus/wallet-accounts": "^14.1.0",
     "@exodus/wild-emitter": "^1.0.0",
     "eslint": "^8.44.0",
     "events": "^3.3.0",
     "jest": "^29.1.2",
     "redux": "^4.0.0"
   },
-  "gitHead": "c2300eac2bdc89cb16b5976a0de5d14005ad720a"
+  "gitHead": "ce4e99ff4dba391f43f279d90e5514f727a62063"
 }

package/plugin/index.js

@@ -7,8 +7,8 @@ const createAssetsPlugin = ({ port, assetsModule, disabledPurposesAtom, multiAdd
     port.emit('assets-load', {
       assets,
       defaultAccountStates: mapValues(
-        pickBy(assets, (asset) => asset.api.hasFeature('accountState')),
-        (asset) => asset?.api?.createAccountState?.()?.create?.()
+        pickBy(assets, (asset) => asset.api?.hasFeature?.('accountState')),
+        (asset) => asset.api.createAccountState().create()
       ),
     })
   }