@exodus/activity-txs 4.4.2 → 4.4.3

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.4.3](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/activity-txs@4.4.1...@exodus/activity-txs@4.4.3) (2025-01-05)
+
+### Bug Fixes
+
+- fix: activity id generation (#10846)
+
+- fix: assume asset.api.getActivity is async (#10848)
+
+### License
+
+- license: re-license under MIT license (#10580)
+
 ## [4.4.2](https://github.com/ExodusMovement/exodus-hydra/compare/@exodus/activity-txs@4.4.1...@exodus/activity-txs@4.4.2) (2024-11-25)
 
 ### License

package/atoms/activity-txs.js

@@ -1,7 +1,6 @@
 import { combine, compute } from '@exodus/atoms'
 import { createSelector } from 'reselect'
 import { memoize } from 'lodash' // eslint-disable-line @exodus/restricted-imports/prefer-basic-utils -- TODO: fix next time we touch this file
-import { mapValues } from '@exodus/basic-utils'
 import { createDeepEqualOutputSelector } from '@exodus/core-selectors/utils/deep-equal'
 
 const createAssetSourceActivityTxsSelector = memoize(
@@ -92,44 +91,70 @@ const createActivityTxsAtom = ({ txLogsAtom, accountStatesAtom, assetsModule })
     accountStates: accountStatesAtom,
   })
 
-  let prevResult
+  let prevResult = Object.create(null)
 
-  const selector = ({ txLogs, accountStates }) => {
+  const selector = async ({ txLogs, accountStates }) => {
     const { value } = txLogs
     const { value: accountStatesValue } = accountStates
-    const result = mapValues(value, (accountTxLogs, walletAccount) =>
-      mapValues(accountTxLogs, (assetTxSet, assetName) => {
-        const asset = assetsModule.getAsset(assetName)
-        const baseAssetName = asset.baseAsset.name
-
-        if (asset?.api?.getActivityTxs) {
-          let activityOptions
-          if (asset?.api?.getActivityOptions) {
-            const baseAssetAccountState = accountStatesValue?.[walletAccount]?.[baseAssetName]
-
-            activityOptions = createAssetSourceActivityOptionsSelector({
-              assetName,
-              walletAccount,
-            })({
-              accountState: baseAssetAccountState,
-              asset,
-            })
-          }
 
-          return createAssetSourceActivityTxsSelector({ assetName, walletAccount })({
-            asset,
-            txs: createAssetSourceTxsSelector({ assetName, walletAccount })({
+    // Process each wallet account asynchronously
+    const resultEntries = await Promise.all(
+      Object.entries(value).map(async ([walletAccount, accountTxLogs]) => {
+        // Process each asset within the wallet account asynchronously
+        const assetEntries = await Promise.all(
+          Object.entries(accountTxLogs).map(async ([assetName, assetTxSet]) => {
+            const asset = assetsModule.getAsset(assetName)
+            const baseAssetName = asset.baseAsset.name
+
+            if (asset?.api?.getActivityTxs) {
+              let activityOptions
+
+              if (asset?.api?.getActivityOptions) {
+                const baseAssetAccountState = accountStatesValue?.[walletAccount]?.[baseAssetName]
+
+                const getOptionsForAssetSource = createAssetSourceActivityOptionsSelector({
+                  assetName,
+                  walletAccount,
+                })
+
+                activityOptions = await getOptionsForAssetSource({
+                  accountState: baseAssetAccountState,
+                  asset,
+                })
+              }
+
+              const txs = createAssetSourceTxsSelector({ assetName, walletAccount })({
+                txSet: assetTxSet,
+              })
+
+              const getActivityForAssetSource = createAssetSourceActivityTxsSelector({
+                assetName,
+                walletAccount,
+              })
+
+              const activityTxs = await getActivityForAssetSource({
+                asset,
+                txs,
+                activityOptions,
+              })
+
+              return [assetName, activityTxs]
+            }
+
+            const txs = createAssetSourceTxsSelector({ assetName, walletAccount })({
               txSet: assetTxSet,
-            }),
-            activityOptions,
+            })
+
+            return [assetName, txs]
           })
-        }
+        )
 
-        return createAssetSourceTxsSelector({ assetName, walletAccount })({
-          txSet: assetTxSet,
-        })
+        return [walletAccount, Object.fromEntries(assetEntries)]
       })
     )
+
+    const result = Object.fromEntries(resultEntries)
+
     if (areActivitiesEqual(result, prevResult)) {
       return prevResult
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/activity-txs",
-  "version": "4.4.2",
+  "version": "4.4.3",
   "description": "The activity-txs feature",
   "author": "Exodus Movement, Inc.",
   "repository": {
@@ -43,21 +43,22 @@
   "devDependencies": {
     "@exodus/assets": "^8.0.95",
     "@exodus/assets-base": "^8.1.10",
-    "@exodus/assets-feature": "^5.14.1",
+    "@exodus/assets-feature": "^6.0.1",
     "@exodus/available-assets": "^8.7.0",
     "@exodus/bitcoin-plugin": "^1.4.2",
-    "@exodus/connected-origins": "^4.1.0",
-    "@exodus/fiat-ramp": "^10.17.4",
-    "@exodus/nfts": "^9.4.1",
+    "@exodus/connected-origins": "^4.1.1",
+    "@exodus/fiat-ramp": "^11.0.1",
+    "@exodus/logger": "^1.2.3",
+    "@exodus/nfts": "^9.4.2",
     "@exodus/orders": "^4.13.0",
-    "@exodus/personal-notes": "^3.6.3",
+    "@exodus/personal-notes": "^3.7.0",
     "@exodus/redux-dependency-injection": "^4.1.1",
-    "@exodus/wallet-accounts": "^17.1.1",
+    "@exodus/wallet-accounts": "^17.1.3",
     "@types/minimalistic-assert": "^1.0.1",
     "redux": "^4.2.1"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "97156baad5ad86796c5eb3721264ba7b0ebb6332"
+  "gitHead": "901c220173a58839ad07917f573fe0752d4bbd70"
 }

package/redux/utils/activity-formatters/format-tx-activity.js

@@ -16,8 +16,9 @@ export function isPending(tx, asset) {
 }
 
 const generateTxActivityId = ({ tx, asset }) => {
-  const sentIndex = tx.data?.sentIndex
-  return sentIndex ? `${asset.name}.${tx.txId}_${sentIndex}` : `${asset.name}.${tx.txId}`
+  const index = tx.data?.activityIndex
+
+  return index ? `${asset.name}.${tx.txId}_${index}` : `${asset.name}.${tx.txId}`
 }
 
 export const formatTxActivity = ({ tx, asset, personalNote }) => {