@exode-team/multicard-uz.api 1.0.1 → 1.0.3

package/PROMPT.md

@@ -0,0 +1,84 @@
+# Fix: requestApi error handling — circular structure to JSON
+
+## Problem
+
+In `src/multicard-api.ts`, the `requestApi` method re-throws the raw Axios error:
+
+```typescript
+} catch (error) {
+    console.error(...);
+    throw error;  // Raw Axios error with circular refs!
+}
+```
+
+Axios error objects contain `error.request` (ClientRequest) and `error.response.req` (IncomingMessage) which form a circular reference: `ClientRequest.res → IncomingMessage.req → ClientRequest`.
+
+When this error bubbles up to Apollo Server (GraphQL), it tries to `JSON.stringify` the error → **"Converting circular structure to JSON"**.
+
+## Fix
+
+In `src/multicard-api.ts`, change the `catch` block in `requestApi` to return a `MulticardErrorResponse` instead of throwing:
+
+**From:**
+```typescript
+} catch (error) {
+    const response = (error as any)?.response;
+
+    console.error(
+        '[PACKAGE:multicard-uz.api]',
+        `status=${response?.status}`,
+        `config=[${JSON.stringify(config)}]`,
+        JSON.stringify(response?.data),
+    );
+
+    throw error;
+}
+```
+
+**To:**
+```typescript
+} catch (error) {
+    const response = (error as any)?.response;
+
+    console.error(
+        '[PACKAGE:multicard-uz.api]',
+        `status=${response?.status}`,
+        `config=[${JSON.stringify(config)}]`,
+        JSON.stringify(response?.data),
+    );
+
+    return {
+        success: false,
+        error: {
+            code: MulticardErrorCode.ERROR_UNKNOWN,
+            details: response?.data?.message
+                || response?.data?.error?.details
+                || (error as Error).message
+                || 'Unknown error',
+        },
+    } as T;
+}
+```
+
+Also add `MulticardErrorCode` to the imports at the top of the file:
+```typescript
+import {
+    // ... existing imports
+    MulticardErrorCode,
+    // ...
+} from './types';
+```
+
+## Why
+
+- All Multicard provider methods already check `response.success` before using `response.data`
+- Returning `{ success: false, error: {...} }` lets the consumer handle errors gracefully
+- No circular references in the error object
+- Consistent with the `MulticardResponse` type contract
+
+## After fix
+
+Bump version to `1.0.2`, build and publish:
+```bash
+npm version patch && yarn build && npm publish
+```

package/dist/multicard-api.js

@@ -21,7 +21,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
         if (v !== undefined) module.exports = v;
     }
     else if (typeof define === "function" && define.amd) {
-        define(["require", "exports", "axios", "./multicard-base"], factory);
+        define(["require", "exports", "axios", "./multicard-base", "./types"], factory);
     }
 })(function (require, exports) {
     "use strict";
@@ -29,6 +29,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     exports.MulticardApi = void 0;
     const axios_1 = __importDefault(require("axios"));
     const multicard_base_1 = require("./multicard-base");
+    const types_1 = require("./types");
     class MulticardApi extends multicard_base_1.MulticardBase {
         /**
          * Запрос к API
@@ -41,6 +42,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
          */
         requestApi(apiUrl_1) {
             return __awaiter(this, arguments, void 0, function* (apiUrl, data = {}, headers, httpMethod = 'post') {
+                var _a, _b, _c;
                 const config = {
                     timeout: this.timeoutMs,
                     url: `${this.baseUrl}${apiUrl}`,
@@ -60,7 +62,16 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
                 catch (error) {
                     const response = error === null || error === void 0 ? void 0 : error.response;
                     console.error('[PACKAGE:multicard-uz.api]', `status=${response === null || response === void 0 ? void 0 : response.status}`, `config=[${JSON.stringify(config)}]`, JSON.stringify(response === null || response === void 0 ? void 0 : response.data));
-                    throw error;
+                    return {
+                        success: false,
+                        error: {
+                            code: types_1.MulticardErrorCode.ERROR_UNKNOWN,
+                            details: ((_a = response === null || response === void 0 ? void 0 : response.data) === null || _a === void 0 ? void 0 : _a.message)
+                                || ((_c = (_b = response === null || response === void 0 ? void 0 : response.data) === null || _b === void 0 ? void 0 : _b.error) === null || _c === void 0 ? void 0 : _c.details)
+                                || error.message
+                                || 'Unknown error',
+                        },
+                    };
                 }
             });
         }

package/dist/types.d.ts

@@ -164,32 +164,14 @@ export interface CardBindSession {
     form_url: string;
 }
 export type CardBindCreateResponse = MulticardSuccessResponse<CardBindSession>;
-export interface CardBindStatusData {
-    /** Идентификатор сессии привязки */
-    session_id: string;
-    /** Статус привязки */
-    status: string;
-    /** Данные карты (при успешной привязке) */
-    card?: CardModel;
-}
+/** Ответ проверки привязки — плоская модель карты (без вложенного card) */
+export type CardBindStatusData = CardModel;
 export type CardBindGetStatusResponse = MulticardSuccessResponse<CardBindStatusData>;
 /**
  * @Card Binding Callback:
  */
-export interface CardBindCallbackPayload {
-    /** Токен привязанной карты */
-    card_token: string;
-    /** Маскированный номер карты */
-    card_pan: string;
-    /** Номер телефона держателя карты */
-    phone: string;
-    /** Платёжная система */
-    ps: MulticardPaymentService;
-    /** Имя держателя карты */
-    holder_name?: string;
-    /** Идентификатор пользователя */
-    payer_id?: string;
-}
+/** Тело callback'а привязки совпадает с моделью карты (подписи нет) */
+export type CardBindCallbackPayload = CardModel;
 /**
  * @Card Management:
  */
@@ -198,8 +180,10 @@ export interface CardModel {
     id: number;
     /** ID приложения */
     application_id: number;
-    /** Идентификатор пользователя */
+    /** Идентификатор пользователя (payer_id из запроса привязки) */
     payer_id: string;
+    /** Идентификатор сессии привязки */
+    session_id: string;
     /** Маскированный номер карты */
     card_pan: string;
     /** Токен карты */
@@ -220,9 +204,11 @@ export interface CardModel {
     card_status: {
         code: number;
         description: string;
-    };
+    } | null;
     /** Подключено ли SMS-информирование */
-    sms_inform: boolean;
+    sms_inform: boolean | null;
+    /** Карта Multicard */
+    is_multicard: boolean;
 }
 export type CardGetResponse = MulticardSuccessResponse<CardModel>;
 export type CardDeleteResponse = MulticardSuccessResponse<void>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exode-team/multicard-uz.api",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "multicard.uz API",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",