@evolu/common 6.0.1-preview.11 → 6.0.1-preview.12

package/dist/src/Type.js

@@ -620,16 +620,16 @@ export const createId = (deps) => deps.nanoIdLib.nanoid();
  * @category String
  */
 export const createIdFromString = (value) => {
-    const hash = sha256(utf8ToBytes(value)); // 32 bytes = 256 bits
+    const hash = sha256(utf8ToBytes(value));
     let output = "";
     let buffer = 0;
     let bits = 0;
-    for (let i = 0; i < hash.length && output.length < 21; i++) {
-        buffer = (buffer << 8) | hash[i]; // push 8 bits
+    for (const byte of hash) {
+        buffer = (buffer << 8) | byte;
         bits += 8;
-        while (bits >= 6 && output.length < 21) {
+        while (bits >= 6 && output.length < idTypeValueLength) {
             bits -= 6;
-            const index = (buffer >> bits) & 0b111111; // extract top 6 bits
+            const index = (buffer >> bits) & 0b111111;
             output += base64UrlAlphabet[index];
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@evolu/common",
-  "version": "6.0.1-preview.11",
+  "version": "6.0.1-preview.12",
   "description": "TypeScript library and local-first framework",
   "keywords": [
     "evolu",

package/src/Type.ts

@@ -1377,19 +1377,19 @@ export const createId = <B extends string = never>(
 export const createIdFromString = <B extends string = never>(
   value: string,
 ): [B] extends [never] ? Id : Id & Brand<B> => {
-  const hash = sha256(utf8ToBytes(value)); // 32 bytes = 256 bits
+  const hash = sha256(utf8ToBytes(value));
 
   let output = "";
   let buffer = 0;
   let bits = 0;
 
-  for (let i = 0; i < hash.length && output.length < 21; i++) {
-    buffer = (buffer << 8) | hash[i]; // push 8 bits
+  for (const byte of hash) {
+    buffer = (buffer << 8) | byte;
     bits += 8;
 
-    while (bits >= 6 && output.length < 21) {
+    while (bits >= 6 && output.length < idTypeValueLength) {
       bits -= 6;
-      const index = (buffer >> bits) & 0b111111; // extract top 6 bits
+      const index = (buffer >> bits) & 0b111111;
       output += base64UrlAlphabet[index];
     }
   }