@evident-ai/cli 3.1.1-dev.4159d3a → 3.1.1-dev.504d05d

package/dist/index.js

@@ -499,6 +499,12 @@ function log(level, event, fields) {
     );
   }
 }
+function errorFields(err) {
+  if (err instanceof Error) {
+    return { error: err.message, error_name: err.name };
+  }
+  return { error: String(err) };
+}
 function stripQuery(url) {
   try {
     return new URL(url).pathname;
@@ -1267,6 +1273,16 @@ async function buildFileParts(attachments, capable) {
       );
       dataUrl = null;
     }
+    if (dataUrl !== null && typeof dataUrl === "object") {
+      outcomes.push({
+        index: a.index,
+        mime: a.mime,
+        filename: a.filename,
+        status: "failed",
+        reason: "needs_reauth"
+      });
+      continue;
+    }
     if (dataUrl == null) {
       outcomes.push({ index: a.index, mime: a.mime, filename: a.filename, status: "failed" });
       continue;
@@ -1684,10 +1700,11 @@ var StreamForwarder = class {
    * Abort every in-flight stream (e.g. on WebSocket close).
    */
   abortAll() {
-    for (const stream of this.inflight.values()) {
+    for (const [sid, stream] of this.inflight.entries()) {
       try {
         stream.abort();
-      } catch {
+      } catch (err) {
+        log("error", "forwarder_abort_failed", { sid, ...errorFields(err) });
       }
     }
     this.inflight.clear();
@@ -1960,7 +1977,11 @@ var RunnerConnection = class {
     if (this.connection) {
       try {
         this.connection.close();
-      } catch {
+      } catch (err) {
+        log("error", "runner_connection_close_failed", {
+          agent_id: this.resolvedAgentId,
+          ...errorFields(err)
+        });
       }
       this.connection = null;
     }
@@ -2041,6 +2062,7 @@ var DEFAULT_STUCK_QUEUED_MS = 6e4;
 var HEARTBEAT_MS = 6e4;
 var ABSOLUTE_MAX_PROCESSING_MS = 6 * 60 * 60 * 1e3;
 var POLL_MISS_GRACE_MS = HEARTBEAT_MS;
+var MAX_SUPERSEDED_CONVERSATIONS = 256;
 var ChannelAuthError = class extends Error {
   constructor(message) {
     super(message);
@@ -2063,7 +2085,7 @@ function backoffDelay(attempt, policy) {
 function isRetryableStatus(status) {
   return status === 429 || status >= 500 && status <= 599;
 }
-var ChannelDriver = class {
+var ChannelDriver = class _ChannelDriver {
   agentId;
   port;
   apiUrl;
@@ -2079,6 +2101,34 @@ var ChannelDriver = class {
   now;
   /** Cache of conversationId → opencode sessionId. */
   sessions = /* @__PURE__ */ new Map();
+  /**
+   * conversationId → the opencode session this runner has ABANDONED as that
+   * conversation's binding (#553), after a genuine (`sessionExists === true`)
+   * dispatch failure: the session still exists but is wedged, so #485's self-heal
+   * must bind a fresh one.
+   *
+   * Dropping the local binding + clearing the server row is not enough on its own:
+   * a SIBLING message dispatched earlier in the same drain is still in-flight under
+   * the same session, and its watcher's routine status writes carry
+   * `opencode_session_id`, RESURRECTING the wedged id server-side after the clear —
+   * and `ensureSession`'s persisted-id fallback then reuses it, defeating the
+   * self-heal. This map makes the runner authoritative instead of racing those
+   * writes: *`ensureSession` never reuses an abandoned id for that conversation,
+   * whatever the server row says* — which holds even when the resurrecting write
+   * is one we deliberately keep (see `markDone`).
+   *
+   * Bounded by construction, on both axes: keyed by CONVERSATION, so N failures on
+   * one conversation hold ONE entry (the newest abandonment replaces the older), and
+   * hard-capped at `MAX_SUPERSEDED_CONVERSATIONS` with FIFO eviction. Only the
+   * NEWEST abandoned id per conversation is guarded: after a second abandonment a
+   * late sibling of the FIRST session can write that id back and `ensureSession`
+   * will reuse it — costing ONE repeat failure, which re-supersedes it. Deliberately
+   * NOT dropped when the session's watcher tears down: `markDone` still writes the
+   * abandoned id back (it must, or the reply is lost), so the guard has to outlive
+   * the turn that resurrects it. In-memory only — a restart forgets it, at the same
+   * bounded cost.
+   */
+  supersededSessions = /* @__PURE__ */ new Map();
   /**
    * Per-opencode-session dispatch lock (Task 2.1a). `sendPromptAsync` is no
    * longer idempotent (no caller-supplied `messageID`), and its read-back picks
@@ -2188,9 +2238,12 @@ var ChannelDriver = class {
   sessionParents = /* @__PURE__ */ new Map();
   /**
    * Per-session OpenCode title cache (#310), keyed by sessionId. Only a resolved
-   * NON-EMPTY name is stored (terminal — a real session name won't later un-name),
-   * so we do NOT re-GET `/session/:id` every tick. A missing entry = not yet
-   * resolved OR resolved-but-still-empty → re-fetch on next need, since OpenCode
+   * NON-EMPTY, non-placeholder name is stored (terminal — a real session name
+   * won't later un-name), so we do NOT re-GET `/session/:id` every tick. "Non-empty"
+   * excludes OpenCode's synchronous default title (see
+   * `OPENCODE_DEFAULT_TITLE_PREFIX`, #549) — that placeholder is treated the same
+   * as an empty title so it never latches. A missing entry = not yet resolved OR
+   * resolved-but-still-empty/placeholder → re-fetch on next need, since OpenCode
    * names sessions asynchronously mid-turn. Driver-level (not per-watcher) so both
    * the watcher completion path AND the restart-recovery re-adopt path (which has
    * no watcher) can resolve the title.
@@ -2384,10 +2437,15 @@ var ChannelDriver = class {
    * @returns the count of messages NEWLY dispatched (not already in-flight).
    */
   async processConversation(conv) {
-    const sessionId = await this.ensureSession(conv);
+    const { sessionId, refusedSessionId } = await this.ensureSession(conv);
     const messages = await this.getPendingMessages(conv.id);
     let dispatched = 0;
     let skippedAlreadyDispatched = 0;
+    if (refusedSessionId && messages.length > 0) {
+      void this.postSignal(conv.id, messages[0].id, "session_superseded", {
+        superseded_session_id: refusedSessionId
+      });
+    }
     for (const message of messages) {
       if (this.stopped) break;
       if (this.dispatched.has(message.id)) {
@@ -2414,7 +2472,8 @@ var ChannelDriver = class {
       } catch (err) {
         if (err instanceof ChannelAuthError) throw err;
         this.dispatched.delete(message.id);
-        if (await sessionExists(this.port, sessionId) === false) {
+        const exists = await sessionExists(this.port, sessionId);
+        if (exists === false) {
           this.sessions.delete(conv.id);
           this.log({
             level: "warn",
@@ -2424,15 +2483,39 @@ var ChannelDriver = class {
           });
           break;
         }
-        await this.markFailed(conv.id, message.id).catch(() => {
+        if (exists === null) {
+          this.log({
+            level: "warn",
+            message: `Message ${message.id.slice(0, 8)} dispatch failed and session (${sessionId.slice(0, 8)}) existence could not be confirmed (opencode momentarily unreachable) \u2014 deferring this and later messages for conversation ${conv.id.slice(0, 8)} to the next tick rather than treating it as a genuine failure.`,
+            conversation_id: conv.id,
+            message_id: message.id
+          });
+          break;
+        }
+        const errorMessage = err instanceof Error ? err.message : String(err);
+        this.sessions.delete(conv.id);
+        this.supersede(conv.id, sessionId);
+        this.log({
+          level: "warn",
+          message: `Abandoning OpenCode session ${sessionId.slice(0, 8)} as the binding for conversation ${conv.id.slice(0, 8)} (it exists but failed to run a turn) \u2014 a fresh session is created on the next tick, whatever the persisted binding says by then.`,
+          conversation_id: conv.id,
+          message_id: message.id
+        });
+        await this.markFailed(conv.id, message.id, null, errorMessage).catch((markErr) => {
+          this.log({
+            level: "warn",
+            message: `markFailed PATCH for message ${message.id.slice(0, 8)} (conversation ${conv.id.slice(0, 8)}) failed (best-effort, not retried): ${markErr instanceof Error ? markErr.message : String(markErr)}`,
+            conversation_id: conv.id,
+            message_id: message.id
+          });
         });
         this.log({
           level: "error",
-          message: `Message ${message.id.slice(0, 8)} dispatch failed: ${err instanceof Error ? err.message : String(err)}`,
+          message: `Message ${message.id.slice(0, 8)} dispatch failed: ${errorMessage}`,
           conversation_id: conv.id,
           message_id: message.id
         });
-        continue;
+        break;
       }
       if (opencodeMessageId === null) {
         this.log({
@@ -2458,8 +2541,42 @@ var ChannelDriver = class {
     this.ensureWatcherRunning(sessionId);
     return dispatched;
   }
+  /**
+   * Record that `sessionId` is no longer a valid binding for `conversationId`
+   * (#553). Keyed by conversation and hard-capped, so it cannot grow with the
+   * number of failures — see the `supersededSessions` field doc.
+   */
+  supersede(conversationId, sessionId) {
+    this.supersededSessions.delete(conversationId);
+    this.supersededSessions.set(conversationId, sessionId);
+    while (this.supersededSessions.size > MAX_SUPERSEDED_CONVERSATIONS) {
+      const oldest = this.supersededSessions.keys().next().value;
+      if (oldest === void 0) return;
+      this.supersededSessions.delete(oldest);
+    }
+  }
+  /** Whether `sessionId` is the session this conversation has abandoned (#553). */
+  isSuperseded(conversationId, sessionId) {
+    return this.supersededSessions.get(conversationId) === sessionId;
+  }
+  /**
+   * Resolve the opencode session to run this conversation's turns in.
+   *
+   * `refusedSessionId` is set when the #553 guard fired — i.e. the persisted
+   * binding was an id this runner had abandoned, so a resurrection genuinely
+   * happened and a fresh session was bound instead. The caller reports it.
+   */
   async ensureSession(conv) {
     const bound = this.sessions.get(conv.id) ?? conv.opencode_session_id ?? null;
+    if (bound && this.isSuperseded(conv.id, bound)) {
+      this.log({
+        level: "warn",
+        message: `OpenCode session ${bound.slice(0, 8)} was abandoned for conversation ${conv.id.slice(0, 8)} after a failed dispatch but is still bound to it (the persisted id was written back by a turn already in flight) \u2014 ignoring it and binding a fresh session.`,
+        conversation_id: conv.id
+      });
+      this.sessions.delete(conv.id);
+      return { sessionId: await this.createAndBindSession(conv.id), refusedSessionId: bound };
+    }
     if (bound) {
       const exists = await sessionExists(this.port, bound);
       if (exists === false) {
@@ -2469,12 +2586,12 @@ var ChannelDriver = class {
           conversation_id: conv.id
         });
         this.sessions.delete(conv.id);
-        return this.createAndBindSession(conv.id);
+        return { sessionId: await this.createAndBindSession(conv.id) };
       }
       this.sessions.set(conv.id, bound);
-      return bound;
+      return { sessionId: bound };
     }
-    return this.createAndBindSession(conv.id);
+    return { sessionId: await this.createAndBindSession(conv.id) };
   }
   /**
    * Create a fresh OpenCode session for a conversation, cache the binding, and
@@ -2562,7 +2679,11 @@ var ChannelDriver = class {
    * (not-owned / out-of-range / deleted-at-source / workspace gone) / 413
    * (over-cap). On ANY non-2xx or thrown failure we return `null` so the caller
    * OMITS that one image and the text turn still sends — NEVER throws the turn.
-   * Failures are logged with context (no silent swallow).
+   * A 404 body carrying `{ reason: 'needs_reauth' }` (#547 — the server CONFIRMED
+   * a Slack `files:read` scope problem via `files.info`) instead resolves the
+   * `AttachmentFetchNeedsReauth` sentinel, so the in-thread note can steer the
+   * user to reconnect Slack instead of a generic "unavailable". Failures are
+   * logged with context (no silent swallow).
    */
   async fetchAttachmentDataUrl(messageId, index, mime) {
     try {
@@ -2571,6 +2692,25 @@ var ChannelDriver = class {
         { headers: { Authorization: this.getAuthHeader() } }
       );
       if (!res.ok) {
+        let reason;
+        try {
+          const body = await res.json();
+          if (body && typeof body.reason === "string") reason = body.reason;
+        } catch (parseErr) {
+          this.log({
+            level: "debug",
+            message: `Attachment fetch for message ${messageId.slice(0, 8)} index ${index}: error body was not JSON (${parseErr instanceof Error ? parseErr.message : String(parseErr)}) \u2014 treating as a plain failure`,
+            message_id: messageId
+          });
+        }
+        if (reason === "needs_reauth") {
+          this.log({
+            level: "error",
+            message: `Attachment fetch for message ${messageId.slice(0, 8)} index ${index} returned HTTP ${res.status} \u2014 server confirmed a Slack reauth/scope problem \u2014 omitting this image (text turn proceeds)`,
+            message_id: messageId
+          });
+          return { needsReauth: true };
+        }
         this.log({
           level: "error",
           message: `Attachment fetch for message ${messageId.slice(0, 8)} index ${index} returned HTTP ${res.status} \u2014 omitting this image (text turn proceeds)`,
@@ -2610,6 +2750,9 @@ var ChannelDriver = class {
     if (this.attachmentsSkippedSignalled.has(messageId)) return;
     this.attachmentsSkippedSignalled.add(messageId);
     const skippedReason = capabilityUnknown ? "unknown" : "unsupported";
+    const failedReason = outcomes.some(
+      (o) => o.status === "failed" && o.reason === "needs_reauth"
+    ) ? "needs_reauth" : void 0;
     this.log({
       level: "info",
       message: `Message ${messageId.slice(0, 8)}: ${skipped} image(s) skipped (${capabilityUnknown ? "capability was unreadable \u2014 failed open to text-only" : "model not attachment-capable"}), ${failed} image(s) unavailable (deleted-at-source or fetch failure) \u2014 noting to Evident`,
@@ -2619,7 +2762,8 @@ var ChannelDriver = class {
     void this.postSignal(conversationId, messageId, "attachments_skipped", {
       skipped,
       failed,
-      ...skipped > 0 ? { skipped_reason: skippedReason } : {}
+      ...skipped > 0 ? { skipped_reason: skippedReason } : {},
+      ...failedReason ? { failed_reason: failedReason } : {}
     });
   }
   /** Register a freshly-dispatched message with its session's watcher state. */
@@ -3658,19 +3802,36 @@ var ChannelDriver = class {
     if (parent !== void 0) this.sessionParents.set(sessionId, parent);
     return parent;
   }
+  /**
+   * OpenCode's synchronous default session title (e.g.
+   * `"New session - 1737800000000"`), assigned immediately when a session is
+   * created — before OpenCode's async LLM-based auto-titling later renames it
+   * mid-turn (#549). Matched by this literal, case-sensitive prefix only; the
+   * timestamp suffix's exact format is deliberately NOT matched, since the prefix
+   * alone is the stable, cheap signal and over-anchoring on the timestamp
+   * representation risks silently breaking if OpenCode ever changes it. Accepted
+   * trade-off: a genuine LLM-assigned title that happens to literally start with
+   * this prefix would also fail to latch (see `resolveSessionTitle`) —
+   * vanishingly unlikely in practice, and deliberately not engineered around.
+   */
+  static OPENCODE_DEFAULT_TITLE_PREFIX = /^New session - /;
   /**
    * Resolve (and cache in `sessionTitles`) the OpenCode session TITLE (#310) so the
    * status PATCH can carry it into the "Live sessions" list. Driver-level cache so
    * BOTH the watcher completion path and the restart-recovery re-adopt path (which
    * has no watcher) can use it. `conversationId` is passed only for log context.
    * Best-effort:
-   *   - a resolved NON-EMPTY title is cached and terminal (a real session name
+   *   - a resolved NON-EMPTY title that does NOT match
+   *     `OPENCODE_DEFAULT_TITLE_PREFIX` is cached and terminal (a real session name
    *     won't later un-name), so we do NOT re-GET `/session/:id` every tick;
-   *   - while the title is still absent/empty we do NOT latch it — OpenCode names
-   *     sessions asynchronously mid-turn, so an early call (e.g. at `processing`)
-   *     must leave the cache unresolved and re-fetch on the next need so a later
-   *     call (e.g. at `done`) picks up the name assigned in the meantime. Such a
-   *     call returns `null` (omit the title on THIS PATCH) without caching;
+   *   - while the title is still absent, empty, or matches the OpenCode
+   *     placeholder prefix (#549) we do NOT latch it — OpenCode names sessions
+   *     asynchronously mid-turn, so an early call (e.g. at `processing`) must leave
+   *     the cache unresolved and re-fetch on the next need so a later call (e.g. at
+   *     `done`) picks up the name assigned in the meantime. Such a call returns
+   *     `null` (omit the title on THIS PATCH) without caching. If a session is
+   *     never renamed, the title is omitted forever rather than ever persisting
+   *     the placeholder as a last resort;
    *   - a failed request likewise leaves the cache unresolved (retry next need)
    *     and returns `null` — it must NEVER throw or block completion.
    * A failure is logged with agent/session context (no silent catch).
@@ -3683,7 +3844,7 @@ var ChannelDriver = class {
       if (res.ok) {
         const body = await res.json();
         const title = body && typeof body.title === "string" ? body.title.trim() : "";
-        if (title.length > 0) {
+        if (title.length > 0 && !_ChannelDriver.OPENCODE_DEFAULT_TITLE_PREFIX.test(title)) {
           this.sessionTitles.set(sessionId, title);
           return title;
         }
@@ -3889,6 +4050,32 @@ var ChannelDriver = class {
     }
     return messages;
   }
+  /**
+   * The `opencode_session_id` fragment of a status PATCH body — `{}` when this
+   * conversation has ABANDONED that session (#553). The field is optional
+   * server-side and an absent one leaves the persisted binding untouched, so
+   * omitting it is how a routine status write stops resurrecting it.
+   *
+   * ONLY for writes whose sole cost is a lost deep link. The `processing` notice
+   * degrades to no "View in Evident" link (the reaction swap still fires) and the
+   * turn-failure notice is built from the PATCH's own `error` text with a link off
+   * the persisted row — neither loses content the user came for. `markDone`
+   * deliberately does NOT use this helper: the server fetches the reply text
+   * THROUGH the session id it is given, so suppressing there would replace the
+   * agent's answer with a bare "✅ Done!" (the #183/#187 failure). The
+   * `ensureSession` guard, not this suppression, is what makes the self-heal
+   * stick.
+   */
+  sessionIdBody(sessionId, conversationId, messageId, status) {
+    if (!this.isSuperseded(conversationId, sessionId)) return { opencode_session_id: sessionId };
+    this.log({
+      level: "debug",
+      message: `Omitting the abandoned OpenCode session ${sessionId.slice(0, 8)} from the '${status}' update for message ${messageId.slice(0, 8)} so it is not re-bound to conversation ${conversationId.slice(0, 8)}`,
+      conversation_id: conversationId,
+      message_id: messageId
+    });
+    return {};
+  }
   /**
    * EXISTING combinedAuth route — now fired by the watcher on queued→running
    * (Task 3.3), NOT at dispatch/claim time. `{status:'processing',
@@ -3918,7 +4105,7 @@ var ChannelDriver = class {
         headers: { Authorization: this.getAuthHeader(), "Content-Type": "application/json" },
         body: JSON.stringify({
           status: "processing",
-          opencode_session_id: sessionId,
+          ...this.sessionIdBody(sessionId, conversationId, messageId, "processing"),
           ...opencodeMessageId ? { opencode_message_id: opencodeMessageId } : {},
           ...title ? { title } : {}
         })
@@ -3967,6 +4154,11 @@ var ChannelDriver = class {
         headers: { Authorization: this.getAuthHeader(), "Content-Type": "application/json" },
         body: JSON.stringify({
           status: "done",
+          // ALWAYS sent, even for a session this conversation has abandoned
+          // (#553): the server reads the reply text back out of THIS session id
+          // to deliver it. Omitting it would leave the user with "✅ Done!"
+          // instead of the answer — a worse regression than the resurrection it
+          // would prevent, which `ensureSession`'s guard handles anyway.
           opencode_session_id: sessionId,
           ...opencodeMessageId ? { opencode_message_id: opencodeMessageId } : {},
           ...title ? { title } : {},
@@ -3983,14 +4175,23 @@ var ChannelDriver = class {
   }
   /**
    * Mark a message `failed`. `sessionId` / `error` are threaded to the API ONLY
-   * when provided (issue #182): a bare `markFailed(conv, msg)` sends
-   * `{status:'failed'}` unchanged (the dispatch-failure path), while an errored
-   * OpenCode turn sends `{status:'failed', opencode_session_id, error}` so the
-   * failure reason reaches the channel.
+   * when provided (issue #182). Three states for `sessionId`:
+   *   - omitted (`undefined`)  → don't send the field, leave the persisted
+   *     session untouched (unused today; kept for API symmetry).
+   *   - a real id (`string`)   → send it, update the persisted session (the
+   *     turn-failure call sites: an errored OpenCode turn).
+   *   - explicit `null`        → send it, CLEAR the persisted session (issue
+   *     #485's dispatch-handoff-failure call site: the session id still
+   *     exists but is wedged, so the next attempt must get a fresh one
+   *     instead of reusing it — see WI-1's server-side null-clearing PATCH).
    */
   async markFailed(conversationId, messageId, sessionId, error2, usage) {
     const body = { status: "failed" };
-    if (sessionId !== void 0) body.opencode_session_id = sessionId;
+    if (sessionId === null) {
+      body.opencode_session_id = null;
+    } else if (sessionId !== void 0) {
+      Object.assign(body, this.sessionIdBody(sessionId, conversationId, messageId, "failed"));
+    }
     if (error2 !== void 0) body.error = error2;
     if (usage) Object.assign(body, usage);
     await this.callWithRetry(