@evident-ai/cli 3.1.1-dev.186f6ef → 3.1.1-dev.2f78b33

package/dist/index.js

@@ -499,6 +499,12 @@ function log(level, event, fields) {
     );
   }
 }
+function errorFields(err) {
+  if (err instanceof Error) {
+    return { error: err.message, error_name: err.name };
+  }
+  return { error: String(err) };
+}
 function stripQuery(url) {
   try {
     return new URL(url).pathname;
@@ -734,7 +740,7 @@ function buildOpenCodeVersionWarning(version2) {
   if (isQueueValidatedVersion(version2)) return null;
   const detected = version2 ? `v${version2}` : "unknown";
   const validated = QUEUE_VALIDATED_OPENCODE_VERSIONS.map((v) => `v${v}`).join(", ");
-  return `Warning: opencode ${detected} is not a queue-validated version (validated: ${validated}). Native message queuing \u2014 which channel (Slack/WhatsApp) message handling relies on \u2014 is unverified on this version; queued/follow-up messages may behave unexpectedly. Continuing anyway. Bumping the validated set requires re-running the queue validation.`;
+  return `Warning: opencode ${detected} is not a queue-validated version (validated: ${validated}). Native message queuing \u2014 which channel (Slack) message handling relies on \u2014 is unverified on this version; queued/follow-up messages may behave unexpectedly. Continuing anyway. Bumping the validated set requires re-running the queue validation.`;
 }
 
 // src/lib/opencode/process.ts
@@ -1026,6 +1032,12 @@ async function promptOpenCodeInstall(interactive) {
   return action;
 }
 
+// src/lib/opencode/provider-check.ts
+function buildNoProviderWarning(hasProvider) {
+  if (hasProvider !== false) return null;
+  return "Warning: opencode has no authenticated model provider configured, so it won't be able to answer prompts. Run `opencode auth login` to set one up (see https://opencode.ai for details).";
+}
+
 // src/lib/opencode/session.ts
 function opencodeBase(port) {
   return `http://127.0.0.1:${port}`;
@@ -1228,6 +1240,11 @@ async function getModelAttachmentCapability(port, model) {
     }
     const entry = provider.models[modelId];
     if (!entry || typeof entry !== "object") return null;
+    if (entry.capabilities && typeof entry.capabilities === "object") {
+      if (typeof entry.capabilities.attachment === "boolean") {
+        return entry.capabilities.attachment;
+      }
+    }
     return typeof entry.attachment === "boolean" ? entry.attachment : null;
   } catch (err) {
     console.error(
@@ -1256,6 +1273,16 @@ async function buildFileParts(attachments, capable) {
       );
       dataUrl = null;
     }
+    if (dataUrl !== null && typeof dataUrl === "object") {
+      outcomes.push({
+        index: a.index,
+        mime: a.mime,
+        filename: a.filename,
+        status: "failed",
+        reason: "needs_reauth"
+      });
+      continue;
+    }
     if (dataUrl == null) {
       outcomes.push({ index: a.index, mime: a.mime, filename: a.filename, status: "failed" });
       continue;
@@ -1484,6 +1511,37 @@ function hasRunningAssistantExcept(messages, exceptUserMessageId) {
     (m) => roleOf(m) === "assistant" && parentIdOf(m) !== exceptUserMessageId && isAssistantInFlight(m)
   );
 }
+async function hasAnyConfiguredProvider(port) {
+  try {
+    const res = await fetch(`${opencodeBase(port)}/config/providers`);
+    if (!res.ok) {
+      console.error(
+        `[hasAnyConfiguredProvider] GET /config/providers returned HTTP ${res.status} (port ${port})`
+      );
+      return null;
+    }
+    const body = await res.json();
+    if (!body || typeof body !== "object" || Array.isArray(body)) {
+      console.error(
+        `[hasAnyConfiguredProvider] GET /config/providers body was not a plain object (port ${port})`
+      );
+      return null;
+    }
+    const defaults2 = body.default;
+    if (!defaults2 || typeof defaults2 !== "object" || Array.isArray(defaults2)) {
+      console.error(
+        `[hasAnyConfiguredProvider] GET /config/providers body had no \`default\` object (port ${port})`
+      );
+      return null;
+    }
+    return Object.keys(defaults2).length > 0;
+  } catch (err) {
+    console.error(
+      `[hasAnyConfiguredProvider] GET /config/providers failed (port ${port}): ${err instanceof Error ? err.message : String(err)}`
+    );
+    return null;
+  }
+}
 
 // src/lib/opencode/session-cleanup.ts
 var DURATION_UNIT_MS = {
@@ -1642,10 +1700,11 @@ var StreamForwarder = class {
    * Abort every in-flight stream (e.g. on WebSocket close).
    */
   abortAll() {
-    for (const stream of this.inflight.values()) {
+    for (const [sid, stream] of this.inflight.entries()) {
       try {
         stream.abort();
-      } catch {
+      } catch (err) {
+        log("error", "forwarder_abort_failed", { sid, ...errorFields(err) });
       }
     }
     this.inflight.clear();
@@ -1795,7 +1854,6 @@ function connectTunnel(options) {
     onConnected,
     onDisconnected,
     onError,
-    onRequest,
     onResponse,
     onInfo,
     onDrainPing
@@ -1808,18 +1866,8 @@ function connectTunnel(options) {
         Authorization: authHeader
       }
     });
-    const streamStartTimes = /* @__PURE__ */ new Map();
     const forwarder = new StreamForwarder(ws, port, {
-      onOpen: (sid, method, path) => {
-        if (path === TUNNEL_DRAIN_PING_PATH) return;
-        streamStartTimes.set(sid, Date.now());
-        onRequest?.(method, path, sid);
-      },
-      onHead: (sid, status) => {
-        const startedAt = streamStartTimes.get(sid);
-        streamStartTimes.delete(sid);
-        onResponse?.(status, startedAt ? Date.now() - startedAt : 0, sid);
-      },
+      onHead: () => onResponse?.(),
       onDrainPing: () => onDrainPing?.()
     });
     const connectionTimeout = setTimeout(() => {
@@ -1895,7 +1943,6 @@ function connectTunnel(options) {
     ws.on("close", (code, reason) => {
       const reasonStr = reason.toString() || upgradeRejection || (code === 1006 ? "abnormal closure" : "No reason provided");
       forwarder.abortAll();
-      streamStartTimes.clear();
       onDisconnected?.(code, reasonStr);
     });
   });
@@ -1930,7 +1977,11 @@ var RunnerConnection = class {
     if (this.connection) {
       try {
         this.connection.close();
-      } catch {
+      } catch (err) {
+        log("error", "runner_connection_close_failed", {
+          agent_id: this.resolvedAgentId,
+          ...errorFields(err)
+        });
       }
       this.connection = null;
     }
@@ -2033,7 +2084,7 @@ function backoffDelay(attempt, policy) {
 function isRetryableStatus(status) {
   return status === 429 || status >= 500 && status <= 599;
 }
-var ChannelDriver = class {
+var ChannelDriver = class _ChannelDriver {
   agentId;
   port;
   apiUrl;
@@ -2158,9 +2209,12 @@ var ChannelDriver = class {
   sessionParents = /* @__PURE__ */ new Map();
   /**
    * Per-session OpenCode title cache (#310), keyed by sessionId. Only a resolved
-   * NON-EMPTY name is stored (terminal — a real session name won't later un-name),
-   * so we do NOT re-GET `/session/:id` every tick. A missing entry = not yet
-   * resolved OR resolved-but-still-empty → re-fetch on next need, since OpenCode
+   * NON-EMPTY, non-placeholder name is stored (terminal — a real session name
+   * won't later un-name), so we do NOT re-GET `/session/:id` every tick. "Non-empty"
+   * excludes OpenCode's synchronous default title (see
+   * `OPENCODE_DEFAULT_TITLE_PREFIX`, #549) — that placeholder is treated the same
+   * as an empty title so it never latches. A missing entry = not yet resolved OR
+   * resolved-but-still-empty/placeholder → re-fetch on next need, since OpenCode
    * names sessions asynchronously mid-turn. Driver-level (not per-watcher) so both
    * the watcher completion path AND the restart-recovery re-adopt path (which has
    * no watcher) can resolve the title.
@@ -2384,7 +2438,8 @@ var ChannelDriver = class {
       } catch (err) {
         if (err instanceof ChannelAuthError) throw err;
         this.dispatched.delete(message.id);
-        if (await sessionExists(this.port, sessionId) === false) {
+        const exists = await sessionExists(this.port, sessionId);
+        if (exists === false) {
           this.sessions.delete(conv.id);
           this.log({
             level: "warn",
@@ -2394,15 +2449,32 @@ var ChannelDriver = class {
           });
           break;
         }
-        await this.markFailed(conv.id, message.id).catch(() => {
+        if (exists === null) {
+          this.log({
+            level: "warn",
+            message: `Message ${message.id.slice(0, 8)} dispatch failed and session (${sessionId.slice(0, 8)}) existence could not be confirmed (opencode momentarily unreachable) \u2014 deferring this and later messages for conversation ${conv.id.slice(0, 8)} to the next tick rather than treating it as a genuine failure.`,
+            conversation_id: conv.id,
+            message_id: message.id
+          });
+          break;
+        }
+        const errorMessage = err instanceof Error ? err.message : String(err);
+        this.sessions.delete(conv.id);
+        await this.markFailed(conv.id, message.id, null, errorMessage).catch((markErr) => {
+          this.log({
+            level: "warn",
+            message: `markFailed PATCH for message ${message.id.slice(0, 8)} (conversation ${conv.id.slice(0, 8)}) failed (best-effort, not retried): ${markErr instanceof Error ? markErr.message : String(markErr)}`,
+            conversation_id: conv.id,
+            message_id: message.id
+          });
         });
         this.log({
           level: "error",
-          message: `Message ${message.id.slice(0, 8)} dispatch failed: ${err instanceof Error ? err.message : String(err)}`,
+          message: `Message ${message.id.slice(0, 8)} dispatch failed: ${errorMessage}`,
           conversation_id: conv.id,
           message_id: message.id
         });
-        continue;
+        break;
       }
       if (opencodeMessageId === null) {
         this.log({
@@ -2532,7 +2604,11 @@ var ChannelDriver = class {
    * (not-owned / out-of-range / deleted-at-source / workspace gone) / 413
    * (over-cap). On ANY non-2xx or thrown failure we return `null` so the caller
    * OMITS that one image and the text turn still sends — NEVER throws the turn.
-   * Failures are logged with context (no silent swallow).
+   * A 404 body carrying `{ reason: 'needs_reauth' }` (#547 — the server CONFIRMED
+   * a Slack `files:read` scope problem via `files.info`) instead resolves the
+   * `AttachmentFetchNeedsReauth` sentinel, so the in-thread note can steer the
+   * user to reconnect Slack instead of a generic "unavailable". Failures are
+   * logged with context (no silent swallow).
    */
   async fetchAttachmentDataUrl(messageId, index, mime) {
     try {
@@ -2541,6 +2617,25 @@ var ChannelDriver = class {
         { headers: { Authorization: this.getAuthHeader() } }
       );
       if (!res.ok) {
+        let reason;
+        try {
+          const body = await res.json();
+          if (body && typeof body.reason === "string") reason = body.reason;
+        } catch (parseErr) {
+          this.log({
+            level: "debug",
+            message: `Attachment fetch for message ${messageId.slice(0, 8)} index ${index}: error body was not JSON (${parseErr instanceof Error ? parseErr.message : String(parseErr)}) \u2014 treating as a plain failure`,
+            message_id: messageId
+          });
+        }
+        if (reason === "needs_reauth") {
+          this.log({
+            level: "error",
+            message: `Attachment fetch for message ${messageId.slice(0, 8)} index ${index} returned HTTP ${res.status} \u2014 server confirmed a Slack reauth/scope problem \u2014 omitting this image (text turn proceeds)`,
+            message_id: messageId
+          });
+          return { needsReauth: true };
+        }
         this.log({
           level: "error",
           message: `Attachment fetch for message ${messageId.slice(0, 8)} index ${index} returned HTTP ${res.status} \u2014 omitting this image (text turn proceeds)`,
@@ -2580,6 +2675,9 @@ var ChannelDriver = class {
     if (this.attachmentsSkippedSignalled.has(messageId)) return;
     this.attachmentsSkippedSignalled.add(messageId);
     const skippedReason = capabilityUnknown ? "unknown" : "unsupported";
+    const failedReason = outcomes.some(
+      (o) => o.status === "failed" && o.reason === "needs_reauth"
+    ) ? "needs_reauth" : void 0;
     this.log({
       level: "info",
       message: `Message ${messageId.slice(0, 8)}: ${skipped} image(s) skipped (${capabilityUnknown ? "capability was unreadable \u2014 failed open to text-only" : "model not attachment-capable"}), ${failed} image(s) unavailable (deleted-at-source or fetch failure) \u2014 noting to Evident`,
@@ -2589,7 +2687,8 @@ var ChannelDriver = class {
     void this.postSignal(conversationId, messageId, "attachments_skipped", {
       skipped,
       failed,
-      ...skipped > 0 ? { skipped_reason: skippedReason } : {}
+      ...skipped > 0 ? { skipped_reason: skippedReason } : {},
+      ...failedReason ? { failed_reason: failedReason } : {}
     });
   }
   /** Register a freshly-dispatched message with its session's watcher state. */
@@ -3628,19 +3727,36 @@ var ChannelDriver = class {
     if (parent !== void 0) this.sessionParents.set(sessionId, parent);
     return parent;
   }
+  /**
+   * OpenCode's synchronous default session title (e.g.
+   * `"New session - 1737800000000"`), assigned immediately when a session is
+   * created — before OpenCode's async LLM-based auto-titling later renames it
+   * mid-turn (#549). Matched by this literal, case-sensitive prefix only; the
+   * timestamp suffix's exact format is deliberately NOT matched, since the prefix
+   * alone is the stable, cheap signal and over-anchoring on the timestamp
+   * representation risks silently breaking if OpenCode ever changes it. Accepted
+   * trade-off: a genuine LLM-assigned title that happens to literally start with
+   * this prefix would also fail to latch (see `resolveSessionTitle`) —
+   * vanishingly unlikely in practice, and deliberately not engineered around.
+   */
+  static OPENCODE_DEFAULT_TITLE_PREFIX = /^New session - /;
   /**
    * Resolve (and cache in `sessionTitles`) the OpenCode session TITLE (#310) so the
    * status PATCH can carry it into the "Live sessions" list. Driver-level cache so
    * BOTH the watcher completion path and the restart-recovery re-adopt path (which
    * has no watcher) can use it. `conversationId` is passed only for log context.
    * Best-effort:
-   *   - a resolved NON-EMPTY title is cached and terminal (a real session name
+   *   - a resolved NON-EMPTY title that does NOT match
+   *     `OPENCODE_DEFAULT_TITLE_PREFIX` is cached and terminal (a real session name
    *     won't later un-name), so we do NOT re-GET `/session/:id` every tick;
-   *   - while the title is still absent/empty we do NOT latch it — OpenCode names
-   *     sessions asynchronously mid-turn, so an early call (e.g. at `processing`)
-   *     must leave the cache unresolved and re-fetch on the next need so a later
-   *     call (e.g. at `done`) picks up the name assigned in the meantime. Such a
-   *     call returns `null` (omit the title on THIS PATCH) without caching;
+   *   - while the title is still absent, empty, or matches the OpenCode
+   *     placeholder prefix (#549) we do NOT latch it — OpenCode names sessions
+   *     asynchronously mid-turn, so an early call (e.g. at `processing`) must leave
+   *     the cache unresolved and re-fetch on the next need so a later call (e.g. at
+   *     `done`) picks up the name assigned in the meantime. Such a call returns
+   *     `null` (omit the title on THIS PATCH) without caching. If a session is
+   *     never renamed, the title is omitted forever rather than ever persisting
+   *     the placeholder as a last resort;
    *   - a failed request likewise leaves the cache unresolved (retry next need)
    *     and returns `null` — it must NEVER throw or block completion.
    * A failure is logged with agent/session context (no silent catch).
@@ -3653,7 +3769,7 @@ var ChannelDriver = class {
       if (res.ok) {
         const body = await res.json();
         const title = body && typeof body.title === "string" ? body.title.trim() : "";
-        if (title.length > 0) {
+        if (title.length > 0 && !_ChannelDriver.OPENCODE_DEFAULT_TITLE_PREFIX.test(title)) {
           this.sessionTitles.set(sessionId, title);
           return title;
         }
@@ -3953,10 +4069,15 @@ var ChannelDriver = class {
   }
   /**
    * Mark a message `failed`. `sessionId` / `error` are threaded to the API ONLY
-   * when provided (issue #182): a bare `markFailed(conv, msg)` sends
-   * `{status:'failed'}` unchanged (the dispatch-failure path), while an errored
-   * OpenCode turn sends `{status:'failed', opencode_session_id, error}` so the
-   * failure reason reaches the channel.
+   * when provided (issue #182). Three states for `sessionId`:
+   *   - omitted (`undefined`)  → don't send the field, leave the persisted
+   *     session untouched (unused today; kept for API symmetry).
+   *   - a real id (`string`)   → send it, update the persisted session (the
+   *     turn-failure call sites: an errored OpenCode turn).
+   *   - explicit `null`        → send it, CLEAR the persisted session (issue
+   *     #485's dispatch-handoff-failure call site: the session id still
+   *     exists but is wedged, so the next attempt must get a fresh one
+   *     instead of reusing it — see WI-1's server-side null-clearing PATCH).
    */
   async markFailed(conversationId, messageId, sessionId, error2, usage) {
     const body = { status: "failed" };
@@ -4726,6 +4847,11 @@ async function run(options) {
       { command: "run" },
       state.agentId
     );
+    const agentFlagNotice = "--agent is deprecated, use --runner instead; will be removed in a future release.";
+    log2(state, agentFlagNotice, "warn");
+    if (state.interactive && !state.json) {
+      logActivity(state, { type: "info", level: "warn", message: agentFlagNotice });
+    }
   }
   if (state.idleTimeout === null && (process.env.GITHUB_ACTIONS || process.env.CI)) {
     log2(
@@ -4784,6 +4910,11 @@ async function run(options) {
         { command: "run" },
         state.agentId
       );
+      const agentKeyNotice = "EVIDENT_AGENT_KEY is deprecated, use EVIDENT_RUNNER_KEY instead; will be removed in a future release.";
+      log2(state, agentKeyNotice, "warn");
+      if (state.interactive && !state.json) {
+        logActivity(state, { type: "info", level: "warn", message: agentKeyNotice });
+      }
     }
     if (!state.agentId) {
       if (credentials2.authType === "agent_key") {
@@ -4874,6 +5005,21 @@ async function run(options) {
           logActivity(state, { type: "info", level: "warn", message: versionWarning });
         }
       }
+      const noProviderWarning = buildNoProviderWarning(await hasAnyConfiguredProvider(state.port));
+      if (noProviderWarning) {
+        log2(state, noProviderWarning, "warn");
+        if (state.interactive && !state.json) {
+          logActivity(state, { type: "info", level: "warn", message: noProviderWarning });
+          blank();
+          console.log(chalk6.yellow("\u26A0 No OpenCode model provider is configured."));
+          console.log(
+            chalk6.dim(
+              `Run ${chalk6.cyan("opencode auth login")} to set one up \u2014 messages will fail until then.`
+            )
+          );
+          blank();
+        }
+      }
     } catch (error2) {
       ocSpinner?.fail(error2.message);
       throw error2;