@eventuras/vite-config 0.3.0 → 0.4.0

package/README.md

@@ -10,7 +10,35 @@ This package provides reusable Vite configuration presets for different types of
 
 - Node.js 24+
 - Vite 7 or 8 (peer dependency)
-- TypeScript 6 in the consuming package — the declaration step (`vite-plugin-dts` v5) needs the TypeScript JS Compiler API, which TypeScript 7 no longer ships by default
+- TypeScript 6 or 7 in the consuming package, used to emit declarations (see below)
+
+## Type declarations
+
+The presets build JavaScript only. Emit declarations with the TypeScript compiler
+the package already has, **after** `vite build` (Vite empties `dist` first):
+
+```json
+{
+  "scripts": {
+    "build": "vite build && tsc --emitDeclarationOnly"
+  }
+}
+```
+
+With `@eventuras/typescript-config/library.json` or `react-library.json`,
+`outDir` already resolves to the package's own `dist`. Otherwise set
+`"outDir": "dist"` in the package's `tsconfig.json`.
+
+Keep test and story files out of the emitted types: the shared base config
+excludes them, but a package `tsconfig.json` that sets its own `exclude` replaces
+that list. Re-add the patterns, or point the build at a `tsconfig.build.json`
+that does (`tsc -p tsconfig.build.json --emitDeclarationOnly`).
+
+`tsc` does not rewrite path aliases such as `@/…` in emitted declarations. Use
+relative imports in anything reachable from a public export.
+
+`vite build --watch` rebuilds JavaScript only. Run `tsc --emitDeclarationOnly --watch`
+alongside it when you need live types.
 
 ## Presets
 
@@ -52,7 +80,6 @@ export default defineReactLibConfig({
 
 **Features:**
 - React plugin (Babel or SWC)
-- TypeScript declaration generation
 - Optional Tailwind CSS support
 - 'use client' directive preservation for RSC
 - Configurable module preservation
@@ -106,10 +133,6 @@ All presets support these options:
 - **`preserveModules`**: Keep source structure in output (default: `true`)
 - **`preserveUseClientDirectives`**: Preserve 'use client' for RSC (default: `true`)
 - **`useSWC`**: Use SWC instead of Babel (default: `false`)
-- **`dts`**: TypeScript declaration options
-  - `entryRoot`: Source root (default: `'src'`)
-  - `outDir`: Output directory (default: `'dist'`)
-  - `rollupTypes`: Bundle types into single file (default: `false`)
 
 ## Migration Guide
 
@@ -164,9 +187,8 @@ export default defineReactLibConfig({
 ## Troubleshooting
 
 ### Types not generated
-- Check that your TypeScript files are in `src/`
-- Ensure test files use `.test.ts` or `.spec.ts` extensions
-- Check `dts.entryRoot` and `dts.outDir` options
+- Since 0.4.0 the presets no longer emit declarations. Add `tsc --emitDeclarationOnly` after `vite build` in the package's build script (see [Type declarations](#type-declarations))
+- If `.d.ts` files land outside the package, `outDir` is being resolved relative to a shared config. Upgrade `@eventuras/typescript-config`, or set `outDir` in the package's own `tsconfig.json`
 
 ### 'use client' directives missing
 - Ensure `preserveUseClientDirectives: true` (default for Next.js)

package/dist/react-lib.d.ts

@@ -35,26 +35,6 @@ export interface ReactLibConfig {
      * @default false
      */
     useSWC?: boolean;
-    /**
-     * TypeScript declaration options.
-     */
-    dts?: {
-        /**
-         * Entry root for DTS generation.
-         * @default 'src'
-         */
-        entryRoot?: string;
-        /**
-         * Output directory for .d.ts files.
-         * @default 'dist'
-         */
-        outDir?: string;
-        /**
-         * Roll up types into a single .d.ts file.
-         * @default false
-         */
-        rollupTypes?: boolean;
-    };
     /**
      * Additional Vite configuration to merge.
      */
@@ -62,6 +42,9 @@ export interface ReactLibConfig {
 }
 /**
  * Vite configuration preset for React libraries.
- * Includes React plugin, TypeScript declarations, and common React externals.
+ * Includes React plugin and common React externals.
+ *
+ * Emits JavaScript only. Declarations come from the package's own compiler:
+ * `vite build && tsc --emitDeclarationOnly`.
  */
 export declare function defineReactLibConfig(config: ReactLibConfig): UserConfig;

package/dist/react-lib.js

@@ -1,7 +1,6 @@
 import { defineConfig } from 'vite';
 import react from '@vitejs/plugin-react';
 import tailwindcss from '@tailwindcss/vite';
-import dts from 'vite-plugin-dts';
 import { resolve } from 'node:path';
 import { glob } from 'glob';
 import fs from 'node:fs';
@@ -13,6 +12,14 @@ import { getRuntimeDependencyExternals, NODE_BUILTINS_EXTERNAL } from './externa
  * consumers never need.
  */
 const requireFromHere = createRequire(import.meta.url);
+/**
+ * Strip leading whitespace and any interleaved mix of line and block comments,
+ * so a directive check sees the first real token. Sequential per-style passes
+ * miss mixed orders (a line comment, then a block comment, then the directive).
+ */
+function stripLeadingComments(code) {
+    return code.replace(/^(?:\s+|\/\*[\s\S]*?\*\/\s*|\/\/.*(?:\r?\n|$)\s*)+/, '');
+}
 /**
  * Plugin to preserve 'use client' directives in React Server Components.
  * This ensures client-side code is properly marked when building for Next.js.
@@ -30,18 +37,19 @@ function preserveUseClient() {
                         try {
                             const content = fs.readFileSync(id, 'utf-8');
                             // Remove leading comments to check for 'use client'
-                            const withoutComments = content
-                                .replace(/^(\s*\/\/.*\n)+/, '')
-                                .replace(/^(\s*\/\*[\s\S]*?\*\/\s*)/, '');
-                            return (withoutComments.trimStart().startsWith("'use client'") ||
-                                withoutComments.trimStart().startsWith('"use client"'));
+                            const withoutComments = stripLeadingComments(content);
+                            return (withoutComments.startsWith("'use client'") ||
+                                withoutComments.startsWith('"use client"'));
                         }
                         catch {
                             return false;
                         }
                     });
                     if (hasClientDirective) {
-                        const codeStart = chunkData.code.trimStart();
+                        // Ignore leading banner/license comments (e.g. Rollup's
+                        // output.banner) when checking for the directive, so we don't
+                        // prepend a duplicate above a directive that's already there.
+                        const codeStart = stripLeadingComments(chunkData.code);
                         if (!codeStart.startsWith("'use client'") && !codeStart.startsWith('"use client"')) {
                             chunkData.code = `'use client';\n${chunkData.code}`;
                         }
@@ -53,10 +61,13 @@ function preserveUseClient() {
 }
 /**
  * Vite configuration preset for React libraries.
- * Includes React plugin, TypeScript declarations, and common React externals.
+ * Includes React plugin and common React externals.
+ *
+ * Emits JavaScript only. Declarations come from the package's own compiler:
+ * `vite build && tsc --emitDeclarationOnly`.
  */
 export function defineReactLibConfig(config) {
-    const { entry, external, tailwind = false, preserveModules = true, preserveUseClientDirectives = true, useSWC = false, dts: dtsOptions = {}, viteConfig = {}, } = config;
+    const { entry, external, tailwind = false, preserveModules = true, preserveUseClientDirectives = true, useSWC = false, viteConfig = {}, } = config;
     const autoExternals = external === false ? [] : getRuntimeDependencyExternals();
     const userExternals = Array.isArray(external) ? external : [];
     // Determine entry points
@@ -86,17 +97,6 @@ export function defineReactLibConfig(config) {
     if (tailwind) {
         plugins.push(tailwindcss());
     }
-    // Add DTS plugin
-    plugins.push(dts({
-        entryRoot: dtsOptions.entryRoot || 'src',
-        // vite-plugin-dts v5 renamed `outDir` -> `outDirs` and
-        // `rollupTypes` -> `bundleTypes`; the preset keeps the old names.
-        outDirs: dtsOptions.outDir || 'dist',
-        include: ['src/**/*'],
-        exclude: ['**/*.test.ts', '**/*.test.tsx', '**/*.spec.ts', '**/*.spec.tsx', '**/*.stories.tsx'],
-        copyDtsFiles: true,
-        bundleTypes: dtsOptions.rollupTypes || false,
-    }));
     // Add use client preservation if enabled
     if (preserveUseClientDirectives) {
         plugins.push(preserveUseClient());

package/dist/vanilla-lib.d.ts

@@ -31,5 +31,8 @@ export interface VanillaLibConfig {
  * - Minification is OFF — consumers minify their own bundle, and unminified
  *   output preserves class names (so `instanceof` and stack traces work).
  * - Sourcemaps ON for debuggable consumer stack traces.
+ *
+ * Emits JavaScript only. Declarations come from the package's own compiler:
+ * `vite build && tsc --emitDeclarationOnly`.
  */
 export declare function defineVanillaLibConfig(config: VanillaLibConfig): UserConfig;

package/dist/vanilla-lib.js

@@ -1,5 +1,4 @@
 import { defineConfig } from 'vite';
-import dts from 'vite-plugin-dts';
 import { resolve } from 'node:path';
 import { getRuntimeDependencyExternals, NODE_BUILTINS_EXTERNAL } from './externals.js';
 /**
@@ -12,19 +11,16 @@ import { getRuntimeDependencyExternals, NODE_BUILTINS_EXTERNAL } from './externa
  * - Minification is OFF — consumers minify their own bundle, and unminified
  *   output preserves class names (so `instanceof` and stack traces work).
  * - Sourcemaps ON for debuggable consumer stack traces.
+ *
+ * Emits JavaScript only. Declarations come from the package's own compiler:
+ * `vite build && tsc --emitDeclarationOnly`.
  */
 export function defineVanillaLibConfig(config) {
     const { entry, name, external, viteConfig = {} } = config;
     const autoExternals = external === false ? [] : getRuntimeDependencyExternals();
     const userExternals = Array.isArray(external) ? external : [];
     return defineConfig({
-        plugins: [
-            dts({
-                include: ['src/**/*'],
-                exclude: ['**/*.test.ts', '**/*.test.tsx', '**/*.spec.ts', '**/*.spec.tsx'],
-            }),
-            ...(viteConfig.plugins || []),
-        ],
+        plugins: [...(viteConfig.plugins || [])],
         build: {
             minify: false,
             sourcemap: true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eventuras/vite-config",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -33,14 +33,13 @@
     "@tailwindcss/vite": "^4.3.2",
     "@vitejs/plugin-react": "^6.0.3",
     "@vitejs/plugin-react-swc": "^4.3.0",
-    "glob": "^13.0.6",
-    "vite-plugin-dts": "^5.0.3"
+    "glob": "^13.0.6"
   },
   "devDependencies": {
     "@types/node": "^24.12.0",
     "typescript": "^6.0.2",
     "vite": "^8.1.0",
-    "@eventuras/typescript-config": "1.0.0"
+    "@eventuras/typescript-config": "1.1.0"
   },
   "peerDependencies": {
     "vite": "^7.0.0 || ^8.0.0"