@eventcatalog/core 0.0.10 → 0.0.11

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @eventcatalog/core
 
+## 0.0.11
+
+### Patch Changes
+
+- [`97e447a`](https://github.com/boyney123/eventcatalog/commit/97e447aa0ec255b2c879eac7fa83d7b705230790) [#95](https://github.com/boyney123/eventcatalog/pull/95) Thanks [@boyney123](https://github.com/boyney123)! - fix: edit url is now optional in not found pages and no longer fetche…
+
 ## 0.0.10
 
 ### Patch Changes

package/components/NotFound/index.tsx

@@ -1,17 +1,14 @@
 import { DocumentAddIcon } from '@heroicons/react/solid';
-import url from 'url';
 
 interface NotFoundProps {
   type: 'service' | 'event';
   name: string;
-  editUrl: string;
+  editUrl?: string;
 }
 
 export default function Example(props: NotFoundProps) {
   const { type, name, editUrl } = props;
 
-  const urlToAddPage = url.resolve(editUrl, `${type}/${name}`);
-
   return (
     <main className="min-h-full bg-cover bg-top sm:bg-top h-screen">
       <div className="max-w-7xl mx-auto px-4 py-16 text-center sm:px-6 sm:py-24 lg:px-8 lg:py-48">
@@ -23,17 +20,19 @@ export default function Example(props: NotFoundProps) {
           Documentation for {type} <span className="underline">{name}</span> is missing!
         </p>
         <p className="mt-4 text-xs text-gray-400">Help the eco-system and add the documentation for others ❤️ </p>
-        <div className="mt-12">
-          <a
-            href={urlToAddPage}
-            target="_blank"
-            className="inline-flex items-center px-4 py-2 border border-transparent text-sm font-medium rounded-md text-white bg-black bg-opacity-75 "
-            rel="noreferrer"
-          >
-            <DocumentAddIcon className="-ml-1 mr-2 h-5 w-5" aria-hidden="true" />
-            Add <span className="underline px-1">{name}</span> documentation
-          </a>
-        </div>
+        {editUrl && (
+          <div className="mt-12">
+            <a
+              href={editUrl}
+              target="_blank"
+              className="inline-flex items-center px-4 py-2 border border-transparent text-sm font-medium rounded-md text-white bg-black bg-opacity-75 "
+              rel="noreferrer"
+            >
+              <DocumentAddIcon className="-ml-1 mr-2 h-5 w-5" aria-hidden="true" />
+              Add <span className="underline px-1">{name}</span> documentation
+            </a>
+          </div>
+        )}
       </div>
     </main>
   );

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eventcatalog/core",
-  "version": "0.0.10",
+  "version": "0.0.11",
   "publishConfig": {
     "access": "public"
   },

package/pages/events/[name].tsx

@@ -2,7 +2,6 @@ import Head from 'next/head';
 import { MDXRemote } from 'next-mdx-remote';
 
 import { Event } from '@eventcatalog/types';
-import { editUrl } from '../../eventcatalog.config';
 import Admonition from '@/components/Mdx/Admonition';
 import Examples from '@/components/Mdx/Examples';
 
@@ -69,9 +68,11 @@ export default function Events(props: EventsPageProps) {
   const { event, markdown, loadedVersion, notFound } = props;
   const { getEditUrl, hasEditUrl } = useUrl();
 
-  if (notFound) return <NotFound type="event" name={event.name} editUrl={editUrl} />;
-
   const { name, summary, draft, schema, examples, version } = event;
+
+  if (notFound)
+    return <NotFound type="event" name={event.name} editUrl={hasEditUrl ? getEditUrl(`/events/${name}/index.md`) : ''} />;
+
   const { lastModifiedDate } = markdown;
 
   const pages = [

package/pages/services/[name].tsx

@@ -1,7 +1,6 @@
 import Head from 'next/head';
 import { MDXRemote } from 'next-mdx-remote';
 import { Service } from '@eventcatalog/types';
-import { editUrl } from '../../eventcatalog.config.js';
 import ContentView from '@/components/ContentView';
 import { getAllServices, getServiceByName } from '@/lib/services';
 
@@ -39,7 +38,10 @@ export default function Services(props: ServicesPageProps) {
   const { service, markdown, notFound } = props;
   const { getEditUrl, hasEditUrl } = useUrl();
 
-  if (notFound) return <NotFound type="service" name={service.name} editUrl={editUrl} />;
+  if (notFound)
+    return (
+      <NotFound type="service" name={service.name} editUrl={hasEditUrl ? getEditUrl(`/services/${service.name}/index.md`) : ''} />
+    );
 
   const { name, summary, draft } = service;
   const { lastModifiedDate } = markdown;