@event4u/agent-config 16.3.0 → 16.5.0

package/dist/scripts/_lib/settings_removed_keys.js

@@ -0,0 +1,168 @@
+/**
+ * The registry of DELETED settings keys, and the once-per-run notice a leftover
+ * value gets. Extracted from `agent_settings.ts`, which sits at the 1500-line
+ * source ceiling — every retirement batch adds entries here, and here they cost
+ * no ratchet. `agent_settings.ts` re-exports `REMOVED_KEYS` so existing
+ * importers (the loader, `lint_settings_classes`) are unchanged.
+ */
+/**
+ * Settings keys this package has DELETED. A leftover value from an older
+ * install is ignored — never applied by any reader — and surfaced with ONE
+ * deprecation line per key per process run (stderr; the exit code never
+ * changes).
+ *
+ * The map carries a per-key REASON rather than one shared sentence, because
+ * the list now spans more than one deletion doctrine and a single blanket
+ * phrase would mis-attribute every future entry. A reader who hits the line
+ * should learn why the key went, not just that it did.
+ *
+ * `subagents.*` — the always-on-orchestration doctrine
+ * (road-to-always-on-orchestration Phase 1): the layer has no per-layer
+ * on/off setting any more. `ai_team.enabled` joined in Step 1.3 — the
+ * `/team` family's availability is a codex-CLI/auth FACT
+ * (`src/scripts/ai_team/availability.ts`), not a flag; the `ai_team` config
+ * loader (`src/scripts/ai_team/config.ts`) separately accepts a leftover
+ * `enabled` key without failing closed, so this warning is the only surfaced
+ * signal of that deletion.
+ *
+ * `hooks.turn_end_gate.*` — the turn-end gate is always armed (2026-08-12).
+ * A default-off safety gate cannot soak, so the switch protecting the soak
+ * made the soak impossible; whether the gate fires is now decided by each
+ * detector's own trigger conditions. See `turn_end_gate_hook.ts` § "Always
+ * armed".
+ *
+ * The five `derivable` leaves below (2026-08-12, road-to-zero-settings Phase
+ * 2.1) are a different case from every entry above them, and the difference is
+ * the whole safety argument: no code path ever *consulted* them. Each appeared
+ * in the template, the schema and the reference page, and several in the setup
+ * wizard, while the decision they looked like they governed was taken
+ * elsewhere. A key nothing reads cannot change a default by leaving — so this
+ * is the one deletion batch that needs no replacement mechanism, only the
+ * per-key statement of what already decides.
+ *
+ * A sixth unread key, `screenshots.data_bearing_gate`, was found in the same
+ * pass and deliberately NOT deleted — it is `consent`, and the open question is
+ * whether the repair is to build its missing reader or to delete a promise a
+ * Hard Floor can never honour. See `settings-classes.md` § The six unread keys.
+ *
+ * `worktrees.mode` (2026-08-13, ADR-229) is a third doctrine again: not
+ * always-on, not unread. It WAS read, and the reader honoured all three values —
+ * the deletion says the decision was never the agent's to make. `ask` bought a
+ * round trip per spawn, `on` let the agent start parallel work unprompted, and
+ * `off` described the wanted behavior, so `off` became the hardcoded rule and
+ * the switch went. What decides instead is the user's own sentence in the chat.
+ *
+ * The 2026-10-09 batch (road-to-settings-classes-derivable-surface-stagnation
+ * Phase 2) is a fourth doctrine: `derivable` keys whose shipped default is the
+ * only behavior the package supports. Each WAS read — by code or by rule and
+ * command prose — and every reader was rewritten to state the old default as
+ * fixed behavior in the same change, so retiring the key changes no effective
+ * default; what a consumer who had set a non-default value loses is named by
+ * the reason.
+ *
+ * Every reason string must name what decides INSTEAD, never just "removed".
+ * Exported so `lint_settings_classes` can check the deletion side of the
+ * surface: a reason that names no replacement, or an entry whose key is live in
+ * the template again, is a contradiction the loader itself cannot notice.
+ */
+export const REMOVED_KEYS = new Map([
+    ['subagents.enabled', 'always-on orchestration'],
+    ['subagents.auto', 'always-on orchestration'],
+    ['subagents.host_capabilities', 'always-on orchestration'],
+    ['subagents.budget_routing', 'always-on orchestration'],
+    ['ai_team.enabled', 'always-on orchestration'],
+    ['hooks.turn_end_gate.enabled', 'the turn-end gate is always armed'],
+    ['hooks.turn_end_gate.promissory', 'the turn-end gate is always armed'],
+    ['hooks.turn_end_gate.language', 'the turn-end gate is always armed'],
+    ['hooks.turn_end_gate.verification', 'the turn-end gate is always armed'],
+    ['telegraph.speak_scope', 'the rule body states its own scope; compile_time_toggles decides whether the rule ships'],
+    ['chat_history.max_size_kb', 'the rotate command takes --max-kb from argv; session-count pruning bounds the file'],
+    ['chat_history.on_overflow', 'the overflow mode comes from the rotate command --mode argv'],
+    ['quality.wait_for_remote_ci', 'whether to poll follows from the push plus a detectable remote pipeline'],
+    ['legal_review_prep.consented_at', 'the provenance sidecar settings:set writes and consentVerdict reads'],
+    ['worktrees.mode', 'the user asking for a worktree in the chat; creation is instruction-only and hardcoded'],
+    // 2026-10-09 — output and tone
+    ['personal.minimal_output', 'direct-answers Iron Law 3 mandates terse replies; there is no verbose mode'],
+    ['personal.play_by_play', 'direct-answers: no narration unless the user asks for it in the turn'],
+    ['personal.pr_comment_bot_icon', 'no-decorative-emojis-in-git-surfaces forbids the 🤖 prefix'],
+    ['verbosity.intent_announcements', 'direct-answers: act and emit the result, no "Let me…" openers'],
+    ['verbosity.preview_artifacts', 'generated content is used directly; preview-on-error and the Iron-Law gates decide when a preview shows'],
+    ['verbosity.routine_confirmations', 'the no-cheap-questions Pre-Send Self-Check; Iron-Law gates always ask'],
+    ['verbosity.post_action_reports', 'direct-answers Iron Law 3: a one-line confirmation and one end-summary'],
+    ['telegraph.speak', 'the telegraph-speak predicate in compile_time_toggles.ts; the bench verdict is package-level (ADR telegraph/0002)'],
+    ['tokens.rich_skills', "the skill's own token_budget_class: rich plus the lint_token_budget_discipline ceiling"],
+    // 2026-10-09 — reasoning protocol switches
+    ['reasoning.auto_gate', 'the RDP gate task signal plus the host self-assessment in rdp-gate.md'],
+    ['reasoning.components.orchestrator', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.notes_first', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.grounding', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.intent', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.complexity_first', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.verifier_default', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.prediction_tracking', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.decision_ledger', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    ['reasoning.components.uncertainty_budget', 'the RDP gate task and host signals decide per component; reasoning.enabled stays the hard off'],
+    // 2026-10-09 — roadmap cadence
+    ['roadmap.skip_pre_run_gate', 'the command name names the scope; only an ambiguous roadmap or an unresolvable conflict shows the gate'],
+    ['roadmap.dashboard_regen_cadence', 'a fixed cadence: every 5th closed step, every phase boundary, reply end and any file-shape touch'],
+    // 2026-10-09 — command suggestion and PR creation
+    ['commands.auto_detect', "an orchestrator's own auto_detect front-matter and the --no-auto-detect flag"],
+    ['commands.suggestion.enabled', 'the suggester match-score floor and cooldown; /command-suggestion-off silences one conversation'],
+    ['commands.suggestion.confidence_floor', "the suggester's fixed 0.6 floor; a command's own suggestion frontmatter can tighten it"],
+    ['commands.suggestion.cooldown_seconds', "the suggester's fixed 600-second cooldown; a command's own suggestion frontmatter can lengthen it"],
+    ['commands.suggestion.max_options', 'the fixed cap of 4 suggestions plus the always-present as-is option'],
+    ['commands.create_pr.api_examples', "/create-pr's grounding rule: an example only from a real source, otherwise a one-line pointer"],
+    ['commands.create_pr.ui_paths', "/create-pr's light frontend heuristic, which fails open"],
+    ['commands.create_pr.api_paths', "/create-pr's light API-endpoint heuristic, which fails open"],
+    // 2026-10-09 — memory and knowledge sharing
+    ['memory.cadence', 'a fixed cadence: the memory line renders whenever a memory type was asked; memory.visibility: off still silences it'],
+    ['memory.review_threshold', "/memory load's fixed preview threshold of 10 unreviewed intake signals"],
+    ['knowledge.global_sharing.redaction.enabled', 'the write-time redaction scan, which always runs before a card goes global'],
+    ['knowledge.global_sharing.redaction.halt_on_trigger', 'the redaction gate, which always halts on a confidential-pattern hit'],
+    ['knowledge.global_sharing.auto_promote_threshold', 'the fixed two-repo sighting count that triggers a promotion suggestion'],
+    ['knowledge.global_sharing.freshness.hypothesis_after_days', "the card's age over last_verified against the fixed 90-day lead-only window"],
+    ['knowledge.global_sharing.freshness.stale_after_days', "the card's age over last_verified against the fixed 180-day skip window"],
+    // 2026-10-09 — hooks and engine
+    ['hooks.concern_budget.max_per_event', "the concern-budget gate's own constant of 8 per (platform, event) cell"],
+    ['hooks.concern_budget.hard_fail', "the concern-budget gate's --strict argv; without it the gate warns"],
+    ['decision_engine.surface_traces', 'nothing: the per-phase decision trace stays off, the old default'],
+    ['decision_engine.on_block_fallback', 'the fail-safe: an on_block ask that times out always stops'],
+    ['explain.enable_last', 'the presence of a work-state trace; explain last always renders it'],
+    // 2026-10-09 — remaining
+    ['project.pr_template', '/create-pr, which reads .github/pull_request_template.md'],
+    ['pipelines.skill_improvement', 'the skill-improvement-trigger rule; the capture is a proposal the user confirms'],
+    ['consistency.cross_source', 'the cross-source-consistency rule, always on; batching and the no-cheap-questions floor bound the noise'],
+    ['subagents.downshift', 'the model_tier each sub-task declares; downshift is always on'],
+    ['ai_team.suppress_setup_hint', 'nothing: the one-line team-mode setup hint is always shown'],
+]);
+/** Keys already warned about in THIS process — the "once per run" dedupe. */
+const _warnedRemovedKeys = new Set();
+/** Read one dotted path out of a merged settings tree; `undefined` when absent. */
+function _readDotted(root, dotted) {
+    let node = root;
+    for (const part of dotted.split('.')) {
+        if (typeof node !== 'object' || node === null || Array.isArray(node)) {
+            return undefined;
+        }
+        node = node[part];
+    }
+    return node;
+}
+/**
+ * Warn once per process, on stderr, for every {@link REMOVED_KEYS} entry still
+ * present in a resolved settings tree. Never throws, never changes what the
+ * caller does with `merged` — a pure notification side effect.
+ */
+export function warnRemovedKeys(merged) {
+    for (const [key, reason] of REMOVED_KEYS) {
+        if (_warnedRemovedKeys.has(key)) {
+            continue;
+        }
+        if (_readDotted(merged, key) === undefined) {
+            continue;
+        }
+        _warnedRemovedKeys.add(key);
+        process.stderr.write(`${key} was removed (${reason}); ignored.\n`);
+    }
+}
+//# sourceMappingURL=settings_removed_keys.js.map

package/dist/scripts/_lib/svg_dom.js

@@ -0,0 +1,284 @@
+/**
+ * svg_dom — a dependency-free XML well-formedness parser, and the tree it
+ * builds.
+ *
+ * Step 3.1 of `road-to-svg-review-followups`, amending step 1.1 of
+ * `road-to-svg-with-a-witness`. Review claim C11: a regex cannot prove nesting
+ * or resolve a reference, and the alternatives were all refused for reasons
+ * that still hold — `package.json`'s runtime dependencies carry no XML parser,
+ * `happy-dom` is dev-only, the three vendored tree-sitter grammars are php,
+ * typescript and javascript, and Playwright is absent in a consumer, so the
+ * browser cannot carry a static layer. The remaining option is to write one,
+ * which is what `lint_design_quality` already does for its own surface.
+ *
+ * WHAT IT IS. One scanner over the bytes, producing every node kind an SVG
+ * carries — elements with their attributes, comments, CDATA sections,
+ * processing instructions, DOCTYPEs and text — each with a line and a column,
+ * assembled into a tree with parent links, plus a list of well-formedness
+ * errors.
+ *
+ * TWO SCANNERS, NOT ONE, and this header used to claim otherwise.
+ * `parseElements` in `svg_rules.ts` is an independent scanner over the same
+ * bytes, so the two CAN disagree about what a file contains — finding 3 of the
+ * third completion review of this change found a case where they did, and the
+ * disagreement produced an error-severity false positive. That one is fixed
+ * where it was (the prolog), but the general claim was false and is not
+ * restored: a reader deciding whether a fix here also lands there must check,
+ * not assume. Merging them is a larger change than the finding asked for and
+ * is not attempted under a remediation.
+ *
+ * WHAT IT IS NOT. Not a validating parser, not namespace-aware beyond keeping
+ * the prefix in the name, and it does not expand entities. It reports that a
+ * file is not well-formed; it does not report which schema it violates.
+ *
+ * WHY A FILE THAT IS NOT WELL-FORMED IS A FINDING RATHER THAN A SKIPPED FILE.
+ * A skipped file reads as a clean one in every count that matters, and the
+ * shape this exists to catch — `<g><path></g></path>` — is exactly the shape a
+ * flat element list cannot see: both tags are present, both are spelled
+ * correctly, and the document is nonetheless not a tree.
+ */
+/** 1-based line and column of an offset. Built once per parse. */
+function positions(content) {
+    const starts = [0];
+    for (let i = 0; i < content.length; i += 1) {
+        if (content[i] === '\n')
+            starts.push(i + 1);
+    }
+    return (offset) => {
+        // Binary search for the last line start at or before `offset`.
+        let lo = 0;
+        let hi = starts.length - 1;
+        while (lo < hi) {
+            const mid = (lo + hi + 1) >> 1;
+            if (starts[mid] <= offset)
+                lo = mid;
+            else
+                hi = mid - 1;
+        }
+        return { line: lo + 1, column: offset - starts[lo] + 1 };
+    };
+}
+/**
+ * End of the tag, honouring quoted attribute values that may contain `>`.
+ *
+ * Exported because `svg_rules.parseElements` scans the same bytes and had its
+ * own byte-identical copy — finding 9 of the third completion review, which
+ * also noted that BOTH copies ship in the per-`.svg`-write hook chunk. Two
+ * scanners is a fact this file's header now states plainly; two copies of
+ * their shared primitives is not a consequence of it.
+ */
+export function tagEnd(content, from) {
+    let quote = null;
+    for (let i = from + 1; i < content.length; i += 1) {
+        const ch = content[i];
+        if (quote !== null) {
+            if (ch === quote)
+                quote = null;
+            continue;
+        }
+        if (ch === '"' || ch === "'") {
+            quote = ch;
+            continue;
+        }
+        if (ch === '>')
+            return i;
+    }
+    return -1;
+}
+/** Attributes of one tag, lowercased keys. Shared with `svg_rules` — see `tagEnd`. */
+export function attrsOf(raw) {
+    const attrs = {};
+    const re = /([A-Za-z_:][\w.:-]*)\s*=\s*("([^"]*)"|'([^']*)')/g;
+    let m;
+    while ((m = re.exec(raw)) !== null) {
+        const key = (m[1] ?? '').toLowerCase();
+        const value = m[3] ?? m[4] ?? '';
+        attrs[key] = value.replace(/&amp;/g, '&');
+    }
+    return attrs;
+}
+/**
+ * Parse one document.
+ *
+ * Never throws: a malformed file produces whatever tree could be built plus
+ * the errors that explain it. A parser that threw would make an unparseable
+ * file indistinguishable from a crash, and the caller's job is to REPORT the
+ * file, not to fall over on it.
+ */
+export function parseDocument(content) {
+    const at = positions(content);
+    const roots = [];
+    const elements = [];
+    const errors = [];
+    const stack = [];
+    const make = (kind, start, name = '', value = '', attrs = {}) => {
+        const { line, column } = at(start);
+        return { kind, name, attrs, line, column, start, value, children: [], parent: null };
+    };
+    const append = (node) => {
+        const parent = stack[stack.length - 1];
+        if (parent === undefined) {
+            roots.push(node);
+        }
+        else {
+            node.parent = parent;
+            parent.children.push(node);
+        }
+    };
+    let i = 0;
+    while (i < content.length) {
+        const lt = content.indexOf('<', i);
+        if (lt === -1) {
+            const rest = content.slice(i);
+            if (rest.trim() !== '')
+                append(make('text', i, '', rest));
+            break;
+        }
+        if (lt > i) {
+            const text = content.slice(i, lt);
+            if (text.trim() !== '')
+                append(make('text', i, '', text));
+        }
+        if (content.startsWith('<!--', lt)) {
+            const end = content.indexOf('-->', lt + 4);
+            if (end === -1) {
+                const p = at(lt);
+                errors.push({ message: 'unterminated comment', line: p.line, column: p.column });
+                append(make('comment', lt, '', content.slice(lt + 4)));
+                break;
+            }
+            append(make('comment', lt, '', content.slice(lt + 4, end)));
+            i = end + 3;
+            continue;
+        }
+        if (content.startsWith('<![CDATA[', lt)) {
+            const end = content.indexOf(']]>', lt + 9);
+            if (end === -1) {
+                const p = at(lt);
+                errors.push({ message: 'unterminated CDATA section', line: p.line, column: p.column });
+                append(make('cdata', lt, '', content.slice(lt + 9)));
+                break;
+            }
+            append(make('cdata', lt, '', content.slice(lt + 9, end)));
+            i = end + 3;
+            continue;
+        }
+        if (content.startsWith('<?', lt)) {
+            const end = content.indexOf('?>', lt + 2);
+            if (end === -1) {
+                // Finding 11 of this change's completion review: this and the
+                // declaration below swallowed the rest of the document into one
+                // node and returned cleanly, so a file ending in
+                // `<?xml version="1.0"` read as WELL-FORMED — a skip, under a
+                // contract whose whole point is that a file which does not
+                // parse is a finding rather than a skipped file.
+                const p = at(lt);
+                errors.push({ message: 'unterminated processing instruction', line: p.line, column: p.column });
+            }
+            const stop = end === -1 ? content.length : end + 2;
+            append(make('pi', lt, '', content.slice(lt + 2, end === -1 ? content.length : end)));
+            i = stop;
+            continue;
+        }
+        if (content.startsWith('<!', lt)) {
+            // A DOCTYPE may carry a bracketed internal subset; it ends after it.
+            const bracket = content.indexOf('[', lt);
+            const close = content.indexOf('>', lt);
+            let stop;
+            if (bracket !== -1 && close !== -1 && bracket < close) {
+                const endBracket = content.indexOf(']', bracket);
+                const after = endBracket === -1 ? close : content.indexOf('>', endBracket);
+                stop = after === -1 ? content.length : after + 1;
+            }
+            else {
+                stop = close === -1 ? content.length : close + 1;
+            }
+            if (close === -1) {
+                const p = at(lt);
+                errors.push({ message: 'unterminated declaration', line: p.line, column: p.column });
+            }
+            append(make('doctype', lt, '', content.slice(lt + 2, Math.max(lt + 2, stop - 1))));
+            i = stop;
+            continue;
+        }
+        const gt = tagEnd(content, lt);
+        if (gt === -1) {
+            const p = at(lt);
+            errors.push({ message: 'unterminated tag', line: p.line, column: p.column });
+            break;
+        }
+        const raw = content.slice(lt, gt + 1);
+        const nameMatch = /^<\/?\s*([A-Za-z_][\w.:-]*)/.exec(raw);
+        if (!nameMatch) {
+            // Finding 11, third case: a `<` that opens something with no legal
+            // element name is malformed markup, not whitespace. Skipping it
+            // silently is the same skip the other two were.
+            const p = at(lt);
+            errors.push({ message: `"${raw.slice(0, 24)}" is not a tag`, line: p.line, column: p.column });
+            i = gt + 1;
+            continue;
+        }
+        const name = (nameMatch[1] ?? '').toLowerCase();
+        const closing = raw.startsWith('</');
+        const selfClosing = raw.endsWith('/>');
+        if (closing) {
+            const open = stack[stack.length - 1];
+            const p = at(lt);
+            if (open === undefined) {
+                errors.push({ message: `closing tag </${name}> with no open element`, line: p.line, column: p.column });
+            }
+            else if (open.name !== name) {
+                // The shape a flat element list cannot see. Reported against
+                // the CLOSING tag, which is where a reader looking at the file
+                // sees the problem.
+                errors.push({
+                    message: `closing tag </${name}> does not match the open <${open.name}> (line ${String(open.line)})`,
+                    line: p.line,
+                    column: p.column,
+                });
+                // Recover by popping to the matching open element WHEN THERE
+                // IS ONE, so a single mistake does not cascade into an error
+                // per remaining tag.
+                //
+                // When there is none, pop NOTHING. Finding 2 of the fourth
+                // completion review: the `else stack.pop()` detached a
+                // perfectly good ancestor to pay for a stray tag that never
+                // opened anything — a file whose `</g>` has no `<g>` lost its
+                // `<svg>` from the stack, so the real `</svg>` at the end then
+                // had no open element and the file collected a SECOND error it
+                // had not earned. Cascading is exactly what this branch exists
+                // to prevent, and the unmatched case was the one where it did
+                // the cascading itself. A closing tag with no match is a stray
+                // tag: report it and carry on.
+                const idx = stack.map((n) => n.name).lastIndexOf(name);
+                if (idx !== -1)
+                    stack.length = idx;
+            }
+            else {
+                stack.pop();
+            }
+            i = gt + 1;
+            continue;
+        }
+        const node = make('element', lt, name, '', attrsOf(raw));
+        append(node);
+        elements.push(node);
+        if (!selfClosing)
+            stack.push(node);
+        i = gt + 1;
+    }
+    for (const unclosed of stack) {
+        errors.push({
+            message: `<${unclosed.name}> is never closed`,
+            line: unclosed.line,
+            column: unclosed.column,
+        });
+    }
+    return { roots, elements, errors };
+}
+// `ancestors` and `documentElement` used to live here. Finding 11 of the third
+// completion review: both were exported, called by nothing, and bundled into
+// the per-`.svg`-write dispatch chunk — own-orphans of this same diff, which
+// `minimal-safe-diff` says the diff that made them removes. `XmlNode.parent`
+// is the primitive either would have been built on and it is still here.
+//# sourceMappingURL=svg_dom.js.map