@evanpurkhiser/eslint-config 0.20.0 → 0.21.0

package/.github/workflows/main.yml

@@ -5,10 +5,17 @@ on:
     branches: [main]
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: volta-cli/action@v4
+      - run: yarn install
+      - run: yarn lint
   publish:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: volta-cli/action@v4
       - name: bump version
         run: |

package/README.md

@@ -7,15 +7,15 @@ These are my eslint configurations that I use across my various personal
 projects.
 
 ```
-yarn install -D @evanpurkihser/eslint-config
+yarn install -D @evanpurkhiser/eslint-config
 ```
 
-Create a `.eslintrc.js` file with the contents:
+Create a `eslint.config.mjs` file with the contents:
 
 ```js
-module.exports = {
-  extends: ['@evanpurkhiser'],
-};
+import {all} from '@evanpurkhiser/eslint-config';
+
+export defaukt [...all];
 ```
 
 The default configuration is for React apps, but you can select from the
@@ -27,7 +27,7 @@ following configurations
 For example:
 
 ```js
-module.exports = {
-  extends: ['@evanpurkhiser/eslint-config/common'],
-};
+import {common} from '@evanpurkhiser/eslint-config';
+
+export defaukt [...common];
 ```

package/eslint.config.mjs

@@ -0,0 +1,3 @@
+import {common} from './src/index.mjs';
+
+export default [...common];

package/package.json

@@ -1,30 +1,35 @@
 {
   "name": "@evanpurkhiser/eslint-config",
-  "version": "0.20.0",
+  "version": "0.21.0",
   "description": "Evan Purkhiser's personal eslint configuration",
   "main": "index.js",
   "repository": "https://github.com/evanpurkhiser/eslint-config",
   "author": "Evan Purkhiser",
   "license": "MIT",
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^6.1.0",
-    "@typescript-eslint/parser": "^6.1.0",
-    "eslint-config-prettier": "^8.8.0",
-    "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-react": "^7.32.2",
-    "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-simple-import-sort": "^10.0.0"
+    "@eslint/js": "^9.15.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-react": "^7.37.2",
+    "eslint-plugin-react-hooks": "^5.0.0",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
+    "globals": "^15.12.0",
+    "typescript-eslint": "^8.16.0"
   },
   "peerDependencies": {
     "eslint": ">=8.0.0",
     "prettier": ">=3.0.0"
   },
   "devDependencies": {
-    "prettier": "^3.0.0"
+    "eslint": "^9.15.0",
+    "prettier": "^3.3.3",
+    "typescript": "^5.7.2"
+  },
+  "scripts": {
+    "lint": "eslint ."
   },
   "volta": {
-    "node": "18.11.0",
-    "yarn": "1.22.19"
+    "node": "22.11.0",
+    "yarn": "1.22.22"
   }
 }

package/{prettier.config.js → prettier.config.mjs}

@@ -1,5 +1,4 @@
-/*eslint-env node*/
-module.exports = {
+const config = {
   bracketSpacing: false,
   jsxBracketSameLine: false,
   printWidth: 90,
@@ -10,3 +9,5 @@ module.exports = {
   useTabs: false,
   arrowParens: 'avoid',
 };
+
+export default config;

package/src/common.mjs

@@ -0,0 +1,104 @@
+import eslint from '@eslint/js';
+import eslintPluginPrettier from 'eslint-plugin-prettier/recommended';
+import simpleImportSort from 'eslint-plugin-simple-import-sort';
+import {builtinModules} from 'node:module';
+import tseslint from 'typescript-eslint';
+
+const common = tseslint.config(
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
+  tseslint.configs.stylistic,
+  eslintPluginPrettier,
+  {
+    plugins: {
+      'simple-import-sort': simpleImportSort,
+    },
+    languageOptions: {
+      ecmaVersion: 'latest',
+      sourceType: 'module',
+    },
+    rules: {
+      // Best practices
+      'array-callback-return': ['warn'],
+      'consistent-return': ['warn'],
+      'no-caller': ['warn'],
+      'no-else-return': ['error', {allowElseIf: false}],
+      'no-extra-label': ['error'],
+      'no-floating-decimal': ['error'],
+      'no-implied-eval': ['error'],
+      'no-lone-blocks': ['error'],
+      'no-return-await': ['error'],
+      'no-self-compare': ['error'],
+      'no-sequences': ['error'],
+      'no-useless-call': ['warn'],
+      'no-useless-concat': ['warn'],
+      'no-useless-return': ['warn'],
+      'require-await': ['warn'],
+      curly: ['error'],
+      eqeqeq: ['error'],
+      radix: ['warn'],
+
+      // Variables
+      'no-undef-init': ['warn'],
+
+      // Style (mostly handled by prettier)
+      'eol-last': ['error', 'always'],
+      'new-parens': ['error'],
+      'padded-blocks': ['warn', 'never'],
+      'spaced-comment': ['warn', 'always'],
+
+      // ECMA 6
+      'no-var': ['error'],
+      'prefer-arrow-callback': ['warn'],
+      'prefer-const': ['error'],
+      'prefer-destructuring': ['off'],
+      'prefer-numeric-literals': ['warn'],
+      'prefer-rest-params': ['warn'],
+      'prefer-spread': ['warn'],
+      'prefer-template': ['warn'],
+      'arrow-body-style': ['error', 'as-needed'],
+
+      // disabled for typescript
+      'no-unused-expressions': ['off'],
+
+      // Typescript
+      '@typescript-eslint/explicit-function-return-type': ['off'],
+      '@typescript-eslint/no-use-before-define': ['off'],
+      '@typescript-eslint/no-explicit-any': ['off'],
+      '@typescript-eslint/no-non-null-assertion': ['off'],
+      '@typescript-eslint/explicit-module-boundary-types': ['off'],
+      '@typescript-eslint/no-unused-vars': ['error', {argsIgnorePattern: '^_'}],
+      '@typescript-eslint/no-unused-expressions': ['error'],
+
+      // see: https://github.com/typescript-eslint/typescript-eslint/issues/420
+      '@typescript-eslint/no-useless-constructor': 'error',
+
+      // Consistent Array<T> / T[] usage
+      '@typescript-eslint/array-type': ['error', {default: 'array-simple'}],
+
+      // Sort imports
+      'simple-import-sort/exports': 'error',
+      'simple-import-sort/imports': [
+        'error',
+        {
+          groups: [
+            // Side effect imports.
+            ['^\\u0000'],
+            // Packages. `react` related packages come first.
+            ['^react', '^@?\\w'],
+            // Node.js builtins.
+            [`^(${builtinModules.join('|')})(/|$)`],
+            // Internal packages.
+            ['^(src|app)(/.*|$)'],
+            // Parent imports. Put `..` last.
+            ['^\\.\\.(?!/?$)', '^\\.\\./?$'],
+            // Other relative imports. Put same-folder imports and `.` last.
+            ['^\\./(?=.*/)(?!/?$)', '^\\.(?!/?$)', '^\\./?$'],
+          ],
+        },
+      ],
+    },
+  }
+);
+
+export {common};

package/src/index.mjs

@@ -0,0 +1,6 @@
+import {common} from './common.mjs';
+import {react} from './react.mjs';
+
+const all = [...common, ...react];
+
+export {all, common, react};

package/src/react.mjs

@@ -0,0 +1,44 @@
+import reactPlugin from 'eslint-plugin-react';
+import reactHooksPlugin from 'eslint-plugin-react-hooks';
+import globals from 'globals';
+import tseslint from 'typescript-eslint';
+
+const react = tseslint.config(
+  reactPlugin.configs.flat.recommended,
+  reactPlugin.configs.flat['jsx-runtime'],
+
+  {
+    plugins: {
+      react: reactPlugin,
+      'react-hooks': reactHooksPlugin,
+    },
+    settings: {
+      react: {
+        version: 'detect',
+      },
+    },
+
+    languageOptions: {
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+      globals: {
+        ...globals.browser,
+      },
+    },
+
+    rules: {
+      'react/prop-types': ['off'],
+      'react/display-name': ['off'],
+      'react/no-access-state-in-setstate': ['warn'],
+      'react/no-this-in-sfc': ['warn'],
+      'react/prefer-stateless-function': ['warn'],
+      'react/jsx-boolean-value': ['warn'],
+      'react/jsx-pascal-case': ['warn'],
+    },
+  }
+);
+
+export {react};

package/common.js

@@ -1,100 +0,0 @@
-module.exports = {
-  extends: [
-    'eslint:recommended',
-    'plugin:prettier/recommended',
-    'plugin:@typescript-eslint/recommended',
-    'plugin:@typescript-eslint/stylistic',
-  ],
-  plugins: ['prettier', 'import', '@typescript-eslint', 'simple-import-sort'],
-  parser: '@typescript-eslint/parser',
-
-  parserOptions: {
-    ecmaVersion: 6,
-    sourceType: 'module',
-    ecmaFeatures: {
-      jsx: true,
-    },
-  },
-
-  rules: {
-    // Best practices
-    'array-callback-return': ['warn'],
-    'consistent-return': ['warn'],
-    'no-caller': ['warn'],
-    'no-else-return': ['error', {allowElseIf: false}],
-    'no-extra-label': ['error'],
-    'no-floating-decimal': ['error'],
-    'no-implied-eval': ['error'],
-    'no-lone-blocks': ['error'],
-    'no-return-await': ['error'],
-    'no-self-compare': ['error'],
-    'no-sequences': ['error'],
-    'no-useless-call': ['warn'],
-    'no-useless-concat': ['warn'],
-    'no-useless-return': ['warn'],
-    'require-await': ['warn'],
-    curly: ['error'],
-    eqeqeq: ['error'],
-    radix: ['warn'],
-
-    // Variables
-    'no-undef-init': ['warn'],
-
-    // Style (mostly handled by prettier)
-    'eol-last': ['error', 'always'],
-    'new-parens': ['error'],
-    'padded-blocks': ['warn', 'never'],
-    'spaced-comment': ['warn', 'always'],
-
-    // ECMA 6
-    'no-var': ['error'],
-    'prefer-arrow-callback': ['warn'],
-    'prefer-const': ['error'],
-    'prefer-destructuring': ['off'],
-    'prefer-numeric-literals': ['warn'],
-    'prefer-rest-params': ['warn'],
-    'prefer-spread': ['warn'],
-    'prefer-template': ['warn'],
-    'arrow-body-style': ['error', 'as-needed'],
-
-    // disabled for typescript
-    'no-unused-expressions': ['off'],
-
-    // Typescript
-    '@typescript-eslint/explicit-function-return-type': ['off'],
-    '@typescript-eslint/no-use-before-define': ['off'],
-    '@typescript-eslint/no-explicit-any': ['off'],
-    '@typescript-eslint/no-non-null-assertion': ['off'],
-    '@typescript-eslint/explicit-module-boundary-types': ['off'],
-    '@typescript-eslint/no-unused-vars': ['error', {argsIgnorePattern: '^_'}],
-    '@typescript-eslint/no-unused-expressions': ['error'],
-
-    // see: https://github.com/typescript-eslint/typescript-eslint/issues/420
-    '@typescript-eslint/no-useless-constructor': 'error',
-
-    // Consistent Array<T> / T[] usage
-    '@typescript-eslint/array-type': ['error', {default: 'array-simple'}],
-
-    // Sort imports
-    'simple-import-sort/exports': 'error',
-    'simple-import-sort/imports': [
-      'error',
-      {
-        groups: [
-          // Side effect imports.
-          ['^\\u0000'],
-          // Packages. `react` related packages come first.
-          ['^react', '^@?\\w'],
-          // Node.js builtins.
-          [`^(${require('module').builtinModules.join('|')})(/|$)`],
-          // Internal packages.
-          ['^(src|app)(/.*|$)'],
-          // Parent imports. Put `..` last.
-          ['^\\.\\.(?!/?$)', '^\\.\\./?$'],
-          // Other relative imports. Put same-folder imports and `.` last.
-          ['^\\./(?=.*/)(?!/?$)', '^\\.(?!/?$)', '^\\./?$'],
-        ],
-      },
-    ],
-  },
-};

package/index.js

@@ -1,3 +0,0 @@
-module.exports = {
-  extends: ['./common', './react'],
-};

package/react.js

@@ -1,18 +0,0 @@
-module.exports = {
-  extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  plugins: ['react', 'react-hooks'],
-
-  settings: {
-    react: {version: 'detect'},
-  },
-
-  rules: {
-    'react/prop-types': ['off'],
-    'react/display-name': ['off'],
-    'react/no-access-state-in-setstate': ['warn'],
-    'react/no-this-in-sfc': ['warn'],
-    'react/prefer-stateless-function': ['warn'],
-    'react/jsx-boolean-value': ['warn'],
-    'react/jsx-pascal-case': ['warn'],
-  },
-};