@ethlete/query 5.43.1 → 5.44.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @ethlete/query
 
+## 5.44.0
+
+### Minor Changes
+
+- [`8d2efef`](https://github.com/ethlete-io/ethdk/commit/8d2efef2a367db82d44977a3fdfe56396bb46515) Thanks [@TomTomB](https://github.com/TomTomB)! - Minor bump only
+
+## 5.43.2
+
+### Patch Changes
+
+- [`830b987`](https://github.com/ethlete-io/ethdk/commit/830b987eba43a51252c3c55eee5590ceef8bf1cb) Thanks [@TomTomB](https://github.com/TomTomB)! - Fix query v3 features not reacting to 204 responses due to null checks
+
 ## 5.43.1
 
 ### Patch Changes

package/fesm2022/ethlete-query.mjs

@@ -1547,11 +1547,11 @@ const withSuccessHandling = (options) => {
         type: QueryFeatureType.WITH_SUCCESS_HANDLING,
         fn: (context) => {
             nestedEffect(() => {
-                const response = context.state.response();
-                if (response === null)
+                const event = context.state.latestHttpEvent();
+                if (!event || event.type !== HttpEventType.Response)
                     return;
                 untracked(() => {
-                    options.handler(response);
+                    options.handler(context.state.response());
                 });
             }, { injector: context.deps.injector });
         },
@@ -1684,7 +1684,8 @@ const createQuerySnapshotFn = (options) => {
                 snapshotState.response.set(currentResponse);
                 if (currentLoading)
                     return;
-                if (!currentResponse && !currentError)
+                const hasCompletedResponse = currentLatestHttpEvent?.type === HttpEventType.Response;
+                if (!hasCompletedResponse && !currentError)
                     return;
                 // kill the effect once loading is done and we either have a response or an error
                 killEffectRef.destroy();
@@ -2084,7 +2085,6 @@ const createHttpRequest = (options) => {
         return true;
     };
     const updateState = (event) => {
-        currentEvent.set(event);
         switch (event.type) {
             case HttpEventType.Response:
                 {
@@ -2111,6 +2111,7 @@ const createHttpRequest = (options) => {
                 }
                 break;
         }
+        currentEvent.set(event);
     };
     const updateErrorState = (errorResponse) => {
         const errorRes = createQueryErrorResponse(errorResponse);