@ethlete/query 5.43.0 → 5.44.0

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @ethlete/query
 
+## 5.44.0
+
+### Minor Changes
+
+- [`8d2efef`](https://github.com/ethlete-io/ethdk/commit/8d2efef2a367db82d44977a3fdfe56396bb46515) Thanks [@TomTomB](https://github.com/TomTomB)! - Minor bump only
+
+## 5.43.2
+
+### Patch Changes
+
+- [`830b987`](https://github.com/ethlete-io/ethdk/commit/830b987eba43a51252c3c55eee5590ceef8bf1cb) Thanks [@TomTomB](https://github.com/TomTomB)! - Fix query v3 features not reacting to 204 responses due to null checks
+
+## 5.43.1
+
+### Patch Changes
+
+- [`f40e8a2`](https://github.com/ethlete-io/ethdk/commit/f40e8a224a6f0c527f4204e696966a1416da0f43) Thanks [@TomTomB](https://github.com/TomTomB)! - Fix query state observable not getting properly memorized
+
+- [`f40e8a2`](https://github.com/ethlete-io/ethdk/commit/f40e8a224a6f0c527f4204e696966a1416da0f43) Thanks [@TomTomB](https://github.com/TomTomB)! - Fix bearer auth provider causing maximum callstack exceeded errors in certain edge cases
+
 ## 5.43.0
 
 ### Minor Changes

package/fesm2022/ethlete-query.mjs

@@ -1,6 +1,6 @@
 import * as i1 from '@ethlete/core';
 import { createDestroy, computedTillTruthy, syncSignal, RuntimeError, isObject, injectRoute, getDomain, getCookie, setCookie, deleteCookie, clamp, previousSignalValue, DelayableDirective, nextFrame, injectQueryParamChanges, injectQueryParams, clone, equal, ET_PROPERTY_REMOVED } from '@ethlete/core';
-import { Observable, takeUntil, startWith, pairwise, tap, switchMap, of, BehaviorSubject, Subject, fromEvent, timer, take, Subscription, retry, throwError, catchError, ReplaySubject, map, shareReplay, interval, skip, takeWhile, filter, combineLatest, withLatestFrom, debounceTime, merge } from 'rxjs';
+import { Observable, takeUntil, startWith, pairwise, tap, switchMap, of, BehaviorSubject, Subject, fromEvent, timer, take, Subscription, retry, throwError, catchError, ReplaySubject, map, shareReplay, interval, skip, takeWhile, filter, combineLatest, EMPTY, withLatestFrom, debounceTime, merge } from 'rxjs';
 import { HttpStatusCode, HttpErrorResponse, HttpEventType, HttpClient, HttpHeaders } from '@angular/common/http';
 import * as i0 from '@angular/core';
 import { assertInInjectionContext, inject, Injector, runInInjectionContext, signal, effect, untracked, computed, isDevMode, InjectionToken, EnvironmentInjector, createEnvironmentInjector, DestroyRef, ɵEffectScheduler as _EffectScheduler, ErrorHandler, Pipe, ChangeDetectorRef, input, ViewContainerRef, TemplateRef, Directive, Input, ElementRef, ViewEncapsulation, ChangeDetectionStrategy, Component, NgZone } from '@angular/core';
@@ -1547,11 +1547,11 @@ const withSuccessHandling = (options) => {
         type: QueryFeatureType.WITH_SUCCESS_HANDLING,
         fn: (context) => {
             nestedEffect(() => {
-                const response = context.state.response();
-                if (response === null)
+                const event = context.state.latestHttpEvent();
+                if (!event || event.type !== HttpEventType.Response)
                     return;
                 untracked(() => {
-                    options.handler(response);
+                    options.handler(context.state.response());
                 });
             }, { injector: context.deps.injector });
         },
@@ -1684,7 +1684,8 @@ const createQuerySnapshotFn = (options) => {
                 snapshotState.response.set(currentResponse);
                 if (currentLoading)
                     return;
-                if (!currentResponse && !currentError)
+                const hasCompletedResponse = currentLatestHttpEvent?.type === HttpEventType.Response;
+                if (!hasCompletedResponse && !currentError)
                     return;
                 // kill the effect once loading is done and we either have a response or an error
                 killEffectRef.destroy();
@@ -2084,7 +2085,6 @@ const createHttpRequest = (options) => {
         return true;
     };
     const updateState = (event) => {
-        currentEvent.set(event);
         switch (event.type) {
             case HttpEventType.Response:
                 {
@@ -2111,6 +2111,7 @@ const createHttpRequest = (options) => {
                 }
                 break;
         }
+        currentEvent.set(event);
     };
     const updateErrorState = (errorResponse) => {
         const errorRes = createQueryErrorResponse(errorResponse);
@@ -4342,13 +4343,16 @@ class Query {
         return ++this._currentLocalId;
     }
     get state$() {
-        return this._state$.pipe(tap((s) => {
-            if (!this._client.config.logging?.preparedQuerySubscriptions)
-                return;
-            if (isQueryStatePrepared(s)) {
-                console.warn(`Query ${this._routeWithParams} was subscribed to in the prepared state. Did you forget to call .execute()?`);
-            }
-        }), switchMap((s) => this._transformState(s)), shareReplay({ bufferSize: 1, refCount: true }));
+        if (!this._memoizedState$) {
+            this._memoizedState$ = this._state$.pipe(tap((s) => {
+                if (!this._client.config.logging?.preparedQuerySubscriptions)
+                    return;
+                if (isQueryStatePrepared(s)) {
+                    console.warn(`Query ${this._routeWithParams} was subscribed to in the prepared state. Did you forget to call .execute()?`);
+                }
+            }), switchMap((s) => this._transformState(s)), shareReplay({ bufferSize: 1, refCount: true }));
+        }
+        return this._memoizedState$;
     }
     /**
      * The current state of the query.
@@ -4452,6 +4456,7 @@ class Query {
          * @internal
          */
         this._isPollingPaused = false;
+        this._memoizedState$ = null;
         this._state$ = new BehaviorSubject({
             type: "PREPARED" /* QueryStateType.Prepared */,
             meta: { id: this._currentLocalId, triggeredVia: 'program' },
@@ -4493,16 +4498,19 @@ class Query {
                     // The tokens might get set without a refresh query being created (e.g.) directly after login.
                     authProvider.currentRefreshQuery$.pipe(switchQueryState(), takeUntilResponse()),
                     authProvider.tokens$.pipe(take(1)),
-                ]).pipe(takeUntil(this._onAbort$), filter(([state, tokens]) => {
-                    if (state) {
-                        return !isQueryStateLoading(state);
+                ]).pipe(takeUntil(this._onAbort$), switchMap(([state, tokens]) => {
+                    if (state && isQueryStateLoading(state)) {
+                        return EMPTY;
                     }
-                    return !!tokens;
-                }), tap(([state]) => {
                     if (isQueryStateFailure(state)) {
                         this._updateEntityState({ type: 'failure', error: state.error, headers: {} }, meta, options);
+                        return EMPTY;
+                    }
+                    if (!state && !(tokens?.token || tokens?.refreshToken)) {
+                        return EMPTY;
                     }
-                }), map(() => true), take(1));
+                    return of(true);
+                }), take(1));
             }
             goSignal
                 .pipe(switchMap(() => {
@@ -4915,7 +4923,9 @@ class BearerAuthProvider {
         }) ?? {
             body: { refreshToken: currentRefreshToken },
         };
-        const query = this._config.refreshConfig.queryCreator.prepare(args).execute({ skipCache: true });
+        const query = this._config.refreshConfig.queryCreator
+            .prepare(args)
+            .execute({ skipCache: true, _isUnauthorizedRetry: true });
         this._currentRefreshQuery$.next(query);
         this._currentRefreshQuery$
             .pipe(switchQueryState(), tap((state) => {