@ethlete/eslint-plugin 0.1.0-next.8 → 0.1.0-next.9

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.1.0-next.9
+
+### Patch Changes
+
+- [`b323ef6`](https://github.com/ethlete-io/ethdk/commit/b323ef66130d196e5c893e844d50ecfc85487373) Thanks [@TomTomB](https://github.com/TomTomB)! - `class-member-order`: recognize custom `injectXyz()` helper functions (not just the raw `inject()` call) as inject-group members, so they're required to be declared before inputs/outputs/queries/properties like other injected dependencies.
+
 ## 0.1.0-next.8
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethlete/eslint-plugin",
-  "version": "0.1.0-next.8",
+  "version": "0.1.0-next.9",
   "license": "MIT",
   "type": "commonjs",
   "main": "./src/index.js",

package/src/configs/recommended.js

@@ -191,6 +191,12 @@ const recommendedTs = {
         message:
           'No barrel imports (index files). Import directly from the source file to avoid breaking lazy loading.',
       },
+      // No on-prefixed method names — name the method after what it does, not that it handles an event
+      {
+        selector: 'MethodDefinition[key.name=/^on[A-Z]/]',
+        message:
+          'No on-prefixed method names. Name the method after what it does (e.g. onLayoutChange -> syncGridItemsWithLayout).',
+      },
     ],
 
     // ── Native DOM globals ──────────────────────────────────────────────────

package/src/rules/class-member-order.js

@@ -81,6 +81,18 @@ const isPropertyInitializedWith = (node, apiNames) => {
   return apiName !== null && apiNames.has(apiName);
 };
 
+const INJECT_HELPER_NAME_PATTERN = /^inject[A-Z]/;
+
+/**
+ * @param {any} node
+ */
+const isPropertyInitializedWithInject = (node) => {
+  if (node.type !== 'PropertyDefinition') return false;
+
+  const apiName = getCallRootName(node.value);
+  return apiName !== null && (apiName === 'inject' || INJECT_HELPER_NAME_PATTERN.test(apiName));
+};
+
 /**
  * @param {any} node
  * @returns {TMemberGroup | null}
@@ -89,7 +101,7 @@ const getMemberGroup = (node) => {
   if (node.static) return null;
 
   if (node.type === 'PropertyDefinition') {
-    if (isPropertyInitializedWith(node, new Set(['inject']))) {
+    if (isPropertyInitializedWithInject(node)) {
       return 'inject';
     }