@ethlete/eslint-plugin 0.1.0-next.1 → 0.1.0-next.10

package/CHANGELOG.md

@@ -1,5 +1,63 @@
 # Changelog
 
+## 0.1.0-next.10
+
+### Minor Changes
+
+- [`4e9f2b4`](https://github.com/ethlete-io/ethdk/commit/4e9f2b4d12335fafef192350aef8ffc584996a91) Thanks [@TomTomB](https://github.com/TomTomB)! - Make the OnPush change detection rules Angular-version aware. Since OnPush is the default from Angular 22, declaring it is now redundant:
+  - Add `no-redundant-on-push-change-detection`, which flags and auto-fixes explicit `changeDetection: ChangeDetectionStrategy.OnPush` on `@Component`, and removes the now-unused `ChangeDetectionStrategy` import when it is no longer referenced. Active on Angular >= 22.
+  - `require-on-push-change-detection` now only applies on Angular <= 21, where OnPush is opt-in.
+
+  Both rules resolve the workspace's Angular major version automatically (overridable via `settings.ethlete.angularMajor`) and stay inert when they don't apply, so exactly one of them is ever active for a given Angular version.
+
+## 0.1.0-next.9
+
+### Patch Changes
+
+- [`b323ef6`](https://github.com/ethlete-io/ethdk/commit/b323ef66130d196e5c893e844d50ecfc85487373) Thanks [@TomTomB](https://github.com/TomTomB)! - `class-member-order`: recognize custom `injectXyz()` helper functions (not just the raw `inject()` call) as inject-group members, so they're required to be declared before inputs/outputs/queries/properties like other injected dependencies.
+
+## 0.1.0-next.8
+
+### Minor Changes
+
+- [`edea44b`](https://github.com/ethlete-io/ethdk/commit/edea44bf1c494420f02b545202f4b24db9a6395c) Thanks [@TomTomB](https://github.com/TomTomB)! - Update to angular 22
+
+## 0.1.0-next.7
+
+### Patch Changes
+
+- [`7e8ac6b`](https://github.com/ethlete-io/ethdk/commit/7e8ac6bf18f580289c7c7966c6c33a2a7f077299) Thanks [@TomTomB](https://github.com/TomTomB)! - Fix false positives in pipes
+
+## 0.1.0-next.6
+
+### Patch Changes
+
+- [`b73a127`](https://github.com/ethlete-io/ethdk/commit/b73a127002a06e3aa0c4e7e977b1ad1f3e04e7e6) Thanks [@TomTomB](https://github.com/TomTomB)! - Bump yet again, final one for sure, pinky promise
+
+## 0.1.0-beta.5
+
+### Patch Changes
+
+- [`ddb5d09`](https://github.com/ethlete-io/ethdk/commit/ddb5d09e4bc56e18cc8c228aa78a200441e7a766) Thanks [@TomTomB](https://github.com/TomTomB)! - Bump to beta
+
+## 0.1.0-next.4
+
+### Patch Changes
+
+- [`a690217`](https://github.com/ethlete-io/ethdk/commit/a6902172efd9bd1956a16237e79acbfbd816d946) Thanks [@TomTomB](https://github.com/TomTomB)! - Version bump only
+
+## 0.1.0-next.3
+
+### Patch Changes
+
+- [`5d1d3ac`](https://github.com/ethlete-io/ethdk/commit/5d1d3accbd4a7657bc50cdc0653a7ca24fe761e2) Thanks [@TomTomB](https://github.com/TomTomB)! - Fix minor lint edge cases
+
+## 0.1.0-next.2
+
+### Patch Changes
+
+- [#2957](https://github.com/ethlete-io/ethdk/pull/2957) [`81173d4`](https://github.com/ethlete-io/ethdk/commit/81173d426d1a53ea2a7af0d16d6eb0fe4a16dbd9) Thanks [@github-actions](https://github.com/apps/github-actions)! - Add missing auto fixers
+
 ## 0.1.0-next.1
 
 ### Patch Changes

package/package.json

@@ -1,13 +1,15 @@
 {
   "name": "@ethlete/eslint-plugin",
-  "version": "0.1.0-next.1",
+  "version": "0.1.0-next.10",
   "license": "MIT",
   "type": "commonjs",
   "main": "./src/index.js",
   "peerDependencies": {
     "@angular-eslint/eslint-plugin-template": ">=21.0.0",
+    "@angular/core": "22.0.5",
     "@typescript-eslint/eslint-plugin": ">=8.0.0",
     "eslint": ">=9.0.0",
-    "tslib": "2.8.1"
+    "tslib": "2.8.1",
+    "typescript": "6.0.3"
   }
 }

package/src/configs/recommended.js

@@ -71,10 +71,16 @@ const recommendedTs = {
       },
       {
         selector: ['variable', 'parameter', 'property', 'parameterProperty', 'accessor'],
-        leadingUnderscore: 'forbid',
+        leadingUnderscore: 'allow',
         trailingUnderscore: 'forbid',
         format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
       },
+      {
+        selector: 'method',
+        leadingUnderscore: 'allow',
+        trailingUnderscore: 'forbid',
+        format: null,
+      },
       {
         selector: 'typeLike',
         leadingUnderscore: 'forbid',
@@ -133,11 +139,6 @@ const recommendedTs = {
         selector: 'FunctionExpression[async=true]',
         message: 'No async/await. Use RxJS for all async operations.',
       },
-      // No public keyword on class members
-      {
-        selector: "MethodDefinition[accessibility='public']",
-        message: 'No public keyword on class members.',
-      },
       // No static class members
       {
         selector: 'MethodDefinition[static=true]',
@@ -190,6 +191,12 @@ const recommendedTs = {
         message:
           'No barrel imports (index files). Import directly from the source file to avoid breaking lazy loading.',
       },
+      // No on-prefixed method names — name the method after what it does, not that it handles an event
+      {
+        selector: 'MethodDefinition[key.name=/^on[A-Z]/]',
+        message:
+          'No on-prefixed method names. Name the method after what it does (e.g. onLayoutChange -> syncGridItemsWithLayout).',
+      },
     ],
 
     // ── Native DOM globals ──────────────────────────────────────────────────
@@ -212,8 +219,18 @@ const recommendedTs = {
     // No inject(X).member chaining — assign to a const first
     'ethlete/no-inject-chain': 'error',
 
-    // No public properties except explicit injected external APIs
-    'ethlete/no-public-property': 'error',
+    // inject(ElementRef) must use inject<ElementRef<HTMLElement>>(ElementRef) — not inject(ElementRef) or inject(ElementRef<...>)
+    'ethlete/no-typed-injected-element-ref': 'error',
+
+    // No @internal on members already hidden by private/protected
+    'ethlete/no-redundant-internal': 'error',
+
+    // Non-injected Angular members should use explicit accessibility when they
+    // participate in the reachable surface. Template/host members must be
+    // explicit, other implicit-public members must be public. @internal does
+    // not replace explicit public; protected remains valid for template-only
+    // members.
+    'ethlete/template-member-accessibility': 'error',
 
     // No explicit trivial return types TypeScript can infer
     'ethlete/no-trivial-return-type': 'error',
@@ -269,6 +286,9 @@ const recommendedTs = {
     // No `import type { Foo }` or `import { type Foo }` — use regular value imports
     'ethlete/no-type-only-import': 'error',
 
+    // No empty blank lines between import declarations
+    'ethlete/no-empty-newlines-between-imports': 'error',
+
     // No legacy Angular decorators — use signal-based APIs (input, output, viewChild, etc.)
     // and host: {} bindings (instead of @HostBinding / @HostListener)
     'ethlete/no-legacy-angular-decorators': 'error',
@@ -304,6 +324,9 @@ const recommendedTs = {
     // — widen the accessibility of the source member instead
     'ethlete/no-member-alias': 'error',
 
+    // No leading underscores on class members; auto-fix private members when safe
+    'ethlete/no-leading-underscore-class-member': 'error',
+
     // No declared-but-never-read private/protected class members
     'ethlete/no-unused-class-member': 'error',
 
@@ -311,6 +334,12 @@ const recommendedTs = {
     // — use viewChild() / viewChildren() or contentChild() / contentChildren() instead
     'ethlete/no-dom-query': 'error',
 
+    // Remove empty imports: [] and hostDirectives: [] metadata noise
+    'ethlete/no-empty-angular-metadata-arrays': 'error',
+
+    // Remove standalone metadata — standalone is implicit and should not be declared
+    'ethlete/no-standalone-flag': 'error',
+
     // ── Angular outputs ─────────────────────────────────────────────────────
 
     // No on-prefixed outputs (onSelectDate → selectDate)
@@ -321,8 +350,13 @@ const recommendedTs = {
 
     // ── Angular components ──────────────────────────────────────────────────
 
-    // Always use ChangeDetectionStrategy.OnPush
-    '@angular-eslint/prefer-on-push-component-change-detection': 'error',
+    // Require ChangeDetectionStrategy.OnPush on Angular <= 21, where it is opt-in
+    // (version-aware: inert on Angular 22+, where OnPush is the default).
+    'ethlete/require-on-push-change-detection': 'error',
+
+    // No redundant ChangeDetectionStrategy.OnPush — it is the default since Angular 22
+    // (version-aware: inert on older Angular). Also removes the now-unused import.
+    'ethlete/no-redundant-on-push-change-detection': 'error',
 
     // Always use ViewEncapsulation.None (angular-eslint's use-component-view-encapsulation does the
     // opposite — it disallows None, so we use our own custom rule instead)
@@ -331,6 +365,12 @@ const recommendedTs = {
     // Keep Angular @Component / @Directive metadata in a consistent order
     'ethlete/angular-decorator-property-order': 'error',
 
+    // Keep class members in the documented styleguide order
+    'ethlete/class-member-order': 'error',
+
+    // True class constants should be readonly and use SCREAMING_CASE
+    'ethlete/class-constant-property': 'error',
+
     // Prefer shorthand hostDirectives entries and keep extended host directive configs ordered
     'ethlete/prefer-concise-angular-host-directives': 'error',
 
@@ -359,4 +399,16 @@ const recommendedTemplate = {
   },
 };
 
-module.exports = { recommendedTs, recommendedTemplate };
+/**
+ * Relaxed rules for test/spec files.
+ * Non-null assertions are common and intentional in tests.
+ * @type {import('eslint').Linter.Config}
+ */
+const recommendedSpec = {
+  files: ['**/*.spec.ts'],
+  rules: {
+    '@typescript-eslint/no-non-null-assertion': 'off',
+  },
+};
+
+module.exports = { recommendedTs, recommendedTemplate, recommendedSpec };

package/src/index.js

@@ -22,6 +22,8 @@ const noSubscribeWithBody = require('./rules/no-subscribe-with-body');
 const requireDollarSuffix = require('./rules/require-dollar-suffix');
 const noPipeLogic = require('./rules/no-pipe-logic');
 const enforceRoutingViewNaming = require('./rules/enforce-routing-view-naming');
+const noRedundantOnPushChangeDetection = require('./rules/no-redundant-on-push-change-detection');
+const requireOnPushChangeDetection = require('./rules/require-on-push-change-detection');
 const requireViewEncapsulationNone = require('./rules/require-view-encapsulation-none');
 const noLegacyAngularDecorators = require('./rules/no-legacy-angular-decorators');
 const noAngularSeoServices = require('./rules/no-angular-seo-services');
@@ -29,16 +31,25 @@ const preferCloneEqual = require('./rules/prefer-clone-equal');
 const noDocumentCookie = require('./rules/no-document-cookie');
 const injectMemberAccessibility = require('./rules/inject-member-accessibility');
 const noPublicProperty = require('./rules/no-public-property');
+const noRedundantInternal = require('./rules/no-redundant-internal');
+const templateMemberAccessibility = require('./rules/template-member-accessibility');
 const noAngularRouterApi = require('./rules/no-angular-router-api');
 const noWindowLocation = require('./rules/no-window-location');
 const noLocaleId = require('./rules/no-locale-id');
 const noMemberAlias = require('./rules/no-member-alias');
 const noUnusedClassMember = require('./rules/no-unused-class-member');
 const noDomQuery = require('./rules/no-dom-query');
+const noLeadingUnderscoreClassMember = require('./rules/no-leading-underscore-class-member');
+const noEmptyAngularMetadataArrays = require('./rules/no-empty-angular-metadata-arrays');
+const noStandaloneFlag = require('./rules/no-standalone-flag');
+const noEmptyNewlinesBetweenImports = require('./rules/no-empty-newlines-between-imports');
 const angularDecoratorPropertyOrder = require('./rules/angular-decorator-property-order');
+const classMemberOrder = require('./rules/class-member-order');
+const classConstantProperty = require('./rules/class-constant-property');
 const preferConciseAngularHostDirectives = require('./rules/prefer-concise-angular-host-directives');
 const preferConciseAngularStyleMetadata = require('./rules/prefer-concise-angular-style-metadata');
-const { recommendedTs, recommendedTemplate } = require('./configs/recommended');
+const noTypedInjectedElementRef = require('./rules/no-typed-injected-element-ref');
+const { recommendedTs, recommendedTemplate, recommendedSpec } = require('./configs/recommended');
 
 /** @type {import('eslint').ESLint.Plugin} */
 const plugin = {
@@ -68,6 +79,8 @@ const plugin = {
     'require-dollar-suffix': requireDollarSuffix,
     'no-pipe-logic': noPipeLogic,
     'enforce-routing-view-naming': enforceRoutingViewNaming,
+    'no-redundant-on-push-change-detection': noRedundantOnPushChangeDetection,
+    'require-on-push-change-detection': requireOnPushChangeDetection,
     'require-view-encapsulation-none': requireViewEncapsulationNone,
     'no-legacy-angular-decorators': noLegacyAngularDecorators,
     'no-angular-seo-services': noAngularSeoServices,
@@ -75,15 +88,24 @@ const plugin = {
     'no-document-cookie': noDocumentCookie,
     'inject-member-accessibility': injectMemberAccessibility,
     'no-public-property': noPublicProperty,
+    'no-redundant-internal': noRedundantInternal,
+    'template-member-accessibility': templateMemberAccessibility,
     'no-angular-router-api': noAngularRouterApi,
     'no-window-location': noWindowLocation,
     'no-locale-id': noLocaleId,
     'no-member-alias': noMemberAlias,
     'no-unused-class-member': noUnusedClassMember,
     'no-dom-query': noDomQuery,
+    'no-leading-underscore-class-member': noLeadingUnderscoreClassMember,
+    'no-empty-angular-metadata-arrays': noEmptyAngularMetadataArrays,
+    'no-standalone-flag': noStandaloneFlag,
+    'no-empty-newlines-between-imports': noEmptyNewlinesBetweenImports,
     'angular-decorator-property-order': angularDecoratorPropertyOrder,
+    'class-member-order': classMemberOrder,
+    'class-constant-property': classConstantProperty,
     'prefer-concise-angular-host-directives': preferConciseAngularHostDirectives,
     'prefer-concise-angular-style-metadata': preferConciseAngularStyleMetadata,
+    'no-typed-injected-element-ref': noTypedInjectedElementRef,
   },
 };
 
@@ -108,7 +130,7 @@ const configs = {
    * Both together as a flat array — the most common usage:
    *   export default [...baseConfig, ...ethlete.configs.recommended]
    */
-  recommended: [recommendedTsWithPlugin, recommendedTemplateWithPlugin],
+  recommended: [recommendedTsWithPlugin, recommendedTemplateWithPlugin, recommendedSpec],
 };
 
 const ethletePlugin = { ...plugin, configs };

package/src/rules/angular-decorator-property-order.js

@@ -29,28 +29,16 @@ const DECORATOR_CONFIG = {
       'outputs',
       'queries',
       'preserveWhitespaces',
-      'standalone',
       'schemas',
       'jit',
       'exportAs',
     ],
     orderText:
-      'selector, template/templateUrl, styleUrl/styleUrls, encapsulation, changeDetection, imports, providers, viewProviders, animations, hostDirectives, host, styles, inputs, outputs, queries, preserveWhitespaces, standalone, schemas, jit, exportAs',
+      'selector, template/templateUrl, styleUrl/styleUrls, encapsulation, changeDetection, imports, providers, viewProviders, animations, hostDirectives, host, styles, inputs, outputs, queries, preserveWhitespaces, schemas, jit, exportAs',
   },
   Directive: {
-    order: [
-      'selector',
-      'exportAs',
-      'providers',
-      'inputs',
-      'outputs',
-      'queries',
-      'hostDirectives',
-      'host',
-      'standalone',
-      'jit',
-    ],
-    orderText: 'selector, exportAs, providers, inputs, outputs, queries, hostDirectives, host, standalone, jit',
+    order: ['selector', 'exportAs', 'providers', 'inputs', 'outputs', 'queries', 'hostDirectives', 'host', 'jit'],
+    orderText: 'selector, exportAs, providers, inputs, outputs, queries, hostDirectives, host, jit',
   },
 };