@ethlete/core 5.0.0-next.7 → 5.0.0-next.9

package/generators/generators.json

@@ -5,10 +5,15 @@
       "schema": "./migrate-to-v5/schema.json",
       "description": "Migrate to v5"
     },
-    "tailwind-4-theme": {
-      "factory": "./tailwind-4-theme/generator",
-      "schema": "./tailwind-4-theme/schema.json",
-      "description": "Generate theming for Tailwind CSS v4"
+    "tailwind-4-color-theme": {
+      "factory": "./tailwind-4-color-theme/generator",
+      "schema": "./tailwind-4-color-theme/schema.json",
+      "description": "Generate color theming for Tailwind CSS v4"
+    },
+    "tailwind-4-surface-theme": {
+      "factory": "./tailwind-4-surface-theme/generator",
+      "schema": "./tailwind-4-surface-theme/schema.json",
+      "description": "Generate surface theming for Tailwind CSS v4"
     }
   }
 }

package/generators/migrate-to-v5/color-naming.js

@@ -0,0 +1,173 @@
+import { logger } from '@nx/devkit';
+/**
+ * Symbol renames in TypeScript files (imports + usage).
+ */
+const TS_SYMBOL_RENAMES = {
+    ProvideThemeDirective: 'ProvideColorDirective',
+    THEME_PROVIDER: 'COLOR_PROVIDER',
+    ColorThemedDirective: 'ColoredDirective',
+    ColorThemedStylesComponent: 'ColoredStylesComponent',
+    SurfaceThemedDirective: 'SurfacedDirective',
+    SurfaceThemedStylesComponent: 'SurfacedStylesComponent',
+    injectThemesPrefix: 'injectColorThemesPrefix',
+    createCssThemeName: 'createCssColorThemeName',
+};
+/**
+ * String replacements applied to HTML templates and inline templates.
+ */
+const TEMPLATE_REPLACEMENTS = [
+    ['[etProvideTheme]', '[etProvideColor]'],
+    ['etProvideTheme', 'etProvideColor'],
+    ['[etProvideAltTheme]', '[etProvideAltColor]'],
+    ['etProvideAltTheme', 'etProvideAltColor'],
+    ['[etColorThemed]', '[etColored]'],
+    ['etColorThemed', 'etColored'],
+    ['[etSurfaceThemed]', '[etSurfaced]'],
+    ['etSurfaceThemed', 'etSurfaced'],
+    ['[theme]=', '[color]='],
+    ['[altTheme]=', '[altColor]='],
+];
+/**
+ * CSS class name replacements.
+ */
+const CSS_REPLACEMENTS = [
+    ['.et-color-themed', '.et-colored'],
+    ['.et-surface-themed', '.et-surfaced'],
+    ['.et-theme--', '.et-color--'],
+    ['.et-theme-alt--', '.et-color-alt--'],
+];
+/**
+ * Host directive input alias replacements in TypeScript files.
+ */
+const HOST_DIRECTIVE_REPLACEMENTS = [
+    ["'etProvideTheme:theme'", "'etProvideColor:color'"],
+    ["'etProvideAltTheme:altTheme'", "'etProvideAltColor:altColor'"],
+    ["'etProvideTheme:color'", "'etProvideColor:color'"],
+    ["'etProvideAltTheme:altColor'", "'etProvideAltColor:altColor'"],
+    ['"etProvideTheme:theme"', '"etProvideColor:color"'],
+    ['"etProvideAltTheme:altTheme"', '"etProvideAltColor:altColor"'],
+    ['"etProvideTheme"', '"etProvideColor"'],
+    ['"etProvideAltTheme"', '"etProvideAltColor"'],
+];
+export default async function migrateColorNaming(tree) {
+    logger.log('\n🔄 Migrating theme → color naming...\n');
+    const tsFiles = [];
+    const htmlFiles = [];
+    const cssFiles = [];
+    findFiles('.', tree, tsFiles, htmlFiles, cssFiles);
+    let filesModified = 0;
+    for (const filePath of tsFiles) {
+        const wasModified = migrateTypeScriptFile(tree, filePath);
+        if (wasModified) {
+            filesModified++;
+            logger.log(`  ✓ ${filePath}`);
+        }
+    }
+    for (const filePath of htmlFiles) {
+        const wasModified = migrateTemplateFile(tree, filePath);
+        if (wasModified) {
+            filesModified++;
+            logger.log(`  ✓ ${filePath}`);
+        }
+    }
+    for (const filePath of cssFiles) {
+        const wasModified = migrateCssFile(tree, filePath);
+        if (wasModified) {
+            filesModified++;
+            logger.log(`  ✓ ${filePath}`);
+        }
+    }
+    if (filesModified > 0) {
+        logger.log(`\n✅ Successfully migrated color naming in ${filesModified} file(s)\n`);
+    }
+    else {
+        logger.log('\nℹ️  No files needed migration\n');
+    }
+}
+function findFiles(dir, tree, tsFiles, htmlFiles, cssFiles) {
+    const children = tree.children(dir);
+    for (const child of children) {
+        const path = dir === '.' ? child : `${dir}/${child}`;
+        if (tree.isFile(path)) {
+            if (path.includes('node_modules'))
+                continue;
+            if (path.endsWith('.ts') && !path.endsWith('.spec.ts')) {
+                tsFiles.push(path);
+            }
+            else if (path.endsWith('.html')) {
+                htmlFiles.push(path);
+            }
+            else if (path.endsWith('.css') || path.endsWith('.scss')) {
+                cssFiles.push(path);
+            }
+        }
+        else {
+            if (child === 'node_modules')
+                continue;
+            findFiles(path, tree, tsFiles, htmlFiles, cssFiles);
+        }
+    }
+}
+function migrateTypeScriptFile(tree, filePath) {
+    let content = tree.read(filePath, 'utf-8');
+    if (!content)
+        return false;
+    const original = content;
+    // Rename symbols
+    for (const [oldName, newName] of Object.entries(TS_SYMBOL_RENAMES)) {
+        content = replaceWholeWord(content, oldName, newName);
+    }
+    // Rename host directive input aliases
+    for (const [oldStr, newStr] of HOST_DIRECTIVE_REPLACEMENTS) {
+        content = content.replaceAll(oldStr, newStr);
+    }
+    // Handle inline templates in TypeScript files
+    for (const [oldStr, newStr] of TEMPLATE_REPLACEMENTS) {
+        content = content.replaceAll(oldStr, newStr);
+    }
+    // Handle CSS in TypeScript files
+    for (const [oldStr, newStr] of CSS_REPLACEMENTS) {
+        content = content.replaceAll(oldStr, newStr);
+    }
+    if (content !== original) {
+        tree.write(filePath, content);
+        return true;
+    }
+    return false;
+}
+function migrateTemplateFile(tree, filePath) {
+    let content = tree.read(filePath, 'utf-8');
+    if (!content)
+        return false;
+    const original = content;
+    for (const [oldStr, newStr] of TEMPLATE_REPLACEMENTS) {
+        content = content.replaceAll(oldStr, newStr);
+    }
+    if (content !== original) {
+        tree.write(filePath, content);
+        return true;
+    }
+    return false;
+}
+function migrateCssFile(tree, filePath) {
+    let content = tree.read(filePath, 'utf-8');
+    if (!content)
+        return false;
+    const original = content;
+    for (const [oldStr, newStr] of CSS_REPLACEMENTS) {
+        content = content.replaceAll(oldStr, newStr);
+    }
+    if (content !== original) {
+        tree.write(filePath, content);
+        return true;
+    }
+    return false;
+}
+function replaceWholeWord(content, oldWord, newWord) {
+    const regex = new RegExp(`\\b${escapeRegex(oldWord)}\\b`, 'g');
+    return content.replace(regex, newWord);
+}
+function escapeRegex(str) {
+    return str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+}
+//# sourceMappingURL=color-naming.js.map

package/generators/migrate-to-v5/migration.js

@@ -1,4 +1,5 @@
 import { formatFiles } from '@nx/devkit';
+import migrateColorNaming from './color-naming.js';
 import migrateCreateProvider from './create-provider.js';
 import migrateRouterStateService from './router-state-service.js';
 import migrateViewportService from './viewport-service.js';
@@ -18,6 +19,11 @@ export default async function migrate(tree, schema) {
     if (shouldMigrateRouterStateService) {
         await migrateRouterStateService(tree);
     }
+    const shouldMigrateColorNaming = schema.migrateColorNaming !== false;
+    if (shouldMigrateColorNaming) {
+        console.log('  • Migrating theme → color naming...');
+        await migrateColorNaming(tree);
+    }
     if (!schema.skipFormat) {
         console.log('  • Formatting files...');
         await formatFiles(tree);

package/generators/migrate-to-v5/schema.json

@@ -23,6 +23,11 @@
       "type": "boolean",
       "description": "Migrate router state service to v5",
       "default": true
+    },
+    "migrateColorNaming": {
+      "type": "boolean",
+      "description": "Migrate theme naming to color naming (ProvideThemeDirective -> ProvideColorDirective, etc.)",
+      "default": true
     }
   },
   "required": []

package/generators/{tailwind-4-theme → tailwind-4-color-theme}/generator.js

@@ -9,7 +9,7 @@ export default async function generate(tree, schema) {
     if (!tree.exists(themesPath)) {
         logger.error(`❌ Themes file not found at: ${themesPath}`);
         logger.log(`\nPlease specify the correct path using --themesPath option.`);
-        logger.log(`Example: nx g @ethlete/core:tailwind-4-theme --themesPath=src/app/themes.ts\n`);
+        logger.log(`Example: nx g @ethlete/core:tailwind-4-color-theme --themesPath=src/app/themes.ts\n`);
         return;
     }
     logger.log(`📁 Reading themes from: ${themesPath}`);
@@ -167,9 +167,9 @@ function parseThemeObject(obj, sourceFile) {
                     theme.isDefault = true;
                 }
                 break;
-            case 'isDefaultAlt':
-                if (initializer.isKind(SyntaxKind.TrueKeyword)) {
-                    theme.isDefaultAlt = true;
+            case 'type':
+                if (initializer.isKind(SyntaxKind.StringLiteral)) {
+                    theme.type = initializer.getLiteralValue();
                 }
                 break;
             case 'primary':
@@ -188,8 +188,6 @@ function parseThemeObject(obj, sourceFile) {
 }
 function validateThemeConfiguration(themes) {
     const defaultThemes = themes.filter((t) => t.isDefault);
-    const defaultAltThemes = themes.filter((t) => t.isDefaultAlt);
-    const bothDefaultAndAlt = themes.filter((t) => t.isDefault && t.isDefaultAlt);
     // Error: No default theme
     if (defaultThemes.length === 0) {
         throw new Error('No default theme found. At least one theme must have isDefault: true');
@@ -198,13 +196,18 @@ function validateThemeConfiguration(themes) {
     if (defaultThemes.length > 1) {
         throw new Error(`Multiple default themes found: ${defaultThemes.map((t) => t.name).join(', ')}. Only one theme can have isDefault: true`);
     }
-    // Error: Theme has both isDefault and isDefaultAlt
-    if (bothDefaultAndAlt.length > 0) {
-        throw new Error(`Theme "${bothDefaultAndAlt[0].name}" has both isDefault and isDefaultAlt set to true. A theme can only be one or the other`);
-    }
-    // Error: Multiple default alt themes
-    if (defaultAltThemes.length > 1) {
-        throw new Error(`Multiple default alt themes found: ${defaultAltThemes.map((t) => t.name).join(', ')}. Only one theme can have isDefaultAlt: true`);
+    // Error: Duplicate theme types
+    const typedThemes = themes.filter((t) => t.type);
+    const typeMap = new Map();
+    for (const theme of typedThemes) {
+        const existing = typeMap.get(theme.type) || [];
+        existing.push(theme.name);
+        typeMap.set(theme.type, existing);
+    }
+    for (const [type, names] of typeMap) {
+        if (names.length > 1) {
+            throw new Error(`Multiple themes with type "${type}" found: ${names.join(', ')}. Only one theme can have a given type`);
+        }
     }
 }
 function parseThemeSwatch(obj, sourceFile) {
@@ -306,14 +309,13 @@ function generateTailwindThemeCss(themes, prefix, schema) {
  * 
  * Generated from your theme definitions
  * This file can be regenerated by running:
- * nx g @ethlete/core:tailwind-4-theme --themesPath=${themesPath}${schema.outputPath ? ` --outputPath=${outputPath}` : ''}${schema.prefix && schema.prefix !== 'et' ? ` --prefix=${schema.prefix}` : ''}
+ * nx g @ethlete/core:tailwind-4-color-theme --themesPath=${themesPath}${schema.outputPath ? ` --outputPath=${outputPath}` : ''}${schema.prefix && schema.prefix !== 'et' ? ` --prefix=${schema.prefix}` : ''}
  */
 
 `;
     // Validation is now done separately before this function is called
     const defaultThemes = themes.filter((t) => t.isDefault);
-    const defaultAltThemes = themes.filter((t) => t.isDefaultAlt);
-    const regularThemes = themes.filter((t) => !t.isDefault && !t.isDefaultAlt);
+    const regularThemes = themes.filter((t) => !t.isDefault);
     // Generate static Tailwind @theme block for each theme
     for (const theme of themes) {
         const name = createCssThemeName(theme.name);
@@ -344,13 +346,10 @@ function generateTailwindThemeCss(themes, prefix, schema) {
         }
     }
     tailwindVars.push('');
-    // Generate dynamic theme variables - check main themes and alt themes separately
+    // Main theme dynamic colors
     const mainThemes = [...defaultThemes, ...regularThemes];
     const hasSecondary = mainThemes.some((t) => t.secondary);
     const hasTertiary = mainThemes.some((t) => t.tertiary);
-    const hasAltSecondary = defaultAltThemes.some((t) => t.secondary);
-    const hasAltTertiary = defaultAltThemes.some((t) => t.tertiary);
-    // Main theme dynamic colors
     tailwindVars.push('  /* Dynamic theme colors (references runtime CSS variables) */');
     addDynamicThemeColors(tailwindVars, prefix, 'theme', 'primary', true);
     addDynamicInkColors(tailwindVars, prefix, 'theme-ink', 'primary-ink');
@@ -360,54 +359,54 @@ function generateTailwindThemeCss(themes, prefix, schema) {
     if (hasTertiary) {
         addDynamicThemeColors(tailwindVars, prefix, 'theme-tertiary', 'tertiary', false);
     }
-    // Alt theme dynamic colors
-    tailwindVars.push('  /* Alt theme dynamic colors */');
-    addDynamicThemeColors(tailwindVars, prefix, 'alt-theme', 'alt-primary', true);
-    addDynamicInkColors(tailwindVars, prefix, 'alt-theme-ink', 'alt-primary-ink');
-    if (hasAltSecondary) {
-        addDynamicThemeColors(tailwindVars, prefix, 'alt-theme-secondary', 'alt-secondary', false);
-    }
-    if (hasAltTertiary) {
-        addDynamicThemeColors(tailwindVars, prefix, 'alt-theme-tertiary', 'alt-tertiary', false);
-    }
-    // Generate runtime CSS for ALL themes (both main and alt variants)
+    // Generate runtime CSS for all themes
     themes.forEach((theme) => {
         const name = createCssThemeName(theme.name);
-        // Determine if this is the default or default-alt theme
+        // Determine if this is the default theme
         const isDefault = theme.isDefault;
-        const isDefaultAlt = theme.isDefaultAlt;
-        // Generate main theme variant (.et-theme--{name})
+        // Generate color variant (.et-color--{name})
         if (isDefault) {
-            // Default theme gets :root and .et-theme--default selectors
-            const selectors = [':root', `.${prefix}-theme--default`, `.${prefix}-theme--${name}`];
-            themeVars.push(`${selectors.join(', ')} {`);
-        }
-        else if (!isDefaultAlt) {
-            // Regular themes just get their own class
-            themeVars.push(`.${prefix}-theme--${name} {`);
-        }
-        if (isDefault || !isDefaultAlt) {
-            addThemeColorVariants(themeVars, prefix, '', theme);
-            themeVars.push('}\n');
-        }
-        // Generate alt theme variant (.et-theme-alt--{name})
-        if (isDefaultAlt) {
-            // Default alt theme gets :root and .et-theme-alt--default selectors
-            const selectors = [':root', `.${prefix}-theme-alt--default`, `.${prefix}-theme-alt--${name}`];
+            // Default color gets :root and .et-color--default selectors
+            const selectors = [':root', `.${prefix}-color--default`, `.${prefix}-color--${name}`];
             themeVars.push(`${selectors.join(', ')} {`);
         }
         else {
-            // All themes (including default and regular) get an alt variant
-            themeVars.push(`.${prefix}-theme-alt--${name} {`);
+            // Regular colors just get their own class
+            themeVars.push(`.${prefix}-color--${name} {`);
         }
-        addThemeColorVariants(themeVars, prefix, 'alt-', theme);
+        addThemeColorVariants(themeVars, prefix, '', theme);
         themeVars.push('}\n');
     });
+    // Convenience var aliases — available on any element with a color class (or root for default)
+    const aliasBlock = `/* Convenience aliases (rgb + solid + opacity variants) */
+@layer base {
+  :root, :where([class*="${prefix}-color--"]) {
+    --${prefix}-theme-color-primary-rgb: var(--${prefix}-color-primary);
+    --${prefix}-theme-color-primary-opacity: 1;
+    --${prefix}-theme-color-primary-solid: rgb(var(--${prefix}-theme-color-primary-rgb));
+    --${prefix}-theme-color-primary: rgb(var(--${prefix}-theme-color-primary-rgb) / var(--${prefix}-theme-color-primary-opacity));
+
+    --${prefix}-theme-color-on-primary-rgb: var(--${prefix}-color-on-primary);
+    --${prefix}-theme-color-on-primary-opacity: 1;
+    --${prefix}-theme-color-on-primary-solid: rgb(var(--${prefix}-theme-color-on-primary-rgb) / var(--${prefix}-theme-color-on-primary-opacity));
+    --${prefix}-theme-color-on-primary: rgb(var(--${prefix}-theme-color-on-primary-rgb) / var(--${prefix}-theme-color-on-primary-opacity));
+
+    --${prefix}-theme-color-ink-rgb: var(--${prefix}-color-primary-ink, var(--${prefix}-color-primary));
+    --${prefix}-theme-color-ink-opacity: 1;
+    --${prefix}-theme-color-ink-solid: rgb(var(--${prefix}-theme-color-ink-rgb) / var(--${prefix}-theme-color-ink-opacity));
+    --${prefix}-theme-color-ink: rgb(var(--${prefix}-theme-color-ink-rgb) / var(--${prefix}-theme-color-ink-opacity));
+  }
+}
+`;
     return `${header}@theme {
 ${tailwindVars.join('\n')}
 }
 
-${themeVars.join('\n')}`;
+@layer base {
+${themeVars.join('\n')}
+}
+
+${aliasBlock}`;
 }
 function addDynamicThemeColors(vars, prefix, tailwindName, cssVarName, addSpacingBefore) {
     if (addSpacingBefore && vars.length > 0 && vars[vars.length - 1] !== '') {

package/generators/{tailwind-4-theme → tailwind-4-color-theme}/schema.json

@@ -1,6 +1,6 @@
 {
   "$schema": "http://json-schema.org/schema",
-  "$id": "tailwind-4-theme",
+  "$id": "tailwind-4-color-theme",
   "title": "Tailwind 4 Theming Generator",
   "description": "Generates Tailwind 4 compatible CSS from your Ethlete theme definitions",
   "type": "object",