@ethlete/core 4.29.1 → 4.29.3

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @ethlete/core
 
+## 4.29.3
+
+### Patch Changes
+
+- [`6b05b76`](https://github.com/ethlete-io/ethdk/commit/6b05b7603cfd0038dda1336c7c0acf590556a4fa) Thanks [@TomTomB](https://github.com/TomTomB)! - Fix `controlValueSignal` not reporting the initial value if the passed control is a required input
+
+## 4.29.2
+
+### Patch Changes
+
+- [`11dc4d3`](https://github.com/ethlete-io/ethdk/commit/11dc4d32d6ae7f3681c50029d3c7e2468cbec3a0) Thanks [@TomTomB](https://github.com/TomTomB)! - Raise an error if signal utils detect a non html element being used as an element
+
 ## 4.29.1
 
 ### Patch Changes

package/fesm2022/ethlete-core.mjs

@@ -1699,12 +1699,19 @@ const buildElementSignal = (el) => {
     else {
         mElSignal = signal([coerceElement(el)]);
     }
-    const elSig = toSignal(toObservable(mElSignal).pipe(startWith(null), pairwise(), map(([previousElements, currentElements]) => ({
-        previousElements: previousElements ?? [],
-        currentElements: currentElements ?? [],
-        currentElement: currentElements?.[0] ?? null,
-        previousElement: previousElements?.[0] ?? null,
-    }))), { initialValue: { currentElement: null, previousElement: null, previousElements: [], currentElements: [] } });
+    const elSig = toSignal(toObservable(mElSignal).pipe(startWith(null), pairwise(), map(([previousElements, currentElements]) => {
+        const previousEl = previousElements?.[0] ?? null;
+        const currentEl = currentElements?.[0] ?? null;
+        if (currentEl && !(currentEl instanceof HTMLElement)) {
+            console.error('Received an element that is not an HTMLElement. You are probably using viewChild or contentChild on a component without the read option set to ElementRef. This will cause issues. Received:', currentEl);
+        }
+        return {
+            previousElements: previousElements ?? [],
+            currentElements: currentElements ?? [],
+            currentElement: currentEl,
+            previousElement: previousEl,
+        };
+    })), { initialValue: { currentElement: null, previousElement: null, previousElements: [], currentElements: [] } });
     return computed(() => elSig(), {
         equal: (a, b) => a.currentElement === b.currentElement &&
             a.previousElement === b.previousElement &&
@@ -2188,14 +2195,14 @@ const controlValueSignal = (control, options) => {
     let initialValue = null;
     const getRawValueSafe = (ctrl) => {
         try {
-            return ctrl?.getRawValue() ?? null;
+            return isSignal(ctrl) ? (ctrl()?.getRawValue() ?? null) : (ctrl?.getRawValue() ?? null);
         }
         catch {
             // Ignore errors. This can happen if the passed control is a required input and is not yet initialized.
             return null;
         }
     };
-    initialValue = isSignal(control) ? getRawValueSafe(control()) : getRawValueSafe(control);
+    initialValue = getRawValueSafe(control);
     const controlStream = isSignal(control)
         ? toObservable(control)
         : of(control);
@@ -2205,7 +2212,7 @@ const controlValueSignal = (control, options) => {
         const vcsObs = options?.debounceTime
             ? ctrl.valueChanges.pipe(debounceTime(options.debounceTime))
             : ctrl.valueChanges;
-        return vcsObs.pipe(map(() => getRawValueSafe(ctrl)));
+        return vcsObs.pipe(startWith(ctrl.getRawValue()), map(() => ctrl.getRawValue()));
     }));
     const obs = !options?.debounceFirst ? merge(of(initialValue), controlObs) : controlObs;
     return toSignal(obs.pipe(distinctUntilChanged((a, b) => equal(a, b))), {