@ethisyscore/vite-plugin 1.86.0 → 1.88.0

package/README.md

@@ -24,6 +24,7 @@ match your render mode into `vite.config.ts`.
 | `ethisysPlatformReactPlugin` | **PlatformReact** pass — builds one ESM bundle per declared page |
 | `buildPlatformReactPages`, `rewriteAliasedExternalImports`, `virtualPageEntry` | Multi-bundle orchestrator: one isolated Vite sub-build per page, with host-externals dedupe (`PLATFORM_REACT_EXTERNALS`, `PLATFORM_REACT_DEDUPE`) and host-loader import rewriting |
 | `generatePlatformReactManifest`, `computePlatformReactPages` | Build-step codegen — derive `feature.manifest.json` + the `extension.manifest.json` overlay from `routeMeta.json` |
+| `parseExportedNames` | The runtime-named exports of one module's source text — how the codegen resolves a view whose exported name differs from its filename |
 | `parsePlatformReactPages` | Test helper for snapshot-testing PlatformReact page declarations |
 | `ethisysIframeSandboxPlugin`, `buildIframeSandboxPages` | **Tier U** iframe-sandbox pass — cross-origin sandboxed pages with SHA-256 digest emission |
 | `ethisysManifestPlugin` | Legacy manifest-driven pass — auto-generates `index.html` for pages/surfaces that declare a `source` field |
@@ -44,6 +45,43 @@ Most plugins never call these directly — `cc package` drives the correct pass
 for the plugin's declared render mode. Reach for the factories when you maintain
 a bespoke build or need the validators/codegen in tests.
 
+### How `generatePlatformReactManifest` resolves a `useView` name
+
+Each page's `useView("<module>", "<Name>")` call becomes one entry of that page's
+`views` map, and `build-pages` wires it with a **named** import
+(`import { <Name> } from "<adapter module>"`). `<Name>` is resolved against the
+adapter tree in this order:
+
+1. **By filename** — an adapter file whose basename is `<Name>` (e.g.
+   `CompanyCostsView` → `src/adapter/finance/CompanyCostsView.tsx`). This is the
+   original and still the winning rule, so a plugin that follows the filename
+   convention resolves exactly as it always has.
+2. **By exported name** — otherwise, the single adapter file that *exports*
+   `<Name>`. An adapter file may legitimately export its component under a name
+   other than its filename:
+
+   ```tsx
+   // src/adapter/chat/ChatChannelCreateFormView.tsx
+   export function ChatChannelCreateFormView(/* … */) { /* … */ }
+   export { ChatChannelCreateFormView as ChatChannelCreateForm };
+   ```
+
+   `useView("chat", "ChatChannelCreateForm")` is correct at runtime, and now
+   generates. `export function|const|let|var|class X`, `export { X }`,
+   `export { X as Y }` and `export { X } from "…"` all count.
+
+   `export default …` deliberately does **not** — a default export cannot satisfy
+   a named import — and neither do type-only exports (`export type` /
+   `export interface`), which are erased at runtime. `export * from "…"` is out of
+   reach of the scan, so a view reachable only that way still reports as
+   unresolvable rather than being mis-resolved.
+3. **Two files export the same name** → the generator fails, naming every
+   candidate. Picking one would compile and then render the wrong component. Give
+   the intended file that basename (rule 1 always wins) or rename the view.
+4. **Nothing matches** → the generator fails (unless `strict: false`). This error
+   is the point of the pass: `useView` is a manifest lookup, not an import, so an
+   unsatisfiable call renders "View not available" at runtime behind a green build.
+
 ## Build and test
 
 ```bash

package/dist/index.cjs

@@ -1639,6 +1639,31 @@ function parsePlatformReactPages(manifestPath, options = {}) {
   return result;
 }
 var DEFAULT_SCHEMA = "https://ethisys.dev/schemas/feature-manifest.json";
+var EXPORT_DECL_RE = /^[ \t]*export\s+(?:async\s+)?(?:function|const|let|var|class)\s+([A-Za-z_$][\w$]*)/gm;
+var EXPORT_LIST_RE = /^[ \t]*export\s*\{([^}]*)\}/gm;
+var EXPORT_SPECIFIER_RE = /^([A-Za-z_$][\w$]*)(?:\s+as\s+([A-Za-z_$][\w$]*))?$/;
+function parseExportedNames(content) {
+  const names = /* @__PURE__ */ new Set();
+  EXPORT_DECL_RE.lastIndex = 0;
+  let m;
+  while ((m = EXPORT_DECL_RE.exec(content)) !== null) {
+    names.add(m[1]);
+  }
+  EXPORT_LIST_RE.lastIndex = 0;
+  while ((m = EXPORT_LIST_RE.exec(content)) !== null) {
+    for (const raw of m[1].split(",")) {
+      const item = raw.trim();
+      if (item.length === 0) continue;
+      if (/^type\s/.test(item)) continue;
+      const spec = EXPORT_SPECIFIER_RE.exec(item);
+      if (spec === null) continue;
+      const exported = spec[2] ?? spec[1];
+      if (exported === "default") continue;
+      names.add(exported);
+    }
+  }
+  return [...names];
+}
 function computePlatformReactPages(input) {
   const routePrefix = `/extensions/${input.slug}/`;
   const routeRoot = `/extensions/${input.slug}`;
@@ -1655,6 +1680,7 @@ function computePlatformReactPages(input) {
   const entries = [];
   const missingViews = [];
   const unregisteredViews = [];
+  const ambiguousViews = [];
   for (const { file, content, moduleSpecifier } of input.pages) {
     const name = path.basename(file, ".tsx");
     const override = input.pageOverrides?.[file] ?? {};
@@ -1671,6 +1697,15 @@ function computePlatformReactPages(input) {
       }
       if (input.viewFiles[v] !== void 0) {
         views[v] = input.viewFiles[v];
+        continue;
+      }
+      const byExport = input.viewExports?.[v] ?? [];
+      if (byExport.length === 1) {
+        views[v] = byExport[0];
+      } else if (byExport.length > 1) {
+        ambiguousViews.push(
+          `${file}: view "${v}" matches no adapter filename and is exported by ${byExport.length} adapter files, so the binding is ambiguous: ${byExport.join(", ")}. Rename the view, or give the intended file that basename (a filename match always wins)`
+        );
       } else {
         missingViews.push(`${file}: view "${v}" has no adapter file`);
       }
@@ -1686,7 +1721,7 @@ function computePlatformReactPages(input) {
       views
     });
   }
-  return { entries, missingViews, unregisteredViews };
+  return { entries, missingViews, unregisteredViews, ambiguousViews };
 }
 function walk2(dir) {
   const out = [];
@@ -1713,13 +1748,26 @@ function generatePlatformReactManifest(config) {
   const pageDirs = (Array.isArray(pagesCfg) ? pagesCfg : [pagesCfg]).map((p) => path.resolve(root, p));
   const exclude = new Set(config.paths?.pageExclude ?? []);
   const viewFiles = {};
+  const viewExportsByName = /* @__PURE__ */ new Map();
   if (fs.existsSync(adapterDir)) {
     for (const f of walk2(adapterDir)) {
       if (f.endsWith(".tsx")) {
-        viewFiles[path.basename(f, ".tsx")] = slash2(path.relative(root, f));
+        const rel = slash2(path.relative(root, f));
+        viewFiles[path.basename(f, ".tsx")] = rel;
+        for (const name of parseExportedNames(fs.readFileSync(f, "utf8"))) {
+          let paths = viewExportsByName.get(name);
+          if (paths === void 0) {
+            paths = /* @__PURE__ */ new Set();
+            viewExportsByName.set(name, paths);
+          }
+          paths.add(rel);
+        }
       }
     }
   }
+  const viewExports = Object.fromEntries(
+    [...viewExportsByName].map(([name, paths]) => [name, [...paths].sort()])
+  );
   const seen = /* @__PURE__ */ new Map();
   const pages = [];
   for (const dir of pageDirs) {
@@ -1743,13 +1791,14 @@ function generatePlatformReactManifest(config) {
       });
     }
   }
-  const { entries, missingViews, unregisteredViews } = computePlatformReactPages({
+  const { entries, missingViews, unregisteredViews, ambiguousViews } = computePlatformReactPages({
     module,
     moduleKeys: config.moduleKeys,
     slug,
     routeMeta,
     pages,
     viewFiles,
+    viewExports,
     pageOverrides: config.pageOverrides
   });
   const schema = config.manifest.schema ?? DEFAULT_SCHEMA;
@@ -1795,13 +1844,15 @@ function generatePlatformReactManifest(config) {
     pagesWithoutView,
     missingViews,
     unregisteredViews,
+    ambiguousViews,
     featureManifestPath,
     overlayPath
   };
-  if ((config.strict ?? true) && (missingViews.length > 0 || unregisteredViews.length > 0)) {
+  const diagnostics = [...unregisteredViews, ...ambiguousViews, ...missingViews];
+  if ((config.strict ?? true) && diagnostics.length > 0) {
     throw new Error(
-      `generate-manifest: ${missingViews.length + unregisteredViews.length} unresolvable useView call(s). Each renders "View not available" at runtime behind a green build:
-` + [...unregisteredViews, ...missingViews].map((d) => `  - ${d}`).join("\n")
+      `generate-manifest: ${diagnostics.length} unresolvable useView call(s). Each renders "View not available" at runtime behind a green build:
+` + diagnostics.map((d) => `  - ${d}`).join("\n")
     );
   }
   return result;
@@ -2166,6 +2217,7 @@ exports.findUnscopedSelectors = findUnscopedSelectors;
 exports.formatUnscopedSelectorError = formatUnscopedSelectorError;
 exports.generatePlatformReactManifest = generatePlatformReactManifest;
 exports.isScopableCssId = isScopableCssId;
+exports.parseExportedNames = parseExportedNames;
 exports.parsePlatformReactPages = parsePlatformReactPages;
 exports.rewriteAliasedExternalImports = rewriteAliasedExternalImports;
 exports.scopePluginCss = scopePluginCss;