@ethisyscore/vite-plugin 1.141.5 → 1.142.1

package/dist/index.js

@@ -1017,8 +1017,8 @@ var PLATFORM_REACT_EXTERNALS = [
   // Externalised, not bundled, and not merely to save weight: bundling it gave
   // every page its OWN `QueryClient`, so a mutation on the detail page
   // invalidated a cache the list page could not see and a deleted row survived
-  // until a browser reload. One host-realm module instance is one cache across
-  // every plugin surface.
+  // until a browser reload. One host-realm module instance is one React context,
+  // through which the host hands every surface of a plugin the same client.
   //
   // Requires a host whose `hostModuleRegistry` serves this specifier: an external
   // the deployed host does NOT register is an unresolvable bare import, and the
@@ -1027,25 +1027,26 @@ var PLATFORM_REACT_EXTERNALS = [
   // `useSurfaceQueryClient` in plugin-ui) covers the softer case — module served,
   // no client in scope — and cannot cover this one.
   //
-  // THE SECOND GATE, and it binds each plugin rather than the estate: one cache
-  // means one KEY SPACE, so two owners using the same key now read each other's
-  // entry. Measured across the estate before this change: `["currencies"]` is
-  // used verbatim by coreconnect-web, bf-hr and bf-legal, from a copied
-  // `useCurrencies.ts` — three owners, one key, previously harmless only because
-  // each bundle had a cache of its own.
-  //
-  // A plugin therefore joins the shared cache the moment it is REBUILT on this
-  // SDK, and must have owner-namespaced its keys first. That ordering is the
-  // enforcement point and it is per plugin: a plugin not yet rebuilt still has
-  // its own cache and is unaffected, so this can be rolled out one plugin at a
-  // time rather than estate-wide.
+  // The KEY SPACE is per plugin, and the host owns that boundary. A single
+  // client for the whole app put every plugin's keys beside the host's and each
+  // other's, and they collided: `["employees","lookup"]` is cached by hr,
+  // finance and projects in different shapes, and `["currencies"]` by
+  // coreconnect-web, bf-hr and bf-legal from a copied `useCurrencies.ts`. So the
+  // host (coreconnect-web `pluginQueryClients.ts`, PBI 5626) wraps every page
+  // and overlay of one plugin in a client of that plugin's own: its surfaces
+  // share a cache, and no plugin can read, overwrite or invalidate another's.
+  // Plugin keys need no owner prefix. The corollary is that a plugin cannot
+  // refresh another plugin's cache either; cross-plugin freshness comes from
+  // the kernel's push to each plugin's OWN group (`cache.plugin-invalidate`),
+  // which the host forwards only to the plugin it names and the plugin maps to
+  // its own keys through the definers' `cacheSubscriptions`. The host fans no
+  // plugin's change out to another plugin's client.
   //
   // The ORGANISATION axis needs nothing here, and that was checked rather than
-  // assumed: coreconnect-web's AuthContext calls `queryClient.clear()` on logout
-  // AND on a live org switch between two non-null tenants, then bumps the
-  // authority epoch to force a remount. Plugins sharing that client inherit both.
-  // Sharing is in fact stricter than the status quo, where a plugin's private
-  // cache is unreachable by the host's teardown.
+  // assumed: coreconnect-web clears its own client AND every plugin client on
+  // logout, on a live organisation or identity switch, and when a plugin's
+  // bundle bytes may have changed, then bumps the authority epoch to force a
+  // remount.
   "@tanstack/react-query"
 ];
 var PLATFORM_REACT_DEDUPE = [
@@ -1127,6 +1128,35 @@ Use a STATIC top-level import of the package root instead. A dynamic import of a
     }
   };
 }
+var RETIRED_HOST_SPECIFIERS = ["@ethisyscore/host-query-client"];
+function looksImported(code, spec) {
+  const gap = String.raw`\s*(?:/\*[\s\S]*?\*/\s*)*`;
+  const q = escapeRegExp(spec);
+  return new RegExp(`(?:\\bfrom${gap}|\\bimport${gap}\\(?${gap}|\\brequire${gap}\\(${gap})["'\`]${q}["'\`]`).test(code);
+}
+function rejectRetiredHostSpecifiers(retired = RETIRED_HOST_SPECIFIERS) {
+  const retiredSet = new Set(retired);
+  const message = (spec, where) => `[build-pages] ${where} imports "${spec}", which the host keeps registered only so old bundles link: it serves no client a plugin should use. A plugin surface runs on the QueryClient the host provides around it; read it with useQueryClient() inside the surface.`;
+  return {
+    name: "reject-retired-host-specifiers",
+    enforce: "pre",
+    resolveId(source, importer) {
+      if (retiredSet.has(source)) {
+        throw new Error(message(source, importer ?? "a module"));
+      }
+      return null;
+    },
+    renderChunk(code, chunk) {
+      const imported = Array.isArray(chunk.imports) ? /* @__PURE__ */ new Set([...chunk.imports, ...chunk.dynamicImports ?? []]) : void 0;
+      for (const spec of retired) {
+        if (imported ? imported.has(spec) : looksImported(code, spec)) {
+          throw new Error(message(spec, chunk.fileName ?? "bundle"));
+        }
+      }
+      return null;
+    }
+  };
+}
 function virtualPageEntry(page, config) {
   const VIRTUAL_ID = `\0virtual:surface/${page.id}`;
   const views = page.views ?? {};
@@ -1212,6 +1242,8 @@ function makeDefaultBuild(viteBuild) {
       // `enforce: "pre"`, this one declares none. See its doc for why "none" is the
       // only position that sees compiled CSS.
       plugins: [
+        // First, so a retired host specifier fails with its importer's name before anything resolves it.
+        rejectRetiredHostSpecifiers(),
         ctx.surfacePlugin,
         ...ctx.plugins,
         scopePluginCssPlugin(),
@@ -1452,7 +1484,8 @@ function ethisysPlatformReactPlugin(options = {}) {
   return [
     ethisysPlatformReactPagesPlugin(options),
     scopePluginCssPlugin(),
-    assertHostResolvableExternals([...PLATFORM_REACT_EXTERNALS, "@ethisyscore/host-ui-externals"])
+    assertHostResolvableExternals([...PLATFORM_REACT_EXTERNALS, "@ethisyscore/host-ui-externals"]),
+    rejectRetiredHostSpecifiers()
   ];
 }
 function ethisysPlatformReactPagesPlugin(options = {}) {