@ethisyscore/vite-plugin 1.120.0 → 1.122.0

package/dist/index.cjs

@@ -938,6 +938,36 @@ var PLATFORM_REACT_EXTERNALS = [
   "react-dom",
   "@mui/material",
   "@mui/icons-material",
+  // MUI X. Every plugin previously shipped its own copy on top of the host's.
+  //
+  // EXACT STRINGS, and that is load-bearing rather than stylistic. Rolldown matches
+  // a string `external` by equality, verified by building an entry that imports both
+  // `date-fns` and `date-fns/addDays` against `external: ["date-fns"]`: the bare
+  // import stayed external, the subpath was bundled. So a prefix or regex matcher
+  // here would externalise `@mui/x-data-grid/style.css` and
+  // `@mui/x-date-pickers/AdapterDayjs` too, which the host does NOT register, and an
+  // external the host does not serve is an unresolvable bare import that kills the
+  // bundle before any plugin code runs. `startsWith("@mui/x-charts")` additionally
+  // swallows `@mui/x-charts-pro`. Add specifiers one at a time; never widen the match.
+  //
+  // THE CONSUMER-SIDE GATE: exact matching makes this safe but PARTIAL. A plugin that
+  // imports the package root AND a subpath of the same package gets TWO module
+  // instances, host-served and bundled, and React context does not cross that seam.
+  // The concrete break is `LocalizationProvider` from "@mui/x-date-pickers" (host)
+  // with `DatePicker` from "@mui/x-date-pickers/DatePicker" (bundled): the picker
+  // cannot see the provider's context and MUI throws "Can not find the date and time
+  // pickers localization context". Every root-exported symbol must therefore be
+  // imported from the ROOT once its package is externalised.
+  //
+  // `@mui/x-date-pickers/AdapterDayjs` is the deliberate exception and stays a
+  // sub-path import, because the root does not re-export it. That is safe here and it
+  // was checked rather than assumed: `LocalizationProvider` validates the adapter with
+  // `if (!dateAdapter.isMUIAdapter)`, a duck-typed flag, so a bundled adapter instance
+  // handed to the host's provider passes. Contrast `instanceof`, which would not.
+  "@mui/x-data-grid",
+  "@mui/x-charts",
+  "@mui/x-charts-pro",
+  "@mui/x-date-pickers",
   "@emotion/react",
   "@emotion/styled",
   "date-fns",
@@ -1029,6 +1059,34 @@ function rewriteAliasedExternalImports() {
     }
   };
 }
+function assertHostResolvableExternals(external) {
+  return {
+    name: "assert-host-resolvable-externals",
+    renderChunk(code, chunk) {
+      const offences = [];
+      for (const spec of external) {
+        const q = escapeRegExp(spec);
+        const reExport = new RegExp(`\\bexport\\s[^;]{0,200}?from\\s*["']${q}["']`);
+        const dynamic = new RegExp(`\\bimport\\s*\\(\\s*["']${q}["']\\s*\\)`);
+        if (reExport.test(code)) {
+          offences.push(`re-export of "${spec}" (export \u2026 from)`);
+        }
+        if (dynamic.test(code)) {
+          offences.push(`dynamic import of "${spec}"`);
+        }
+      }
+      if (offences.length > 0) {
+        throw new Error(
+          `[build-pages] ${chunk.fileName ?? "bundle"} emits host-provided specifiers in a form the host loader cannot rewrite, so the surface would fail to load at mount:
+` + offences.map((o) => `  - ${o}`).join("\n") + `
+
+Use a STATIC top-level import of the package root instead. A dynamic import of a host-provided package is never needed: the host already loads its namespaces on demand, per bundle. For a re-export, import the symbols and export them explicitly.`
+        );
+      }
+      return null;
+    }
+  };
+}
 function virtualPageEntry(page, config) {
   const VIRTUAL_ID = `\0virtual:surface/${page.id}`;
   const views = page.views ?? {};
@@ -1117,7 +1175,9 @@ function makeDefaultBuild(viteBuild) {
         ctx.surfacePlugin,
         ...ctx.plugins,
         scopePluginCssPlugin(),
-        rewriteAliasedExternalImports()
+        rewriteAliasedExternalImports(),
+        // Last, so it sees exactly the bytes the host will fetch.
+        assertHostResolvableExternals(ctx.external)
       ],
       resolve: {
         dedupe: [...ctx.dedupe],
@@ -1348,7 +1408,11 @@ function assertHostOriginRelativePath2(value, label) {
   }
 }
 function ethisysPlatformReactPlugin(options = {}) {
-  return [ethisysPlatformReactPagesPlugin(options), scopePluginCssPlugin()];
+  return [
+    ethisysPlatformReactPagesPlugin(options),
+    scopePluginCssPlugin(),
+    assertHostResolvableExternals([...PLATFORM_REACT_EXTERNALS, "@ethisyscore/host-ui-externals"])
+  ];
 }
 function ethisysPlatformReactPagesPlugin(options = {}) {
   const explicitRoot = options.root;
@@ -2294,6 +2358,7 @@ exports.EHX_PLUGIN_SCOPE_ROOTS = EHX_PLUGIN_SCOPE_ROOTS;
 exports.EHX_SCOPED_CSS_LAYERS = EHX_SCOPED_CSS_LAYERS;
 exports.PLATFORM_REACT_DEDUPE = PLATFORM_REACT_DEDUPE;
 exports.PLATFORM_REACT_EXTERNALS = PLATFORM_REACT_EXTERNALS;
+exports.assertHostResolvableExternals = assertHostResolvableExternals;
 exports.buildIframeSandboxPages = buildIframeSandboxPages;
 exports.buildPlatformReactPages = buildPlatformReactPages;
 exports.computePlatformReactPages = computePlatformReactPages;