@ethisyscore/eslint-plugin-coreconnect 1.92.0 → 1.93.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethisyscore/eslint-plugin-coreconnect",
-  "version": "1.92.0",
+  "version": "1.93.0",
   "description": "ESLint rules enforcing EthisysCore plugin frontend conventions. Published so a new rule reaches every plugin on a version bump, rather than being copied into each scaffold and drifting.",
   "type": "module",
   "main": "src/index.js",

package/src/rules/componentDeclarations.js

@@ -87,9 +87,32 @@ export function looksLikeComponent(init) {
  * @param {string} options.message
  * @param {{ source: string, name: string }} options.canonical The promoted component this rule
  *   points people at. A local declaration that COMPOSES it is exempt - see below.
+ * @param {boolean} [options.fileScopedExemption] Exempt EVERY matching declaration in a file
+ *   that composes the canonical component anywhere, instead of only the declaration whose own
+ *   body reaches it.
+ *
+ *   <p>Off by default, because range containment is what keeps these rules narrow. Opt in when
+ *   the pattern deliberately matches FEATURE-SURFACE names rather than component names - the
+ *   in-progress-banner rule matches `TechImportIndicator`, whose legitimate shape is a top-level
+ *   component that renders the shared banner through a SIBLING helper. Range containment cannot
+ *   express that: the helper composes the canonical component, the outer name is what matches the
+ *   pattern, and the two are different declarations. Without this the rule fires on correctly
+ *   adopted code - which it did, on the first real adoption, because the test asserting the
+ *   exemption used the easy shape where the wrapper renders the canonical component directly.</p>
+ *
+ *   <p>The cost, stated: a file that composes the canonical component AND hand-rolls a second
+ *   banner beside it goes unreported. Accepted for that rule only - a false positive on every
+ *   correct adoption is the worse failure, because it trains people to switch the rule off.</p>
  * @returns {import("eslint").Rule.RuleModule}
  */
-export function createNoLocalComponentRule({ pattern, messageId, description, message, canonical }) {
+export function createNoLocalComponentRule({
+  pattern,
+  messageId,
+  description,
+  message,
+  canonical,
+  fileScopedExemption = false,
+}) {
   // Fail at construction, not on the first source file that happens to contain an import. Without
   // this a fifth rule added without a `canonical` line throws a TypeError from inside the
   // ImportDeclaration visitor, which surfaces as an opaque lint crash on an arbitrary file.
@@ -145,7 +168,9 @@ export function createNoLocalComponentRule({ pattern, messageId, description, me
        * one next door still reports the second.
        */
       const composesCanonical = (node) =>
-        canonicalUses.some((at) => at >= node.range[0] && at <= node.range[1]);
+        fileScopedExemption
+          ? canonicalUses.length > 0
+          : canonicalUses.some((at) => at >= node.range[0] && at <= node.range[1]);
 
       const check = (idNode, declarationNode) => {
         if (!idNode || idNode.type !== "Identifier") {

package/src/rules/no-local-in-progress-banner.js

@@ -31,4 +31,10 @@ export default createNoLocalComponentRule({
     "Disallow a locally-declared in-progress banner - import InProgressBanner from @ethisyscore/plugin-ui/components/shared",
   message:
     "'{{name}}' looks like a local in-progress banner. Import { InProgressBanner } from '@ethisyscore/plugin-ui/components/shared' instead, so a background job looks the same wherever it appears. It takes title, children, value (omit for an indeterminate bar), action and sx.",
+  // FILE-SCOPED, unlike its four siblings, because this pattern matches feature-surface names.
+  // `TechImportIndicator` is a top-level component that renders the shared banner through a
+  // SIBLING helper (`ImportingGroup`), so the declaration matching the pattern and the one
+  // composing the canonical component are different nodes and range containment cannot exempt it.
+  // Without this the rule fired on the very first correct adoption.
+  fileScopedExemption: true,
 });