@ethisyscore/eslint-plugin-coreconnect 1.90.0 → 1.92.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethisyscore/eslint-plugin-coreconnect",
-  "version": "1.90.0",
+  "version": "1.92.0",
   "description": "ESLint rules enforcing EthisysCore plugin frontend conventions. Published so a new rule reaches every plugin on a version bump, rather than being copied into each scaffold and drifting.",
   "type": "module",
   "main": "src/index.js",

package/src/index.js

@@ -5,6 +5,7 @@ import noLocalCompletenessBanner from "./rules/no-local-completeness-banner.js";
 import noLocalDataGrid from "./rules/no-local-data-grid.js";
 import noLocalDateInput from "./rules/no-local-date-input.js";
 import noLocalEmptyState from "./rules/no-local-empty-state.js";
+import noLocalInProgressBanner from "./rules/no-local-in-progress-banner.js";
 import noLocalMappingEditor from "./rules/no-local-mapping-editor.js";
 import noLocalSearchInput from "./rules/no-local-search-input.js";
 import noParamInNavPath from "./rules/no-param-in-nav-path.js";
@@ -17,6 +18,7 @@ const rules = {
   "no-local-data-grid": noLocalDataGrid,
   "no-local-date-input": noLocalDateInput,
   "no-local-empty-state": noLocalEmptyState,
+  "no-local-in-progress-banner": noLocalInProgressBanner,
   "no-local-mapping-editor": noLocalMappingEditor,
   "no-local-search-input": noLocalSearchInput,
   "no-param-in-nav-path": noParamInNavPath,

package/src/rules/no-local-in-progress-banner.js

@@ -0,0 +1,34 @@
+/**
+ * Disallow a plugin declaring its own in-progress / background-job banner.
+ *
+ * The backstop to a promotion, and the sibling of `no-local-empty-state` - deliberately, because
+ * the two components are one decision. A surface with no in-progress state does not stay silent: it
+ * renders its EMPTY state instead, which claims the operation finished and produced nothing. That
+ * defect shipped twice in one week on a single page (engineering-skills UX-113).
+ *
+ * Three hand-written copies existed at promotion time - the tech repo-import indicator, the
+ * self-healing fix-run banner, and the monolith's own OperationGlobalBanner - with a byte-identical
+ * `height: 6, borderRadius: 3` progress bar, and that same pair repeated in ten more places. A rule
+ * describing the correct markup did not stop the second occurrence; one implementation can.
+ *
+ * Fires on a DECLARATION, never a use, so importing `InProgressBanner` from
+ * `@ethisyscore/plugin-ui/components/shared` and rendering it is what the rule wants - including
+ * wrapping it in a plugin-specific component that feeds it that plugin's own progress data, which
+ * the shared helper exempts by recognising the canonical binding.
+ *
+ * @type {import("eslint").Rule.RuleModule}
+ */
+import { createNoLocalComponentRule } from "./componentDeclarations.js";
+
+export default createNoLocalComponentRule({
+  // The names this banner keeps being rewritten under. `Indicator` is included because the tech
+  // copy was called `TechImportIndicator`, and a suffix match is what catches the plugin-prefixed
+  // spellings; the shared helper's hook guard keeps `useImportIndicator` out of it.
+  pattern: /(InProgressBanner|ImportIndicator|ProgressBanner|ProgressIndicator|OperationBanner|BusyBanner)$/,
+  canonical: { source: "@ethisyscore/plugin-ui/components/shared", name: "InProgressBanner" },
+  messageId: "noLocalInProgressBanner",
+  description:
+    "Disallow a locally-declared in-progress banner - import InProgressBanner from @ethisyscore/plugin-ui/components/shared",
+  message:
+    "'{{name}}' looks like a local in-progress banner. Import { InProgressBanner } from '@ethisyscore/plugin-ui/components/shared' instead, so a background job looks the same wherever it appears. It takes title, children, value (omit for an indeterminate bar), action and sx.",
+});