@ethisyscore/eslint-plugin-coreconnect 1.76.0 → 1.78.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethisyscore/eslint-plugin-coreconnect",
-  "version": "1.76.0",
+  "version": "1.78.0",
   "description": "ESLint rules enforcing EthisysCore plugin frontend conventions. Published so a new rule reaches every plugin on a version bump, rather than being copied into each scaffold and drifting.",
   "type": "module",
   "main": "src/index.js",

package/src/index.js

@@ -1,9 +1,11 @@
 import noHardcodedColors from "./rules/no-hardcoded-colors.js";
 import noInlineObjectType from "./rules/no-inline-object-type.js";
 import noInlineStringUnion from "./rules/no-inline-string-union.js";
+import noLocalCompletenessBanner from "./rules/no-local-completeness-banner.js";
 import noLocalDataGrid from "./rules/no-local-data-grid.js";
 import noLocalDateInput from "./rules/no-local-date-input.js";
 import noLocalEmptyState from "./rules/no-local-empty-state.js";
+import noLocalMappingEditor from "./rules/no-local-mapping-editor.js";
 import noLocalSearchInput from "./rules/no-local-search-input.js";
 import noParamInNavPath from "./rules/no-param-in-nav-path.js";
 
@@ -11,9 +13,11 @@ const rules = {
   "no-hardcoded-colors": noHardcodedColors,
   "no-inline-object-type": noInlineObjectType,
   "no-inline-string-union": noInlineStringUnion,
+  "no-local-completeness-banner": noLocalCompletenessBanner,
   "no-local-data-grid": noLocalDataGrid,
   "no-local-date-input": noLocalDateInput,
   "no-local-empty-state": noLocalEmptyState,
+  "no-local-mapping-editor": noLocalMappingEditor,
   "no-local-search-input": noLocalSearchInput,
   "no-param-in-nav-path": noParamInNavPath,
 };

package/src/rules/no-local-completeness-banner.js

@@ -0,0 +1,92 @@
+/**
+ * Disallow a plugin declaring its own connector mapping-completeness banner.
+ *
+ * The second backstop to the Tool Mappings promotion, and the one that shows why these rules report
+ * rather than warn. `MappingCompletenessBanner` moved into
+ * `@ethisyscore/plugin-ui/components/connectors` in 1.71.6, and `timesheets` adopted it. Measured on
+ * origin/develop months later, `self-healing` and `tech` still carried their own - 126 and 155 lines
+ * - and one of them had drifted on the string that matters most:
+ *
+ *   - `self-healing`'s optional-gap alert is titled "Optional operations not mapped". The SDK's, and
+ *     `tech`'s, read "Optional operations aren't fully mapped".
+ *
+ * That reads like a wording nit and is not. BOTH alerts select on
+ * `unmappedRequiredCanonicalFields`, i.e. on FIELD mapping, but "not mapped" describes TOOL mapping,
+ * which is a binary an operator can close with one button. So operators pressed auto-match - which
+ * picks the tool and cannot touch its fields - watched the count refuse to move, and raised the
+ * banner as broken. It was right; the sentence describing it was wrong, and the cost was paid in
+ * support round-trips rather than in a stack trace. Nothing was ever going to catch that in review,
+ * because reviewing a copy tells you nothing about the copy next door.
+ *
+ * Fires on a DECLARATION, never a use, so importing `MappingCompletenessBanner` from
+ * `@ethisyscore/plugin-ui/components/connectors` and rendering it is exactly what the rule wants -
+ * as is a local wrapper that composes it, which the shared helper exempts.
+ *
+ * ## Why there is no companion rule for the selectors
+ *
+ * `mappingCompleteness.ts` - `selectRequiredIncompleteOperations`,
+ * `selectOptionalIncompleteOperations`, `selectMappingReadiness` - is duplicated in the same two
+ * plugins, and it is where the field-vs-tool predicate actually lives, so it looks like the more
+ * dangerous copy. Measured, it is not:
+ *
+ *   - Both plugin copies are BEHAVIOURALLY IDENTICAL to the promoted ones. Diffed against the SDK,
+ *     they differ only by the type import's source and by selectors they never used being absent.
+ *     Three copies, months, zero logic drift. What drifted was the prose explaining the predicate to
+ *     an operator - which lives in the banner, and is what this rule guards.
+ *   - The local selectors have exactly ONE consumer each, the local banner beside them. No page,
+ *     hook or service imports them, and `tech`'s `selectIncompleteOperations` is referenced by
+ *     nothing but its own docstring. So this rule already closes the duplication: `timesheets`,
+ *     the one plugin that adopted the shared banner, deleted its whole `components/connectors`
+ *     directory in the same move.
+ *   - `createNoLocalComponentRule` could not express it anyway. It gates on `isComponentName`
+ *     (`^[A-Z]`) and on a component-shaped initializer, and a selector is neither. A selectors rule
+ *     would be new machinery for no coverage any measured file lacks.
+ *
+ * If a plugin ever imports those selectors somewhere other than its own banner, that reasoning stops
+ * holding and the rule becomes worth adding. Nothing in the estate does today.
+ *
+ * @type {import("eslint").Rule.RuleModule}
+ */
+import { createNoLocalComponentRule } from "./componentDeclarations.js";
+
+export default createNoLocalComponentRule({
+  // Both a MAPPING context AND the literal `Completeness` AND a banner-shaped suffix. All three are
+  // load-bearing, and each was chosen against a count rather than a guess.
+  //
+  // A bare `Banner$` is unusable: the estate declares 25 other banners, among them
+  // `ConnectorWarningBanner`, `AiPlatformStatusBanner`, `PluginRuntimeBanner`, `ErrorBanner`,
+  // `SuspiciousActivityBanner`, `PinnedMessagesBanner` and `InvoiceWarningsBanner` - the first of
+  // which sits on the very same Tool Mappings page. Requiring `Completeness` spares all of them.
+  //
+  // A bare `Completeness(Banner|Alert)$` is no better, because `Completeness` is NOT this feature's
+  // private word. `repo-monitoring` ships a `DataCompleteness` union ("Complete" |
+  // "PartialFallbackApplied" | "Degraded") in both the host contracts and `tech`, and a
+  // `DataCompletenessBanner` warning that commit data is degraded is exactly the component that
+  // would appear next. So the qualifier alternation is required, and it is the same shape
+  // `no-local-mapping-editor` uses: `Mapping` normally, `Connector` or `Tool` for a rename that
+  // drops it. A prefixed spelling needs no branch of its own - `ToolMappingCompletenessBanner` ends
+  // in the branch-one form already.
+  //
+  // The suffix set is likewise measured. `Alert` is the MUI component the banner literally renders,
+  // so it is the likeliest rename; `Notice` and `Callout` are estate vocabulary (`DeveloperCallout`).
+  // `(View|Panel)` is optional so the adapter-view spelling matches. What is deliberately EXCLUDED
+  // is the rest of the `MappingCompleteness*` family, which is legitimately duplicated everywhere as
+  // wire contracts: `MappingCompletenessItem` (112 references), `MappingCompletenessResult` (34),
+  // `ConnectorMappingCompletenessResult`, `GetToolMappingCompletenessResponse` and
+  // `MappingCompletenessBannerProps`. Anchoring on a banner-shaped suffix is what keeps them out.
+  //
+  // Hooks are excluded by the shared helper, which matters here: `useConnectorMappingCompleteness`
+  // is a real hook in three repos. Lowercase names are excluded too, which covers
+  // `getMappingCompleteness`, `mappingCompleteness`, `dataCompleteness` and
+  // `invalidateMappingsAndCompleteness`.
+  pattern: /(Mappings?|Connector|Tool)Completeness(Banner|Alert|Notice|Callout)(View|Panel)?$/,
+  canonical: {
+    source: "@ethisyscore/plugin-ui/components/connectors",
+    name: "MappingCompletenessBanner",
+  },
+  messageId: "noLocalCompletenessBanner",
+  description:
+    "Disallow a locally-declared mapping completeness banner - import MappingCompletenessBanner from @ethisyscore/plugin-ui/components/connectors",
+  message:
+    "'{{name}}' re-declares the mapping completeness banner. Import { MappingCompletenessBanner } from '@ethisyscore/plugin-ui/components/connectors' instead: a local copy had already drifted to \"Optional operations not mapped\", which describes TOOL mapping when the alert selects on unmapped FIELDS - so operators pressed auto-match, saw the count refuse to move, and reported the banner as broken. If this reports completeness for something other than connector mappings, rename it so it does not read as one.",
+});

package/src/rules/no-local-mapping-editor.js

@@ -0,0 +1,58 @@
+/**
+ * Disallow a plugin declaring its own connector-mapping field-translation editor.
+ *
+ * The backstop to the promotion that finished the Tool Mappings surface. Measured on origin/develop:
+ * `ConnectorMappingTranslationEditorView.tsx` existed in FOUR places - the host's gogo-ui adapter
+ * plus `self-healing`, `tech` and `timesheets` - at 592/522/527/527 lines, and the copies had
+ * already drifted in three ways, one of them a live defect:
+ *
+ *   - `self-healing` rendered the "Test mapping" button unconditionally. Its enclosing block opens
+ *     on `(onTestMapping || onSuggestTranslation)`, so a consumer wiring only auto-configure got a
+ *     button whose handler returns on its first line - a DEAD CONTROL. Nobody noticed, because
+ *     there was no single source to notice it against.
+ *   - `self-healing` washed two panels with a literal `rgba(0,0,0,0.03)`, invisible in dark mode.
+ *   - `self-healing` carried emoji in the extraction chips, on top of the icon and colour the chip
+ *     already had.
+ *
+ * Meanwhile the three plugin copies had dropped the HOST's `?? []` coalescing on the canonical field
+ * lists, which is the only thing standing between an operation with no canonical schema and a
+ * TypeError - the host copy carries a comment recording that exact crash. So each copy held a fix
+ * the others lacked, in both directions. That is what makes duplication here expensive rather than
+ * merely untidy, and it is why the rule reports rather than warns.
+ *
+ * Fires on a DECLARATION, never a use, so importing the shared component from
+ * `@ethisyscore/plugin-ui/components/connectors` and rendering it is exactly what the rule wants -
+ * as is a local wrapper that composes it, which the shared helper exempts.
+ *
+ * @type {import("eslint").Rule.RuleModule}
+ */
+import { createNoLocalComponentRule } from "./componentDeclarations.js";
+
+export default createNoLocalComponentRule({
+  // Every branch requires the MAPPING context, and that is the whole design of this pattern.
+  //
+  // A bare `Editor$` is unusable here: measured across the plugin repos, legitimate local editors
+  // ending in `Editor` include `BreachAssessmentTaskTemplateEditor`, `BusinessHoursHolidaysEditor`,
+  // `SlaPolicyEscalationRulesEditor`, `SupplierDdIntervalDaysByTierEditor`,
+  // `SupplementSequenceEditorView` and `InlineMessageEditor` - none of them this component. A bare
+  // `TranslationEditor$` is no better, because the estate runs i18next and a localisation admin
+  // screen would carry exactly that name.
+  //
+  // So branch one needs the literal `Mapping` before `Editor`, which also spares
+  // `LicenceTypeSeverityMapEditor` (`Map`, not `Mapping`); branch two allows the `Mapping` token to
+  // be dropped only when `Connector` or `Tool` is present instead, which is how a rename would most
+  // plausibly still mean this component. `(View|Dialog)` is optional so both the adapter-view
+  // spelling and a dialog-named rewrite match. Hook names are excluded by the shared helper, so
+  // `useTranslationEditor` and `useMappingEditor` do not match, and lowercase `translationEditorView`
+  // - a real local variable in two of these repos - is excluded as a non-component name.
+  pattern: /(Mapping(Translation)?Editor|(Connector|Tool)Translation(Field)?Editor)(View|Dialog)?$/,
+  canonical: {
+    source: "@ethisyscore/plugin-ui/components/connectors",
+    name: "ConnectorMappingTranslationEditorView",
+  },
+  messageId: "noLocalMappingEditor",
+  description:
+    "Disallow a locally-declared connector-mapping translation editor - import ConnectorMappingTranslationEditorView from @ethisyscore/plugin-ui/components/connectors",
+  message:
+    "'{{name}}' re-declares the connector-mapping translation editor. Import { ConnectorMappingTranslationEditorView } from '@ethisyscore/plugin-ui/components/connectors' instead: four copies had already drifted, one of them rendering a dead 'Test mapping' button and three of them dropping the null tolerance on the canonical field lists. If this edits something other than a connector mapping, rename it so it does not read as one.",
+});