@ethisyscore/eslint-plugin-coreconnect 1.76.0 → 1.77.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethisyscore/eslint-plugin-coreconnect",
-  "version": "1.76.0",
+  "version": "1.77.0",
   "description": "ESLint rules enforcing EthisysCore plugin frontend conventions. Published so a new rule reaches every plugin on a version bump, rather than being copied into each scaffold and drifting.",
   "type": "module",
   "main": "src/index.js",

package/src/index.js

@@ -4,6 +4,7 @@ import noInlineStringUnion from "./rules/no-inline-string-union.js";
 import noLocalDataGrid from "./rules/no-local-data-grid.js";
 import noLocalDateInput from "./rules/no-local-date-input.js";
 import noLocalEmptyState from "./rules/no-local-empty-state.js";
+import noLocalMappingEditor from "./rules/no-local-mapping-editor.js";
 import noLocalSearchInput from "./rules/no-local-search-input.js";
 import noParamInNavPath from "./rules/no-param-in-nav-path.js";
 
@@ -14,6 +15,7 @@ const rules = {
   "no-local-data-grid": noLocalDataGrid,
   "no-local-date-input": noLocalDateInput,
   "no-local-empty-state": noLocalEmptyState,
+  "no-local-mapping-editor": noLocalMappingEditor,
   "no-local-search-input": noLocalSearchInput,
   "no-param-in-nav-path": noParamInNavPath,
 };

package/src/rules/no-local-mapping-editor.js

@@ -0,0 +1,58 @@
+/**
+ * Disallow a plugin declaring its own connector-mapping field-translation editor.
+ *
+ * The backstop to the promotion that finished the Tool Mappings surface. Measured on origin/develop:
+ * `ConnectorMappingTranslationEditorView.tsx` existed in FOUR places - the host's gogo-ui adapter
+ * plus `self-healing`, `tech` and `timesheets` - at 592/522/527/527 lines, and the copies had
+ * already drifted in three ways, one of them a live defect:
+ *
+ *   - `self-healing` rendered the "Test mapping" button unconditionally. Its enclosing block opens
+ *     on `(onTestMapping || onSuggestTranslation)`, so a consumer wiring only auto-configure got a
+ *     button whose handler returns on its first line - a DEAD CONTROL. Nobody noticed, because
+ *     there was no single source to notice it against.
+ *   - `self-healing` washed two panels with a literal `rgba(0,0,0,0.03)`, invisible in dark mode.
+ *   - `self-healing` carried emoji in the extraction chips, on top of the icon and colour the chip
+ *     already had.
+ *
+ * Meanwhile the three plugin copies had dropped the HOST's `?? []` coalescing on the canonical field
+ * lists, which is the only thing standing between an operation with no canonical schema and a
+ * TypeError - the host copy carries a comment recording that exact crash. So each copy held a fix
+ * the others lacked, in both directions. That is what makes duplication here expensive rather than
+ * merely untidy, and it is why the rule reports rather than warns.
+ *
+ * Fires on a DECLARATION, never a use, so importing the shared component from
+ * `@ethisyscore/plugin-ui/components/connectors` and rendering it is exactly what the rule wants -
+ * as is a local wrapper that composes it, which the shared helper exempts.
+ *
+ * @type {import("eslint").Rule.RuleModule}
+ */
+import { createNoLocalComponentRule } from "./componentDeclarations.js";
+
+export default createNoLocalComponentRule({
+  // Every branch requires the MAPPING context, and that is the whole design of this pattern.
+  //
+  // A bare `Editor$` is unusable here: measured across the plugin repos, legitimate local editors
+  // ending in `Editor` include `BreachAssessmentTaskTemplateEditor`, `BusinessHoursHolidaysEditor`,
+  // `SlaPolicyEscalationRulesEditor`, `SupplierDdIntervalDaysByTierEditor`,
+  // `SupplementSequenceEditorView` and `InlineMessageEditor` - none of them this component. A bare
+  // `TranslationEditor$` is no better, because the estate runs i18next and a localisation admin
+  // screen would carry exactly that name.
+  //
+  // So branch one needs the literal `Mapping` before `Editor`, which also spares
+  // `LicenceTypeSeverityMapEditor` (`Map`, not `Mapping`); branch two allows the `Mapping` token to
+  // be dropped only when `Connector` or `Tool` is present instead, which is how a rename would most
+  // plausibly still mean this component. `(View|Dialog)` is optional so both the adapter-view
+  // spelling and a dialog-named rewrite match. Hook names are excluded by the shared helper, so
+  // `useTranslationEditor` and `useMappingEditor` do not match, and lowercase `translationEditorView`
+  // - a real local variable in two of these repos - is excluded as a non-component name.
+  pattern: /(Mapping(Translation)?Editor|(Connector|Tool)Translation(Field)?Editor)(View|Dialog)?$/,
+  canonical: {
+    source: "@ethisyscore/plugin-ui/components/connectors",
+    name: "ConnectorMappingTranslationEditorView",
+  },
+  messageId: "noLocalMappingEditor",
+  description:
+    "Disallow a locally-declared connector-mapping translation editor - import ConnectorMappingTranslationEditorView from @ethisyscore/plugin-ui/components/connectors",
+  message:
+    "'{{name}}' re-declares the connector-mapping translation editor. Import { ConnectorMappingTranslationEditorView } from '@ethisyscore/plugin-ui/components/connectors' instead: four copies had already drifted, one of them rendering a dead 'Test mapping' button and three of them dropping the null tolerance on the canonical field lists. If this edits something other than a connector mapping, rename it so it does not read as one.",
+});