@ethisyscore/eslint-plugin-coreconnect 1.71.6 → 1.73.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethisyscore/eslint-plugin-coreconnect",
-  "version": "1.71.6",
+  "version": "1.73.0",
   "description": "ESLint rules enforcing EthisysCore plugin frontend conventions. Published so a new rule reaches every plugin on a version bump, rather than being copied into each scaffold and drifting.",
   "type": "module",
   "main": "src/index.js",

package/src/rules/testFiles.js

@@ -6,16 +6,39 @@
  * next person who needs it, and that argument does not reach a test file: the shape belongs to one
  * mock in one file, nobody imports it, and it is deleted when the test is.
  *
- * Measured before adding this: 80 of the estate's convention findings sit in test and mock files,
- * 74 of them `no-inline-object-type`, and almost all are the prop type of a hand-rolled MUI stub -
+ * Measured before adding this: 80 of the estate's convention findings sit in test files, 74 of them
+ * `no-inline-object-type`, and almost all are the prop type of a hand-rolled MUI stub -
  * `Alert: ({ children, action }: { children?: ReactNode; action?: ReactNode }) => ...`. Naming those
  * 74 would add 74 aliases that exist only to satisfy a rule, in files where the rule's own rationale
  * does not apply. A rule that demands ceremony gets switched off, which costs the 679 findings in
  * shipped code that it is genuinely right about.
  *
- * Deliberately NOT applied to `no-hardcoded-colors` or to any of the `no-local-*` rules. A hardcoded
- * colour is trivially fixable anywhere and there is exactly one in a test file estate-wide; and a
- * test file that re-declares the shared data grid is exactly the drift those rules exist to catch.
+ * ## What counts, and why a basename never can
+ *
+ * Only the three markers below, all of which say "this file exists to test something":
+ * a `__tests__/` or `__mocks__/` directory, or a `.test.` / `.spec.` suffix. They are conventions a
+ * bundler, a test runner and a reader all already agree on.
+ *
+ * A fourth marker was tried and WITHDRAWN: a basename match on `Mock[A-Z]*`, meant to catch "a
+ * hand-rolled stub kept beside the code it doubles rather than under `__tests__`". It was wrong,
+ * and wrong in the direction that costs most - it exempted SHIPPED code.
+ *
+ * Every plugin in this estate has `src/services/implementations/mock/Mock<Domain>Service.ts`, and
+ * those are not scaffolding. `useProjectService.ts` imports `MockProjectService` statically and
+ * picks between it and the real service at runtime on `IS_MOCK_MODE`, so the class is in the
+ * production bundle and its shapes are read by the same hooks that read the real service's. The
+ * rule's rationale reaches them exactly as it reaches any other source file.
+ *
+ * Measured on 2026-08-29 across the eight lint-adopting plugins: the basename branch was the ONLY
+ * thing exempting 17 findings, and every one of them was in a shipped `Mock*Service.ts` under a
+ * `mock/` directory. Nothing legitimate depended on it - the hand-rolled MUI stubs the exemption
+ * was written for all sit under `__tests__/` or carry a `.test.` suffix, and stay exempt.
+ *
+ * Two lessons worth keeping: a heuristic on a NAME cannot tell a test double from a shipped
+ * implementation of the same interface, because both are named after what they double; and an
+ * exemption that silently widens is worse than a finding, because nothing reports it.
+ *
+ * ## Why the check lives here
  *
  * The glob-shaped alternative - a `files` override in `configs.recommended` - would require that
  * config to become an array, and every consumer spreads it as an object
@@ -23,6 +46,10 @@
  * repos at once, so the check lives in the rules, which is also how this package delivers everything
  * else: on a version bump, with no consumer edit.
  *
+ * Deliberately NOT applied to `no-hardcoded-colors` or to any of the `no-local-*` rules. A hardcoded
+ * colour is trivially fixable anywhere and there is exactly one in a test file estate-wide; and a
+ * test file that re-declares the shared data grid is exactly the drift those rules exist to catch.
+ *
  * @param {string} filename Absolute or relative path, as ESLint reports it.
  * @returns {boolean}
  */
@@ -37,9 +64,6 @@ export function isTestFile(filename) {
   return (
     /(^|\/)__tests__\//.test(path) ||
     /(^|\/)__mocks__\//.test(path) ||
-    /\.(test|spec)\.[cm]?[jt]sx?$/.test(path) ||
-    // A hand-rolled stub kept beside the code it doubles rather than under __tests__. Anchored to the
-    // basename so a legitimate directory like `mockups/` cannot match.
-    /(^|\/)Mock[A-Z][^/]*\.[cm]?[jt]sx?$/.test(path)
+    /\.(test|spec)\.[cm]?[jt]sx?$/.test(path)
   );
 }