@ethisyscore/eslint-plugin-coreconnect 1.71.5 → 1.72.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethisyscore/eslint-plugin-coreconnect",
-  "version": "1.71.5",
+  "version": "1.72.0",
   "description": "ESLint rules enforcing EthisysCore plugin frontend conventions. Published so a new rule reaches every plugin on a version bump, rather than being copied into each scaffold and drifting.",
   "type": "module",
   "main": "src/index.js",

package/src/rules/no-hardcoded-colors.js

@@ -9,6 +9,18 @@
  */
 const COLOR_REGEX = /^#(?:[0-9a-fA-F]{3}){1,2}(?:[0-9a-fA-F]{2})?$|^rgba?\(|^hsla?\(/;
 
+/**
+ * A colour function whose channels come from CSS custom properties - `hsl(var(--border))`,
+ * `rgb(var(--cc-accent) / 0.5)`.
+ *
+ * This is not a hardcoded colour, it is the exact thing the rule's own message asks for, and
+ * flagging it was a false positive: `COLOR_REGEX` matches on the `hsl(` prefix alone and never
+ * looked inside. Measured on `finance`, whose `src/styles/tailwind.config.ts` is written entirely in
+ * this form - 48 findings, every one of them already themed, which is enough noise to teach a reader
+ * that the rule is wrong rather than that the file is.
+ */
+const TOKENISED_COLOR_REGEX = /^(?:rgba?|hsla?)\(\s*var\(\s*--/;
+
 export default {
   meta: {
     type: "suggestion",
@@ -28,7 +40,15 @@ export default {
         if (typeof node.value !== "string") {
           return;
         }
-        if (COLOR_REGEX.test(node.value.trim())) {
+        const value = node.value.trim();
+
+        // Order matters: a tokenised colour matches COLOR_REGEX too, so the exemption has to be
+        // checked first.
+        if (TOKENISED_COLOR_REGEX.test(value)) {
+          return;
+        }
+
+        if (COLOR_REGEX.test(value)) {
           context.report({ node, messageId: "noHardcodedColor", data: { value: node.value } });
         }
       },

package/src/rules/no-inline-object-type.js

@@ -13,6 +13,8 @@
  * @type {import("eslint").Rule.RuleModule}
  */
 
+import { isTestFile } from "./testFiles.js";
+
 const FUNCTION_LIKE = new Set([
   "FunctionDeclaration",
   "FunctionExpression",
@@ -96,6 +98,11 @@ export default {
     schema: [],
   },
   create(context) {
+    // Test scaffolding is exempt: see isTestFile for why this rule's rationale does not reach it.
+    if (isTestFile(context.filename ?? context.getFilename?.())) {
+      return {};
+    }
+
     return {
       TSTypeLiteral(node) {
         const position = positionOf(node);

package/src/rules/no-inline-string-union.js

@@ -12,6 +12,8 @@
  * @type {import("eslint").Rule.RuleModule}
  */
 
+import { isTestFile } from "./testFiles.js";
+
 const MINIMUM_MEMBERS = 3;
 
 /** A `"literal"` type node, across the parser versions that spell it differently. */
@@ -37,6 +39,11 @@ export default {
     schema: [],
   },
   create(context) {
+    // Test scaffolding is exempt: see isTestFile for why this rule's rationale does not reach it.
+    if (isTestFile(context.filename ?? context.getFilename?.())) {
+      return {};
+    }
+
     return {
       TSUnionType(node) {
         const members = node.types ?? [];

package/src/rules/testFiles.js

@@ -0,0 +1,69 @@
+/**
+ * Whether a file is test scaffolding rather than shipped code.
+ *
+ * Used by the two STRUCTURAL rules - `no-inline-object-type` and `no-inline-string-union` - and by
+ * nothing else. Both exist to stop an unnamed shape being re-written slightly differently by the
+ * next person who needs it, and that argument does not reach a test file: the shape belongs to one
+ * mock in one file, nobody imports it, and it is deleted when the test is.
+ *
+ * Measured before adding this: 80 of the estate's convention findings sit in test files, 74 of them
+ * `no-inline-object-type`, and almost all are the prop type of a hand-rolled MUI stub -
+ * `Alert: ({ children, action }: { children?: ReactNode; action?: ReactNode }) => ...`. Naming those
+ * 74 would add 74 aliases that exist only to satisfy a rule, in files where the rule's own rationale
+ * does not apply. A rule that demands ceremony gets switched off, which costs the 679 findings in
+ * shipped code that it is genuinely right about.
+ *
+ * ## What counts, and why a basename never can
+ *
+ * Only the three markers below, all of which say "this file exists to test something":
+ * a `__tests__/` or `__mocks__/` directory, or a `.test.` / `.spec.` suffix. They are conventions a
+ * bundler, a test runner and a reader all already agree on.
+ *
+ * A fourth marker was tried and WITHDRAWN: a basename match on `Mock[A-Z]*`, meant to catch "a
+ * hand-rolled stub kept beside the code it doubles rather than under `__tests__`". It was wrong,
+ * and wrong in the direction that costs most - it exempted SHIPPED code.
+ *
+ * Every plugin in this estate has `src/services/implementations/mock/Mock<Domain>Service.ts`, and
+ * those are not scaffolding. `useProjectService.ts` imports `MockProjectService` statically and
+ * picks between it and the real service at runtime on `IS_MOCK_MODE`, so the class is in the
+ * production bundle and its shapes are read by the same hooks that read the real service's. The
+ * rule's rationale reaches them exactly as it reaches any other source file.
+ *
+ * Measured on 2026-08-29 across the eight lint-adopting plugins: the basename branch was the ONLY
+ * thing exempting 17 findings, and every one of them was in a shipped `Mock*Service.ts` under a
+ * `mock/` directory. Nothing legitimate depended on it - the hand-rolled MUI stubs the exemption
+ * was written for all sit under `__tests__/` or carry a `.test.` suffix, and stay exempt.
+ *
+ * Two lessons worth keeping: a heuristic on a NAME cannot tell a test double from a shipped
+ * implementation of the same interface, because both are named after what they double; and an
+ * exemption that silently widens is worse than a finding, because nothing reports it.
+ *
+ * ## Why the check lives here
+ *
+ * The glob-shaped alternative - a `files` override in `configs.recommended` - would require that
+ * config to become an array, and every consumer spreads it as an object
+ * (`{ files: [...], ...coreconnect.configs.recommended }`). Changing that shape would break nine
+ * repos at once, so the check lives in the rules, which is also how this package delivers everything
+ * else: on a version bump, with no consumer edit.
+ *
+ * Deliberately NOT applied to `no-hardcoded-colors` or to any of the `no-local-*` rules. A hardcoded
+ * colour is trivially fixable anywhere and there is exactly one in a test file estate-wide; and a
+ * test file that re-declares the shared data grid is exactly the drift those rules exist to catch.
+ *
+ * @param {string} filename Absolute or relative path, as ESLint reports it.
+ * @returns {boolean}
+ */
+export function isTestFile(filename) {
+  if (!filename) {
+    return false;
+  }
+
+  // Normalise Windows separators: ESLint reports native paths, and the estate is developed on both.
+  const path = filename.replace(/\\/g, "/");
+
+  return (
+    /(^|\/)__tests__\//.test(path) ||
+    /(^|\/)__mocks__\//.test(path) ||
+    /\.(test|spec)\.[cm]?[jt]sx?$/.test(path)
+  );
+}