@ethisyscore/eslint-plugin-coreconnect 1.69.1 → 1.71.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethisyscore/eslint-plugin-coreconnect",
-  "version": "1.69.1",
+  "version": "1.71.0",
   "description": "ESLint rules enforcing EthisysCore plugin frontend conventions. Published so a new rule reaches every plugin on a version bump, rather than being copied into each scaffold and drifting.",
   "type": "module",
   "main": "src/index.js",

package/src/rules/componentDeclarations.js

@@ -24,6 +24,26 @@ export function isHookName(name) {
   return /^use[A-Z]/.test(name);
 }
 
+/**
+ * A component, by name.
+ *
+ * These rules match on a name SUFFIX, so anything ending in the suffix is a candidate - including
+ * plain conversion helpers that are not components at all. Measured on origin/develop: `finance`
+ * and `projects` and `timesheets` all declare `isoToDateInput` and `isoUtcToLocalDateTimeInput` in
+ * `utils/dateUtils.ts` (six), and `finance` a local `toDateInput` (one). Seven reports across three
+ * repos, none of them a component, each telling the author to replace an ISO-string converter with
+ * a React date field.
+ *
+ * React's own convention is what makes this safe to detect by name: a component MUST start with an
+ * uppercase letter or JSX treats it as an HTML tag, so `<toDateInput />` cannot be the thing these
+ * rules exist to catch. That makes the guard free - it cannot mask a real duplicate.
+ *
+ * @param {string} name
+ */
+export function isComponentName(name) {
+  return /^[A-Z]/.test(name);
+}
+
 /**
  * Is this initializer a component definition rather than a string, config object or hook result?
  *
@@ -80,8 +100,7 @@ export function createNoLocalComponentRule({ pattern, messageId, description, me
         if (!idNode || idNode.type !== "Identifier") {
           return;
         }
-
-        if (isHookName(idNode.name) || !pattern.test(idNode.name)) {
+        if (isHookName(idNode.name) || !isComponentName(idNode.name) || !pattern.test(idNode.name)) {
           return;
         }
 

package/src/rules/no-local-date-input.js

@@ -8,7 +8,12 @@
  * copies is six places for either to be dropped, and nothing would have noticed.
  *
  * Fires on a DECLARATION, never a use, so importing `DateInput` from
- * `@ethisyscore/plugin-ui/components/ui` and rendering it is what the rule wants.
+ * `@ethisyscore/plugin-ui/components/date` and rendering it is what the rule wants.
+ *
+ * The sub-path is `/date`, not `/components/ui`: the component needs `@mui/x-date-pickers` and
+ * `dayjs`, which are optional peers, so it has a barrel of its own that a plugin without date
+ * fields never imports. That also means the `@/components/ui/<name>` file-existence alias does not
+ * reach it - a plugin deleting its local `date-input.tsx` changes the import to the package.
  *
  * @type {import("eslint").Rule.RuleModule}
  */
@@ -20,7 +25,7 @@ export default createNoLocalComponentRule({
   pattern: /Date(Time)?(Input|Picker|Field)$/,
   messageId: "noLocalDateInput",
   description:
-    "Disallow a locally-declared date input - import DateInput from @ethisyscore/plugin-ui",
+    "Disallow a locally-declared date input - import DateInput from @ethisyscore/plugin-ui/components/date",
   message:
-    "'{{name}}' looks like a local date input. Date fields must come from one implementation or the popper and bounds fixes drift: import { DateInput } from '@ethisyscore/plugin-ui/components/ui' instead. If this is genuinely something else, rename it so it does not end in Input/Picker/Field.",
+    "'{{name}}' looks like a local date input. Date fields must come from one implementation or the popper and bounds fixes drift: import { DateInput } from '@ethisyscore/plugin-ui/components/date' instead. If this is genuinely something else, rename it so it does not end in Input/Picker/Field.",
 });

package/src/rules/no-local-empty-state.js

@@ -7,7 +7,7 @@
  * can, and this stops a fifth.
  *
  * Fires on a DECLARATION, never a use, so importing `EmptyState` from
- * `@ethisyscore/plugin-ui/shared` and rendering it is what the rule wants.
+ * `@ethisyscore/plugin-ui/components/shared` and rendering it is what the rule wants.
  *
  * @type {import("eslint").Rule.RuleModule}
  */
@@ -19,7 +19,7 @@ export default createNoLocalComponentRule({
   pattern: /(EmptyState|NoResults|NoData|BlankSlate)$/,
   messageId: "noLocalEmptyState",
   description:
-    "Disallow a locally-declared empty state - import EmptyState from @ethisyscore/plugin-ui/shared",
+    "Disallow a locally-declared empty state - import EmptyState from @ethisyscore/plugin-ui/components/shared",
   message:
-    "'{{name}}' looks like a local empty state. Import { EmptyState } from '@ethisyscore/plugin-ui/shared' instead, so every app's empty state matches. It takes icon, title, description and fill; pass description=\"\" for a heading only.",
+    "'{{name}}' looks like a local empty state. Import { EmptyState } from '@ethisyscore/plugin-ui/components/shared' instead, so every app's empty state matches. It takes icon, title, description and fill; pass description=\"\" for a heading only.",
 });