@etherisc/gif-next 3.0.0-a511887-523 → 3.0.0-ab0fcb2-112

package/contracts/pool/PoolServiceManager.sol

@@ -12,14 +12,12 @@ contract PoolServiceManager is ProxyManager {
     /// @dev initializes proxy manager with pool service implementation 
     constructor(
         address authority, 
-        address registry,
         bytes32 salt
     ) 
     {
         PoolService poolSrv = new PoolService{salt: salt}();
-        bytes memory data = abi.encode(authority, registry);
+        bytes memory data = abi.encode(authority);
         IUpgradeable upgradeable = initialize(
-            registry,
             address(poolSrv), 
             data,
             salt);

package/contracts/product/ApplicationService.sol

@@ -41,11 +41,10 @@ contract ApplicationService is
         onlyInitializing()
     {
         (
-            address authority,
-            address registry
-        ) = abi.decode(data, (address, address));
+            address authority
+        ) = abi.decode(data, (address));
 
-        __Service_init(authority, registry, owner);
+        __Service_init(authority, owner);
 
         _distributionService = IDistributionService(_getServiceAddress(DISTRIBUTION()));
         _pricingService = IPricingService(_getServiceAddress(PRICE()));
@@ -54,7 +53,9 @@ contract ApplicationService is
         _registerInterface(type(IApplicationService).interfaceId);
     }
 
-
+    // TODO product - bundle - risk - refferal - distribution
+    // checkBundle() is faster then checking with registry but first need to know poolNftId
+    // check pool, get its nftIdf and instance -> instacne.getBundleSet.checkBundle(bundsleNftId) ???? 
     function _checkLinkedApplicationParameters(
         InstanceReader instanceReader,
         NftId productNftId,
@@ -154,7 +155,7 @@ contract ApplicationService is
     {
         _checkNftType(bundleNftId, BUNDLE());
 
-        (NftId productNftId, IInstance instance) = _getAndVerifyActiveProduct();
+        (NftId productNftId, IInstance instance) = ContractLib.getAndVerifyProduct(getRelease());
 
         // check if provided references are valid and linked to calling product contract
         InstanceReader instanceReader = instance.getInstanceReader();
@@ -289,36 +290,15 @@ contract ApplicationService is
         restricted()
         nonReentrant()
     {
-        _checkNftType(applicationNftId, POLICY());
+        (, IInstance instance) = ContractLib.getAndVerifyProductForPolicy(
+            applicationNftId, getRelease());
 
-        (, IInstance instance) = _getAndVerifyActiveProduct();
         instance.getProductStore().updateApplicationState(applicationNftId, REVOKED());
         emit LogApplicationServiceApplicationRevoked(applicationNftId);
     }
 
     // internal functions
 
-    function _getAndVerifyActiveProduct()
-        internal
-        view
-        returns (
-            NftId productNftId,
-            IInstance instance
-        )
-    {
-        (
-            IRegistry.ObjectInfo memory info, 
-            address instanceAddress
-        ) = ContractLib.getAndVerifyComponent(
-            getRegistry(), 
-            msg.sender,
-            PRODUCT(),
-            true); // only active pools
-
-        productNftId = info.nftId;
-        instance = IInstance(instanceAddress);
-    }
-
 
     function _getDomain() internal pure override returns(ObjectType) {
         return APPLICATION();

package/contracts/product/ApplicationServiceManager.sol

@@ -12,14 +12,12 @@ contract ApplicationServiceManager is ProxyManager {
     /// @dev initializes proxy manager with service implementation 
     constructor(
         address authority, 
-        address registry,
         bytes32 salt
     ) 
     {
         ApplicationService svc = new ApplicationService{salt: salt}();
-        bytes memory data = abi.encode(authority, registry);
+        bytes memory data = abi.encode(authority);
         IUpgradeable upgradeable = initialize(
-            registry,
             address(svc), 
             data,
             salt);

package/contracts/product/BasicProduct.sol

@@ -24,7 +24,6 @@ abstract contract BasicProduct is
     }
 
     function _initializeBasicProduct(
-        address registry,
         NftId instanceNftId,
         string memory name,
         IComponents.ProductInfo memory productInfo,
@@ -37,7 +36,6 @@ abstract contract BasicProduct is
         onlyInitializing()
     {
         __Product_init(
-            registry, 
             instanceNftId, 
             name, 
             productInfo,

package/contracts/product/BasicProductAuthorization.sol

@@ -2,12 +2,12 @@
 pragma solidity ^0.8.20;
 
 import {IAccess} from "../authorization/IAccess.sol";
-import {IComponent} from "../shared/IInstanceLinkedComponent.sol";
+import {IComponent} from "../shared/IComponent.sol";
 import {IProductComponent} from "./IProductComponent.sol";
 
 import {Authorization} from "../authorization/Authorization.sol";
 import {BasicProduct} from "./BasicProduct.sol"; 
-import {COMPONENT, PRODUCT, POLICY} from "../type/ObjectType.sol";
+import {COMPONENT, ORACLE, PRODUCT, POLICY} from "../type/ObjectType.sol";
 import {RoleId, PUBLIC_ROLE} from "../type/RoleId.sol";
 import {GIF_INITIAL_RELEASE} from "../registry/Registry.sol";
 import {TokenHandler} from "../shared/TokenHandler.sol";
@@ -31,7 +31,8 @@ contract BasicProductAuthorization
           virtual override
      {
           _authorizeServiceDomain(COMPONENT(), address(10));
-          _authorizeServiceDomain(POLICY(), address(11));
+          _authorizeServiceDomain(ORACLE(), address(11));
+          _authorizeServiceDomain(POLICY(), address(12));
      }
 
      function _setupTokenHandlerAuthorizations() internal virtual override {

package/contracts/product/ClaimService.sol

@@ -42,14 +42,13 @@ contract ClaimService is
         onlyInitializing()
     {
         (
-            address authority,
-            address registry
-        ) = abi.decode(data, (address, address));
+            address authority
+        ) = abi.decode(data, (address));
 
-        __Service_init(authority, registry, owner);
+        __Service_init(authority, owner);
 
-        _policyService = IPolicyService(getRegistry().getServiceAddress(POLICY(), getVersion().toMajorPart()));
-        _poolService = IPoolService(getRegistry().getServiceAddress(POOL(), getVersion().toMajorPart()));
+        _policyService = IPolicyService(_getRegistry().getServiceAddress(POLICY(), getVersion().toMajorPart()));
+        _poolService = IPoolService(_getRegistry().getServiceAddress(POOL(), getVersion().toMajorPart()));
 
         _registerInterface(type(IClaimService).interfaceId);
     }
@@ -478,7 +477,7 @@ contract ClaimService is
         uint24 payoutNo = claimInfo.payoutsCount + 1;
         payoutId = PayoutIdLib.toPayoutId(claimId, payoutNo);
         if (beneficiary == address(0)) {
-            beneficiary = getRegistry().ownerOf(policyNftId);
+            beneficiary = _getRegistry().ownerOf(policyNftId);
         }
 
         instanceContracts.productStore.createPayout(
@@ -515,7 +514,7 @@ contract ClaimService is
             IPolicy.PolicyInfo memory policyInfo
         )
     {
-        (productNftId, instance) = _getAndVerifyActiveProduct();
+        (productNftId, instance) = ContractLib.getAndVerifyProduct(getRelease());
         instanceContracts.instanceReader = InstanceReader(instance.getInstanceReader());
         instanceContracts.instanceStore = InstanceStore(instance.getInstanceStore());
         instanceContracts.productStore = ProductStore(instance.getProductStore());
@@ -529,29 +528,6 @@ contract ClaimService is
         }
     }
 
-
-    function _getAndVerifyActiveProduct() 
-        internal 
-        view 
-        returns (
-            NftId productNftId,
-            IInstance instance
-        )
-    {
-        (
-            IRegistry.ObjectInfo memory info,
-            address instanceAddress
-        ) = ContractLib.getAndVerifyComponent(
-            getRegistry(),
-            msg.sender, // caller
-            PRODUCT(),
-            true); // isActive 
-
-        // get component nft id and instance
-        productNftId = info.nftId;
-        instance = IInstance(instanceAddress);
-    }
-
     function _verifyClaim(
         InstanceReader instanceReader,
         NftId policyNftId, 
@@ -586,7 +562,7 @@ contract ClaimService is
     {
         NftId poolNftId = instanceReader.getProductInfo(productNftId).poolNftId;
         if (instanceReader.getPoolInfo(poolNftId).isProcessingConfirmedClaims) {
-            address poolAddress = getRegistry().getObjectAddress(poolNftId);
+            address poolAddress = _getRegistry().getObjectAddress(poolNftId);
             IPoolComponent(poolAddress).processConfirmedClaim(policyNftId, claimId, amount);
         }
     }
@@ -611,7 +587,7 @@ contract ClaimService is
         view 
         returns (IPolicyHolder policyHolder)
     {
-        address policyHolderAddress = getRegistry().ownerOf(policyNftId);
+        address policyHolderAddress = _getRegistry().ownerOf(policyNftId);
         policyHolder = IPolicyHolder(policyHolderAddress);
 
         if (!ContractLib.isPolicyHolder(policyHolderAddress)) {

package/contracts/product/ClaimServiceManager.sol

@@ -11,15 +11,13 @@ contract ClaimServiceManager is ProxyManager {
 
     /// @dev initializes proxy manager with service implementation 
     constructor(
-        address authority, 
-        address registry,
+        address authority,
         bytes32 salt
     ) 
     {
         ClaimService svc = new ClaimService{salt: salt}();
-        bytes memory data = abi.encode(authority, registry);
+        bytes memory data = abi.encode(authority);
         IUpgradeable upgradeable = initialize(
-            registry,
             address(svc), 
             data,
             salt);

package/contracts/product/IPolicyService.sol

@@ -20,7 +20,6 @@ interface IPolicyService is IService {
     event LogPolicyServicePolicyClosed(NftId policyNftId);
 
     error LogPolicyServiceMaxPremiumAmountExceeded(NftId policyNftId, Amount maxPremiumAmount, Amount premiumAmount);
-    error ErrorPolicyServicePolicyProductMismatch(NftId applicationNftId, NftId expectedProductNftId, NftId actualProductNftId);
     error ErrorPolicyServicePolicyStateNotApplied(NftId applicationNftId);
     error ErrorPolicyServicePolicyStateNotCollateralized(NftId applicationNftId);
     error ErrorPolicyServicePolicyAlreadyActivated(NftId policyNftId);

package/contracts/product/PolicyService.sol

@@ -48,18 +48,17 @@ contract PolicyService is
         onlyInitializing()
     {
         (
-            address authority,
-            address registry
-        ) = abi.decode(data, (address, address));
+            address authority
+        ) = abi.decode(data, (address));
 
-        __Service_init(authority, registry, owner);
+        __Service_init(authority, owner);
 
         VersionPart majorVersion = getVersion().toMajorPart();
-        _accountingService = IAccountingService(getRegistry().getServiceAddress(ACCOUNTING(), majorVersion));
-        _componentService = IComponentService(getRegistry().getServiceAddress(COMPONENT(), majorVersion));
-        _poolService = IPoolService(getRegistry().getServiceAddress(POOL(), majorVersion));
-        _distributionService = IDistributionService(getRegistry().getServiceAddress(DISTRIBUTION(), majorVersion));
-        _pricingService = IPricingService(getRegistry().getServiceAddress(PRICE(), majorVersion));
+        _accountingService = IAccountingService(_getRegistry().getServiceAddress(ACCOUNTING(), majorVersion));
+        _componentService = IComponentService(_getRegistry().getServiceAddress(COMPONENT(), majorVersion));
+        _poolService = IPoolService(_getRegistry().getServiceAddress(POOL(), majorVersion));
+        _distributionService = IDistributionService(_getRegistry().getServiceAddress(DISTRIBUTION(), majorVersion));
+        _pricingService = IPricingService(_getRegistry().getServiceAddress(PRICE(), majorVersion));
 
         _registerInterface(type(IPolicyService).interfaceId);
     }
@@ -74,7 +73,8 @@ contract PolicyService is
         nonReentrant()
     {
         // checks
-        (IInstance instance,,) = _getAndVerifyCallerForPolicy(applicationNftId);
+        (, IInstance instance) = ContractLib.getAndVerifyProductForPolicy(
+            applicationNftId, getRelease());
 
         // check policy is in state applied
         if (instance.getInstanceReader().getPolicyState(applicationNftId) != APPLIED()) {
@@ -105,10 +105,10 @@ contract PolicyService is
     {
         // checks
         (
-            IInstance instance,
             NftId productNftId,
-            IPolicy.PolicyInfo memory applicationInfo
-        ) = _getAndVerifyCallerForPolicy(applicationNftId);
+            IPolicy.PolicyInfo memory applicationInfo,
+            IInstance instance
+        ) = _getAndVerifyCallerAndInfoForPolicy(applicationNftId);
 
         // check policy is in state applied
         InstanceReader instanceReader = instance.getInstanceReader();
@@ -173,7 +173,7 @@ contract PolicyService is
         }
 
         // link policy to risk and bundle
-        NftId poolNftId = getRegistry().getParentNftId(bundleNftId);
+        NftId poolNftId = _getRegistry().getParentNftId(bundleNftId);
         instance.getRiskSet().linkPolicy(productNftId, riskId, applicationNftId);
         instance.getBundleSet().linkPolicy(poolNftId, bundleNftId, applicationNftId);
 
@@ -198,10 +198,10 @@ contract PolicyService is
     {
         // checks
         (
-            IInstance instance,
             NftId productNftId,
-            IPolicy.PolicyInfo memory policyInfo
-        ) = _getAndVerifyCallerForPolicy(policyNftId);
+            IPolicy.PolicyInfo memory policyInfo,
+            IInstance instance
+        ) = _getAndVerifyCallerAndInfoForPolicy(policyNftId);
 
         // check policy is in state collateralized
         InstanceReader instanceReader = instance.getInstanceReader();
@@ -218,7 +218,7 @@ contract PolicyService is
         IPolicy.PremiumInfo memory premium = instanceReader.getPremiumInfo(policyNftId);
         instanceReader.getTokenHandler(
             productNftId).checkBalanceAndAllowance(
-                getRegistry().ownerOf(policyNftId), 
+                _getRegistry().ownerOf(policyNftId), 
                 premium.premiumAmount, 
                 false);
 
@@ -226,7 +226,7 @@ contract PolicyService is
         // _checkPremiumBalanceAndAllowance(
         //     tokenHandler.TOKEN(), 
         //     address(tokenHandler),
-        //     getRegistry().ownerOf(policyNftId), 
+        //     _getRegistry().ownerOf(policyNftId), 
         //     premium.premiumAmount);
 
         // effects
@@ -263,9 +263,10 @@ contract PolicyService is
     {
         // checks
         (
-            IInstance instance,,
-            IPolicy.PolicyInfo memory policyInfo
-        ) = _getAndVerifyCallerForPolicy(policyNftId);
+            , // NftId productNftId,
+            IPolicy.PolicyInfo memory policyInfo,
+            IInstance instance
+        ) = _getAndVerifyCallerAndInfoForPolicy(policyNftId);
 
         // effects
         policyInfo = PolicyServiceLib.activate(policyNftId, policyInfo, activateAt);
@@ -291,9 +292,10 @@ contract PolicyService is
     {
         // checks
         (
-            IInstance instance,,
-            IPolicy.PolicyInfo memory policyInfo
-        ) = _getAndVerifyCallerForPolicy(policyNftId);
+            , // NftId productNftId,
+            IPolicy.PolicyInfo memory policyInfo,
+            IInstance instance
+        ) = _getAndVerifyCallerAndInfoForPolicy(policyNftId);
 
         if (policyInfo.activatedAt.eqz()) {
             revert ErrorPolicyServicePolicyNotActivated(policyNftId);
@@ -333,9 +335,10 @@ contract PolicyService is
     {
         // checks
         (
-            IInstance instance,,
-            IPolicy.PolicyInfo memory policyInfo
-        ) = _getAndVerifyCallerForPolicy(policyNftId);
+            , // NftId productNftId,
+            IPolicy.PolicyInfo memory policyInfo,
+            IInstance instance
+        ) = _getAndVerifyCallerAndInfoForPolicy(policyNftId);
 
         // more checks, effects + interactions
         return _expire(
@@ -385,10 +388,10 @@ contract PolicyService is
     {
         // checks
         (
-            IInstance instance,
             NftId productNftId,
-            IPolicy.PolicyInfo memory policyInfo
-        ) = _getAndVerifyCallerForPolicy(policyNftId);
+            IPolicy.PolicyInfo memory policyInfo,
+            IInstance instance
+        ) = _getAndVerifyCallerAndInfoForPolicy(policyNftId);
         InstanceReader instanceReader = instance.getInstanceReader();
 
         // check policy is in a closeable state
@@ -418,7 +421,7 @@ contract PolicyService is
         instance.getProductStore().updatePolicy(policyNftId, policyInfo, CLOSED());
 
         // unlink policy from risk and bundle
-        NftId poolNftId = getRegistry().getParentNftId(bundleNftId);
+        NftId poolNftId = _getRegistry().getParentNftId(bundleNftId);
         instance.getRiskSet().unlinkPolicy(productNftId, riskId, policyNftId);
         instance.getBundleSet().unlinkPolicy(poolNftId, bundleNftId, policyNftId);
 
@@ -500,7 +503,7 @@ contract PolicyService is
         internal
         virtual
     {
-        address policyHolder = getRegistry().ownerOf(policyNftId);
+        address policyHolder = _getRegistry().ownerOf(policyNftId);
 
         (
             ,
@@ -574,7 +577,7 @@ contract PolicyService is
         view 
         returns (IPolicyHolder policyHolder)
     {
-        address policyHolderAddress = getRegistry().ownerOf(policyNftId);
+        address policyHolderAddress = _getRegistry().ownerOf(policyNftId);
         policyHolder = IPolicyHolder(policyHolderAddress);
 
         if (!ContractLib.isPolicyHolder(policyHolderAddress)) {
@@ -606,36 +609,20 @@ contract PolicyService is
         }
     }
 
-
-    function  _getAndVerifyCallerForPolicy(NftId policyNftId)
+    function  _getAndVerifyCallerAndInfoForPolicy(NftId policyNftId)
         internal
         virtual
         view
         returns (
-            IInstance instance,
             NftId productNftId,
-            IPolicy.PolicyInfo memory policyInfo
+            IPolicy.PolicyInfo memory policyInfo,
+            IInstance instance
         )
     {
-        (
-            IRegistry.ObjectInfo memory productInfo, 
-            address instanceAddress
-        ) = ContractLib.getAndVerifyComponent(
-            getRegistry(), 
-            msg.sender, // caller contract 
-            PRODUCT(), // caller must be product
-            true); // only active caller
-
-        productNftId = productInfo.nftId; // calling product nft id
-        instance = IInstance(instanceAddress);
-        policyInfo = instance.getInstanceReader().getPolicyInfo(policyNftId);
+        (productNftId, instance) = ContractLib.getAndVerifyProductForPolicy(
+            policyNftId, getRelease());
 
-        if (policyInfo.productNftId != productNftId) {
-            revert ErrorPolicyServicePolicyProductMismatch(
-                policyNftId, 
-                productNftId,
-                policyInfo.productNftId);
-        }
+        policyInfo = instance.getInstanceReader().getPolicyInfo(policyNftId);
     }
 
 

package/contracts/product/PolicyServiceManager.sol

@@ -12,14 +12,12 @@ contract PolicyServiceManager is ProxyManager {
     /// @dev initializes proxy manager with product service implementation 
     constructor(
         address authority, 
-        address registry,
         bytes32 salt
     ) 
     {
         PolicyService svc = new PolicyService{salt: salt}();
-        bytes memory data = abi.encode(authority, registry);
+        bytes memory data = abi.encode(authority);
         IUpgradeable upgradeable = initialize(
-            registry,
             address(svc), 
             data,
             salt);

package/contracts/product/PricingService.sol

@@ -39,11 +39,10 @@ contract PricingService is
         onlyInitializing()
     {
         (
-            address authority,
-            address registry
-        ) = abi.decode(data, (address, address));
+            address authority
+        ) = abi.decode(data, (address));
 
-        __Service_init(authority, registry, owner);
+        __Service_init(authority, owner);
 
         _distributionService = IDistributionService(_getServiceAddress(DISTRIBUTION()));
 
@@ -78,11 +77,11 @@ contract PricingService is
             // verify product
             (
                 IRegistry.ObjectInfo memory registryInfo, 
-                address instanceAddress
-            ) = ContractLib.getInfoAndInstance(getRegistry(), productNftId, false);
+                IInstance instance
+            ) = ContractLib.getInfoAndInstance(productNftId, getRelease(), false);
 
             // get instance reader from local instance variable
-            reader = IInstance(instanceAddress).getInstanceReader();
+            reader = instance.getInstanceReader();
 
             NftId riskProductNftId = reader.getRiskInfo(riskId).productNftId;
             if (productNftId != riskProductNftId) {

package/contracts/product/PricingServiceManager.sol

@@ -12,14 +12,12 @@ contract PricingServiceManager is ProxyManager {
     /// @dev initializes proxy manager with pricing service implementation and deploys instance
     constructor(
         address authority, 
-        address registry,
         bytes32 salt
     )
     {
         PricingService pricingSrv = new PricingService{salt: salt}();
-        bytes memory data = abi.encode(authority, registry);
+        bytes memory data = abi.encode(authority);
         IUpgradeable upgradeable = initialize(
-            registry,
             address(pricingSrv), 
             data,
             salt);

package/contracts/product/Product.sol

@@ -134,7 +134,6 @@ abstract contract Product is
 
 
     function __Product_init(
-        address registry,
         NftId instanceNftId,
         string memory name,
         IComponents.ProductInfo memory productInfo,
@@ -147,7 +146,6 @@ abstract contract Product is
         onlyInitializing()
     {
         __InstanceLinkedComponent_init(
-            registry, 
             instanceNftId, 
             name, 
             PRODUCT(), 

package/contracts/product/RiskService.sol

@@ -30,11 +30,10 @@ contract RiskService is
         onlyInitializing()
     {
         (
-            address authority,
-            address registry
-        ) = abi.decode(data, (address, address));
+            address authority
+        ) = abi.decode(data, (address));
 
-        __Service_init(authority, registry, owner);
+        __Service_init(authority, owner);
         _registerInterface(type(IRiskService).interfaceId);
     }
 
@@ -49,7 +48,7 @@ contract RiskService is
         returns (RiskId riskId)
     {
         // checks
-        (NftId productNftId, IInstance instance) = _getAndVerifyActiveComponent(PRODUCT());
+        (NftId productNftId, IInstance instance) = ContractLib.getAndVerifyProduct(getRelease());
 
         // effects
         riskId = RiskIdLib.toRiskId(productNftId, id);
@@ -80,7 +79,7 @@ contract RiskService is
         restricted()
     {
         // checks
-        (NftId productNftId, IInstance instance) = _getAndVerifyActiveComponent(PRODUCT());
+        (NftId productNftId, IInstance instance) = ContractLib.getAndVerifyProduct(getRelease());
 
         // effects
         InstanceReader instanceReader = instance.getInstanceReader();
@@ -107,7 +106,7 @@ contract RiskService is
         restricted()
     {
         // checks
-        (NftId productNftId, IInstance instance) = _getAndVerifyActiveComponent(PRODUCT());
+        (NftId productNftId, IInstance instance) = ContractLib.getAndVerifyProduct(getRelease());
 
         if (!instance.getRiskSet().hasRisk(productNftId, riskId)) {
             revert ErrorRiskServiceUnknownRisk(productNftId, riskId);
@@ -135,7 +134,7 @@ contract RiskService is
         restricted()
     {
         // checks
-        (NftId productNftId, IInstance instance) = _getAndVerifyActiveComponent(PRODUCT());
+        (NftId productNftId, IInstance instance) = ContractLib.getAndVerifyProduct(getRelease());
         (bool exists, bool active) = instance.getRiskSet().checkRisk(productNftId, riskId);
 
         if (!exists) {
@@ -152,37 +151,6 @@ contract RiskService is
         emit LogRiskServiceRiskClosed(productNftId, riskId);
     }
 
-    function _getAndVerifyActiveComponent(ObjectType expectedType) 
-        internal 
-        view 
-        returns (
-            NftId componentNftId,
-            IInstance instance
-        )
-    {
-        IRegistry.ObjectInfo memory info;
-        address instanceAddress;
-        bool isActive = true;
-
-        if (expectedType != COMPONENT()) {
-            (info, instanceAddress) = ContractLib.getAndVerifyComponent(
-                getRegistry(),
-                msg.sender, // caller
-                expectedType,
-                isActive); 
-        } else {
-            (info, instanceAddress) = ContractLib.getAndVerifyAnyComponent(
-                getRegistry(),
-                msg.sender,
-                isActive); 
-        }
-
-        // get component nft id and instance
-        componentNftId = info.nftId;
-        instance = IInstance(instanceAddress);
-    }
-
-
     function _getDomain() internal pure override returns(ObjectType) {
         return RISK();
     }

package/contracts/product/RiskServiceManager.sol

@@ -12,14 +12,12 @@ contract RiskServiceManager is ProxyManager {
     /// @dev initializes proxy manager with product service implementation 
     constructor(
         address authority, 
-        address registry,
         bytes32 salt
     ) 
     {
         RiskService svc = new RiskService{salt: salt}();
-        bytes memory data = abi.encode(authority, registry);
+        bytes memory data = abi.encode(authority);
         IUpgradeable upgradeable = initialize(
-            registry,
             address(svc), 
             data,
             salt);