@etherisc/gif-next 0.0.2-fd4931b-974 → 0.0.2-fd9539f-062

package/contracts/registry/ReleaseManager.sol

@@ -1,68 +1,82 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.20;
+pragma solidity ^0.8.24;
 
+import {Create2} from "@openzeppelin/contracts/utils/Create2.sol";
 import {Clones} from "@openzeppelin/contracts/proxy/Clones.sol";
 import {IAccessManager} from "@openzeppelin/contracts/access/manager/IAccessManager.sol";
+import {Initializable} from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
 import {AccessManaged} from "@openzeppelin/contracts/access/manager/AccessManaged.sol";
+import {Math} from "@openzeppelin/contracts/utils/math/Math.sol";
 
-import {AccessManagerUpgradeableInitializeable} from "../shared/AccessManagerUpgradeableInitializeable.sol";
+import {NftId} from "../type/NftId.sol";
+import {RoleId, ADMIN_ROLE, PUBLIC_ROLE} from "../type/RoleId.sol";
+import {ObjectType, ObjectTypeLib, POOL, RELEASE, REGISTRY, SERVICE, STAKING} from "../type/ObjectType.sol";
+import {Version, VersionLib, VersionPart, VersionPartLib} from "../type/Version.sol";
+import {Timestamp, TimestampLib, zeroTimestamp, ltTimestamp} from "../type/Timestamp.sol";
+import {Seconds, SecondsLib} from "../type/Seconds.sol";
+import {StateId, INITIAL, SCHEDULED, DEPLOYING, ACTIVE} from "../type/StateId.sol";
+import {Version, VersionLib, VersionPart, VersionPartLib} from "../type/Version.sol";
+
+import {IService} from "../shared/IService.sol";
+import {AccessManagerExtendedWithDisableInitializeable} from "../shared/AccessManagerExtendedWithDisableInitializeable.sol";
 import {ILifecycle} from "../shared/ILifecycle.sol";
+import {INftOwnable} from "../shared/INftOwnable.sol";
 import {IRegisterable} from "../shared/IRegisterable.sol";
+
 import {IRegistry} from "./IRegistry.sol";
+import {IRegistryLinked} from "../shared/IRegistryLinked.sol";
 import {IRegistryService} from "./IRegistryService.sol";
-import {IService} from "../shared/IService.sol";
-import {IStaking} from "../staking/IStaking.sol";
-import {NftId} from "../type/NftId.sol";
-import {ObjectType, ObjectTypeLib, zeroObjectType, RELEASE, REGISTRY, SERVICE, STAKING} from "../type/ObjectType.sol";
+import {IServiceAuthorization} from "./IServiceAuthorization.sol";
+import {IAccessAdmin} from "../shared/IAccessAdmin.sol";
+import {RegistryAdmin} from "./RegistryAdmin.sol";
 import {Registry} from "./Registry.sol";
-import {RegistryAccessManager} from "./RegistryAccessManager.sol";
-import {RoleId, ADMIN_ROLE} from "../type/RoleId.sol";
-import {ServiceAuthorizationsLib} from "./ServiceAuthorizationsLib.sol";
-import {StateId, INITIAL, SCHEDULED, DEPLOYING, ACTIVE} from "../type/StateId.sol";
-import {Timestamp, TimestampLib} from "../type/Timestamp.sol";
 import {TokenRegistry} from "./TokenRegistry.sol";
-import {Version, VersionLib, VersionPart, VersionPartLib} from "../type/Version.sol";
 
-    // gif admin is not technical, should sent simple txs
-    // foundation creates
-    // other guy deployes
-    // other guy checks (can precompute addresses and compare with what deployed)
-    // foundation activates
-// TODO add function to deactivate releases
-// TODO in next pr add getVersion() to releaseAccessManager only, set in initialize()
-// TODO in next pr make single base for registry access manager, release access manager and instance access manager
-
-contract ReleaseManager is
-    AccessManaged,
-    ILifecycle
+
+contract ReleaseManager is 
+    AccessManaged, 
+    ILifecycle, 
+    IRegistryLinked
 {
     using ObjectTypeLib for ObjectType;
 
-    event LogReleaseCreation(VersionPart version, bytes32 salt, AccessManagerUpgradeableInitializeable accessManager); 
+    uint256 public constant INITIAL_GIF_VERSION = 3;
+
+    event LogReleaseCreation(VersionPart version, bytes32 salt, address authority); 
     event LogReleaseActivation(VersionPart version);
 
+    // constructor
+    error ErrorReleaseManagerNotRegistry(Registry registry);
+
     // createNextRelease
     error ErrorReleaseManagerReleaseCreationDisallowed(StateId currentStateId);
 
     // prepareRelease
     error ErrorReleaseManagerReleasePreparationDisallowed(StateId currentStateId);
-    error ErrorReleaseManagerReleaseEmpty();
-    error ErrorReleaseManagerReleaseAlreadyCreated(VersionPart version);
-    
+    error ErrorReleaseManagerReleaseAlreadyPrepared(VersionPart version);
+    error ErrorReleaseManagerVersionMismatch(VersionPart expectedVersion, VersionPart providedVersion);
+    error ErrorReleaseManagerNoDomains(VersionPart version);
+
     // register staking
-    error ErrorReleaseManagerStakingAlreadySet(address stakingAddress);
+    //error ErrorReleaseManagerStakingAlreadySet(address stakingAddress);
 
     // registerService
+    error ErrorReleaseManagerNoServiceRegistrationExpected();
     error ErrorReleaseManagerServiceRegistrationDisallowed(StateId currentStateId);
+    error ErrorReleaseManagerServiceDomainMismatch(ObjectType expectedDomain, ObjectType actualDomain);
     error ErrorReleaseManagerNotService(IService service);
     error ErrorReleaseManagerServiceAddressInvalid(IService given, address expected);
 
     // activateNextRelease
-    error ErrorReleaseManagerActivationDisallowed(StateId currentStateId);
+    error ErrorReleaseManagerReleaseActivationDisallowed(StateId currentStateId);
     error ErrorReleaseManagerReleaseNotCreated(VersionPart releaseVersion);
     error ErrorReleaseManagerReleaseRegistrationNotFinished(VersionPart releaseVersion, uint awaitingRegistration);
     error ErrorReleaseManagerReleaseAlreadyActivated(VersionPart releaseVersion);
 
+    // disableRelease
+    error ErrorReleaseManagerReleaseNotActivated(VersionPart releaseVersion);
+    error ErrorReleaseManagerReleaseAlreadyDisabled(VersionPart releaseVersion);
+
     // _verifyService
     error ErrorReleaseManagerServiceReleaseAuthorityMismatch(IService service, address serviceAuthority, address releaseAuthority);
     error ErrorReleaseManagerServiceReleaseVersionMismatch(IService service, VersionPart serviceVersion, VersionPart releaseVersion);
@@ -75,137 +89,127 @@ contract ReleaseManager is
     error ErrorReleaseManagerServiceSelfRegistration(IService service);
     error ErrorReleaseManagerServiceOwnerRegistered(IService service, address owner);
 
-    // _verifyServiceAuthorizations
-    error ErrorReleaseManagerServiceRoleInvalid(address service, RoleId role);
+    Seconds public constant MIN_DISABLE_DELAY = Seconds.wrap(60 * 24 * 365); // 1 year
 
-    RegistryAccessManager public immutable _accessManager;
+    RegistryAdmin public immutable _admin;
+    address public immutable _releaseAccessManagerCodeAddress;
     Registry public immutable _registry;
-    TokenRegistry private immutable _tokenRegistry;
-    IStaking private _staking;
+    IRegisterable private _staking;
+    address private _stakingOwner;
 
-    mapping(VersionPart version => AccessManagerUpgradeableInitializeable accessManager) internal _releaseAccessManager;
+    // TODO remove once it's clear that release authority will always be registry authority
+    mapping(VersionPart version => address authority) internal _releaseAccessManager;
     mapping(VersionPart version => IRegistry.ReleaseInfo info) internal _releaseInfo;
-    mapping(address registryService => bool isActive) internal _active;// have access to registry
+    mapping(address registryService => VersionPart version) _releaseVersionByAddress;
+
+    mapping(VersionPart version => IServiceAuthorization authz) internal _serviceAuthorization;
 
     VersionPart immutable internal _initial;// first active version    
     VersionPart internal _latest; // latest active version
     VersionPart internal _next; // version to create and activate 
     StateId internal _state; // current state of release manager
 
-    uint256 internal _awaitingRegistration; // "services left to register" counter
-
+    uint256 internal _registeredServices;
+    uint256 internal _servicesToRegister;
 
-    constructor(
-        RegistryAccessManager accessManager, 
-        VersionPart initialVersion,
-        address dipTokenAddress
-    )
-        AccessManaged(accessManager.authority())
+    // deployer of this contract must be gif admin
+    constructor(Registry registry)
+        AccessManaged(msg.sender)
     {
-        _accessManager = accessManager;
-        _initial = initialVersion;
-        _next = VersionPartLib.toVersionPart(initialVersion.toInt() - 1);
-        _state = getInitialState(RELEASE());
+        // TODO move this part to RegistryLinked constructor
+        if(!_isRegistry(address(registry))) {
+            revert ErrorReleaseManagerNotRegistry(registry);
+        }
 
-        _registry = new Registry();
-        _tokenRegistry = new TokenRegistry(
-            address(_registry),
-            dipTokenAddress);
+        _registry = registry;
+        setAuthority(_registry.getAuthority());
+        _admin = RegistryAdmin(_registry.getRegistryAdminAddress());
 
-        _registry.setTokenRegistry(address(_tokenRegistry));
+        _initial = VersionPartLib.toVersionPart(INITIAL_GIF_VERSION);
+        _next = VersionPartLib.toVersionPart(INITIAL_GIF_VERSION - 1);
+        _state = getInitialState(RELEASE());
+        
+        AccessManagerExtendedWithDisableInitializeable masterReleaseAccessManager = new AccessManagerExtendedWithDisableInitializeable();
+        masterReleaseAccessManager.initialize(_registry.NFT_LOCK_ADDRESS(), VersionLib.toVersionPart(0));
+        //masterReleaseAccessManager.disable();
+        _releaseAccessManagerCodeAddress = address(masterReleaseAccessManager);
     }
 
-
     /// @dev skips previous release if was not activated
     /// sets release manager into state SCHEDULED
     function createNextRelease()
         external
-        restricted // GIF_ADMIN_ROLE
-        returns(VersionPart version)
+        restricted() // GIF_ADMIN_ROLE
+        returns(VersionPart)
     {
         if (!isValidTransition(RELEASE(), _state, SCHEDULED())) {
             revert ErrorReleaseManagerReleaseCreationDisallowed(_state);
         }
 
         _next = VersionPartLib.toVersionPart(_next.toInt() + 1);
-        _awaitingRegistration = 0;
+        _servicesToRegister = 0;
+        _registeredServices = 0;
         _state = SCHEDULED();
-    }
 
+        return _next;
+    }
 
     function prepareNextRelease(
-        address[] memory addresses, 
-        RoleId[][] memory serviceRoles, 
-        RoleId[][] memory functionRoles, 
-        bytes4[][][] memory selectors, 
+        IServiceAuthorization serviceAuthorization,
         bytes32 salt
     )
         external
         restricted() // GIF_MANAGER_ROLE
         returns(
-            address releaseAccessManagerAddress, 
+            address authority, 
             VersionPart version, 
             bytes32 releaseSalt
         )
     {
-        if (!isValidTransition(RELEASE(), _state, DEPLOYING())) {
-            revert ErrorReleaseManagerReleasePreparationDisallowed(_state);
-        }
+        // TODO Any call to serviceAuthorization contract must be treated as a call to an external malicious contract
+        // How can wrong authorizations tamper the core, releases or instances?
+        (
+            VersionPart releaseVersion,
+            uint serviceDomainsCount
+        ) = serviceAuthorization.getRelease();
 
-        if(addresses.length == 0) {
-            revert ErrorReleaseManagerReleaseEmpty();
+        // verify authorizaion contract release matches with expected version
+        if (releaseVersion != _next) {
+            revert ErrorReleaseManagerVersionMismatch(_next, releaseVersion);
         }
 
-        if(_awaitingRegistration > 0) {
-            revert ErrorReleaseManagerReleaseAlreadyCreated(version);
+        // sanity check to ensure service domain list is not empty
+        if (serviceDomainsCount == 0) {
+            revert ErrorReleaseManagerNoDomains(_next);
         }
 
-        _verifyReleaseAuthorizations(addresses, serviceRoles, functionRoles, selectors);
+        // verify release manager is in proper state to start deploying a next release
+        if (!isValidTransition(RELEASE(), _state, DEPLOYING())) {
+            revert ErrorReleaseManagerReleasePreparationDisallowed(_state);
+        }
 
-        version = getNextVersion();
+        // verify prepareNextRelease is only called once per release
+        if(_servicesToRegister > 0) {
+            revert ErrorReleaseManagerReleaseAlreadyPrepared(version);
+        }
 
-        _releaseInfo[version].version = version;
-        _releaseInfo[version].addresses = addresses;
-        _releaseInfo[version].serviceRoles = serviceRoles;
-        _releaseInfo[version].functionRoles = functionRoles;
-        _releaseInfo[version].selectors = selectors;
-        _awaitingRegistration = addresses.length;
-        _state = DEPLOYING();
+        // store release specific service authorization
+        _serviceAuthorization[_next] = serviceAuthorization;
 
-        version = getNextVersion();
         // ensures unique salt
         releaseSalt = keccak256(
             bytes.concat(
                 bytes32(version.toInt()),
                 salt));
 
-        releaseAccessManagerAddress = Clones.cloneDeterministic(_accessManager.authority(), releaseSalt);
-        AccessManagerUpgradeableInitializeable releaseAccessManager = AccessManagerUpgradeableInitializeable(releaseAccessManagerAddress);
-        
-        _releaseAccessManager[version] = releaseAccessManager;
-        
-        releaseAccessManager.initialize(address(this));
-
-        emit LogReleaseCreation(version, releaseSalt, releaseAccessManager);
-    }
+        authority = _admin.authority();
 
+        _releaseAccessManager[_next] = authority;
+        _servicesToRegister = serviceDomainsCount;
 
-    function registerStaking(
-        address stakingAddress,
-        address stakingOwner
-    )
-        external
-        restricted // GIF_ADMIN_ROLE
-        returns(NftId nftId)
-    {
-        // TODO add verify staking contract
-        _staking = IStaking(stakingAddress);
-
-        nftId = _registry.registerStaking(
-            stakingAddress,
-            stakingOwner);
+        _state = DEPLOYING();
 
-        _staking.linkToRegisteredNftId();
+        emit LogReleaseCreation(version, releaseSalt, authority);
     }
 
 
@@ -214,52 +218,52 @@ contract ReleaseManager is
         restricted // GIF_MANAGER_ROLE
         returns(NftId nftId)
     {
+        // TODO is it usefull to check transition from A to A?
         if (!isValidTransition(RELEASE(), _state, DEPLOYING())) {
             revert ErrorReleaseManagerServiceRegistrationDisallowed(_state);
         }
 
+        if (_servicesToRegister == _registeredServices) {
+            revert ErrorReleaseManagerNoServiceRegistrationExpected();
+        }
+
         (
             IRegistry.ObjectInfo memory info,
             ObjectType domain,
             VersionPart version
         ) = _verifyService(service);
 
-        require(_awaitingRegistration > 0, "_awaitingRegistration == 0");
-
-        uint serviceIdx = _awaitingRegistration - 1;
-        address serviceAddress = _releaseInfo[version].addresses[serviceIdx];
-        // TODO temp, while typescript addresses computation is not implemented 
-        /*if(address(service) != serviceAddress) {
-            revert ErrorReleaseManagerServiceAddressInvalid(service, serviceAddress);
-        }*/
-
-        _setServiceAuthorizations(
-            _releaseAccessManager[version],
-            // TODO temp, while typescript addresses computation is not implemented
-            address(service),//serviceAddress, 
-            _releaseInfo[version].serviceRoles[serviceIdx],
-            _releaseInfo[version].functionRoles[serviceIdx],
-            _releaseInfo[version].selectors[serviceIdx]);
-
-        // TODO decide for one of the approaches
-        // // service to service authorization
-        // ServiceAuthorizationsLib.ServiceAuthorization memory authz = ServiceAuthorizationsLib.getAuthorizations(domain);
-        // for(uint8 idx = 0; idx < authz.authorizedRole.length; idx++) {
-        //     _accessManager.setTargetFunctionRole(
-        //         address(service), 
-        //         authz.authorizedSelectors[idx], 
-        //         authz.authorizedRole[idx]);
-        // }
-
-        _awaitingRegistration = serviceIdx;
-        _state = DEPLOYING();
+        ObjectType expectedDomain = _serviceAuthorization[version].getServiceDomains()[_registeredServices];
+        if (service.getDomain() != expectedDomain) {
+            revert ErrorReleaseManagerServiceDomainMismatch(expectedDomain, service.getDomain());
+        }
 
         // checked in registry
         _releaseInfo[version].domains.push(domain);
 
+        // register service with registry
         nftId = _registry.registerService(info, version, domain);
+        _registeredServices++;
 
         service.linkToRegisteredNftId();
+
+        // setup service authorization
+        _admin.authorizeService(
+            _serviceAuthorization[version], 
+            service);
+
+        // TODO consider to extend this to REGISTRY
+        // special roles for registry/staking/pool service
+        if (domain == STAKING() || domain == POOL()) {
+            // TODO rename to grantServiceDomainRole()
+            _admin.grantServiceRoleForAllVersions(service, domain);
+        }
+
+        if (_registeredServices < _servicesToRegister) {
+            _state = DEPLOYING();
+        } else {
+            // TODO end state depends on (_awaitingRegistration == 0)
+        }
     }
 
 
@@ -268,23 +272,21 @@ contract ReleaseManager is
         restricted // GIF_ADMIN_ROLE
     {
         if (!isValidTransition(RELEASE(), _state, ACTIVE())) {
-            revert ErrorReleaseManagerActivationDisallowed(_state);
+            revert ErrorReleaseManagerReleaseActivationDisallowed(_state);
         }
 
+        // release fully deployed
         VersionPart version = _next;
-        address service = _registry.getServiceAddress(REGISTRY(), version);
+        if(_registeredServices < _servicesToRegister) {
+            revert ErrorReleaseManagerReleaseRegistrationNotFinished(version, _servicesToRegister - _registeredServices);
+        }
 
-        // release exists, registry service is a MUST
-        //if(_releaseAccessManager[version] == address(0)) {
+        // release exists, registry service MUST exist
+        address service = _registry.getServiceAddress(REGISTRY(), version);
         if(service == address(0)) {
             revert ErrorReleaseManagerReleaseNotCreated(version);
         }
 
-        // release fully deployed
-        if(_awaitingRegistration > 0) {
-            revert ErrorReleaseManagerReleaseRegistrationNotFinished(version, _awaitingRegistration);
-        }
-
         // release is not activated
         if(_releaseInfo[version].activatedAt.gtz()) {
             revert ErrorReleaseManagerReleaseAlreadyActivated(version);
@@ -293,12 +295,51 @@ contract ReleaseManager is
         _latest = version;
         _state = ACTIVE();
 
-        _active[service] = true;
+        _releaseVersionByAddress[service] = version;
         _releaseInfo[version].activatedAt = TimestampLib.blockTimestamp();
 
         emit LogReleaseActivation(version);
     }
 
+    // release becomes disabled after delay expiration (can be reenabled before that)
+    function disableRelease(VersionPart version, Seconds disableDelay)
+        external
+        restricted // GIF_ADMIN_ROLE
+    {
+        // release was activated
+        if(_releaseInfo[version].activatedAt.eqz()) {
+            revert ErrorReleaseManagerReleaseNotActivated(version);
+        }
+
+        // release not disabled already
+        if(_releaseInfo[version].disabledAt.gtz()) {
+            revert ErrorReleaseManagerReleaseAlreadyDisabled(version);
+        }
+
+        disableDelay = SecondsLib.toSeconds(Math.max(disableDelay.toInt(), MIN_DISABLE_DELAY.toInt()));
+
+        // TODO come up with a substitute
+        // _releaseAccessManager[version].disable(disableDelay);
+
+        _releaseInfo[version].disabledAt = TimestampLib.blockTimestamp().addSeconds(disableDelay);
+    }
+    
+    function enableRelease(VersionPart version)
+        external
+        restricted // GIF_ADMIN_ROLE
+    {
+        // release was disabled
+        //if(_releaseInfo[version].disabledAt.eqz()) {
+        //    revert ErrorReleaseManagerReleaseAlreadyEnabled(version);
+        //}
+
+        // reverts if disable delay expired
+        // TODO come up with a substitute
+        // _releaseAccessManager[version].enable();
+        
+        _releaseInfo[version].disabledAt = zeroTimestamp();
+    }
+
     //--- view functions ----------------------------------------------------//
 
     function predictDeterministicAddress(
@@ -310,17 +351,14 @@ contract ReleaseManager is
     }
 
     function isActiveRegistryService(address service) external view returns(bool) {
-        return _active[service];
+        VersionPart version = _releaseVersionByAddress[service];
+        return isActiveRelease(version);
     }
 
-    function isValidRelease(VersionPart version) external view returns(bool) {
+    function isActiveRelease(VersionPart version) public view returns(bool) {
         return _releaseInfo[version].activatedAt.gtz();
     }
 
-    function getRegistryAddress() external view returns(address) {
-        return (address(_registry));
-    }
-
     function getReleaseInfo(VersionPart version) external view returns(IRegistry.ReleaseInfo memory) {
         return _releaseInfo[version];
     }
@@ -342,18 +380,30 @@ contract ReleaseManager is
     }
 
     function getRemainingServicesToRegister() external view returns (uint256 services) {
-        return _awaitingRegistration;
+        return _servicesToRegister - _registeredServices;
+    }
+
+    // TODO cleanup
+    function getReleaseAccessManager(VersionPart version) external view returns(AccessManagerExtendedWithDisableInitializeable) {
+        // return _releaseAccessManager[version];
     }
 
-    function getReleaseAccessManager(VersionPart version) external view returns(AccessManagerUpgradeableInitializeable) {
-        return _releaseAccessManager[version];
+    // TODO token registry knows nothing about adfmin, only registry
+    function getRegistryAdmin() external view returns (address) {
+        return address(_admin);
+    }
+
+    //--- IRegistryLinked ------------------------------------------------------//
+
+    function getRegistry() external view returns (IRegistry) {
+        return _registry;
     }
 
     //--- ILifecycle -----------------------------------------------------------//
 
-    function hasLifecycle(ObjectType objectType) external view returns (bool) { return objectType == RELEASE(); }
+    function hasLifecycle(ObjectType objectType) external pure returns (bool) { return objectType == RELEASE(); }
 
-    function getInitialState(ObjectType objectType) public view returns (StateId stateId) { 
+    function getInitialState(ObjectType objectType) public pure returns (StateId stateId) { 
         if (objectType == RELEASE()) {
             stateId = INITIAL();
         }
@@ -365,7 +415,7 @@ contract ReleaseManager is
         StateId toId
     )
         public 
-        view 
+        pure 
         returns (bool isValid)
     {
         if (objectType != RELEASE()) { return false; }
@@ -375,6 +425,7 @@ contract ReleaseManager is
         if (fromId == DEPLOYING() && toId == SCHEDULED()) { return true; }
         if (fromId == DEPLOYING() && toId == DEPLOYING()) { return true; }
         if (fromId == DEPLOYING() && toId == ACTIVE()) { return true; }
+        // TODO active -> scheduled missing, add tests to cover this and more scenarios (#358)
 
         return false;
     }
@@ -383,6 +434,7 @@ contract ReleaseManager is
 
     function _verifyService(IService service)
         internal
+        view
         returns(
             IRegistry.ObjectInfo memory serviceInfo,
             ObjectType serviceDomain, 
@@ -456,75 +508,20 @@ contract ReleaseManager is
         }
     }
 
+    /// @dev returns true iff a the address passes some simple proxy tests.
+    function _isRegistry(address registryAddress) internal view returns (bool) {
 
-    function _verifyReleaseAuthorizations(
-        address[] memory serviceAddress,
-        RoleId[][] memory serviceRoles,
-        RoleId[][] memory functionRoles,
-        bytes4[][][] memory selectors
-    )
-        internal
-        view
-    {
-        for(uint serviceIdx = 0; serviceIdx < serviceAddress.length; serviceIdx++)
-        {
-            for(uint roleIdx = 0; roleIdx < serviceRoles[serviceIdx].length; roleIdx++)
-            {
-                RoleId role = serviceRoles[serviceIdx][roleIdx];
-                if(role == ADMIN_ROLE()) {
-                    revert ErrorReleaseManagerServiceRoleInvalid(serviceAddress[serviceIdx], role);
-                }
-            }
+        // zero address is certainly not registry
+        if (registryAddress == address(0)) {
+            return false;
         }
-
-        // TODO no duplicate service "domain" role per release
-        // TODO no duplicate service roles per service
-        // TODO no duplicate service function roles per service
-        // TODO no duplicate service function selectors per service
-    }
-
-    function _setServiceAuthorizations(
-        IAccessManager accessManager,
-        address serviceAddress,
-        RoleId[] memory serviceRoles,
-        RoleId[] memory functionRoles,
-        bytes4[][] memory selectors
-    )
-        internal
-    {
-        for(uint idx = 0; idx < functionRoles.length; idx++)
-        {
-            accessManager.setTargetFunctionRole(
-                serviceAddress, 
-                selectors[idx],
-                functionRoles[idx].toInt());
-
-            // TODO check/figure out which approach to take
-            // ObjectType domain = config[idx].serviceDomain;
-            // // not "registry service" / zero domain
-            // if(
-            //     domain == REGISTRY() ||
-            //     domain.eqz()
-            // ) { revert ConfigServiceDomainInvalid(idx, domain); } 
-
-            // bytes4[] memory selectors = config[idx].authorizedSelectors;
-
-            // // TODO can be zero -> e.g. duplicate domain, first with zero selector, second with non zero selector -> need to check _release[version].domains.contains(domain) instead
-            // // no overwrite
-            // if(_selectors[version][domain].length > 0) {
-            //     revert SelectorAlreadyExists(version, domain); 
-            // }
-            
-            // _selectors[version][domain] = selectors;
-            // _release[version].domains.push(domain);
+        // TODO try catch and return false in case of revert
+        // a just panic
+        // check if contract returns a zero nft id for its own address
+        if (IRegistry(registryAddress).getNftId(registryAddress).eqz()) {
+            return false;
         }
 
-        for(uint idx = 0; idx < serviceRoles.length; idx++)
-        {
-            accessManager.grantRole(
-                serviceRoles[idx].toInt(),
-                serviceAddress, 
-                0);
-        }
+        return true;
     }
 }