@etherisc/gif-next 0.0.2-f2b0fa2-473 → 0.0.2-f63e99e-607

package/contracts/components/BaseComponent.sol

@@ -11,13 +11,15 @@ import {IInstance} from "../instance/IInstance.sol";
 import {IInstance} from "../instance/IInstance.sol";
 import {IComponentOwnerService} from "../instance/service/IComponentOwnerService.sol";
 import {IBaseComponent} from "./IBaseComponent.sol";
-import {NftId} from "../types/NftId.sol";
+import {NftId, zeroNftId, NftIdLib} from "../types/NftId.sol";
 import {ObjectType} from "../types/ObjectType.sol";
 
 abstract contract BaseComponent is
     Registerable,
     IBaseComponent
 {
+    using NftIdLib for NftId;
+
     IComponentOwnerService internal _componentOwnerService;
 
     address internal _deployer;
@@ -29,7 +31,6 @@ abstract contract BaseComponent is
     constructor(
         address registry,
         NftId instanceNftId,
-        NftId productNftId,
         address token,
         ObjectType componentType,
         bool isInterceptor,
@@ -49,7 +50,6 @@ abstract contract BaseComponent is
         _componentOwnerService = _instance.getComponentOwnerService();
         _wallet = address(this);
         _token = IERC20Metadata(token);
-        _productNftId = productNftId;
 
         _registerInterface(type(IBaseComponent).interfaceId);
     }
@@ -80,6 +80,11 @@ abstract contract BaseComponent is
         return _instance;
     }
 
+    function setProductNftId(NftId productNftId) public override onlyOwner {
+        require(_productNftId.eq(zeroNftId()), "product nft id already set");
+        _productNftId = productNftId;
+    }
+
     function getProductNftId() public view override returns (NftId productNftId) {
         return _productNftId;
     }

package/contracts/components/Distribution.sol

@@ -38,20 +38,19 @@ contract Distribution is
     constructor(
         address registry,
         NftId instanceNftId,
-        NftId productNftId,
         // TODO refactor into tokenNftId
         address token,
         bool verifying,
         Fee memory distributionFee,
         address initialOwner
     )
-        BaseComponent(registry, instanceNftId, productNftId, token, DISTRIBUTION(), true, initialOwner)
+        BaseComponent(registry, instanceNftId, token, DISTRIBUTION(), true, initialOwner)
     {
         _isVerifying = verifying;
         _initialDistributionFee = distributionFee;
 
+        _distributionService = _instance.getDistributionService();
         // TODO: reactivate when services are available again
-        // _distributionService = _instance.getDistributionService();
         // _productService = _instance.getProductService();
 
         _registerInterface(type(IDistributionComponent).interfaceId);
@@ -123,19 +122,10 @@ contract Distribution is
     }
 
     function getSetupInfo() public view returns (ISetup.DistributionSetupInfo memory setupInfo) {
-        if (getNftId().eq(zeroNftId())) {
-            return ISetup.DistributionSetupInfo(
-                _productNftId,
-                TokenHandler(address(0)),
-                _initialDistributionFee,
-                _isVerifying,
-                address(0)
-            );
-        } 
-
         InstanceReader reader = _instance.getInstanceReader();
         return reader.getDistributionSetupInfo(getNftId());
     }
+    
 
     /// @dev returns true iff the component needs to be called when selling/renewing policis
     function isVerifying() external view returns (bool verifying) {
@@ -152,14 +142,18 @@ contract Distribution is
     {
         (
             IRegistry.ObjectInfo memory info, 
-            bytes memory data
         ) = super.getInitialInfo();
 
         return (
             info,
             abi.encode(
-                _initialDistributionFee,
-                _isVerifying
+                ISetup.DistributionSetupInfo(
+                    _productNftId,
+                    TokenHandler(address(_token)),
+                    _initialDistributionFee,
+                    _isVerifying,
+                    address(this)
+                )
             )
         );
     }

package/contracts/components/IBaseComponent.sol

@@ -19,6 +19,7 @@ interface IBaseComponent is IRegisterable {
 
     function getInstance() external view returns (IInstance instance);
 
+    function setProductNftId(NftId productNftId) external;
     function getProductNftId() external view returns (NftId productNftId);
 
 }

package/contracts/components/IDistributionComponent.sol

@@ -4,6 +4,7 @@ pragma solidity ^0.8.19;
 import {Fee} from "../types/Fee.sol";
 import {ReferralId} from "../types/Referral.sol";
 import {NftId} from "../types/NftId.sol";
+import {ISetup} from "../instance/module/ISetup.sol";
 
 interface IDistributionComponent {
 

package/contracts/components/Pool.sol

@@ -55,7 +55,6 @@ contract Pool is BaseComponent, IPoolComponent {
     constructor(
         address registry,
         NftId instanceNftId,
-        NftId productNftId,
         // TODO refactor into tokenNftId
         address token,
         bool isInterceptor,
@@ -66,7 +65,7 @@ contract Pool is BaseComponent, IPoolComponent {
         Fee memory performanceFee,
         address initialOwner
     )
-        BaseComponent(registry, instanceNftId, productNftId, token, POOL(), isInterceptor, initialOwner)
+        BaseComponent(registry, instanceNftId, token, POOL(), isInterceptor, initialOwner)
     {
         _isVerifying = verifying;
         // TODO add validation
@@ -75,8 +74,8 @@ contract Pool is BaseComponent, IPoolComponent {
         _initialStakingFee = stakingFee;
         _initialPerformanceFee = performanceFee;
 
+        _poolService = _instance.getPoolService();
         // TODO: reactivate when services are available again
-        // _poolService = _instance.getPoolService();
         // _productService = _instance.getProductService();
 
         _registerInterface(type(IPoolComponent).interfaceId);
@@ -170,20 +169,6 @@ contract Pool is BaseComponent, IPoolComponent {
     }
 
     function getSetupInfo() public view returns (ISetup.PoolSetupInfo memory setupInfo) {
-        // TODO fix this
-        if (getNftId().eq(zeroNftId())) {
-            return ISetup.PoolSetupInfo(
-                _productNftId,
-                TokenHandler(address(0)),
-                _collateralizationLevel,
-                _initialPoolFee,
-                _initialStakingFee,
-                _initialPerformanceFee,
-                _isVerifying,
-                _wallet
-            );
-        } 
-
         InstanceReader reader = _instance.getInstanceReader();
         return reader.getPoolSetupInfo(getNftId());
     }
@@ -200,15 +185,14 @@ contract Pool is BaseComponent, IPoolComponent {
     {
         (
             IRegistry.ObjectInfo memory info, 
-            bytes memory data
         ) = super.getInitialInfo();
 
         return (
             info,
             abi.encode(
                 ISetup.PoolSetupInfo(
-                    getProductNftId(),
-                    TokenHandler(address(0)),
+                    _productNftId,
+                    TokenHandler(address(_token)),
                     _collateralizationLevel,
                     _initialPoolFee,
                     _initialStakingFee,

package/contracts/components/Product.sol

@@ -49,7 +49,7 @@ contract Product is BaseComponent, IProductComponent {
         Fee memory productFee,
         Fee memory processingFee,
         address initialOwner
-    ) BaseComponent(registry, instanceNftid, zeroNftId(), token, PRODUCT(), isInterceptor, initialOwner) {
+    ) BaseComponent(registry, instanceNftid, token, PRODUCT(), isInterceptor, initialOwner) {
         // TODO add validation
         // TODO: reactivate when services are available again
         // _productService = _instance.getProductService();

package/contracts/instance/AccessManagedSimple.sol

@@ -19,17 +19,18 @@ import {IAccessManagerSimple} from "./IAccessManagerSimple.sol";
  * functions, and ideally only used in `external` functions. See {restricted}.
  */
 abstract contract AccessManagedSimple is Context, IAccessManaged {
+    bool private _initialized;
     address private _authority;
 
     bool private _consumingSchedule;
 
-    /**
-     * @dev Initializes the contract connected to an initial authority.
-     */
-    constructor(address initialAuthority) {
+    function initializeAccessManagedSimple(address initialAuthority) internal {
+        require(!_initialized, "AccessManaged: already initialized");
         _setAuthority(initialAuthority);
+        _initialized = true;
     }
 
+
     /**
      * @dev Restricts access to a function as defined by the connected Authority for this contract and the
      * caller and selector of the function that entered the contract.

package/contracts/instance/AccessManagerSimple.sol

@@ -46,6 +46,8 @@ contract AccessManagerSimple is Context, IAccessManagerSimple {
         uint32 nonce;
     }
 
+    bool private _initialized;
+
     uint64 public constant ADMIN_ROLE = type(uint64).min; // 0
     uint64 public constant PUBLIC_ROLE = type(uint64).max; // 2**64-1
 
@@ -67,14 +69,22 @@ contract AccessManagerSimple is Context, IAccessManagerSimple {
     }
 
     constructor(address initialAdmin) {
+        initialize(initialAdmin);
+    }
+    
+    function initialize(address initialAdmin) public {
+        require(!_initialized, "AccessManager: already initialized");
+        
         if (initialAdmin == address(0)) {
             revert AccessManagerInvalidInitialAdmin(address(0));
         }
 
         // admin is active immediately and without any execution delay.
         _grantRole(ADMIN_ROLE, initialAdmin, 0, 0);
+        _initialized = true;
     }
 
+
     // =================================================== GETTERS ====================================================
     /// @inheritdoc IAccessManagerSimple
     function canCall(

package/contracts/instance/IInstance.sol

@@ -9,20 +9,31 @@ import {IComponentOwnerService} from "./service/IComponentOwnerService.sol";
 import {IDistributionService} from "./service/IDistributionService.sol";
 import {IPoolService} from "./service/IPoolService.sol";
 import {IProductService} from "./service/IProductService.sol";
+import {IBundle} from "./module/IBundle.sol";
 import {ISetup} from "./module/ISetup.sol";
 import {NftId} from "../types/NftId.sol";
+import {StateId} from "../types/StateId.sol";
 
 interface IInstance is IERC165 {
 
     function getComponentOwnerService() external view returns (IComponentOwnerService);
-    // TODO: renable these when we have the services
-    // function getDistributionService() external view returns (IDistributionService);
+    function getDistributionService() external view returns (IDistributionService);
     // function getProductService() external view returns (IProductService);
-    // function getPoolService() external view returns (IPoolService);
+    function getPoolService() external view returns (IPoolService);
 
     function createProductSetup(NftId productNftId, ISetup.ProductSetupInfo memory setup) external;
+
     function createDistributionSetup(NftId distributionNftId, ISetup.DistributionSetupInfo memory setup) external;
-    function createPoolSetup(NftId distributionNftId, ISetup.PoolSetupInfo memory setup) external;
+    function updateDistributionSetup(NftId distributionNftId, ISetup.DistributionSetupInfo memory setup, StateId newState) external;
+    function updateDistributionSetupState(NftId distributionNftId, StateId newState) external;
+
+    function createPoolSetup(NftId poolNftId, ISetup.PoolSetupInfo memory setup) external;
+    function updatePoolSetup(NftId poolNftId, ISetup.PoolSetupInfo memory setup, StateId newState) external;
+    function updatePoolSetupState(NftId poolNftId, StateId newState) external;
+
+    function createBundle(NftId bundleNftId, IBundle.BundleInfo memory bundle) external;
+    function updateBundle(NftId bundleNftId, IBundle.BundleInfo memory bundle, StateId newState) external;
+    function updateBundleState(NftId bundleNftId, StateId newState) external;
 
     function getInstanceReader() external view returns (InstanceReader);
 }

package/contracts/instance/IInstanceService.sol

@@ -10,8 +10,21 @@ import {IRegistry} from "../registry/IRegistry.sol";
 import {IRegisterable} from "../shared/IRegisterable.sol";
 import {IBaseComponent} from "../components/IBaseComponent.sol";
 
+import {AccessManagerSimple} from "./AccessManagerSimple.sol";
+import {Instance} from "./Instance.sol";
+import {InstanceReader} from "./InstanceReader.sol";
+
 interface IInstanceService is IService {
 
-    
+    event LogInstanceCloned(address clonedAccessManagerAddress, address clonedInstanceAddress, address clonedInstanceReaderAddress, NftId clonedInstanceNftId);
+
+    function createInstanceClone()
+        external 
+        returns (
+            AccessManagerSimple clonedAccessManager, 
+            Instance clonedInstance,
+            NftId instanceNftId,
+            InstanceReader clonedInstanceReader
+        );
 }
 

package/contracts/instance/Instance.sol

@@ -25,6 +25,8 @@ import {ERC165} from "../shared/ERC165.sol";
 import {Registerable} from "../shared/Registerable.sol";
 import {ComponentOwnerService} from "./service/ComponentOwnerService.sol";
 import {IComponentOwnerService} from "./service/IComponentOwnerService.sol";
+import {IDistributionService} from "./service/IDistributionService.sol";
+import {IPoolService} from "./service/IPoolService.sol";
 import {VersionPart} from "../types/Version.sol";
 
 contract Instance is
@@ -41,6 +43,8 @@ contract Instance is
 
     uint32 public constant EXECUTION_DELAY = 0;
 
+    bool private _initialized;
+
     mapping(ShortString name => RoleId roleId) internal _role;
     mapping(RoleId roleId => EnumerableSet.AddressSet roleMembers) internal _roleMembers; 
     RoleId [] internal _roles;
@@ -51,16 +55,23 @@ contract Instance is
     InstanceReader internal _instanceReader;
 
     constructor(address accessManagerAddress, address registryAddress, NftId registryNftId)
-        AccessManagedSimple(accessManagerAddress)
     {
-        // TODO move to initializer method and remove constructor - required for the instance to be cloneable
+        initialize(accessManagerAddress, registryAddress, registryNftId, msg.sender);
+    }
+
+    function initialize(address accessManagerAddress, address registryAddress, NftId registryNftId, address initialOwner) public {
+        require(!_initialized, "Contract instance has already been initialized");
+
+        initializeAccessManagedSimple(accessManagerAddress);
+                
         _accessManager = AccessManagerSimple(accessManagerAddress);
         _createRole(RoleIdLib.toRoleId(ADMIN_ROLE), "AdminRole", false, false);
         _createRole(RoleIdLib.toRoleId(PUBLIC_ROLE), "PublicRole", false, false);
 
-        _initializeRegisterable(registryAddress, registryNftId, INSTANCE(), false, msg.sender, "");
+        _initializeRegisterable(registryAddress, registryNftId, INSTANCE(), false, initialOwner, "");
 
-        _registerInterface(type(IInstance).interfaceId);
+        _registerInterface(type(IInstance).interfaceId);    
+        _initialized = true;
     }
 
     //--- Role ------------------------------------------------------//
@@ -210,16 +221,16 @@ contract Instance is
     }
 
     //--- PoolSetup ------------------------------------------------------//
-    function createPoolSetup(NftId distributionNftId, ISetup.PoolSetupInfo memory setup) external restricted() {
-        create(_toNftKey32(distributionNftId, POOL()), abi.encode(setup));
+    function createPoolSetup(NftId poolNftId, ISetup.PoolSetupInfo memory setup) external restricted() {
+        create(_toNftKey32(poolNftId, POOL()), abi.encode(setup));
     }
 
-    function updatePoolSetup(NftId distributionNftId, ISetup.PoolSetupInfo memory setup, StateId newState) external restricted() {
-        update(_toNftKey32(distributionNftId, POOL()), abi.encode(setup), newState);
+    function updatePoolSetup(NftId poolNftId, ISetup.PoolSetupInfo memory setup, StateId newState) external restricted() {
+        update(_toNftKey32(poolNftId, POOL()), abi.encode(setup), newState);
     }
 
-    function updatePoolSetupState(NftId distributionNftId, StateId newState) external restricted() {
-        updateState(_toNftKey32(distributionNftId, POOL()), newState);
+    function updatePoolSetupState(NftId poolNftId, StateId newState) external restricted() {
+        updateState(_toNftKey32(poolNftId, POOL()), newState);
     }
 
     //--- DistributorType ---------------------------------------------------//
@@ -408,25 +419,21 @@ contract Instance is
         return ComponentOwnerService(_registry.getServiceAddress("ComponentOwnerService", VersionPart.wrap(3)));
     }
 
-    // TODO reactivate when services are available
-    // function getDistributionService() external view returns (IDistributionService) {
-    //     return DistributionService(_registry.getServiceAddress("DistributionService", VersionPart.wrap(3)));
-    // }
+    function getDistributionService() external view returns (IDistributionService) {
+        return IDistributionService(_registry.getServiceAddress("DistributionService", VersionPart.wrap(3)));
+    }
 
     // TODO reactivate when services are available
     // function getProductService() external view returns (IProductService) {
     //     return ProductService(_registry.getServiceAddress("ProductService", VersionPart.wrap(3)));
     // }
 
-    // TODO reactivate when services are available
-    // function getPoolService() external view returns (IPoolService) {
-    //     return PoolService(_registry.getServiceAddress("PoolService", VersionPart.wrap(3)));
-    // }
+    function getPoolService() external view returns (IPoolService) {
+        return IPoolService(_registry.getServiceAddress("PoolService", VersionPart.wrap(3)));
+    }
 
     function setInstanceReader(InstanceReader instanceReader) external restricted() {
-        if (address(_instanceReader) != address(0)) {
-            revert("InstanceReader is set");
-        }
+        require(address(_instanceReader) == address(0), "InstanceReader is set");
         _instanceReader = instanceReader;
     }
 

package/contracts/instance/InstanceAccessManager.sol

@@ -79,9 +79,9 @@ contract InstanceAccessManager is
     AccessManagerSimple internal _accessManager;
 
     constructor(address accessManager)
-        AccessManagedSimple(accessManager)
     {
         _accessManager = AccessManagerSimple(accessManager);
+        initializeAccessManagedSimple(accessManager);
 
         _createRole(RoleIdLib.toRoleId(_accessManager.ADMIN_ROLE()), ADMIN_ROLE_NAME, false, false);
         _createRole(RoleIdLib.toRoleId(_accessManager.PUBLIC_ROLE()), PUBLIC_ROLE_NAME, false, false);

package/contracts/instance/InstanceReader.sol

@@ -7,7 +7,7 @@ import {DistributorType} from "../types/DistributorType.sol";
 import {Fee, FeeLib} from "../types/Fee.sol";
 import {Key32} from "../types/Key32.sol";
 import {NftId} from "../types/NftId.sol";
-import {ObjectType, DISTRIBUTOR, DISTRIBUTION, INSTANCE, PRODUCT, POLICY, POOL, TREASURY} from "../types/ObjectType.sol";
+import {ObjectType, DISTRIBUTOR, DISTRIBUTION, INSTANCE, PRODUCT, POLICY, POOL, TREASURY, BUNDLE} from "../types/ObjectType.sol";
 import {ReferralId, ReferralStatus, ReferralLib, REFERRAL_OK, REFERRAL_ERROR_UNKNOWN, REFERRAL_ERROR_EXPIRED, REFERRAL_ERROR_EXHAUSTED} from "../types/Referral.sol";
 import {Registerable} from "../shared/Registerable.sol";
 import {RiskId} from "../types/RiskId.sol";
@@ -15,6 +15,7 @@ import {UFixed, MathLib, UFixedLib} from "../types/UFixed.sol";
 import {Version} from "../types/Version.sol";
 
 import {IRegistry} from "../registry/IRegistry.sol";
+import {IBundle} from "../instance/module/IBundle.sol";
 import {IDistribution} from "../instance/module/IDistribution.sol";
 import {IInstance} from "./IInstance.sol";
 import {IKeyValueStore} from "../instance/base/IKeyValueStore.sol";
@@ -26,6 +27,7 @@ import {TimestampLib} from "../types/Timestamp.sol";
 
 
 contract InstanceReader {
+    bool private _initialized;
 
     IRegistry internal _registry;
     NftId internal _instanceNftId;
@@ -37,6 +39,12 @@ contract InstanceReader {
         NftId instanceNftId
     )
     {
+        initialize(registry, instanceNftId);
+    }
+
+    function initialize(address registry, NftId instanceNftId) public {
+        require(!_initialized, "ERROR:CRD-000:ALREADY_INITIALIZED");
+
         require(
             address(registry) != address(0),
             "ERROR:CRD-001:REGISTRY_ZERO");
@@ -55,8 +63,11 @@ contract InstanceReader {
 
         _instance = IInstance(instanceInfo.objectAddress);
         _store = IKeyValueStore(instanceInfo.objectAddress);
+
+        _initialized = true;
     }
 
+
     // module specific functions
 
     function getPolicyInfo(NftId policyNftId)
@@ -104,6 +115,17 @@ contract InstanceReader {
             return abi.decode(data, (ITreasury.TreasuryInfo));
         }
     }
+    
+    function getBundleInfo(NftId bundleNftId)
+        public 
+        view 
+        returns (IBundle.BundleInfo memory info)
+    {
+        bytes memory data = _store.getData(toBundleKey(bundleNftId));
+        if (data.length > 0) {
+            return abi.decode(data, (IBundle.BundleInfo));
+        }
+    }
 
     function getDistributorTypeInfo(DistributorType distributorType)
         public 
@@ -249,6 +271,10 @@ contract InstanceReader {
         return distributionNftId.toKey32(DISTRIBUTION());
     }
 
+    function toBundleKey(NftId poolNftId) public pure returns (Key32) { 
+        return poolNftId.toKey32(BUNDLE());
+    }
+
     function toPoolKey(NftId poolNftId) public pure returns (Key32) { 
         return poolNftId.toKey32(POOL());
     }