@etherisc/gif-next 0.0.2-f15b559-661 → 0.0.2-f1b01e0-214

package/contracts/pool/Pool.sol

@@ -127,7 +127,6 @@ abstract contract Pool is
         address registry,
         NftId productNftId,
         string memory name,
-        address token,
         IComponents.PoolInfo memory poolInfo,
         IAuthorization authorization,
         address initialOwner,
@@ -141,7 +140,6 @@ abstract contract Pool is
             registry, 
             productNftId,  
             name, 
-            token, 
             POOL(), 
             authorization, 
             poolInfo.isInterceptingBundleTransfers, 

package/contracts/pool/PoolService.sol

@@ -466,9 +466,7 @@ contract PoolService is
             payoutAmount);
 
         // update value locked with staking service
-        TokenHandler poolTokenHandler = TokenHandler(
-            instanceReader.getTokenHandler(
-                poolNftId));
+        TokenHandler poolTokenHandler = instanceReader.getTokenHandler(poolNftId);
 
         _staking.decreaseTotalValueLocked(
             instanceReader.getInstanceNftId(), 

package/contracts/product/ApplicationService.sol

@@ -71,13 +71,28 @@ contract ApplicationService is
         if (!exists) { revert ErrorApplicationServiceRiskUnknown(riskId, productNftId); }
         if (!active) { revert ErrorApplicationServiceRiskPaused(riskId, productNftId); }
 
-        // check bundle with pool
-        NftId poolNftId = instanceReader.getProductInfo(productNftId).poolNftId;
-        (exists, active) = instanceReader.getBundleSet().checkBundle(poolNftId, bundleNftId);
-        if (!exists) { revert ErrorApplicationServiceBundleUnknown(bundleNftId, poolNftId); }
-        if (!active) { revert ErrorApplicationServiceBundleLocked(bundleNftId, poolNftId); }
+        NftId riskProductNftId = instanceReader.getRiskInfo(riskId).productNftId;
+        if (productNftId != riskProductNftId) {
+            revert ErrorApplicationServiceRiskProductMismatch(riskId, riskProductNftId, productNftId);
+        }
 
-        // TODO check referral with distribution
+        // check bundle with pool
+        IComponents.ProductInfo memory productInfo = instanceReader.getProductInfo(productNftId);
+        {
+            NftId poolNftId = productInfo.poolNftId;
+            (exists, active) = instanceReader.getBundleSet().checkBundle(poolNftId, bundleNftId);
+            if (!exists) { revert ErrorApplicationServiceBundleUnknown(bundleNftId, poolNftId); }
+            if (!active) { revert ErrorApplicationServiceBundleLocked(bundleNftId, poolNftId); }
+        }
+
+        // check referral with distribution
+        {
+            if (productInfo.hasDistribution && ! referralId.eqz()) {
+                if (!_distributionService.referralIsValid(productInfo.distributionNftId, referralId)) {
+                    revert ErrorApplicationServiceReferralInvalid(productNftId, productInfo.distributionNftId, referralId);
+                }
+            }
+        }
     }
 
 

package/contracts/product/BasicProduct.sol

@@ -27,7 +27,6 @@ abstract contract BasicProduct is
         address registry,
         NftId instanceNftId,
         string memory name,
-        address token,
         IComponents.ProductInfo memory productInfo,
         IComponents.FeeInfo memory feeInfo,
         IAuthorization authorization,
@@ -41,7 +40,6 @@ abstract contract BasicProduct is
             registry, 
             instanceNftId, 
             name, 
-            token, 
             productInfo,
             feeInfo,
             authorization, 

package/contracts/product/BasicProductAuthorization.sol

@@ -16,7 +16,7 @@ contract BasicProductAuthorization
 {
 
      constructor(string memory componentName)
-          Authorization(componentName, PRODUCT())
+          Authorization(componentName, PRODUCT(), true, true)
      {}
 
      function _setupServiceTargets()

package/contracts/product/IApplicationService.sol

@@ -16,10 +16,13 @@ import {Seconds} from "../type/Seconds.sol";
 interface IApplicationService is IService {
     
     // _checkLinkedApplicationParameters
+    error ErrorApplicationServiceRiskProductMismatch(RiskId riskId, NftId riskProductNftId, NftId productNftId);
     error ErrorApplicationServiceRiskUnknown(RiskId riskId, NftId productNftId);
     error ErrorApplicationServiceRiskPaused(RiskId riskId, NftId productNftId);
     error ErrorApplicationServiceBundleUnknown(NftId bundleNftId, NftId poolNftId);
     error ErrorApplicationServiceBundleLocked(NftId bundleNftId, NftId poolNftId);
+    error ErrorApplicationServiceReferralInvalid(NftId productNftId, NftId distributionNftId, ReferralId referralId);
+    
 
     /// @dev creates a new application based on the specified attributes
     /// may only be called by a product component

package/contracts/product/IPricingService.sol

@@ -14,6 +14,7 @@ interface IPricingService is IService
 {
 
     error ErrorPricingServiceTargetWalletAmountsMismatch();
+    error ErrorPricingServiceRiskProductMismatch(RiskId riskId, NftId riskProductNftId, NftId productNftId);
     error ErrorPricingServiceBundlePoolMismatch(NftId bundleNftId, NftId bundlePoolNftId, NftId poolNftId);
     error ErrorPricingServiceFeeCalculationMismatch(
         Amount distributionFeeFixAmount,

package/contracts/product/IRiskService.sol

@@ -3,11 +3,14 @@ pragma solidity ^0.8.20;
 
 import {IService} from "../shared/IService.sol";
 
+import {NftId} from "../type/NftId.sol";
 import {RiskId} from "../type/RiskId.sol";
 import {StateId} from "../type/StateId.sol";
 
 interface IRiskService is IService {
 
+    error ErrorRiskServiceRiskProductMismatch(RiskId riskId, NftId riskProductNftId, NftId productNftId);
+
     /// @dev Create a new risk with the given id and provided data. 
     /// The key of the risk derived from the risk id in comination with the product NftId. 
     /// Risk data is stored in the instance store. 

package/contracts/product/PolicyService.sol

@@ -544,24 +544,6 @@ contract PolicyService is
             tokenHandler.pushToken(poolWallet, premium.poolPremiumAndFeeAmount);
         }
     }
-
-
-    /// @dev checks that policy has been collateralized and has been activated.
-    /// does not check if policy has been expired or closed.
-    function _policyHasBeenActivated(
-        StateId policyState,
-        IPolicy.PolicyInfo memory policyInfo
-    )
-        internal
-        view
-        returns (bool)
-    {
-        if (policyState != COLLATERALIZED()) { return false; } 
-        if (TimestampLib.blockTimestamp() < policyInfo.activatedAt) { return false; } 
-        return true;
-    }
-
-
     function _policyHolderPolicyActivated(
         NftId policyNftId,
         Timestamp activateAt

package/contracts/product/PricingService.sol

@@ -87,6 +87,11 @@ contract PricingService is
             // get instance reader from local instance variable
             reader = instance.getInstanceReader();
 
+            NftId riskProductNftId = reader.getRiskInfo(riskId).productNftId;
+            if (productNftId != riskProductNftId) {
+                revert ErrorPricingServiceRiskProductMismatch(riskId, riskProductNftId, productNftId);
+            }
+
             // calculate net premium
             netPremiumAmount = IProductComponent(registryInfo.objectAddress).calculateNetPremium(
                 sumInsuredAmount,
@@ -140,7 +145,7 @@ contract PricingService is
                 revert ErrorPricingServiceTargetWalletAmountsMismatch();
             }
 
-            if (premium.distributionOwnerFeeFixAmount.toInt() < feeInfo.minDistributionOwnerFee.fixedFee) {
+            if (premium.distributionOwnerFeeFixAmount < feeInfo.minDistributionOwnerFee.fixedFee) {
                 revert ErrorPricingServiceFeeCalculationMismatch( 
                     premium.distributionFeeFixAmount,
                     premium.distributionFeeVarAmount,
@@ -180,19 +185,19 @@ contract PricingService is
         premium.netPremiumAmount = netPremiumAmount;
         premium.fullPremiumAmount = netPremiumAmount;
 
-        Amount t = AmountLib.toAmount(feeInfo.productFee.fixedFee);
+        Amount t = feeInfo.productFee.fixedFee;
         premium.productFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
-        t = AmountLib.toAmount(feeInfo.poolFee.fixedFee);
+        t = feeInfo.poolFee.fixedFee;
         premium.poolFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
-        t = AmountLib.toAmount(bundleInfo.fee.fixedFee);
+        t = bundleInfo.fee.fixedFee;
         premium.bundleFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
-        t = AmountLib.toAmount(feeInfo.distributionFee.fixedFee);
+        t = feeInfo.distributionFee.fixedFee;
         premium.distributionFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
     }
@@ -262,7 +267,7 @@ contract PricingService is
             Amount commissionAmount = premium.netPremiumAmount.multiplyWith(distributorTypeInfo.commissionPercentage);
             premium.commissionAmount = commissionAmount;
             premium.discountAmount = premium.fullPremiumAmount.multiplyWith(referralInfo.discountPercentage);
-            premium.distributionOwnerFeeFixAmount = AmountLib.toAmount(minDistributionOwnerFee.fixedFee);
+            premium.distributionOwnerFeeFixAmount = minDistributionOwnerFee.fixedFee;
             premium.distributionOwnerFeeVarAmount = premium.distributionFeeVarAmount - commissionAmount - premium.discountAmount;
             premium.premiumAmount = premium.fullPremiumAmount - premium.discountAmount;
         }

package/contracts/product/Product.sol

@@ -135,7 +135,6 @@ abstract contract Product is
         address registry,
         NftId instanceNftId,
         string memory name,
-        address token,
         IComponents.ProductInfo memory productInfo,
         IComponents.FeeInfo memory feeInfo,
         IAuthorization authorization,
@@ -150,7 +149,6 @@ abstract contract Product is
             registry, 
             instanceNftId, 
             name, 
-            token, 
             PRODUCT(), 
             authorization, 
             productInfo.isInterceptingPolicyTransfers, 

package/contracts/product/RiskService.sol

@@ -82,6 +82,11 @@ contract RiskService is
         // effects
         InstanceReader instanceReader = instance.getInstanceReader();
         IRisk.RiskInfo memory riskInfo = instanceReader.getRiskInfo(riskId);
+
+        if (riskInfo.productNftId != productNftId) {
+            revert ErrorRiskServiceRiskProductMismatch(riskId, riskInfo.productNftId, productNftId);
+        }
+
         riskInfo.data = data;
         instance.getInstanceStore().updateRisk(riskId, riskInfo, KEEP_STATE());
     }
@@ -97,6 +102,11 @@ contract RiskService is
         // checks
         (NftId productNftId, IInstance instance) = _getAndVerifyActiveComponent(PRODUCT());
 
+        NftId riskProductNftId = instance.getInstanceReader().getRiskInfo(riskId).productNftId;
+        if (riskProductNftId != productNftId) {
+            revert ErrorRiskServiceRiskProductMismatch(riskId, riskProductNftId, productNftId);
+        }
+
         // effects
         instance.getInstanceStore().updateRiskState(riskId, state);
 

package/contracts/registry/IRegistry.sol

@@ -52,12 +52,16 @@ interface IRegistry is
     error ErrorRegistryContractAlreadyRegistered(address objectAddress);
 
     struct ObjectInfo {
+        // slot 0
         NftId nftId;
         NftId parentNftId;
         ObjectType objectType;
         bool isInterceptor;
+        // slot 1
         address objectAddress;
+        // slot 2
         address initialOwner;
+        // slot 3
         bytes data;
     }