@etherisc/gif-next 0.0.2-f08d150-296 → 0.0.2-f2b0fa2-473

package/contracts/registry/Registry.sol

@@ -1,381 +1,423 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.19;
+pragma solidity ^0.8.20;
 
 import {IRegisterable} from "../shared/IRegisterable.sol";
-import {IService} from "../instance/base/IService.sol";
+import {IService} from "../shared/IService.sol";
 
-import {IChainNft} from "./IChainNft.sol";
 import {ChainNft} from "./ChainNft.sol";
 import {IRegistry} from "./IRegistry.sol";
 import {NftId, toNftId, zeroNftId, NftIdLib} from "../types/NftId.sol";
-import {VersionPart} from "../types/Version.sol";
-import {ObjectType, PROTOCOL, REGISTRY, TOKEN, SERVICE, INSTANCE, STAKE, PRODUCT, DISTRIBUTOR, ORACLE, POOL, POLICY, BUNDLE} from "../types/ObjectType.sol";
+import {Version, VersionPart, VersionLib} from "../types/Version.sol";
+import {ObjectType, PROTOCOL, REGISTRY, TOKEN, SERVICE, INSTANCE, STAKE, PRODUCT, DISTRIBUTION, ORACLE, POOL, POLICY, BUNDLE} from "../types/ObjectType.sol";
+import {ITransferInterceptor} from "./ITransferInterceptor.sol";
+
+import {ERC165} from "../shared/ERC165.sol";
+
+
+// IMPORTANT
+// Each NFT minted by registry is accosiated with:
+// 1) NFT owner
+// 2) registred contract OR object stored in registered (parent) contract
+// Four registration flows:
+// 1) non IRegisterable address by registryOwner (TOKEN)
+// 2) IRegisterable address by registryOwner (SERVICE)
+// 3) IRegisterable address by approved service (INSTANCE, COMPONENT)
+// 4) state object by approved service (POLICY, BUNDLE, STAKE)
 
-// TODO make registry upgradable
 contract Registry is
-    IRegisterable,
+    ERC165,
     IRegistry
 {
-    using NftIdLib for NftId;
-
+    // register
+    error NotRegistryService();
+    error ZeroParentAddress();
+    error ContractAlreadyRegistered(address objectAddress);
+    error InvalidServiceVersion(VersionPart majorVersion);
+    error ServiceNameAlreadyRegistered(string name, VersionPart majorVersion);
+            
+    // approve
+    error NotOwner();
+    error NotRegisteredContract(NftId registrarNftId);
+    error NotService(NftId registrarNftId);
+    error InvalidTypesCombination(ObjectType objectType, ObjectType parentType);
+
+    uint256 public constant MAJOR_VERSION_MIN = 3;
+    address public constant NFT_LOCK_ADDRESS = address(0x1);
+    uint256 public constant REGISTRY_SERVICE_TOKEN_SEQUENCE_ID = 3;
     string public constant EMPTY_URI = "";
 
-    mapping(NftId nftId => ObjectInfo info) private _info;
-    mapping(NftId nftId => address owner) private _owner;
-    mapping(address object => NftId nftId) private _nftIdByAddress;
-    mapping(ObjectType objectType => bool) private _isValidType;
-    mapping(ObjectType objectType => mapping(ObjectType objectParentType => bool)) private _isValidParentType;
-
-    mapping(NftId nftId => string stringValue) private _string;
-    mapping(bytes32 serviceNameHash => mapping(VersionPart majorVersion => address service)) _service;
-
-    NftId private _nftId;
-    IChainNft private _chainNft;
-    ChainNft private _chainNftInternal;
-    address private _initialOwner;
-
-    // @dev will own protocol nft and registry nft(s) minted during initialize
-    address private _protocolOwner;
-
-    // TODO refactor once registry becomes upgradable
-    // @Dev the protocol owner will get ownership of the
-    // protocol nft and the global registry nft minted in this 
-    // initializer function 
-    function initialize(
-        address chainNft, 
-        address protocolOwner
-    )
-        public 
-    {
-        require(
-            address(_chainNft) == address(0),
-            "ERROR:REG-001:ALREADY_INITIALIZED"
-        );
+    mapping(NftId nftId => ObjectInfo info) internal _info;
+    mapping(address object => NftId nftId) internal _nftIdByAddress;
 
-        _initialOwner = msg.sender;
-        _protocolOwner = protocolOwner;
+    mapping(NftId registrator => mapping(
+            ObjectType objectType => bool)) internal _isApproved;
 
-        _chainNft = IChainNft(chainNft);
-        _chainNftInternal = ChainNft(chainNft);
+    mapping(ObjectType objectType => mapping(
+            ObjectType parentType => bool)) internal _isValidContractCombination;
 
-        // initial registry setup
-        _registerProtocol();
-        _nftId = _registerRegistry();
+    mapping(ObjectType objectType => mapping(
+            ObjectType parentType => bool)) internal _isValidObjectCombination;
 
-        // setup rules for further registrations
-        _setupValidTypes();
-        _setupValidParentTypes();
-    }
+    mapping(NftId nftId => string name) internal _string;
+    mapping(bytes32 serviceNameHash => mapping(
+            VersionPart majorVersion => address service)) internal _service;
 
+    NftId internal _registryNftId;
+    NftId internal _serviceNftId; // set in stone upon registry creation
+    ChainNft internal _chainNft;
 
-    function register(
-        address objectAddress
-    )
-    // TODO add authz (only services may register components etc)
-    // we have to check how we do authz for registring services (just restrict to protocol owner/registry owner)
-    external override returns (NftId nftId) {
-        require(
-            _nftIdByAddress[objectAddress].eqz(),
-            "ERROR:REG-002:ALREADY_REGISTERED"
-        );
 
-        IRegisterable registerable = IRegisterable(objectAddress);
-        require(
-            registerable.supportsInterface(type(IRegisterable).interfaceId),
-            "ERROR:REG-003:NOT_REGISTERABLE"
-        );
-
-        ObjectType objectType = registerable.getType();
-        require(
-            _isValidType[objectType],
-            "ERROR:REG-004:TYPE_INVALID"
-        );
-
-        NftId parentNftId = registerable.getParentNftId();
-        require(
-            isRegistered(parentNftId),
-            "ERROR:REG-005:PARENT_NOT_REGISTERED"
-        );
+    modifier onlyOwner() {
+        if(msg.sender != getOwner()) {
+            revert NotOwner();
+        }
+        _;
+    }
 
-        require(
-            _isValidParentType[objectType][_info[parentNftId].objectType],
-            "ERROR:REG-006:PARENT_TYPE_INVALID"
-        );
+    modifier onlyRegistryService() {
+        
+        if(msg.sender != _info[_serviceNftId].objectAddress) {
+            revert NotRegistryService();
+        }
+        _;
+    }
 
-        // also check that nftId and parentNFtId are on the same chain if applicable
+    constructor(address registryOwner, VersionPart majorVersion)
+    {
+        require(registryOwner > address(0), "Registry: registry owner is 0");
+        require(majorVersion.toInt() == MAJOR_VERSION_MIN, "Registry: initial major version of registry service is not MAJOR_VERSION_MIN");
 
-        // nft minting
-        uint256 mintedTokenId = _chainNft.mint(
-            registerable.getOwner(),
-            EMPTY_URI
-        );
+        // deploy NFT 
+        _chainNft = new ChainNft(address(this));// adds 10kb to deployment size
 
-        nftId = toNftId(mintedTokenId);
+        // initial registry setup
+        _registerProtocol();
+        _registerRegistry(registryOwner);
+        _registerRegistryService(registryOwner);
 
-        // special case services
-        if(registerable.getType() == SERVICE()) {
-            IService service = IService(objectAddress);
-            require(
-                service.supportsInterface(type(IService).interfaceId),
-                "ERROR:REG-007:NOT_SERVICE"
-            );
-
-            string memory serviceName = service.getName();
-            VersionPart majorVersion = service.getMajorVersion();
-            bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
-
-            // service specific state
-            _string[nftId] = serviceName;
-
-            require(
-                _service[serviceNameHash][majorVersion] == address(0),
-                "ERROR:REG-008:ALREADY_REGISTERED"
-            );
-            _service[serviceNameHash][majorVersion] = objectAddress;
-        }
+        // set object parent relations
+        _setupValidObjectParentCombinations();
 
-        // create object info and link nft id with it
-        _registerObjectInfo(registerable, nftId);
+        _registerInterface(type(IRegistry).interfaceId);
     }
 
-
-    function registerObjectForInstance(
-        NftId parentNftId,
-        ObjectType objectType,
-        address initialOwner,
-        bytes memory data
-    )
+    /// @dev registry protects only against tampering existing records, registering with invalid types pairs and 0 parent address
+    // TODO service registration means its approval for some type?
+    // TODO registration of precompile addresses
+    function register(ObjectInfo memory info)
         external
-        override
-        returns (
-            // TODO add onlyRegisteredInstance
-            NftId nftId
-        )
+        onlyRegistryService
+        returns(NftId nftId)
     {
-        // TODO add more validation
-        require(
-            objectType == POLICY() || objectType == BUNDLE(),
-            "ERROR:REG-010:TYPE_INVALID"
-        );
+        ObjectType objectType = info.objectType;
+        NftId parentNftId = info.parentNftId;
+        ObjectInfo memory parentInfo = _info[parentNftId];
+        ObjectType parentType = parentInfo.objectType; // see function header
+        address parentAddress = parentInfo.objectAddress;
+
+        // parent is contract -> need to check? -> check before minting
+        // special case: global registry nft as parent when not on mainnet -> global registry address is 0
+        // special case: when parentNftId == _chainNft.mint(), check for zero parent address before mint
+        // special case: when parentNftId == _chainNft.mint() && objectAddress == initialOwner
+        if(parentAddress == address(0)) {
+            revert ZeroParentAddress();
+        }
 
-        uint256 mintedTokenId = _chainNft.mint(initialOwner, EMPTY_URI);
-        nftId = toNftId(mintedTokenId);
+        address interceptor = _getInterceptor(info.isInterceptor, info.objectAddress, parentInfo.isInterceptor, parentAddress);
 
-        ObjectInfo memory info = ObjectInfo(
-            nftId,
-            parentNftId,
-            objectType,
-            address(0),
-            initialOwner,
-            data
-        );
+        // TODO does external call
+        uint256 mintedTokenId = _chainNft.mint(
+            info.initialOwner,
+            interceptor,
+            EMPTY_URI);
+        nftId = toNftId(mintedTokenId);
 
+        // TODO move nftId out of info struct
+        // getters by nftId -> return struct without nftId
+        // getters by address -> return nftId AND struct
+        info.nftId = nftId;
         _info[nftId] = info;
 
-        // add logging
+        if(info.objectAddress > address(0)) 
+        {
+            // TODO if need to add types latter -> at least call this check from registry service
+            // parent is registered + object-parent types are valid
+            if(_isValidContractCombination[objectType][parentType] == false) {
+                revert InvalidTypesCombination(objectType, parentType);
+            }
+
+            address contractAddress = info.objectAddress;
+
+            if(_nftIdByAddress[contractAddress].gtz()) { 
+                revert ContractAlreadyRegistered(contractAddress);
+            }
+
+            _nftIdByAddress[contractAddress] = nftId;
+
+            // special case
+            if(objectType == SERVICE()) {
+                _registerService(info);
+            }
+        }
+        else
+        {
+            if(_isValidObjectCombination[objectType][parentType] == false) {
+                revert InvalidTypesCombination(objectType, parentType);
+            }
+        }
+
+        emit LogRegistration(info);
     }
 
+    // from IRegistry
     function getObjectCount() external view override returns (uint256) {
+        
         return _chainNft.totalSupply();
     }
 
-    function getNftId(
-        address object
-    ) external view override returns (NftId id) {
+    function getNftId(address object) external view override returns (NftId id) {
         return _nftIdByAddress[object];
     }
 
-    function isRegistered(
-        NftId nftId
-    ) public view override returns (bool) {
-        return _info[nftId].objectType.gtz();
+    function ownerOf(NftId nftId) public view override returns (address) {
+        return _chainNft.ownerOf(nftId.toInt());
     }
 
-    function isRegistered(
-        address object
-    ) external view override returns (bool) {
-        return _nftIdByAddress[object].gtz();
+    function ownerOf(address contractAddress) public view returns (address) {
+        
+        return _chainNft.ownerOf(_nftIdByAddress[contractAddress].toInt());
     }
 
-    function getObjectInfo(
-        NftId nftId
-    ) external view override returns (ObjectInfo memory info) {
+    function getObjectInfo(NftId nftId) external view override returns (ObjectInfo memory) {
         return _info[nftId];
     }
 
-    function getName(
-        NftId nftId
-    ) external view returns (string memory name) {
-        return _string[nftId];
+    function getObjectInfo(address object) external view override returns (ObjectInfo memory) {
+        
+        return _info[_nftIdByAddress[object]];
     }
 
-    function getOwner(NftId nftId) external view override returns (address) {
-        return _chainNft.ownerOf(nftId.toInt());
+    function isRegistered(NftId nftId) public view override returns (bool) {
+        return _info[nftId].objectType.gtz();
     }
 
-    function getChainNft() external view override returns (IChainNft) {
-        return _chainNft;
+    function isRegistered(address object) external view override returns (bool) {
+        return _nftIdByAddress[object].gtz();
+    }
+
+    function getServiceName(NftId nftId) external view returns (string memory) {
+        return _string[nftId];
     }
 
     // special case to retrive a gif service
-    function getServiceAddress(string memory serviceName, VersionPart majorVersion) external view override returns (address serviceAddress) {
+    function getServiceAddress(
+        string memory serviceName, 
+        VersionPart majorVersion
+    ) external view returns (address)
+    {
         bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
         return _service[serviceNameHash][majorVersion];
     }
 
-    // from IERC165
-    function supportsInterface(bytes4 interfaceId) external pure override returns (bool) {
-        return interfaceId == type(IRegistry).interfaceId;
+    function getChainNft() external view override returns (ChainNft) {
+        return _chainNft;
     }
 
-    // from IRegistryLinked
-    function getRegistry() external view override returns (IRegistry registry) {
-        return this;
+    function getOwner() public view returns (address owner) {
+        return ownerOf(address(this));
     }
 
-    // from IRegisterable
-    function register() external pure override returns (NftId nftId) {
-        return zeroNftId();
-    }
+    // Internals
 
-    function getType() external pure override returns (ObjectType objectType) {
-        return REGISTRY();
-    }
+    function _registerService(ObjectInfo memory info)
+        internal
+    {
+        (
+            string memory serviceName,
+            VersionPart majorVersion
+        ) = abi.decode(info.data, (string, VersionPart));
+        bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
 
+        // TODO MUST guarantee consistency of service.getVersion() and majorVersion here
+        // TODO update _serviceNftId when registryService with new major version is registered? -> it is fixed in current setup -> can lock up
+        // TODO do not use names -> each object type is registered by corresponding service -> conflicting with approve()
+        if(
+            majorVersion.toInt() < MAJOR_VERSION_MIN ||
+            (majorVersion.toInt() > MAJOR_VERSION_MIN &&
+            _service[serviceNameHash][VersionLib.toVersionPart(majorVersion.toInt() - 1)] == address(0) )
+        ) {
+            revert InvalidServiceVersion(majorVersion);
+        }
+        
+        if(_service[serviceNameHash][majorVersion] != address(0)) {
+            revert ServiceNameAlreadyRegistered(serviceName, majorVersion);
+        }
 
-    function getOwner() public view override returns (address owner) {
-        return _nftId.gtz() ? this.getOwner(_nftId) : _initialOwner;
-    }
+        _string[info.nftId] = serviceName;
+        _service[serviceNameHash][majorVersion] = info.objectAddress;
 
-    function getNftId() external view override (IRegisterable, IRegistry) returns (NftId nftId) {
-        return _nftId;
+        emit LogServiceNameRegistration(serviceName, majorVersion); 
     }
 
-    function getParentNftId() external view returns (NftId nftId) {
-        // we're the global registry
-        if(block.chainid == 1) {
-            return toNftId(_chainNftInternal.PROTOCOL_NFT_ID());
+    /// @dev obtain interceptor address for this nft if applicable, address(0) otherwise
+    function _getInterceptor(
+        bool isInterceptor, 
+        address objectAddress,
+        bool parentIsInterceptor,
+        address parentObjectAddress
+    )
+        internal 
+        view 
+        returns (address interceptor) 
+    {
+        if (objectAddress == address(0)) {
+            if (parentIsInterceptor) {
+                return parentObjectAddress;
+            } else {
+                return address(0);
+            }
         }
-        else {
-            return toNftId(_chainNftInternal.GLOBAL_REGISTRY_ID());
+
+        if (isInterceptor) {
+            return objectAddress;
         }
-    }
 
-    function getData() external pure returns (bytes memory data) {
-        return "";
+        return address(0);
     }
 
-    // registry specific functions
-    function getProtocolOwner() external view override returns (address) {
-        return _protocolOwner;
-    }
+    // Internals called only in constructor
 
-    /// @dev defines which types are allowed to register
-    function _setupValidTypes() internal {
-        _isValidType[REGISTRY()] = true; // only for global registry 
-        _isValidType[TOKEN()] = true;
-        _isValidType[SERVICE()] = true;
-        _isValidType[INSTANCE()] = true;
-        _isValidType[STAKE()] = true;
-        _isValidType[PRODUCT()] = true;
-        _isValidType[ORACLE()] = true;
-        _isValidType[POOL()] = true;
-        _isValidType[POLICY()] = true;
-        _isValidType[BUNDLE()] = true;
-    }
+    /// @dev protocol registration used to anchor the dip ecosystem relations
+    function _registerProtocol() 
+        internal
+    {
+        uint256 protocolId = _chainNft.PROTOCOL_NFT_ID();
+        NftId protocolNftId = toNftId(protocolId);
 
-    /// @dev defines which types - parent type relations are allowed to register
-    function _setupValidParentTypes() internal {
-        // registry as parent
-        _isValidParentType[TOKEN()][REGISTRY()] = true;
-        _isValidParentType[SERVICE()][REGISTRY()] = true;
-        _isValidParentType[INSTANCE()][REGISTRY()] = true;
-
-        // instance as parent
-        _isValidParentType[PRODUCT()][INSTANCE()] = true;
-        _isValidParentType[DISTRIBUTOR()][INSTANCE()] = true;
-        _isValidParentType[ORACLE()][INSTANCE()] = true;
-        _isValidParentType[POOL()][INSTANCE()] = true;
-
-        // product as parent
-        _isValidParentType[POLICY()][PRODUCT()] = true;
-
-        // pool as parent
-        _isValidParentType[BUNDLE()][POOL()] = true;
-        _isValidParentType[STAKE()][POOL()] = true;
-    }
+        _chainNft.mint(NFT_LOCK_ADDRESS, protocolId);
 
-    /// @dev protocol registration used to anchor the dip ecosystem relations
-    function _registerProtocol() virtual internal {
-        uint256 protocolId = _chainNftInternal.PROTOCOL_NFT_ID();
-        _chainNftInternal.mint(_protocolOwner, protocolId);
-
-        NftId protocolNftid = toNftId(protocolId);
-        ObjectInfo memory protocolInfo = ObjectInfo(
-            protocolNftid,
-            zeroNftId(), // parent nft id
+        _info[protocolNftId] = ObjectInfo(
+            protocolNftId,
+            zeroNftId(), // parent
             PROTOCOL(),
-            address(0), // contract address
-            _protocolOwner,
-            "" // data
+            false, // isInterceptor
+            address(0), // objectAddress
+            NFT_LOCK_ADDRESS,// initialOwner
+            ""
         );
-
-        _info[protocolNftid] = protocolInfo;
     }
 
     /// @dev registry registration
     /// might also register the global registry when not on mainnet
-    function _registerRegistry() virtual internal returns (NftId registryNftId) {
-        uint256 registryId = _chainNftInternal.calculateTokenId(2);
-        registryNftId = toNftId(registryId);
+    function _registerRegistry(address registryOwner) 
+        internal
+    {
+        uint256 registryId = _chainNft.calculateTokenId(2);
+        NftId registryNftId = toNftId(registryId);
+
+        NftId parentNftId;
 
-        // we're not the global registry
-        if(registryId != _chainNftInternal.GLOBAL_REGISTRY_ID()) {
+        if(registryId != _chainNft.GLOBAL_REGISTRY_ID()) 
+        {// we're not the global registry
             _registerGlobalRegistry();
+            parentNftId = toNftId(_chainNft.GLOBAL_REGISTRY_ID());
+        }
+        else 
+        {// we are global registry
+            parentNftId = toNftId(_chainNft.PROTOCOL_NFT_ID());
         }
 
-        _chainNftInternal.mint(_protocolOwner, registryId);
-        _registerObjectInfo(this, registryNftId);
+        _chainNft.mint(registryOwner, registryId);
+
+        _info[registryNftId] = ObjectInfo(
+            registryNftId,
+            parentNftId,
+            REGISTRY(),
+            false, // isInterceptor
+            address(this), 
+            registryOwner,
+            "" 
+        );
+        _nftIdByAddress[address(this)] = registryNftId;
+        _registryNftId = registryNftId;
     }
 
 
     /// @dev global registry registration for non mainnet registries
-    function _registerGlobalRegistry() virtual internal {
-        uint256 globalRegistryId = _chainNftInternal.GLOBAL_REGISTRY_ID();
-        _chainNftInternal.mint(_protocolOwner, globalRegistryId);
+    function _registerGlobalRegistry() 
+        internal
+    {
+        uint256 globalRegistryId = _chainNft.GLOBAL_REGISTRY_ID();
+
+        _chainNft.mint(NFT_LOCK_ADDRESS, globalRegistryId);
 
         NftId globalRegistryNftId = toNftId(globalRegistryId);
-        ObjectInfo memory globalRegistryInfo = ObjectInfo(
+
+        _info[globalRegistryNftId] = ObjectInfo(
             globalRegistryNftId,
-            toNftId(_chainNftInternal.PROTOCOL_NFT_ID()),
+            toNftId(_chainNft.PROTOCOL_NFT_ID()), // parent
             REGISTRY(),
-            address(0), // contract address
-            _protocolOwner,
+            false, // isInterceptor
+            address(0), // objectAddress
+            NFT_LOCK_ADDRESS, // initialOwner
             "" // data
         );
-
-        _info[globalRegistryNftId] = globalRegistryInfo;
     }
 
-
-    function _registerObjectInfo(
-        IRegisterable registerable,
-        NftId nftId
-    ) internal virtual {
-        address objectAddress = address(registerable);
-        ObjectInfo memory info = ObjectInfo(
-            nftId,
-            registerable.getParentNftId(),
-            registerable.getType(),
-            objectAddress,
-            registerable.getOwner(),
-            registerable.getData()
+    function _registerRegistryService(address registryOwner)
+        internal
+    {
+        uint256 serviceId = _chainNft.calculateTokenId(REGISTRY_SERVICE_TOKEN_SEQUENCE_ID);
+        NftId serviceNftId = toNftId(serviceId);        
+
+        _chainNft.mint(registryOwner, serviceId);
+
+        _info[serviceNftId] = ObjectInfo(
+            serviceNftId,
+            _registryNftId,
+            SERVICE(),
+            false, // isInterceptor
+            msg.sender, // service deploys registry
+            registryOwner, // initialOwner,
+            "" 
         );
 
-        _info[nftId] = info;
-        _nftIdByAddress[objectAddress] = nftId;
+        _nftIdByAddress[msg.sender] = serviceNftId;
 
-        // add logging
+        string memory serviceName = "RegistryService";
+        bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
+        _service[serviceNameHash][VersionLib.toVersionPart(MAJOR_VERSION_MIN)] = msg.sender;
+        _string[serviceNftId] = serviceName;
+        _serviceNftId = serviceNftId;
     }
 
+    /// @dev defines which object - parent types relations are allowed to register
+    // IMPORTANT: 
+    // 1) EACH object type MUST have only one parent type across ALL mappings
+    // 2) DO NOT use object type (e.g. POLCY, BUNDLE, STAKE) as parent type
+    // 3) DO NOT use REGISTRY as object type
+    // 2) DO NOT use PROTOCOL and "zeroObjectType"
+    function _setupValidObjectParentCombinations() 
+        internal 
+    {
+        // registry as parent, ONLY registry owner
+        _isValidContractCombination[TOKEN()][REGISTRY()] = true;
+        _isValidContractCombination[SERVICE()][REGISTRY()] = true;
+
+        // registry as parent, ONLY approved
+        _isValidContractCombination[INSTANCE()][REGISTRY()] = true;
+
+        // instance as parent, ONLY approved
+        _isValidContractCombination[PRODUCT()][INSTANCE()] = true;
+        _isValidContractCombination[DISTRIBUTION()][INSTANCE()] = true;
+        _isValidContractCombination[ORACLE()][INSTANCE()] = true;
+        _isValidContractCombination[POOL()][INSTANCE()] = true;
+
+        // product as parent, ONLY approved
+        _isValidObjectCombination[POLICY()][PRODUCT()] = true;
+
+        // pool as parent, ONLY approved
+        _isValidObjectCombination[BUNDLE()][POOL()] = true;
+        _isValidObjectCombination[STAKE()][POOL()] = true;
+    }
 }