@etherisc/gif-next 0.0.2-ebf1a6b-485 → 0.0.2-ec4918f-024

package/README.md

@@ -1,18 +1,6 @@
 # GIF-Next (Generic Insurance Framework, next version)
 
 
-```mermaid
-  graph TD
-      IPoolComponent --> IComponent
-      IComponent --> IRegisterable
-      IComponent --> ITransferInterceptor
-      IRegistryService --> IService
-      IService-->IRegisterable
-      IService-->IVersionable
-      IRegisterable-->INftOwnable
-      INftOwnable-->IERC165
-```
-
 ## Add OpenZeppelin V5 Dependencies
 
 ```shell
@@ -40,6 +28,10 @@ This repository uses submodules. To checkout or update to the latest submodules,
 git submodule update --recursive
 ```
 
+## Example components
+
+A (very early) example of a product and a pool can be found in the [gif-next-sandbox repository](https://github.com/etherisc/gif-next-sandbox). 
+
 ## Hardhat 
 
 ### NPM Commands
@@ -76,7 +68,6 @@ The deploy script will deploy all required contracts and create a test instance
 
 ```bash
 # run deployment on a locally created ganache instance
-export SKIP_VERIFICATION=true
 hh run scripts/deploy_all.ts
 ```
 
@@ -87,9 +78,17 @@ hh run scripts/deploy_all.ts
 hh run --network <networkname> scripts/deploy_all.ts
 ```
 
+The deployment will persist deployment information into the files `deployment_state_<chainid>.json`, `libraries_<chainid>.json` and `verification_log_<chainid>.json`. 
+This data can then be used for verification of the deployed contracts on etherscan/polygonscan.
+
+For the verification of the contracts on etherscan/polygonscan the above files (created by previous deployment) are required and then the following command can be used:
+
+```bash
+hh run --network <networkname> scripts/verify_deployment.ts 
+```
+
 Environment variables:
 
-- `SKIP_VERIFICATION` set to `true` to skip etherscan verification (required for ganacht and anvil)
 - `WEB3_INFURA_PROJECT_ID` set to infura project id (required for mumbai and mainnet)
 - `WALLET_MNEMONIC` the mnemonic of the wallet to use for deployment (required for mumbai and mainnet)
 - `ETHERSCAN_API_KEY` `POLYGONSCAN_API_KEY` the api key for etherscan/polygonscan (required for mumbai and mainnet)
@@ -129,6 +128,27 @@ await provider.getBalance(me)
 
 https://hardhat.org/hardhat-runner/docs/guides/compile-contracts
 
+### Scripts to find syntax bugs in code
+
+#### find methods missing the `restricted` modifier
+
+```bash
+hh run scripts/find_unrestricted_methods.ts.ts
+```
+
+Checks all public/external methods in services and components for methods that are missing the `restricted` modifier but should have one.
+
+The script `find_unrestricted_methods.ts` is based on the ANTLR grammar `Solidity.g4` (from https://github.com/solidity-parser/antlr) and uses the antlr4ng runtime (https://github.com/mike-lischke/antlr4ng).
+To compile grammar to ts classes run `antlr4ng -Dlanguage=TypeScript -o antlr/generated/ -visitor -listener  antlr/Solidity.g4` (requires openjdk to be installed `sudo apt install openjdk-17-jre-headless`).
+
+#### find methods missing the `virtual` keyword
+
+```bash
+hh run scripts/find_missing_virtual_methods.ts.ts
+```
+
+Checks all public/external methods in services and components for methods that are not marked as `virtual` but should be.
+
 ## Forge 
 
 ### Commands
@@ -154,11 +174,28 @@ forge test --mt test_decimals --gas-report
 # provide code coverage report
 forge coverage
 forge coverage --report lcov 
+```
 
+### Aliases 
 
-```
 
-Chisel session
+| Alias | Command |
+| --- | --- |
+| fb | forge build |
+| fbw | forge build --watch |
+| fbc | forge build contracts/ |
+| fbcw | forge build --watch contracts/ |
+| ft | forge test |
+| ftf | forge test --nmt "_longRunning" |
+| ftt | forge test -vvvv --mt |
+| fttw | forge test -vvvv --watch --mt |
+| ftc | forge test -vvvv --mc |
+| ftcw | forge test -vvvv --watch --mc |
+
+**Important**: All profiles are run using the foundry `ci` profile which disables the optimizer (for speed).
+
+### Chisel session
+
 ```typescript
 import "./contracts/components/Component.sol";
 import "./contracts/components/IPool.sol";
@@ -232,17 +269,7 @@ https://book.getfoundry.sh/reference/
 
 ## Style Guide
 
-Solidity code is to be written according to the [Solidity Style Guide](https://docs.soliditylang.org/en/latest/style-guide.html).
-
-Documentation of the code should be written inline using [NatSpec](https://docs.soliditylang.org/en/latest/natspec-format.html).
-
-### Naming conventions
-
-Additionally, we use the following naming conventions:
-
-- Function arguments and return types: If using custom data types, make the name include the type by appending the Type to the argument name, e.g. `function getInfo(NftId bundleNftId)` instead of `function getInfo(NftId bundleId)`. Background: Custom data types are lost when using the ABI or Typescript binding classes (e.g. instead of `NftID` a `uint96` is used), so the type needs to be included in the name to make it clear what the argument is without having to look at the documentation or checking the solidity source code. 
-- When naming a field or an attribute `id` and the context is not clear, call it `nftId` instead so its clear what type if id it is as there will be multiple ids for different kind of objects. Example: if you the function has a bundle nft id and a policy nft id as arguments, call them `bundleNftId` and `policyNftId` instead of `id` and `policyId`. In case of doubt, be a bit more verbose for the sake of clarity. 
-- When naming things, remember that the code will likely be used in Javascript/Typescript as well, so avoid names that are reserved in Javascript/Typescript. A list of reserved words in Javascript can be found [here](https://www.w3schools.com/js/js_reserved.asp) and a list of reserved words in Typescript can be found [here](https://www.tektutorialshub.com/typescript/identifiers-keywords-in-typescript/). 
+Please see https://docs.etherisc.com/gif-next/3.x/ for style guide and general coding rules. 
 
 ### Automatic code formatting
 
@@ -257,7 +284,7 @@ We use solhint to lint the code.
 To execute linting run `npm run lint`.
 
 
-### Adding Brownie (Legacy)
+### Adding Brownie (Legacy - don't do that :wink: )
 
 python3 is already installed
 
@@ -405,65 +432,6 @@ Intercepting property
 
 ### Product
 
-### Payout Handling
-
-Pool specifies **retention level**.
-Retention level defines up to which percentage of the sum insured the pool is payout out using its own/current funds.
-Depending on the amount of a new payout the poolService decides to either execute the payout directly or to add the payout as a pending payout with a notification of the pool.
-
-The sequence below sketches the small payout flow (payout < retention amount)
-- retention level: 30%
-- sum insured: 1000
-- payout: 200
-
-```mermaid
-sequenceDiagram
-  participant customer
-  participant product
-  participant claimService
-  participant poolService
-  participant pool
-  product->>claimService: createPayout()
-  claimService ->> poolService: requestPayout()
-  poolService -->> pool: verifyPayout() *
-  poolService ->> poolService: processPayout()
-  poolService ->> customer: transfer token for payout
-  poolService ->> claimService: payoutExecuted()
-  poolService -->> customer: payoutExecutedCallback() **
-```
-
-*: if pool is configured to verify payouts before execution
-
-**: callback only if customer is contract (IPolicyHolder)
-
-The sequence below sketches the call flow for payouts larger than the retention amount
-- retention level: 30%
-- sum insured: 1000
-- payout: 500
-  * locally available: 300
-  * via policy (re-insurance): 200
-
-```mermaid
-sequenceDiagram 
-  participant customer
-  participant product
-  participant claimService
-  participant poolService
-  participant pool
-  pool ->> reinsuranceProduct: applyForPolicy()
-  product->>claimService: createPayout()
-  claimService ->> poolService: requestPayout()
-  poolService ->> pool: pendingPayoutAdded()
-  pool ->> pool: getReinsurancePolicy()
-  pool ->> reinsuranceProduct: claim()
-  reinsuranceProduct -->> reinsurancePool: createPayout
-  reinsurancePool ->> pool: transfer token for payout
-  reinsurancePool ->> pool: payoutExecutedCallback()
-  pool ->> poolService: processPendingPayout()
-  poolService ->> customer: transfer token for payout
-  poolService ->> claimService: payoutExecuted()
-```
-
 ### Pool
 
 ### Distribution
@@ -537,13 +505,14 @@ contracts
     ComponentService.sol
   instance
     Instance.sol
-    InstanceAccessManager.sol
+    InstanceAdmin.sol
     InstanceReader.sol
     InstanceService.sol
     InstanceServiceManager.sol
   registry
     ChainNft.sol
     Registry.sol
+    RegistryAdmin.sol
     RegistryService.sol
     RegistryServiceManager.sol
   shared

package/artifacts/contracts/authorization/AccessAdmin.sol/AccessAdmin.dbg.json

@@ -0,0 +1,4 @@
+{
+  "_format": "hh-sol-dbg-1",
+  "buildInfo": "../../../build-info/e5a8cf4867fca2685a5a66bdebb5843e.json"
+}