@etherisc/gif-next 0.0.2-de9ede4-391 → 0.0.2-deb924b-641

package/contracts/product/PolicyService.sol

@@ -22,6 +22,7 @@ import {APPLIED, COLLATERALIZED, KEEP_STATE, CLOSED, DECLINED, PAID} from "../ty
 import {ContractLib} from "../shared/ContractLib.sol";
 import {NftId} from "../type/NftId.sol";
 import {ObjectType, ACCOUNTING, COMPONENT, DISTRIBUTION, PRODUCT, POOL, POLICY, PRICE} from "../type/ObjectType.sol";
+import {PolicyServiceLib} from "./PolicyServiceLib.sol";
 import {ReferralId} from "../type/Referral.sol";
 import {RiskId} from "../type/RiskId.sol";
 import {Service} from "../shared/Service.sol";
@@ -50,11 +51,11 @@ contract PolicyService is
         initializer
     {
         (
-            address registryAddress,
-            address authority
+            address authority,
+            address registry
         ) = abi.decode(data, (address, address));
 
-        _initializeService(registryAddress, authority, owner);
+        __Service_init(authority, registry, owner);
 
         VersionPart majorVersion = getVersion().toMajorPart();
         _accountingService = IAccountingService(getRegistry().getServiceAddress(ACCOUNTING(), majorVersion));
@@ -119,14 +120,14 @@ contract PolicyService is
         // actual collateralizaion
         _poolService.lockCollateral(
             instance,
-            address(instanceReader.getComponentInfo(productNftId).token),
+            address(instanceReader.getToken(productNftId)),
             productNftId,
             applicationNftId,
             applicationInfo.bundleNftId,
             applicationInfo.sumInsuredAmount);
 
         // optional activation of policy
-        if(activateAt > TimestampLib.zero()) {
+        if(activateAt.gtz()) {
             applicationInfo = _activate(applicationNftId, applicationInfo, activateAt);
         }
 
@@ -165,7 +166,7 @@ contract PolicyService is
         }
 
         // link policy to risk and bundle
-        NftId poolNftId = getRegistry().getObjectInfo(bundleNftId).parentNftId;
+        NftId poolNftId = getRegistry().getParentNftId(bundleNftId);
         instance.getRiskSet().linkPolicy(productNftId, riskId, applicationNftId);
         instance.getBundleSet().linkPolicy(poolNftId, bundleNftId, applicationNftId);
 
@@ -207,12 +208,18 @@ contract PolicyService is
 
         // check funds and allowance of policy holder
         IPolicy.PremiumInfo memory premium = instanceReader.getPremiumInfo(policyNftId);
-        TokenHandler tokenHandler = _getTokenHandler(instanceReader, policyInfo.productNftId);        
-        _checkPremiumBalanceAndAllowance(
-            tokenHandler.TOKEN(), 
-            address(tokenHandler),
-            getRegistry().ownerOf(policyNftId), 
-            premium.premiumAmount);
+        instanceReader.getTokenHandler(
+            productNftId).checkBalanceAndAllowance(
+                getRegistry().ownerOf(policyNftId), 
+                premium.premiumAmount, 
+                false);
+
+        // )
+        // _checkPremiumBalanceAndAllowance(
+        //     tokenHandler.TOKEN(), 
+        //     address(tokenHandler),
+        //     getRegistry().ownerOf(policyNftId), 
+        //     premium.premiumAmount);
 
         // effects
         _processSale(
@@ -235,7 +242,7 @@ contract PolicyService is
         emit LogPolicyServicePolicyPremiumCollected(policyNftId, premium.premiumAmount);
 
         // interactions
-        _transferFunds(instanceReader, policyNftId, policyInfo.productNftId, premium);
+        _transferPremiumAmounts(instanceReader, policyNftId, policyInfo.productNftId, premium);
     }
 
 
@@ -263,6 +270,45 @@ contract PolicyService is
         _policyHolderPolicyActivated(policyNftId, activateAt);
     }
 
+    /// @inheritdoc IPolicyService
+    function adjustActivation(
+        NftId policyNftId,
+        Timestamp newActivateAt
+    )
+        external
+        virtual
+        nonReentrant()
+    {
+        // checks
+        (
+            IInstance instance,,
+            IPolicy.PolicyInfo memory policyInfo
+        ) = _getAndVerifyCallerForPolicy(policyNftId);
+
+        if (policyInfo.activatedAt.eqz()) {
+            revert ErrorPolicyServicePolicyNotActivated(policyNftId);
+        }
+
+        if (newActivateAt < TimestampLib.blockTimestamp()) {
+            revert ErrorPolicyServicePolicyActivationTooEarly(policyNftId, TimestampLib.blockTimestamp(), newActivateAt);
+        }
+
+        if (newActivateAt > policyInfo.expiredAt) {
+            revert ErrorPolicyServicePolicyActivationTooLate(policyNftId, policyInfo.expiredAt, newActivateAt);
+        }
+
+        // effects
+        policyInfo.activatedAt = newActivateAt;
+        instance.getInstanceStore().updatePolicy(policyNftId, policyInfo, KEEP_STATE());
+
+        // log policy activation before interactions with policy holder
+        emit LogPolicyServicePolicyActivatedUpdated(policyNftId, newActivateAt);
+
+        // interactions
+        // callback to policy holder if applicable
+        _policyHolderPolicyActivated(policyNftId, newActivateAt);
+    }
+
 
     /// @inheritdoc IPolicyService
     function expire(
@@ -333,7 +379,7 @@ contract PolicyService is
         InstanceReader instanceReader = instance.getInstanceReader();
 
         // check policy is in a closeable state
-        if (!policyIsCloseable(instanceReader, policyNftId)) {
+        if (!PolicyServiceLib.policyIsCloseable(instanceReader, policyNftId)) {
             revert ErrorPolicyServicePolicyNotCloseable(policyNftId);
         }
 
@@ -349,7 +395,6 @@ contract PolicyService is
         // release (remaining) collateral that was blocked by policy
         _poolService.releaseCollateral(
             instance, 
-            address(instanceReader.getComponentInfo(productNftId).token),
             policyNftId, 
             policyInfo);
 
@@ -360,40 +405,13 @@ contract PolicyService is
         instance.getInstanceStore().updatePolicy(policyNftId, policyInfo, CLOSED());
 
         // unlink policy from risk and bundle
-        NftId poolNftId = getRegistry().getObjectInfo(bundleNftId).parentNftId;
+        NftId poolNftId = getRegistry().getParentNftId(bundleNftId);
         instance.getRiskSet().unlinkPolicy(productNftId, riskId, policyNftId);
         instance.getBundleSet().unlinkPolicy(poolNftId, bundleNftId, policyNftId);
 
         emit LogPolicyServicePolicyClosed(policyNftId);
     }
 
-
-    function policyIsCloseable(InstanceReader instanceReader, NftId policyNftId)
-        public
-        view
-        returns (bool isCloseable)
-    {
-        // policy already closed
-        if (instanceReader.getPolicyState(policyNftId) == CLOSED()) {
-            return false;
-        }
-
-        IPolicy.PolicyInfo memory info = instanceReader.getPolicyInfo(policyNftId);
-        
-        if (info.productNftId.eqz()) { return false; } // not closeable: policy does not exist (or does not belong to this instance)
-        if (info.activatedAt.eqz()) { return false; } // not closeable: not yet activated
-        if (info.openClaimsCount > 0) { return false; } // not closeable: has open claims
-
-        // closeable: if sum of claims matches sum insured a policy may be closed prior to the expiry date
-        if (info.claimAmount == info.sumInsuredAmount) { return true; }
-
-        // not closeable: not yet expired
-        if (TimestampLib.blockTimestamp() < info.expiredAt) { return false; }
-
-        // all conditions to close the policy are met
-        return true; 
-    }
-
     /// @dev shared functionality for expire() and policyExpire().
     function _expire(
         IInstance instance,
@@ -402,67 +420,31 @@ contract PolicyService is
         Timestamp expireAt
     )
         internal
-        returns (Timestamp expiredAt)
+        returns (Timestamp)
     {
-        // checks
-        // check policy is active
-        StateId policyState = instance.getInstanceReader().getPolicyState(policyNftId);
-        if (!_policyHasBeenActivated(policyState, policyInfo)) {
-            revert ErrorPolicyServicePolicyNotActive(policyNftId, policyState);
-        }
-
-        // set return value to provided timestamp
-        expiredAt = expireAt;
-
-        // update expiredAt to current block timestamp if not set
-        if (expiredAt.eqz()) {
-            expiredAt = TimestampLib.blockTimestamp();
-        }
-
-        // check expiredAt represents a valid expiry time
-        if (expiredAt >= policyInfo.expiredAt) {
-            revert ErrorPolicyServicePolicyExpirationTooLate(policyNftId, policyInfo.expiredAt, expireAt);
-        }
-
-        if (expiredAt < TimestampLib.blockTimestamp()) {
-            revert ErrorPolicyServicePolicyExpirationTooEarly(policyNftId, TimestampLib.blockTimestamp(), expireAt);
-        }
+        PolicyServiceLib.checkExpiration(
+            expireAt,
+            policyNftId,
+            instance.getInstanceReader().getPolicyState(policyNftId),
+            policyInfo);
 
         // effects
         // update policyInfo with new expiredAt timestamp
-        Timestamp originalExpiredAt = policyInfo.expiredAt;
-        policyInfo.expiredAt = expiredAt;
+        if (expireAt.gtz()) {
+            policyInfo.expiredAt = expireAt;
+        } else {
+            policyInfo.expiredAt = TimestampLib.blockTimestamp();
+        }
         instance.getInstanceStore().updatePolicy(policyNftId, policyInfo, KEEP_STATE());
 
-        emit LogPolicyServicePolicyExpirationUpdated(policyNftId, originalExpiredAt, expiredAt);
+        emit LogPolicyServicePolicyExpirationUpdated(policyNftId, policyInfo.expiredAt);
 
         // interactions
         // callback to policy holder if applicable
-        _policyHolderPolicyExpired(policyNftId, expiredAt);
+        _policyHolderPolicyExpired(policyNftId, policyInfo.expiredAt);
+        return policyInfo.expiredAt;
     }
 
-    // TODO cleanup
-    // /// @dev Calculates the premium and updates all counters in the other services.
-    // /// Only book keeping, no token transfers.
-    // function _processPremium(
-    //     IInstance instance,
-    //     NftId applicationNftId,
-    //     IPolicy.PolicyInfo memory applicationInfo,
-    //     IPolicy.PremiumInfo memory premium
-    // )
-    //     internal
-    //     virtual
-    // {
-    //     // update the counters
-    //     _processSale(
-    //         instanceReader, 
-    //         instance.getInstanceStore(), 
-    //         productNftId, 
-    //         applicationInfo.bundleNftId, 
-    //         applicationInfo.referralId, 
-    //         premium);
-    // }
-
 
     function _activate(
         NftId policyNftId, 
@@ -528,7 +510,7 @@ contract PolicyService is
 
 
     /// @dev transfer the premium to the wallets the premium is distributed to
-    function _transferFunds(
+    function _transferPremiumAmounts(
         InstanceReader instanceReader,
         NftId policyNftId,
         NftId productNftId,
@@ -537,7 +519,6 @@ contract PolicyService is
         internal
         virtual
     {
-        TokenHandler tokenHandler = _getTokenHandler(instanceReader, productNftId);
         address policyHolder = getRegistry().ownerOf(policyNftId);
 
         (
@@ -549,14 +530,19 @@ contract PolicyService is
             instanceReader, 
             productNftId);
 
-        tokenHandler.collectTokensToThreeRecipients(
-            policyHolder,
-            productWallet,
-            premium.productFeeAmount,
-            distributionWallet,
-            premium.distributionFeeAndCommissionAmount,
-            poolWallet,
-            premium.poolPremiumAndFeeAmount);
+        // step 1: collect premium amount from policy holder
+        TokenHandler tokenHandler = instanceReader.getTokenHandler(productNftId);
+        tokenHandler.pullToken(policyHolder, premium.premiumAmount);
+
+        // step 2: push distribution fee to distribution wallet
+        if (premium.distributionFeeAndCommissionAmount.gtz()) {
+            tokenHandler.pushToken(distributionWallet, premium.distributionFeeAndCommissionAmount);
+        }
+
+        // step 3: push pool fee, bundle fee and pool premium to pool wallet
+        if (premium.poolPremiumAndFeeAmount.gtz()) {
+            tokenHandler.pushToken(poolWallet, premium.poolPremiumAndFeeAmount);
+        }
     }
 
 
@@ -576,31 +562,6 @@ contract PolicyService is
     }
 
 
-    /// @dev checks the balance and allowance of the policy holder
-    function _checkPremiumBalanceAndAllowance(
-        IERC20Metadata token,
-        address tokenHandlerAddress, 
-        address policyHolder, 
-        Amount premiumAmount
-    )
-        internal
-        virtual
-        view
-    {
-        uint256 premium = premiumAmount.toInt();
-        uint256 balance = token.balanceOf(policyHolder);
-        uint256 allowance = token.allowance(policyHolder, tokenHandlerAddress);
-    
-        if (balance < premium) {
-            revert ErrorPolicyServiceBalanceInsufficient(policyHolder, premium, balance);
-        }
-
-        if (allowance < premium) {
-            revert ErrorPolicyServiceAllowanceInsufficient(policyHolder, tokenHandlerAddress, premium, allowance);
-        }
-    }
-
-
     function _policyHolderPolicyActivated(
         NftId policyNftId,
         Timestamp activateAt
@@ -659,21 +620,6 @@ contract PolicyService is
     }
 
 
-    function _getTokenHandler(
-        InstanceReader instanceReader,
-        NftId productNftId
-    )
-        internal 
-        virtual
-        view 
-        returns (
-            TokenHandler tokenHandler
-        )
-    {
-        tokenHandler = instanceReader.getComponentInfo(productNftId).tokenHandler;
-    }
-
-
     function _getDistributionNftAndWallets(
         InstanceReader instanceReader,
         NftId productNftId
@@ -717,7 +663,7 @@ contract PolicyService is
             PRODUCT(), // caller must be product
             true); // only active caller
 
-        productNftId = productInfo.nftId;
+        productNftId = productInfo.nftId; // calling product nft id
         instance = IInstance(instanceAddress);
         policyInfo = instance.getInstanceReader().getPolicyInfo(policyNftId);
 

package/contracts/product/PolicyServiceLib.sol

@@ -0,0 +1,65 @@
+// SPDX-License-Identifier: Apache-2.0
+pragma solidity ^0.8.20;
+
+import {InstanceReader} from "../instance/InstanceReader.sol";
+import {IPolicy} from "../instance/module/IPolicy.sol";
+import {IPolicyService} from "../product/IPolicyService.sol";
+import {NftId} from "../type/NftId.sol";
+import {StateId, CLOSED, COLLATERALIZED} from "../type/StateId.sol";
+import {Timestamp, TimestampLib} from "../type/Timestamp.sol";
+
+library PolicyServiceLib {
+
+    function checkExpiration(
+        Timestamp newExpiredAt,
+        NftId policyNftId,
+        StateId policyState,
+        IPolicy.PolicyInfo memory policyInfo
+    )
+        external 
+        view
+    {
+        if (policyState != COLLATERALIZED()) { 
+            revert IPolicyService.ErrorPolicyServicePolicyNotActive(policyNftId, policyState);
+        } 
+        if (TimestampLib.blockTimestamp() < policyInfo.activatedAt) { 
+            revert IPolicyService.ErrorPolicyServicePolicyNotActive(policyNftId, policyState);
+        } 
+
+        // check expiredAt represents a valid expiry time
+        if (newExpiredAt >= policyInfo.expiredAt) {
+            revert IPolicyService.ErrorPolicyServicePolicyExpirationTooLate(policyNftId, policyInfo.expiredAt, newExpiredAt);
+        }
+
+        if (newExpiredAt.gtz() && newExpiredAt < TimestampLib.blockTimestamp()) {
+            revert IPolicyService.ErrorPolicyServicePolicyExpirationTooEarly(policyNftId, TimestampLib.blockTimestamp(), newExpiredAt);
+        }
+    }
+
+    function policyIsCloseable(InstanceReader instanceReader, NftId policyNftId)
+        external 
+        view
+        returns (bool isCloseable)
+    {
+        // policy already closed
+        if (instanceReader.getPolicyState(policyNftId) == CLOSED()) {
+            return false;
+        }
+
+        IPolicy.PolicyInfo memory info = instanceReader.getPolicyInfo(policyNftId);
+        
+        if (info.productNftId.eqz()) { return false; } // not closeable: policy does not exist (or does not belong to this instance)
+        if (info.activatedAt.eqz()) { return false; } // not closeable: not yet activated
+        if (info.openClaimsCount > 0) { return false; } // not closeable: has open claims
+
+        // closeable: if sum of claims matches sum insured a policy may be closed prior to the expiry date
+        if (info.claimAmount == info.sumInsuredAmount) { return true; }
+
+        // not closeable: not yet expired
+        if (TimestampLib.blockTimestamp() < info.expiredAt) { return false; }
+
+        // all conditions to close the policy are met
+        return true; 
+    }
+
+}

package/contracts/product/PolicyServiceManager.sol

@@ -17,7 +17,7 @@ contract PolicyServiceManager is ProxyManager {
     ) 
     {
         PolicyService svc = new PolicyService{salt: salt}();
-        bytes memory data = abi.encode(registry, authority);
+        bytes memory data = abi.encode(authority, registry);
         IVersionable versionable = initialize(
             registry,
             address(svc), 

package/contracts/product/PricingService.sol

@@ -42,14 +42,15 @@ contract PricingService is
         initializer()
     {
         (
-            address registryAddress, 
-            address authority
+            address authority,
+            address registry
         ) = abi.decode(data, (address, address));
 
-        _initializeService(registryAddress, authority, owner);
-        _registerInterface(type(IPricingService).interfaceId);
+        __Service_init(authority, registry, owner);
 
         _distributionService = IDistributionService(_getServiceAddress(DISTRIBUTION()));
+
+        _registerInterface(type(IPricingService).interfaceId);
     }
 
     /// @dev calculates the premium amount for the specified attributes
@@ -98,6 +99,7 @@ contract PricingService is
         {
             // get configurations for all involed objects
             IComponents.ProductInfo memory productInfo = reader.getProductInfo(productNftId);
+            IComponents.FeeInfo memory feeInfo = reader.getFeeInfo(productNftId);
 
             IBundle.BundleInfo memory bundleInfo = reader.getBundleInfo(bundleNftId);
             if(bundleInfo.poolNftId != productInfo.poolNftId) {
@@ -107,21 +109,22 @@ contract PricingService is
             // calculate fixed fees for product, pool, bundle
             premium = _getFixedFeeAmounts(
                 netPremiumAmount,
-                productInfo,
+                feeInfo,
                 bundleInfo
             );
 
             // calculate variable fees for product, pool, bundle
             premium = _calculateVariableFeeAmounts(
                 premium,
-                productInfo,
+                feeInfo,
                 bundleInfo
             );
 
             // calculate distribution fee and (if applicable) commission
             premium = _calculateDistributionOwnerFeeAmount(
                 premium,
-                productInfo,
+                feeInfo,
+                productInfo.distributionNftId,
                 referralId,
                 reader
             );
@@ -137,7 +140,7 @@ contract PricingService is
                 revert ErrorPricingServiceTargetWalletAmountsMismatch();
             }
 
-            if (premium.distributionOwnerFeeFixAmount.toInt() < productInfo.minDistributionOwnerFee.fixedFee) {
+            if (premium.distributionOwnerFeeFixAmount.toInt() < feeInfo.minDistributionOwnerFee.fixedFee) {
                 revert ErrorPricingServiceFeeCalculationMismatch( 
                     premium.distributionFeeFixAmount,
                     premium.distributionFeeVarAmount,
@@ -164,7 +167,7 @@ contract PricingService is
     // internal functions
     function _getFixedFeeAmounts(
         Amount netPremiumAmount,
-        IComponents.ProductInfo memory productInfo,
+        IComponents.FeeInfo memory feeInfo,
         IBundle.BundleInfo memory bundleInfo
     )
         internal
@@ -177,11 +180,11 @@ contract PricingService is
         premium.netPremiumAmount = netPremiumAmount;
         premium.fullPremiumAmount = netPremiumAmount;
 
-        Amount t = AmountLib.toAmount(productInfo.productFee.fixedFee);
+        Amount t = AmountLib.toAmount(feeInfo.productFee.fixedFee);
         premium.productFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
-        t = AmountLib.toAmount(productInfo.poolFee.fixedFee);
+        t = AmountLib.toAmount(feeInfo.poolFee.fixedFee);
         premium.poolFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
@@ -189,14 +192,14 @@ contract PricingService is
         premium.bundleFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
-        t = AmountLib.toAmount(productInfo.distributionFee.fixedFee);
+        t = AmountLib.toAmount(feeInfo.distributionFee.fixedFee);
         premium.distributionFeeFixAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
     }
 
     function _calculateVariableFeeAmounts(
         IPolicy.PremiumInfo memory premium,
-        IComponents.ProductInfo memory productInfo,
+        IComponents.FeeInfo memory feeInfo,
         IBundle.BundleInfo memory bundleInfo
     )
         internal
@@ -207,11 +210,11 @@ contract PricingService is
     {
         Amount netPremiumAmount = premium.netPremiumAmount;
 
-        Amount t = netPremiumAmount.multiplyWith(productInfo.productFee.fractionalFee);
+        Amount t = netPremiumAmount.multiplyWith(feeInfo.productFee.fractionalFee);
         premium.productFeeVarAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
-        t = netPremiumAmount.multiplyWith(productInfo.poolFee.fractionalFee);
+        t = netPremiumAmount.multiplyWith(feeInfo.poolFee.fractionalFee);
         premium.poolFeeVarAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
@@ -219,7 +222,7 @@ contract PricingService is
         premium.bundleFeeVarAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
-        t = netPremiumAmount.multiplyWith(productInfo.distributionFee.fractionalFee);
+        t = netPremiumAmount.multiplyWith(feeInfo.distributionFee.fractionalFee);
         premium.distributionFeeVarAmount = t;
         premium.fullPremiumAmount = premium.fullPremiumAmount + t;
 
@@ -228,7 +231,8 @@ contract PricingService is
 
     function _calculateDistributionOwnerFeeAmount(
         IPolicy.PremiumInfo memory premium,
-        IComponents.ProductInfo memory productInfo,
+        IComponents.FeeInfo memory feeInfo,
+        NftId distributionNftId,
         // ISetup.DistributionSetupInfo memory distInfo,
         ReferralId referralId,
         InstanceReader reader
@@ -239,14 +243,14 @@ contract PricingService is
     {
 
         // if the referral is not valid, then the distribution owner gets everything
-        if (productInfo.distributionNftId.eqz() || ! _distributionService.referralIsValid(productInfo.distributionNftId, referralId)) {
+        if (distributionNftId.eqz() || ! _distributionService.referralIsValid(distributionNftId, referralId)) {
             premium.distributionOwnerFeeFixAmount = premium.distributionFeeFixAmount;
             premium.distributionOwnerFeeVarAmount = premium.distributionFeeVarAmount;
             premium.premiumAmount = premium.fullPremiumAmount;
             return premium;
         }
 
-        Fee memory minDistributionOwnerFee = productInfo.minDistributionOwnerFee;
+        Fee memory minDistributionOwnerFee = feeInfo.minDistributionOwnerFee;
 
         // if the referral is valid, the the commission and discount are calculated based in the full premium
         // the remaing amount goes to the distribution owner

package/contracts/product/PricingServiceManager.sol

@@ -12,14 +12,14 @@ contract PricingServiceManager is ProxyManager {
     /// @dev initializes proxy manager with pricing service implementation and deploys instance
     constructor(
         address authority, 
-        address registryAddress,
+        address registry,
         bytes32 salt
     )
     {
         PricingService pricingSrv = new PricingService{salt: salt}();
-        bytes memory data = abi.encode(registryAddress, authority);
+        bytes memory data = abi.encode(authority, registry);
         IVersionable versionable = initialize(
-            registryAddress,
+            registry,
             address(pricingSrv), 
             data,
             salt);