@etherisc/gif-next 0.0.2-91b514c-961 → 0.0.2-9272c43-568

package/contracts/pool/PoolService.sol

@@ -2,13 +2,11 @@
 pragma solidity ^0.8.20;
 
 import {IAccountingService} from "../accounting/IAccountingService.sol";
-import {IBundle} from "../instance/module/IBundle.sol";
 import {IBundleService} from "./IBundleService.sol";
 import {IComponents} from "../instance/module/IComponents.sol";
 import {IComponentService} from "../shared/IComponentService.sol";
 import {IInstance} from "../instance/IInstance.sol";
 import {IPolicy} from "../instance/module/IPolicy.sol";
-import {IPolicyHolder} from "../shared/IPolicyHolder.sol";
 import {IPoolComponent} from "../pool/IPoolComponent.sol";
 import {IPoolService} from "./IPoolService.sol";
 import {IProductComponent} from "../product/IProductComponent.sol";
@@ -27,9 +25,6 @@ import {PayoutId} from "../type/PayoutId.sol";
 import {PoolLib} from "./PoolLib.sol";
 import {Service} from "../shared/Service.sol";
 import {TokenHandler} from "../shared/TokenHandler.sol";
-import {UFixed} from "../type/UFixed.sol";
-
-string constant POOL_SERVICE_NAME = "PoolService";
 
 
 contract PoolService is 
@@ -69,6 +64,7 @@ contract PoolService is
     function setMaxBalanceAmount(Amount maxBalanceAmount)
         external
         virtual
+        restricted()
     {
         (NftId poolNftId, IInstance instance) = _getAndVerifyActivePool();
         InstanceReader instanceReader = instance.getInstanceReader();
@@ -84,6 +80,7 @@ contract PoolService is
 
     function closeBundle(NftId bundleNftId)
         external
+        restricted()
         virtual
     {
         _checkNftType(bundleNftId, BUNDLE());
@@ -119,6 +116,7 @@ contract PoolService is
         Amount availableAmount
     ) 
         external
+        restricted()
         virtual
     {
         _checkNftType(policyNftId, POLICY());
@@ -175,7 +173,7 @@ contract PoolService is
     function stake(NftId bundleNftId, Amount amount) 
         external 
         virtual
-        // TODO: restricted() (once #462 is done)
+        restricted()
         returns(
             Amount netAmount
         ) 
@@ -222,7 +220,7 @@ contract PoolService is
 
             // collect tokens from bundle owner
             address bundleOwner = getRegistry().ownerOf(bundleNftId);
-            _pullStakingAmount(
+            PoolLib.pullStakingAmount(
                 instanceReader,
                 poolNftId, 
                 bundleOwner, 
@@ -235,7 +233,7 @@ contract PoolService is
     function unstake(NftId bundleNftId, Amount amount) 
         external 
         virtual
-        // TODO: restricted() (once #462 is done)
+        restricted()
         returns(Amount netAmount) 
     {
         (
@@ -269,7 +267,7 @@ contract PoolService is
 
             // transfer amount to bundle owner
             address bundleOwner = getRegistry().ownerOf(bundleNftId);
-            _pushUnstakingAmount(
+            PoolLib.pushUnstakingAmount(
                 instanceReader,
                 poolNftId, 
                 bundleOwner, 
@@ -281,7 +279,7 @@ contract PoolService is
     function fundPoolWallet(Amount amount)
         external
         virtual
-        // restricted()
+        restricted()
     {
         (
             NftId poolNftId,
@@ -297,7 +295,7 @@ contract PoolService is
         address poolOwner = getRegistry().ownerOf(poolNftId);
         emit LogPoolServiceWalletFunded(poolNftId, poolOwner, amount);
 
-        _pullStakingAmount(
+        PoolLib.pullStakingAmount(
             reader,
             poolNftId, 
             poolOwner, 
@@ -308,7 +306,7 @@ contract PoolService is
     function defundPoolWallet(Amount amount)
         external
         virtual
-        // restricted()
+        restricted()
     {
         (
             NftId poolNftId,
@@ -324,7 +322,7 @@ contract PoolService is
         address poolOwner = getRegistry().ownerOf(poolNftId);
         emit LogPoolServiceWalletDefunded(poolNftId, poolOwner, amount);
 
-        _pushUnstakingAmount(
+        PoolLib.pushUnstakingAmount(
             reader,
             poolNftId, 
             poolOwner, 
@@ -474,7 +472,8 @@ contract PoolService is
             payoutAmount);
 
         // interactions
-        _transferTokenAndNotifyPolicyHolder(
+        PoolLib.transferTokenAndNotifyPolicyHolder(
+            getRegistry(),
             instanceReader, 
             poolTokenHandler,
             productNftId, 
@@ -484,50 +483,6 @@ contract PoolService is
             payoutBeneficiary);
     }
 
-    function _transferTokenAndNotifyPolicyHolder(
-        InstanceReader instanceReader,
-        TokenHandler poolTokenHandler,
-        NftId productNftId,
-        NftId policyNftId,
-        PayoutId payoutId,
-        Amount payoutAmount,
-        address payoutBeneficiary
-    )
-        internal
-    {
-        (
-            Amount netPayoutAmount,
-            Amount processingFeeAmount,
-            address beneficiary
-        ) = PoolLib.calculatePayoutAmounts(
-            getRegistry(),
-            instanceReader,
-            productNftId, 
-            policyNftId,
-            payoutAmount,
-            payoutBeneficiary);
-
-        // 1st token tx to payout to beneficiary
-        poolTokenHandler.pushToken(
-            beneficiary, 
-            netPayoutAmount);
-
-        // 2nd token tx to transfer processing fees to product wallet
-        // if processingFeeAmount > 0
-        if (processingFeeAmount.gtz()) {
-            poolTokenHandler.pushToken(
-                instanceReader.getWallet(productNftId), 
-                processingFeeAmount);
-        }
-
-        // callback to policy holder if applicable
-        _policyHolderPayoutExecuted(
-            policyNftId, 
-            payoutId, 
-            beneficiary, 
-            netPayoutAmount);
-    }
-
 
     /// @inheritdoc IPoolService
     function withdrawBundleFees(
@@ -608,112 +563,6 @@ contract PoolService is
     }
 
 
-    // function calculateRequiredCollateral(
-    //     InstanceReader instanceReader,
-    //     NftId productNftId, 
-    //     Amount sumInsuredAmount
-    // )
-    //     public
-    //     view 
-    //     returns(
-    //         NftId poolNftId,
-    //         Amount totalCollateralAmount,
-    //         Amount localCollateralAmount,
-    //         bool poolIsVerifyingApplications
-    //     )
-    // {
-    //     return CollateralLib.calculateRequiredCollateral(
-    //         instanceReader,
-    //         productNftId, 
-    //         sumInsuredAmount);
-    // }
-
-    //     _checkNftType(productNftId, PRODUCT());
-
-    //     poolNftId = instanceReader.getProductInfo(productNftId).poolNftId;
-    //     IComponents.PoolInfo memory poolInfo = instanceReader.getPoolInfo(poolNftId);
-    //     poolIsVerifyingApplications = poolInfo.isVerifyingApplications;
-
-    //     (
-    //         totalCollateralAmount,
-    //         localCollateralAmount
-    //     ) = calculateRequiredCollateral(
-    //         poolInfo.collateralizationLevel,
-    //         poolInfo.retentionLevel,
-    //         sumInsuredAmount);
-    // }
-
-
-    // function calculateRequiredCollateral(
-    //     UFixed collateralizationLevel, 
-    //     UFixed retentionLevel, 
-    //     Amount sumInsuredAmount
-    // )
-    //     public
-    //     pure 
-    //     returns(
-    //         Amount totalCollateralAmount,
-    //         Amount localCollateralAmount
-    //     )
-    // {
-    //     // collateralization is applied to sum insured
-    //     UFixed totalUFixed = collateralizationLevel * sumInsuredAmount.toUFixed();
-    //     totalCollateralAmount = AmountLib.toAmount(totalUFixed.toInt());
-
-    //     // retention level defines how much capital is required locally
-    //     localCollateralAmount = AmountLib.toAmount(
-    //         (retentionLevel * totalUFixed).toInt());
-    // }
-
-
-
-
-    function _policyHolderPayoutExecuted(
-        NftId policyNftId, 
-        PayoutId payoutId,
-        address beneficiary,
-        Amount payoutAmount
-    )
-        internal
-    {
-        IPolicyHolder policyHolder = PoolLib.getPolicyHolder(getRegistry(), policyNftId);
-        if(address(policyHolder) != address(0)) {
-            policyHolder.payoutExecuted(policyNftId, payoutId, payoutAmount, beneficiary);
-        }
-    }
-
-
-    /// @dev Transfers the specified amount from the "from account" to the pool's wallet
-    function _pullStakingAmount(
-        InstanceReader reader,
-        NftId poolNftId,
-        address from,
-        Amount amount
-    )
-        internal
-    {
-        IComponents.ComponentInfo memory info = reader.getComponentInfo(poolNftId);
-        info.tokenHandler.pullToken(
-            from,
-            amount);
-    }
-
-    /// @dev Transfers the specified amount from the pool's wallet to the "to account"
-    function _pushUnstakingAmount(
-        InstanceReader reader,
-        NftId poolNftId,
-        address to,
-        Amount amount
-    )
-        internal
-    {
-        IComponents.ComponentInfo memory info = reader.getComponentInfo(poolNftId);
-        info.tokenHandler.pushToken(
-            to, 
-            amount);
-    }
-
-
     function _getAndVerifyActivePool()
         internal
         virtual
@@ -726,28 +575,6 @@ contract PoolService is
         return PoolLib.getAndVerifyActivePool(getRegistry(), msg.sender);
     }
 
-    // function _getAndVerifyActivePool()
-    //     internal
-    //     virtual
-    //     view
-    //     returns (
-    //         NftId poolNftId,
-    //         IInstance instance
-    //     )
-    // {
-    //     (
-    //         IRegistry.ObjectInfo memory info, 
-    //         address instanceAddress
-    //     ) = ContractLib.getAndVerifyComponent(
-    //         getRegistry(), 
-    //         msg.sender,
-    //         POOL(),
-    //         true); // only active pools
-
-    //     poolNftId = info.nftId;
-    //     instance = IInstance(instanceAddress);
-    // }
-
 
     function _getDomain() internal pure override returns(ObjectType) {
         return POOL();

package/contracts/product/ApplicationService.sol

@@ -11,6 +11,7 @@ import {IPricingService} from "./IPricingService.sol";
 import {IRegistryService} from "../registry/IRegistryService.sol";
 
 import {AmountLib} from "../type/Amount.sol";
+import {ContractLib} from "../shared/ContractLib.sol";
 import {Seconds} from "../type/Seconds.sol";
 import {zeroTimestamp} from "../type/Timestamp.sol";
 import {ObjectType, BUNDLE, DISTRIBUTION, PRODUCT, REGISTRY, APPLICATION, POLICY, PRICE} from "../type/ObjectType.sol";
@@ -19,13 +20,12 @@ import {NftId, NftIdLib} from "../type/NftId.sol";
 import {ReferralId} from "../type/Referral.sol";
 import {RiskId} from "../type/RiskId.sol";
 import {Amount, AmountLib} from "../type/Amount.sol";
-import {ComponentVerifyingService} from "../shared/ComponentVerifyingService.sol";
+import {Service} from "../shared/Service.sol";
 import {InstanceReader} from "../instance/InstanceReader.sol";
 
 
-
 contract ApplicationService is 
-    ComponentVerifyingService, 
+    Service, 
     IApplicationService
 {
     IDistributionService private _distributionService;
@@ -149,12 +149,13 @@ contract ApplicationService is
     )
         external
         virtual
+        restricted()
         nonReentrant()
         returns (NftId applicationNftId)
     {
         _checkNftType(bundleNftId, BUNDLE());
 
-        (NftId productNftId,, IInstance instance) = _getAndVerifyActiveComponent(PRODUCT());
+        (NftId productNftId, IInstance instance) = _getAndVerifyActiveProduct();
 
         // check if provided references are valid and linked to calling product contract
         InstanceReader instanceReader = instance.getInstanceReader();
@@ -227,6 +228,7 @@ contract ApplicationService is
     )
         external
         virtual
+        restricted()
         nonReentrant()
         returns (NftId applicationNftId)
     {
@@ -247,6 +249,7 @@ contract ApplicationService is
     )
         external
         virtual
+        restricted()
         nonReentrant()
     {
         _checkNftType(applicationNftId, POLICY());
@@ -257,16 +260,38 @@ contract ApplicationService is
     function revoke(NftId applicationNftId)
         external
         virtual
+        restricted()
         nonReentrant()
     {
         _checkNftType(applicationNftId, POLICY());
 
-        (,, IInstance instance) = _getAndVerifyActiveComponent(PRODUCT());
+        (, IInstance instance) = _getAndVerifyActiveProduct();
         instance.getInstanceStore().updateApplicationState(applicationNftId, REVOKED());
     }
 
     // internal functions
 
+    function _getAndVerifyActiveProduct()
+        internal
+        view
+        returns (
+            NftId productNftId,
+            IInstance instance
+        )
+    {
+        (
+            IRegistry.ObjectInfo memory info, 
+            address instanceAddress
+        ) = ContractLib.getAndVerifyComponent(
+            getRegistry(), 
+            msg.sender,
+            PRODUCT(),
+            true); // only active pools
+
+        productNftId = info.nftId;
+        instance = IInstance(instanceAddress);
+    }
+
 
     function _getDomain() internal pure override returns(ObjectType) {
         return APPLICATION();

package/contracts/product/BasicProductAuthorization.sol

@@ -14,17 +14,22 @@ import {TokenHandler} from "../shared/TokenHandler.sol";
 contract BasicProductAuthorization
      is Authorization
 {
-
      constructor(string memory componentName)
-          Authorization(componentName, PRODUCT(), true, true)
+          Authorization(
+               componentName, 
+               PRODUCT(), 
+               3,
+               COMMIT_HASH,
+               true, 
+               true)
      {}
 
      function _setupServiceTargets()
           internal
           virtual override
      {
-          _addServiceTargetWithRole(COMPONENT());
-          _addServiceTargetWithRole(POLICY());
+          _authorizeServiceDomain(COMPONENT(), address(10));
+          _authorizeServiceDomain(POLICY(), address(11));
      }
 
      function _setupTokenHandlerAuthorizations() internal virtual override {

package/contracts/product/ClaimService.sol

@@ -2,7 +2,6 @@
 pragma solidity ^0.8.20;
 
 import {IClaimService} from "./IClaimService.sol";
-import {IComponents} from "../instance/module/IComponents.sol";
 import {IInstance} from "../instance/IInstance.sol";
 import {IPolicy} from "../instance/module/IPolicy.sol";
 import {IPolicyHolder} from "../shared/IPolicyHolder.sol";
@@ -14,11 +13,10 @@ import {IRegistry} from "../registry/IRegistry.sol";
 import {Amount, AmountLib} from "../type/Amount.sol";
 import {ClaimId, ClaimIdLib} from "../type/ClaimId.sol";
 import {ContractLib} from "../shared/ContractLib.sol";
-import {FeeLib} from "../type/Fee.sol";
 import {InstanceReader} from "../instance/InstanceReader.sol";
 import {InstanceStore} from "../instance/InstanceStore.sol";
 import {NftId} from "../type/NftId.sol";
-import {ObjectType, COMPONENT, CLAIM, POLICY, POOL, PRODUCT} from "../type/ObjectType.sol";
+import {ObjectType, CLAIM, POLICY, POOL, PRODUCT} from "../type/ObjectType.sol";
 import {PayoutId, PayoutIdLib} from "../type/PayoutId.sol";
 import {Service} from "../shared/Service.sol";
 import {StateId} from "../type/StateId.sol";
@@ -68,8 +66,7 @@ contract ClaimService is
     {
         // checks
         (
-            ,
-            IInstance instance,,
+            ,,,
             InstanceStore instanceStore,
             IPolicy.PolicyInfo memory policyInfo
         ) = _verifyCallerWithPolicy(policyNftId);
@@ -114,6 +111,7 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
         // nonReentrant() // prevents creating a reinsurance claim in a single tx
     {
         // checks
@@ -163,13 +161,13 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
         // nonReentrant() // prevents creating a reinsurance claim in a single tx
     {
         _checkNftType(policyNftId, POLICY());
 
         (
-            ,
-            IInstance instance,
+            ,,
             InstanceReader instanceReader,
             InstanceStore instanceStore,
             IPolicy.PolicyInfo memory policyInfo
@@ -195,11 +193,11 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
         // nonReentrant() // prevents creating a reinsurance claim in a single tx
     {        
         (
-            ,
-            IInstance instance,
+            ,,
             InstanceReader instanceReader,
             InstanceStore instanceStore,
             IPolicy.PolicyInfo memory policyInfo
@@ -224,16 +222,15 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
         // nonReentrant() // prevents creating a reinsurance claim in a single tx
     {
         _checkNftType(policyNftId, POLICY());
         
         (
-            ,
-            IInstance instance,
+            ,,
             InstanceReader instanceReader,
             InstanceStore instanceStore,
-            IPolicy.PolicyInfo memory policyInfo
         ) = _verifyCallerWithPolicy(policyNftId);
 
         // check/update claim info
@@ -270,6 +267,7 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
         // nonReentrant() // prevents creating a reinsurance claim in a single tx
         returns (PayoutId payoutId)
     {
@@ -294,6 +292,7 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
         // nonReentrant() // prevents creating a reinsurance payout in a single tx
         returns (PayoutId payoutId)
     {
@@ -314,12 +313,12 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
         // nonReentrant() // prevents creating a reinsurance payout in a single tx
     {
         // checks
         (
-            NftId productNftId,,
-            // IInstance instance,
+            ,,
             InstanceReader instanceReader,
             InstanceStore instanceStore,
             IPolicy.PolicyInfo memory policyInfo
@@ -351,7 +350,8 @@ contract ClaimService is
         Amount payoutAmount = payoutInfo.amount;
         {
             ClaimId claimId = payoutId.toClaimId();
-            IPolicy.ClaimInfo memory claimInfo = instanceReader.getClaimInfo(policyNftId, claimId);
+            // TODO cleanup
+            // IPolicy.ClaimInfo memory claimInfo = instanceReader.getClaimInfo(policyNftId, claimId);
             claimInfo.paidAmount = claimInfo.paidAmount.add(payoutAmount);
             claimInfo.openPayoutsCount -= 1;
 
@@ -392,14 +392,13 @@ contract ClaimService is
     )
         external
         virtual
+        restricted()
     {
         // checks
         (
-            ,
-            IInstance instance,
+            ,,
             InstanceReader instanceReader,
             InstanceStore instanceStore,
-            IPolicy.PolicyInfo memory policyInfo
         ) = _verifyCallerWithPolicy(policyNftId);
 
         StateId payoutState = instanceReader.getPayoutState(policyNftId, payoutId);
@@ -522,7 +521,7 @@ contract ClaimService is
             IPolicy.PolicyInfo memory policyInfo
         )
     {
-        (productNftId, instance) = _getAndVerifyActiveComponent(PRODUCT());
+        (productNftId, instance) = _getAndVerifyActiveProduct();
         instanceReader = instance.getInstanceReader();
         instanceStore = instance.getInstanceStore();
 
@@ -536,7 +535,7 @@ contract ClaimService is
     }
 
 
-    function _getAndVerifyActiveComponent(ObjectType expectedType) 
+    function _getAndVerifyActiveProduct() 
         internal 
         view 
         returns (

package/contracts/product/IPolicyService.sol

@@ -5,7 +5,6 @@ import {IService} from "../shared/IService.sol";
 
 import {Amount} from "../type/Amount.sol";
 import {IInstance} from "../instance/IInstance.sol";
-import {InstanceReader} from "../instance/InstanceReader.sol";
 import {NftId} from "../type/NftId.sol";
 import {StateId} from "../type/StateId.sol";
 import {Timestamp} from "../type/Timestamp.sol";