@etherisc/gif-next 0.0.2-743affe-003 → 0.0.2-7878646-744

package/contracts/registry/Registry.sol

@@ -12,7 +12,6 @@ import {Version, VersionPart, VersionLib} from "../types/Version.sol";
 import {ObjectType, PROTOCOL, REGISTRY, TOKEN, SERVICE, INSTANCE, STAKE, PRODUCT, DISTRIBUTION, ORACLE, POOL, POLICY, BUNDLE} from "../types/ObjectType.sol";
 import {ITransferInterceptor} from "./ITransferInterceptor.sol";
 
-import {IOwnable} from "../shared/IOwnable.sol";
 import {ERC165} from "../shared/ERC165.sol";
 
 
@@ -44,11 +43,10 @@ contract Registry is
     error InvalidTypesCombination(ObjectType objectType, ObjectType parentType);
 
     uint256 public constant MAJOR_VERSION_MIN = 3;
-    
+    address public constant NFT_LOCK_ADDRESS = address(0x1);
+    uint256 public constant REGISTRY_SERVICE_TOKEN_SEQUENCE_ID = 3;
     string public constant EMPTY_URI = "";
 
-    address constant public NFT_LOCK_ADDRESS = address(0x1);
-
     mapping(NftId nftId => ObjectInfo info) _info;
     mapping(address object => NftId nftId) _nftIdByAddress;
 
@@ -70,19 +68,6 @@ contract Registry is
     IChainNft _chainNft;
     ChainNft _chainNftInternal;
 
-    /// @dev will own protocol, global registry, registry and registry service nfts minted during creation
-    // TODO registry nft can be transfered while protocol, global registry and registry service nfts are not transferable
-    // TODO get owner from one place -> nft contract
-    address _protocolOwner;
-
-    /*
-    modifier onlyInitialOwner() {
-        if(
-            msg.sender != getOwner() ||
-            msg.sender != _info[_registryNftId].initialOwner) {
-            revert NotInitialOwner();
-        }
-    }*/
 
     modifier onlyOwner() {
         if(msg.sender != getOwner()) {
@@ -99,36 +84,29 @@ contract Registry is
         _;
     }
 
-    constructor(address protocolOwner, VersionPart majorVersion)
+    constructor(address registryOwner, VersionPart majorVersion)
     {
-        require(protocolOwner > address(0), "Registry: protocol owner is 0");
+        require(registryOwner > address(0), "Registry: registry owner is 0");
         require(majorVersion.toInt() == MAJOR_VERSION_MIN, "Registry: initial major version of registry service is not MAJOR_VERSION_MIN");
 
-        // TODO registry owner can change, while protocol is not?
-        _protocolOwner = protocolOwner;
-
         // deploy NFT 
         _chainNftInternal = new ChainNft(address(this));// adds 10kb to deployment size
         _chainNft = IChainNft(_chainNftInternal);
 
         // initial registry setup
         _registerProtocol();
-
-        _registerRegistry();
-
-        _registerRegistryService();
+        _registerRegistry(registryOwner);
+        _registerRegistryService(registryOwner);
 
         // set object parent relations
         _setupValidObjectParentCombinations();
 
         _registerInterface(type(IRegistry).interfaceId);
-        _registerInterface(type(IOwnable).interfaceId);
     }
 
-    /// @dev registry protects only from tampering existing records and invalid types pairs
-    // IMPORTANT: rare case when parentNftId is not registered and == next nftId -> technincally this is ZeroParentAddress error
-    // to catch this check parent address before minting !!!!
+    /// @dev registry protects only against tampering existing records, registering with invalid types pairs and 0 parent address
     // TODO service registration means its approval for some type?
+    // TODO registration of precompile addresses
     function register(ObjectInfo memory info)
         external
         onlyRegistryService
@@ -150,6 +128,7 @@ contract Registry is
 
         address interceptor = _getInterceptor(info.isInterceptor, info.objectAddress, parentInfo.isInterceptor, parentAddress);
 
+        // TODO does external call
         uint256 mintedTokenId = _chainNft.mint(
             info.initialOwner,
             interceptor,
@@ -179,33 +158,8 @@ contract Registry is
             _nftIdByAddress[contractAddress] = nftId;
 
             // special case
-            if(objectType == SERVICE())
-            {
-                (
-                    string memory serviceName,
-                    VersionPart majorVersion
-                ) = abi.decode(info.data, (string, VersionPart));
-                bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
-
-                // TODO MUST guarantee consistency of registerable.getVersion() and majorVersion here
-                // TODO update _serviceNftId when registryService with new major version is registered? -> it is fixed in current setup
-                // TODO do not use names -> each object type is registered by corresponding service -> conflicting with approve()
-                if(
-                    majorVersion.toInt() < MAJOR_VERSION_MIN ||
-                    (majorVersion.toInt() > MAJOR_VERSION_MIN &&
-                    _service[serviceNameHash][VersionLib.toVersionPart(majorVersion.toInt() - 1)] == address(0) )
-                ) {
-                    revert InvalidServiceVersion(majorVersion);
-                }
-                
-                if(_service[serviceNameHash][majorVersion] != address(0)) {
-                    revert ServiceNameAlreadyRegistered(serviceName, majorVersion);
-                }
-
-                _string[nftId] = serviceName;
-                _service[serviceNameHash][majorVersion] = contractAddress;
-
-                emit LogServiceNameRegistration(serviceName, majorVersion); 
+            if(objectType == SERVICE()) {
+                _registerService(info);
             }
         }
         else
@@ -215,67 +169,7 @@ contract Registry is
             }
         }
 
-        emit LogRegistration(nftId, info.parentNftId, info.objectType, info.objectAddress, info.initialOwner);
-    }
-
-    function registerFrom(
-        address from, 
-        ObjectInfo memory info
-    ) external returns (NftId nftId) 
-    {
-        revert();
-    }
-    
-
-    /// @dev 
-    // msg.sender - registry owner 
-    //     CAN approve only registered service contract
-    //     CAN approve any combination specified in _isValidCombination
-    //     CAN NOT approve itself
-    // TODO in case where exists exactly one registered service per objectType (and major version):
-    // - registration and approve is a single operation, no need for separate approve() function
-    // - then approve can be used to adding new valid object-parent combinations???
-    function approve(
-        NftId serviceNftId,
-        ObjectType objectType,
-        ObjectType parentType 
-    ) 
-        public
-        onlyOwner()
-    {
-        address serviceAddress = _info[serviceNftId].objectAddress;
-            
-        if(_nftIdByAddress[serviceAddress].eqz()) {
-            revert NotRegisteredContract(serviceNftId);
-        }
-
-        if(_info[serviceNftId].objectType != SERVICE()) {
-            revert NotService(serviceNftId);
-        }
-
-        if(
-            _isValidContractCombination[objectType][parentType] == false &&
-            _isValidObjectCombination[objectType][parentType] == false) {
-            revert InvalidTypesCombination(objectType, parentType);
-        }
-
-        _isApproved[serviceNftId][objectType] = true;
-
-        emit LogApproval(serviceNftId, objectType);
-    }
-
-    /// @dev returns false for registry owner nft
-    // TODO allowance by address?
-    // TODO checked by registry service -> but registry owner can upgrade registry service not to check allowance....
-    function allowance(
-        NftId nftId,
-        ObjectType object
-    ) 
-        public
-        view 
-        returns (bool)
-    {
-        return _isApproved[nftId][object];
+        emit LogRegistration(info);
     }
 
     // from IRegistry
@@ -328,20 +222,73 @@ contract Registry is
         return _service[serviceNameHash][majorVersion];
     }
 
-    function getProtocolOwner() external view override returns (address) {
-        return _protocolOwner;
-    }
-
     function getChainNft() external view override returns (IChainNft) {
         return _chainNft;
     }
 
-    // from IOwnable
     function getOwner() public view returns (address owner) {
         return ownerOf(address(this));
     }
 
-    // Internals, called only in constructor
+    // Internals
+
+    function _registerService(ObjectInfo memory info)
+        internal
+    {
+        (
+            string memory serviceName,
+            VersionPart majorVersion
+        ) = abi.decode(info.data, (string, VersionPart));
+        bytes32 serviceNameHash = keccak256(abi.encode(serviceName));
+
+        // TODO MUST guarantee consistency of service.getVersion() and majorVersion here
+        // TODO update _serviceNftId when registryService with new major version is registered? -> it is fixed in current setup -> can lock up
+        // TODO do not use names -> each object type is registered by corresponding service -> conflicting with approve()
+        if(
+            majorVersion.toInt() < MAJOR_VERSION_MIN ||
+            (majorVersion.toInt() > MAJOR_VERSION_MIN &&
+            _service[serviceNameHash][VersionLib.toVersionPart(majorVersion.toInt() - 1)] == address(0) )
+        ) {
+            revert InvalidServiceVersion(majorVersion);
+        }
+        
+        if(_service[serviceNameHash][majorVersion] != address(0)) {
+            revert ServiceNameAlreadyRegistered(serviceName, majorVersion);
+        }
+
+        _string[info.nftId] = serviceName;
+        _service[serviceNameHash][majorVersion] = info.objectAddress;
+
+        emit LogServiceNameRegistration(serviceName, majorVersion); 
+    }
+
+    /// @dev obtain interceptor address for this nft if applicable, address(0) otherwise
+    function _getInterceptor(
+        bool isInterceptor, 
+        address objectAddress,
+        bool parentIsInterceptor,
+        address parentObjectAddress
+    )
+        internal 
+        view 
+        returns (address interceptor) 
+    {
+        if (objectAddress == address(0)) {
+            if (parentIsInterceptor) {
+                return parentObjectAddress;
+            } else {
+                return address(0);
+            }
+        }
+
+        if (isInterceptor) {
+            return objectAddress;
+        }
+
+        return address(0);
+    }
+
+    // Internals called only in constructor
 
     /// @dev protocol registration used to anchor the dip ecosystem relations
     function _registerProtocol() 
@@ -365,7 +312,7 @@ contract Registry is
 
     /// @dev registry registration
     /// might also register the global registry when not on mainnet
-    function _registerRegistry() 
+    function _registerRegistry(address registryOwner) 
         internal
     {
         uint256 registryId = _chainNftInternal.calculateTokenId(2);
@@ -383,7 +330,7 @@ contract Registry is
             parentNftId = toNftId(_chainNftInternal.PROTOCOL_NFT_ID());
         }
 
-        _chainNftInternal.mint(_protocolOwner, registryId);
+        _chainNftInternal.mint(registryOwner, registryId);
 
         _info[registryNftId] = ObjectInfo(
             registryNftId,
@@ -391,7 +338,7 @@ contract Registry is
             REGISTRY(),
             false, // isInterceptor
             address(this), 
-            _protocolOwner,
+            registryOwner,
             "" 
         );
         _nftIdByAddress[address(this)] = registryNftId;
@@ -420,13 +367,13 @@ contract Registry is
         );
     }
 
-    function _registerRegistryService()
+    function _registerRegistryService(address registryOwner)
         internal
     {
-        uint256 serviceId = _chainNftInternal.calculateTokenId(3);
+        uint256 serviceId = _chainNftInternal.calculateTokenId(REGISTRY_SERVICE_TOKEN_SEQUENCE_ID);
         NftId serviceNftId = toNftId(serviceId);        
 
-        _chainNftInternal.mint(NFT_LOCK_ADDRESS, serviceId);
+        _chainNftInternal.mint(registryOwner, serviceId);
 
         _info[serviceNftId] = ObjectInfo(
             serviceNftId,
@@ -434,7 +381,7 @@ contract Registry is
             SERVICE(),
             false, // isInterceptor
             msg.sender, // service deploys registry
-            NFT_LOCK_ADDRESS, // initialOwner,
+            registryOwner, // initialOwner,
             "" 
         );
 
@@ -447,32 +394,6 @@ contract Registry is
         _serviceNftId = serviceNftId;
     }
 
-    /// @dev obtain interceptor address for this nft if applicable, address(0) otherwise
-    function _getInterceptor(
-        bool isInterceptor, 
-        address objectAddress,
-        bool parentIsInterceptor,
-        address parentObjectAddress
-    )
-        internal 
-        view 
-        returns (address interceptor) 
-    {
-        if (objectAddress == address(0)) {
-            if (parentIsInterceptor) {
-                return parentObjectAddress;
-            } else {
-                return address(0);
-            }
-        }
-
-        if (isInterceptor) {
-            return objectAddress;
-        }
-
-        return address(0);
-    }
-
     /// @dev defines which object - parent types relations are allowed to register
     // IMPORTANT: 
     // 1) EACH object type MUST have only one parent type across ALL mappings