@ethberry/eslint-config 5.0.8 → 6.0.3

package/.github/workflows/manual.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       # BEGIN INSTALL
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: Install Packages npm i
         run: npm i
@@ -36,7 +36,7 @@ jobs:
       - name: Version by NPM
         run: npm version patch -m "[Manual release] [skip ci] %s"
 
-      - uses: JS-DevTools/npm-publish@v3
+      - uses: JS-DevTools/npm-publish@v4
         with:
           token: ${{ secrets.GITHUBTOKEN }}
           registry: "https://npm.pkg.github.com"
@@ -59,7 +59,7 @@ jobs:
       - name: Authenticate check via npm NPM
         run: npm whoami --registry=https://registry.npmjs.org/
 
-      - uses: JS-DevTools/npm-publish@v3
+      - uses: JS-DevTools/npm-publish@v4
         with:
           registry: "https://registry.npmjs.org"
           token: ${{ secrets.NPM_TOKEN }}

package/README.md

@@ -2,14 +2,47 @@
 
 This is sharable ESLint config which we use across of all our repositories. It is amazing.
 
+### Requirements
+
+- **ESLint 10** and **Node.js** [supported by ESLint 10](https://eslint.org/docs/latest/use/migrate-to-10.0.0#nodejs--v2019-v21-v23-are-no-longer-supported) (this package declares `engines.node` `>=22.13.0`).
+- **Flat config only** — `.eslintrc` / `ESLINT_USE_FLAT_CONFIG=false` are not supported in ESLint 10.
+
+### Prettier at lint time
+
+Presets include [`eslint-plugin-prettier`](https://github.com/prettier/eslint-plugin-prettier) (`prettier/prettier` as `error`) plus [`eslint-config-prettier`](https://github.com/prettier/eslint-config-prettier) so formatting rules do not fight Prettier. Run **`eslint --fix`** (this repo’s `npm run lint`) to apply Prettier’s output. Add a [Prettier config](https://prettier.io/docs/configuration) in consuming projects when you need options beyond defaults.
+
+### ESLint 10 notes for consumers
+
+- **Config lookup** starts from each **linted file’s directory** and walks up (not from the current working directory). In monorepos, put an `eslint.config.*` in each package or pass `--config` explicitly when needed.
+- **`eslint:recommended`** enables [`no-unassigned-vars`](https://eslint.org/docs/latest/rules/no-unassigned-vars), [`no-useless-assignment`](https://eslint.org/docs/latest/rules/no-useless-assignment), and [`preserve-caught-error`](https://eslint.org/docs/latest/rules/preserve-caught-error). Fix new findings or turn rules off in your overlay config if you need stricter control.
+- Remove **`/* eslint-env … */`** comments; ESLint 10 reports them as errors. Use `languageOptions.globals` (e.g. from the [`globals`](https://www.npmjs.com/package/globals) package) instead.
+- **Type-checked TypeScript** (`recommendedTypeChecked` in this preset): merge a block that sets parser options, for example:
+
+```js
+import {defineConfig} from "eslint/config";
+import typescriptRules from "./presets/ts.mjs"; // or your path to this preset
+
+export default defineConfig([
+  ...typescriptRules,
+  {
+    files: ["**/*.{ts,mts,tsx,mtsx}"],
+    languageOptions: {
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+  },
+]);
+```
+
 ### Usage
 
 eslint.config.mjs
 
 ```js
+import {defineConfig} from "eslint/config";
 import typescriptRules from "./presets/tsx.mjs";
 
-export default [
-  ...typescriptRules,
-];
+export default defineConfig([...typescriptRules]);
 ```

package/package.json

@@ -8,26 +8,26 @@
     "url": "https://github.com/ethberry/eslint-config/issues"
   },
   "dependencies": {
-    "@eslint/js": "9.32.0",
-    "@stylistic/eslint-plugin": "5.2.2",
-    "eslint": "9.32.0",
+    "@eslint/js": "10.0.1",
+    "@stylistic/eslint-plugin": "5.10.0",
+    "eslint": "10.0.3",
     "eslint-config-prettier": "10.1.8",
     "eslint-import-resolver-typescript": "4.4.4",
     "eslint-plugin-import": "2.32.0",
-    "eslint-plugin-jest": "29.0.1",
-    "eslint-plugin-mocha": "11.1.0",
-    "eslint-plugin-n": "17.21.3",
-    "eslint-plugin-prettier": "5.5.3",
+    "eslint-plugin-jest": "29.15.0",
+    "eslint-plugin-mocha": "11.2.0",
+    "eslint-plugin-n": "17.24.0",
+    "eslint-plugin-prettier": "5.5.5",
     "eslint-plugin-promise": "7.2.1",
     "eslint-plugin-react": "7.37.5",
-    "eslint-plugin-testing-library": "7.6.3",
-    "globals": "16.3.0",
-    "prettier": "3.6.2",
-    "typescript": "5.8.3",
-    "typescript-eslint": "8.38.0"
+    "eslint-plugin-testing-library": "7.16.1",
+    "globals": "17.4.0",
+    "prettier": "3.8.1",
+    "typescript": "5.9.3",
+    "typescript-eslint": "8.57.1"
   },
   "engines": {
-    "node": ">=22"
+    "node": ">=22.13.0"
   },
   "keywords": [],
   "license": "MIT",
@@ -46,5 +46,5 @@
   },
   "sideEffects": false,
   "title": "EthBerry ESLint config",
-  "version": "5.0.8"
+  "version": "6.0.3"
 }

package/presets/js.mjs

@@ -8,4 +8,4 @@ export default [
   ...promiseRules,
   ...nodeRules,
   ...prettierRules,
-]
+];

package/presets/jsx.mjs

@@ -10,4 +10,4 @@ export default [
   ...nodeRules,
   ...reactRules,
   ...prettierRules,
-]
+];

package/presets/ts.mjs

@@ -10,6 +10,6 @@ export default [
   ...typescriptRules,
   ...promiseRules,
   ...nodeRules,
-  ...prettierRules,
   ...importRules,
-]
+  ...prettierRules,
+];

package/presets/tsx.mjs

@@ -12,7 +12,6 @@ export default [
   ...promiseRules,
   ...nodeRules,
   ...reactRules,
-  ...prettierRules,
   ...importRules,
+  ...prettierRules,
 ];
-

package/rules/common.mjs

@@ -8,6 +8,7 @@ export default [
   // overrides
   {
     rules: {
+      curly: ["error", "all"],
       "no-console": [
         "error",
         {
@@ -24,7 +25,7 @@ export default [
         },
       ],
       "no-void": "off",
-    }
+    },
   },
 
   // stylistic
@@ -39,7 +40,7 @@ export default [
           code: 120,
           ignoreRegExpLiterals: true,
           ignoreTemplateLiterals: true,
-          ignorePattern: "^\\s+d=\"", // ignore path in svg icons
+          ignorePattern: '^\\s+d="', // ignore path in svg icons
         },
       ],
       "arrow-parens": ["error", "as-needed"],
@@ -67,4 +68,4 @@ export default [
       semi: ["error", "always"],
     },
   },
-]
+];

package/rules/import.mjs

@@ -5,10 +5,10 @@ export default [
   importPlugin.flatConfigs.typescript,
   {
     rules: {
-      'import/order': [
+      "import/order": [
         "error",
         {
-          "groups": [
+          groups: [
             "builtin",
             "external",
             "internal",
@@ -16,17 +16,17 @@ export default [
             "index",
             "object",
           ],
-          "pathGroups": [
+          pathGroups: [
             {
-              "pattern": "@{ethberry,framework}/**",
-              "group": "external",
-              "position": "after"
-            }
+              pattern: "@{ethberry,framework}/**",
+              group: "external",
+              position: "after",
+            },
           ],
-          "pathGroupsExcludedImportTypes": ["builtin"],
-          'newlines-between': 'always',
+          pathGroupsExcludedImportTypes: ["builtin"],
+          "newlines-between": "always",
         },
       ],
-    }
-  }
-]
+    },
+  },
+];

package/rules/prettier.mjs

@@ -1,5 +1,3 @@
-import eslintConfigPrettier from "eslint-config-prettier";
+import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended";
 
-export default [
-  eslintConfigPrettier
-]
+export default [eslintPluginPrettierRecommended];

package/rules/react.mjs

@@ -37,6 +37,7 @@ export default [
 
   // stylistic
   {
+    files: ["**/*.{jsx,mjsx,tsx,mtsx}"],
     plugins: {
       "@stylistic": stylistic,
     },
@@ -44,4 +45,4 @@ export default [
       "@stylistic/jsx-indent": ["error", 2],
     },
   },
-]
+];

package/rules/typescript.mjs

@@ -58,4 +58,4 @@ export default [
       "@stylistic": stylistic,
     },
   },
-]
+];

package/tests/mocha.mjs

@@ -4,9 +4,9 @@ import mochaPlugin from "eslint-plugin-mocha";
 export default [
   {
     files: ["**/*.spec.ts", "**/*.spec.js"],
-    ...mochaPlugin.configs.flat.recommended,
+    ...mochaPlugin.configs.recommended,
     rules: {
-      ...mochaPlugin.configs.flat.recommended.rules,
+      ...mochaPlugin.configs.recommended.rules,
       "mocha/no-exports": "off",
       "mocha/no-hooks-for-single-case": "off",
       "mocha/no-skipped-tests": "off",

package/tests/testing-library.mjs

@@ -4,10 +4,10 @@ export default [
   {
     files: ["**/*.spec.tsx", "**/*.spec.jsx"],
     ...testingLibraryPlugin.configs["flat/dom"],
-    ...testingLibraryPlugin.configs['flat/react'],
+    ...testingLibraryPlugin.configs["flat/react"],
     rules: {
       ...testingLibraryPlugin.configs["flat/dom"].rules,
-      ...testingLibraryPlugin.configs['flat/react'].rules,
+      ...testingLibraryPlugin.configs["flat/react"].rules,
       "testing-library/await-async-queries": "error",
       "testing-library/no-await-sync-queries": "error",
       "testing-library/no-debugging-utils": "warn",