@ethang/eslint-config 19.7.4 → 19.8.0

package/README.md

@@ -5,20 +5,22 @@
 > [!CAUTION]
 > Do not use this with Prettier! Styling rules are included.
 
-- 886 errored rules.
+- 890 errored rules.
 - 289 rules from [eslint-plugin-sonarjs](https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md)
 - 144 rules from [@eslint/js](https://github.com/eslint/eslint/tree/main/packages/js)
 - 113 rules from [sindresorhus/eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn)
 - 103 rules from [@typescript/eslint](https://github.com/typescript-eslint/typescript-eslint)
-- 91 rules from [@stylistic/eslint-plugin](https://eslint.style/)
+- 67 rules from [@stylistic/eslint-plugin](https://eslint.style/)
 - 42 rules from [eslint-plugin-lodash](https://github.com/wix-incubator/eslint-plugin-lodash)
 - 35 rules from [jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y)
+- 25 rules from [@stylistic/eslint-plugin-ts](https://eslint.style/)
 - 20 rules from [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n)
 - 20 rules from [eslint-plugin-perfectionist](https://github.com/azat-io/eslint-plugin-perfectionist)
 - 7 rules from [eslint-plugin-tailwindcss](https://github.com/francoismassart/eslint-plugin-tailwindcss)
 - 7 rules from [@eslint/markdown](https://github.com/eslint/markdown)
 - 5 rules from [@tanstack/eslint-plugin-query](https://tanstack.com/query/latest/docs/eslint/eslint-plugin-query)
 - 4 rules from [eslint-plugin-barrel-files](https://github.com/thepassle/eslint-plugin-barrel-files)
+- 3 rules from [exception-handling](https://github.com/Akronae/eslint-plugin-exception-handling)
 - 2 rules from [@eslint/json](https://github.com/eslint/json)
 - 1 rule from [eslint-plugin-depend](https://github.com/es-tooling/eslint-plugin-depend/tree/main)
 - 1 rule from [@cspell/eslint-plugin](https://github.com/streetsidesoftware/cspell/tree/main/packages/cspell-eslint-plugin)

package/build/rule-list.ts

@@ -21,6 +21,7 @@ import { unicornRules } from "../setup/unicorn.ts";
 import { cspellRules } from "../setup/cspell.js";
 import { tanstackRouterRules } from "../setup/tanstack-router.js";
 import { exceptionHandlingRules } from "../setup/exception-handling.js";
+import { stylisticTsRules } from "../setup/stylistic-ts.js";
 
 export const ruleList = [
   {
@@ -144,11 +145,21 @@ export const ruleList = [
     type: "core",
     url: "https://eslint.style/",
   },
+  {
+    importString: 'import stylisticTs from "@stylistic/eslint-plugin-ts";',
+    list: stylisticTsRules,
+    name: "@stylistic/eslint-plugin-ts",
+    order: 12,
+    pluginName: "stylisticTs",
+    pluginValue: "stylisticTs",
+    type: "core",
+    url: "https://eslint.style/",
+  },
   {
     importString: 'import perfectionist from "eslint-plugin-perfectionist";',
     list: perfectionistRules,
     name: "eslint-plugin-perfectionist",
-    order: 12,
+    order: 13,
     pluginName: "perfectionist",
     pluginValue: "perfectionist",
     type: "core",
@@ -158,7 +169,7 @@ export const ruleList = [
     importString: 'import tanstackQuery from "@tanstack/eslint-plugin-query";',
     list: tanstackQueryRules,
     name: "@tanstack/eslint-plugin-query",
-    order: 13,
+    order: 14,
     pluginName: "@tanstack/query",
     pluginValue: "tanstackQuery",
     type: "core",
@@ -169,7 +180,7 @@ export const ruleList = [
       'import tanstackRouter from "@tanstack/eslint-plugin-router";',
     list: tanstackRouterRules,
     name: "@tanstack/eslint-plugin-router",
-    order: 14,
+    order: 15,
     pluginName: "@tanstack/router",
     pluginValue: "tanstackRouter",
     type: "core",
@@ -179,7 +190,7 @@ export const ruleList = [
     importString: 'import a11y from "eslint-plugin-jsx-a11y";',
     list: a11yRules,
     name: "jsx-a11y",
-    order: 15,
+    order: 16,
     pluginName: "a11y",
     pluginValue: "a11y",
     type: "core",
@@ -189,7 +200,7 @@ export const ruleList = [
     importString: undefined,
     list: deprecatedRules,
     name: "@eslint/js",
-    order: 16,
+    order: 17,
     pluginName: undefined,
     pluginValue: undefined,
     type: "core",

package/eslint.config.js

@@ -13,6 +13,7 @@ import n from "eslint-plugin-n";
 import perfectionist from "eslint-plugin-perfectionist";
 import sonar from "eslint-plugin-sonarjs";
 import stylistic from "@stylistic/eslint-plugin";
+import stylisticTs from "@stylistic/eslint-plugin-ts";
 import tailwind from "eslint-plugin-tailwindcss";
 import tanstackQuery from "@tanstack/eslint-plugin-query";
 import tanstackRouter from "@tanstack/eslint-plugin-router";
@@ -40,6 +41,7 @@ export default tseslint.config(
       "exception-handling": exceptionHandling,
       tailwind: tailwind,
       stylistic: stylistic,
+      stylisticTs: stylisticTs,
       perfectionist: perfectionist,
       "@tanstack/query": tanstackQuery,
       "@tanstack/router": tanstackRouter,
@@ -932,9 +934,9 @@ export default tseslint.config(
       "sonar/weak-ssl": "error",
       "sonar/x-powered-by": "error",
       "sonar/xml-parser-xxe": "error",
-      "exception-handling/might-throw": "off",
-      "exception-handling/no-unhandled": "off",
-      "exception-handling/use-error-cause": "off",
+      "exception-handling/might-throw": "error",
+      "exception-handling/no-unhandled": "error",
+      "exception-handling/use-error-cause": "error",
       "tailwind/classnames-order": "error",
       "tailwind/enforces-negative-arbitrary-values": "error",
       "tailwind/enforces-shorthand": "error",
@@ -948,21 +950,21 @@ export default tseslint.config(
       "stylistic/array-element-newline": ["error", "consistent"],
       "stylistic/arrow-parens": "error",
       "stylistic/arrow-spacing": "error",
-      "stylistic/block-spacing": "error",
-      "stylistic/brace-style": "error",
-      "stylistic/comma-dangle": ["error", "always-multiline"],
-      "stylistic/comma-spacing": "error",
+      "stylistic/block-spacing": "off",
+      "stylistic/brace-style": "off",
+      "stylistic/comma-dangle": "off",
+      "stylistic/comma-spacing": "off",
       "stylistic/comma-style": "error",
       "stylistic/computed-property-spacing": "error",
       "stylistic/dot-location": ["error", "property"],
       "stylistic/eol-last": "error",
-      "stylistic/func-call-spacing": "error",
+      "stylistic/func-call-spacing": "off",
       "stylistic/function-call-argument-newline": ["error", "consistent"],
-      "stylistic/function-call-spacing": "error",
+      "stylistic/function-call-spacing": "off",
       "stylistic/function-paren-newline": ["error", "consistent"],
       "stylistic/generator-star-spacing": "error",
       "stylistic/implicit-arrow-linebreak": "error",
-      "stylistic/indent": ["error", 2],
+      "stylistic/indent": "off",
       "stylistic/indent-binary-ops": "error",
       "stylistic/jsx-child-element-spacing": "error",
       "stylistic/jsx-closing-bracket-location": "error",
@@ -988,11 +990,11 @@ export default tseslint.config(
         { declaration: "parens-new-line" },
       ],
       "stylistic/key-spacing": "error",
-      "stylistic/keyword-spacing": "error",
+      "stylistic/keyword-spacing": "off",
       "stylistic/line-comment-position": "off",
       "stylistic/linebreak-style": "error",
-      "stylistic/lines-around-comment": "error",
-      "stylistic/lines-between-class-members": "error",
+      "stylistic/lines-around-comment": "off",
+      "stylistic/lines-between-class-members": "off",
       "stylistic/max-len": [
         "error",
         {
@@ -1005,18 +1007,14 @@ export default tseslint.config(
         },
       ],
       "stylistic/max-statements-per-line": "error",
-      "stylistic/member-delimiter-style": "error",
+      "stylistic/member-delimiter-style": "off",
       "stylistic/multiline-comment-style": "off",
       "stylistic/multiline-ternary": "error",
       "stylistic/new-parens": "error",
       "stylistic/newline-per-chained-call": "error",
       "stylistic/no-confusing-arrow": "error",
-      "stylistic/no-extra-parens": [
-        "error",
-        "all",
-        { ignoreJSX: "multi-line" },
-      ],
-      "stylistic/no-extra-semi": "error",
+      "stylistic/no-extra-parens": "off",
+      "stylistic/no-extra-semi": "off",
       "stylistic/no-floating-decimal": "error",
       "stylistic/no-mixed-operators": "error",
       "stylistic/no-mixed-spaces-and-tabs": "error",
@@ -1026,40 +1024,81 @@ export default tseslint.config(
       "stylistic/no-trailing-spaces": "error",
       "stylistic/no-whitespace-before-property": "error",
       "stylistic/nonblock-statement-body-position": "error",
-      "stylistic/object-curly-newline": [
-        "error",
-        { multiline: true, consistent: true },
-      ],
-      "stylistic/object-curly-spacing": ["error", "always"],
-      "stylistic/object-property-newline": "error",
+      "stylistic/object-curly-newline": "off",
+      "stylistic/object-curly-spacing": "off",
+      "stylistic/object-property-newline": "off",
       "stylistic/one-var-declaration-per-line": "error",
       "stylistic/operator-linebreak": "error",
       "stylistic/padded-blocks": ["error", "never"],
-      "stylistic/padding-line-between-statements": "error",
-      "stylistic/quote-props": ["error", "as-needed"],
-      "stylistic/quotes": "error",
+      "stylistic/padding-line-between-statements": "off",
+      "stylistic/quote-props": "off",
+      "stylistic/quotes": "off",
       "stylistic/rest-spread-spacing": "error",
-      "stylistic/semi": "error",
+      "stylistic/semi": "off",
       "stylistic/semi-spacing": "error",
       "stylistic/semi-style": "error",
-      "stylistic/space-before-blocks": "error",
-      "stylistic/space-before-function-paren": [
-        "error",
-        { anonymous: "always", named: "never", asyncArrow: "always" },
-      ],
+      "stylistic/space-before-blocks": "off",
+      "stylistic/space-before-function-paren": "off",
       "stylistic/space-in-parens": "error",
-      "stylistic/space-infix-ops": "error",
+      "stylistic/space-infix-ops": "off",
       "stylistic/space-unary-ops": "error",
       "stylistic/spaced-comment": "error",
       "stylistic/switch-colon-spacing": "error",
       "stylistic/template-curly-spacing": "error",
       "stylistic/template-tag-spacing": "error",
-      "stylistic/type-annotation-spacing": "error",
+      "stylistic/type-annotation-spacing": "off",
       "stylistic/type-generic-spacing": "error",
       "stylistic/type-named-tuple-spacing": "error",
       "stylistic/wrap-iife": "error",
       "stylistic/wrap-regex": "error",
       "stylistic/yield-star-spacing": "error",
+      "stylistic/ts/block-spacing": "error",
+      "stylistic/ts/brace-style": "error",
+      "stylistic/ts/comma-dangle": [
+        "error",
+        {
+          arrays: "always-multiline",
+          objects: "always-multiline",
+          imports: "always-multiline",
+          exports: "always-multiline",
+          functions: "always-multiline",
+          enums: "never",
+          generics: "never",
+          tuples: "never",
+        },
+      ],
+      "stylistic/ts/comma-spacing": "error",
+      "stylistic/ts/func-call-spacing": "error",
+      "stylistic/ts/function-call-spacing": "error",
+      "stylistic/ts/indent": ["error", 2],
+      "stylistic/ts/key-spacing": "error",
+      "stylistic/ts/keyword-spacing": "error",
+      "stylistic/ts/lines-around-comment": "error",
+      "stylistic/ts/lines-between-class-members": "error",
+      "stylistic/ts/member-delimiter-style": "error",
+      "stylistic/ts/no-extra-parens": [
+        "error",
+        "all",
+        { ignoreJSX: "multi-line" },
+      ],
+      "stylistic/ts/no-extra-semi": "error",
+      "stylistic/ts/object-curly-newline": [
+        "error",
+        { multiline: true, consistent: true },
+      ],
+      "stylistic/ts/object-curly-spacing": ["error", "always"],
+      "stylistic/ts/object-property-newline": "error",
+      "stylistic/ts/padding-line-between-statements": "error",
+      "stylistic/ts/quote-props": ["error", "as-needed"],
+      "stylistic/ts/quotes": "error",
+      "stylistic/ts/semi": "error",
+      "stylistic/ts/space-before-blocks": "error",
+      "stylistic/ts/space-before-function-paren": [
+        "error",
+        { anonymous: "always", named: "never", asyncArrow: "always" },
+      ],
+      "stylistic/ts/space-infix-ops": "error",
+      "stylistic/ts/type-annotation-spacing": "error",
       "perfectionist/sort-array-includes": "error",
       "perfectionist/sort-astro-attributes": [
         "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethang/eslint-config",
-  "version": "19.7.4",
+  "version": "19.8.0",
   "repository": {
     "url": "git+https://github.com/eglove/eslint-config-ethang.git"
   },
@@ -20,6 +20,7 @@
     "@eslint/json": "^0.4.0",
     "@eslint/markdown": "^6.1.0",
     "@stylistic/eslint-plugin": "^2.8.0",
+    "@stylistic/eslint-plugin-ts": "^2.8.0",
     "@tanstack/eslint-plugin-query": "^5.57.1",
     "@tanstack/eslint-plugin-router": "^1.58.6",
     "@typescript-eslint/parser": "^8.6.0",
@@ -28,7 +29,7 @@
     "eslint-plugin-barrel-files": "^2.1.0",
     "eslint-plugin-compat": "^6.0.1",
     "eslint-plugin-depend": "^0.11.0",
-    "eslint-plugin-exception-handling": "^1.4.2",
+    "eslint-plugin-exception-handling": "^1.4.3",
     "eslint-plugin-jsx-a11y": "^6.10.0",
     "eslint-plugin-lodash": "^8.0.0",
     "eslint-plugin-n": "^17.10.3",
@@ -60,6 +61,7 @@
     "@eslint/json": "^0.4.0",
     "@eslint/markdown": "^6.1.0",
     "@stylistic/eslint-plugin": "^2.8.0",
+    "@stylistic/eslint-plugin-ts": "^2.8.0",
     "@tanstack/eslint-plugin-query": "^5.57.1",
     "@tanstack/eslint-plugin-router": "^1.58.6",
     "@typescript-eslint/parser": "^8.6.0",
@@ -68,7 +70,7 @@
     "eslint-plugin-barrel-files": "^2.1.0",
     "eslint-plugin-compat": "^6.0.1",
     "eslint-plugin-depend": "^0.11.0",
-    "eslint-plugin-exception-handling": "^1.4.2",
+    "eslint-plugin-exception-handling": "^1.4.3",
     "eslint-plugin-jsx-a11y": "^6.10.0",
     "eslint-plugin-lodash": "^8.0.0",
     "eslint-plugin-n": "^17.10.3",

package/setup/exception-handling.ts

@@ -9,5 +9,4 @@ export const exceptionHandlingRules = genRules(
   ruleNames,
   [],
   "exception-handling",
-  "off", // TODO fix with https://github.com/Akronae/eslint-plugin-exception-handling/issues/5
 );

package/setup/stylistic-ts.ts

@@ -0,0 +1,51 @@
+import stylisticTs from "@stylistic/eslint-plugin-ts";
+import { genRules, getNonDeprecatedRules } from "./gen-rules.js";
+
+const ruleNames = Object.keys(getNonDeprecatedRules(stylisticTs.rules));
+
+const customRules = [
+  {
+    name: "comma-dangle",
+    rule: [
+      "error",
+      {
+        arrays: "always-multiline",
+        objects: "always-multiline",
+        imports: "always-multiline",
+        exports: "always-multiline",
+        functions: "always-multiline",
+        enums: "never",
+        generics: "never",
+        tuples: "never",
+      },
+    ],
+  },
+  { name: "indent", rule: ["error", 2] },
+  {
+    name: "no-extra-parens",
+    rule: ["error", "all", { ignoreJSX: "multi-line" }],
+  },
+  {
+    name: "object-curly-newline",
+    rule: ["error", { multiline: true, consistent: true }],
+  },
+  { name: "object-curly-spacing", rule: ["error", "always"] },
+  { name: "quote-props", rule: ["error", "as-needed"] },
+  {
+    name: "space-before-function-paren",
+    rule: [
+      "error",
+      {
+        anonymous: "always",
+        named: "never",
+        asyncArrow: "always",
+      },
+    ],
+  },
+];
+
+export const stylisticTsRules = genRules(
+  ruleNames,
+  customRules,
+  "stylistic/ts",
+);

package/setup/stylistic.ts

@@ -5,13 +5,36 @@ import { genRules, getNonDeprecatedRules } from "./gen-rules.ts";
 // @ts-expect-error this exists
 const ruleNames = Object.keys(getNonDeprecatedRules(stylistic.rules));
 const customRules = [
+  { name: "block-spacing", rule: "off" }, // TS
+  { name: "brace-style", rule: "off" }, // TS
+  { name: "comma-dangle", rule: "off" }, // TS
+  { name: "comma-spacing", rule: "off" }, // TS
+  { name: "func-call-spacing", rule: "off" }, // TS
+  { name: "function-call-spacing", rule: "off" }, // TS
+  { name: "indent", rule: "off" }, // TS
+  { name: "keyword-spacing", rule: "off" }, // TS
+  { name: "lines-around-comment", rule: "off" }, // TS
+  { name: "lines-between-class-members", rule: "off" }, // TS
+  { name: "member-delimiter-style", rule: "off" }, // TS
+  { name: "no-extra-parens", rule: "off" }, // TS
+  { name: "no-extra-semi", rule: "off" }, // TS
+  { name: "object-curly-newline", rule: "off" }, // TS
+  { name: "object-curly-spacing", rule: "off" }, // TS
+  { name: "object-property-newline", rule: "off" }, // TS
+  { name: "padding-line-between-statements", rule: "off" }, // TS
+  { name: "quote-props", rule: "off" }, // TS
+  { name: "quotes", rule: "off" }, // TS
+  { name: "semi", rule: "off" }, // TS
+  { name: "space-before-blocks", rule: "off" }, // TS
+  { name: "space-before-function-paren", rule: "off" }, // TS
+  { name: "space-infix-ops", rule: "off" }, // TS
+  { name: "type-annotation-spacing", rule: "off" }, // TS
+
   { name: "array-bracket-newline", rule: ["error", "consistent"] },
   { name: "array-element-newline", rule: ["error", "consistent"] },
-  { name: "comma-dangle", rule: ["error", "always-multiline"] },
   { name: "dot-location", rule: ["error", "property"] },
   { name: "function-call-argument-newline", rule: ["error", "consistent"] },
   { name: "function-paren-newline", rule: ["error", "consistent"] },
-  { name: "indent", rule: ["error", 2] },
   { name: "line-comment-position", rule: "off" },
   {
     name: "max-len",
@@ -28,28 +51,7 @@ const customRules = [
     ],
   },
   { name: "multiline-comment-style", rule: "off" },
-  {
-    name: "no-extra-parens",
-    rule: ["error", "all", { ignoreJSX: "multi-line" }],
-  },
-  {
-    name: "object-curly-newline",
-    rule: ["error", { multiline: true, consistent: true }],
-  },
-  { name: "object-curly-spacing", rule: ["error", "always"] },
   { name: "padded-blocks", rule: ["error", "never"] },
-  { name: "quote-props", rule: ["error", "as-needed"] },
-  {
-    name: "space-before-function-paren",
-    rule: [
-      "error",
-      {
-        anonymous: "always",
-        named: "never",
-        asyncArrow: "always",
-      },
-    ],
-  },
   { name: "jsx-indent-props", rule: ["error", 2] },
   { name: "jsx-newline", rule: ["error", { prevent: true }] },
   { name: "jsx-sort-props", rule: "off" },