@ethang/eslint-config 19.4.2 → 19.4.4

package/README.md

@@ -29,9 +29,10 @@
 - 51 rules for **Astro**
   - `import astroConfig from "@ethang/eslint-config/config.astro.js";`
   - 51 rules from [eslint-plugin-astro](https://github.com/ota-meshi/eslint-plugin-astro)
-- 71 rules for **React**
+- 73 rules for **React**
   - `import reactConfig from "@ethang/eslint-config/config.react.js";`
   - 71 rules from [@eslint-react/eslint-plugin](https://eslint-react.xyz/)
+  - 2 rules from [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks)
 - 18 rules for **Solid**
   - `import solidConfig from "@ethang/eslint-config/config.solid.js";`
   - 18 rules from [eslint-plugin-solid](https://github.com/solidjs-community/eslint-plugin-solid)

package/build/rule-list.mjs

@@ -226,7 +226,7 @@ export const ruleList = [
     type: "react",
     importString: 'import reactHooks from "eslint-plugin-react-hooks";',
     pluginName: "react-hooks",
-    pluginValue: "reactHooks",
+    pluginValue: "fixupPluginRules(reactHooks)",
   },
   {
     list: solidRules,

package/build/update-rules.js

@@ -43,7 +43,10 @@ const reactFile = [
       includeReactVersion: true,
       includeIgnores: true,
       includeLanguageOptions: true,
-      extraImports: ['import tseslint from "typescript-eslint";'],
+      extraImports: [
+        'import tseslint from "typescript-eslint";',
+        'import { fixupPluginRules } from "@eslint/compat";',
+      ],
     },
   },
 ];

package/config.react.js

@@ -1,3 +1,4 @@
+import { fixupPluginRules } from "@eslint/compat";
 import { ignores, languageOptions } from "./constants.js";
 import react from "@eslint-react/eslint-plugin";
 import reactHooks from "eslint-plugin-react-hooks";
@@ -12,7 +13,7 @@ export default tseslint.config({
   },
   plugins: {
     react: react,
-    "react-hooks": reactHooks,
+    "react-hooks": fixupPluginRules(reactHooks),
   },
   rules: {
     "react/avoid-shorthand-boolean": "off",
@@ -93,7 +94,7 @@ export default tseslint.config({
     "react/debug/hook": "off",
     "react/debug/is-from-react": "off",
     "react/debug/react-hooks": "off",
-    "react-hooks/rules-of-hooks": "off",
-    "react-hooks/exhaustive-deps": "off",
+    "react-hooks/rules-of-hooks": "error",
+    "react-hooks/exhaustive-deps": "error",
   },
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethang/eslint-config",
-  "version": "19.4.2",
+  "version": "19.4.4",
   "repository": {
     "url": "git+https://github.com/eglove/eslint-config-ethang.git"
   },
@@ -13,7 +13,8 @@
     "lint": "prettier . -w"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^1.13.0",
+    "@eslint-react/eslint-plugin": "^1.13.1",
+    "@eslint/compat": "^1.1.1",
     "@eslint/js": "^9.10.0",
     "@eslint/json": "^0.4.0",
     "@eslint/markdown": "^6.1.0",
@@ -40,13 +41,14 @@
   },
   "devDependencies": {
     "@ethang/markdown-generator": "^1.1.1",
-    "@ethang/project-builder": "^2.5.9",
+    "@ethang/project-builder": "^2.5.10",
     "@tsconfig/node-lts": "^20.1.3",
     "@tsconfig/strictest": "^2.0.5",
     "prettier": "^3.3.3"
   },
   "peerDependencies": {
-    "@eslint-react/eslint-plugin": "^1.13.0",
+    "@eslint-react/eslint-plugin": "^1.13.1",
+    "@eslint/compat": "^1.1.1",
     "@eslint/js": "^9.10.0",
     "@eslint/json": "^0.4.0",
     "@eslint/markdown": "^6.1.0",

package/setup/react.js

@@ -1,6 +1,7 @@
 import react from "@eslint-react/eslint-plugin";
 import reactHooks from "eslint-plugin-react-hooks";
 import { genRules } from "./gen-rules.js";
+import { fixupPluginRules } from "@eslint/compat";
 
 const reactRuleNames = Object.keys(react.rules);
 const customReactRules = [
@@ -20,8 +21,8 @@ const reactGen = genRules(reactRuleNames, customReactRules, "react");
 
 const reactHookRuleNames = Object.keys(reactHooks.rules);
 const customHookRules = [
-  { name: "exhaustive-deps", rule: "off" }, // TODO fix w/ v9 compatibility
-  { name: "rules-of-hooks", rule: "off" }, // TODO fix w/ v9 compatibility
+  { name: "exhaustive-deps", rule: "error" },
+  { name: "rules-of-hooks", rule: "error" },
 ];
 const hookGen = genRules(reactHookRuleNames, customHookRules, "react-hooks");