@ethang/eslint-config 19.2.8 → 19.2.10

package/README.md

@@ -5,9 +5,9 @@
 > [!CAUTION]
 > Do not use this with Prettier! Styling rules are included.
 
-- 884 errored rules.
+- 885 errored rules.
 - 289 rules from [eslint-plugin-sonarjs](https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md)
-- 144 rules from [@eslint/js](https://github.com/eslint/eslint/tree/main/packages/js)
+- 145 rules from [@eslint/js](https://github.com/eslint/eslint/tree/main/packages/js)
 - 113 rules from [sindresorhus/eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn)
 - 104 rules from [@typescript/eslint](https://github.com/typescript-eslint/typescript-eslint)
 - 91 rules from [@stylistic/eslint-plugin](https://eslint.style/)

package/build/create-config-file.js

@@ -0,0 +1,45 @@
+import { getTypeImportStrings } from "./list-utils.mjs";
+import { createConfig } from "./create-config.js";
+import { writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+export const createConfigFile = async (listConfigs, fileName) => {
+  let configFile = "";
+
+  const imports = listConfigs
+    .map((list) => {
+      const importStrings = getTypeImportStrings(list.name);
+
+      if (list.options?.extraImports?.length > 0) {
+        importStrings.push(...list.options.extraImports);
+      }
+
+      return importStrings;
+    })
+    .flat();
+
+  const importList = [
+    'import { ignores, languageOptions } from "./constants.js";',
+    ...imports,
+  ].sort((a, b) => a.localeCompare(b));
+
+  importList.forEach((item) => {
+    configFile += `${item}\n`;
+  });
+
+  const configs = await Promise.all(
+    listConfigs.map((list) => {
+      return createConfig(list.name, list.options);
+    }),
+  );
+
+  configFile += `\nexport default tseslint.config(
+    ${configs.join("\n")}
+  );\n`;
+
+  writeFileSync(
+    join(import.meta.dirname, `../${fileName}`),
+    configFile,
+    "utf8",
+  );
+};

package/build/create-config.js

@@ -0,0 +1,50 @@
+import {
+  getList,
+  getListJson,
+  getListPlugins,
+  getTypeFiles,
+} from "./list-utils.mjs";
+import { getLatestReact } from "./get-react-version.js";
+
+export const createConfig = async (type, options = {}) => {
+  let config = "";
+  let settings;
+
+  if (options.includeReactVersion) {
+    const react = await getLatestReact();
+    settings = JSON.stringify({
+      react: { version: react.version },
+    }).slice(1, -1);
+  }
+
+  const list = getList(type);
+  const ruleJson = getListJson(list);
+
+  let optionals = "";
+
+  if (options.includeIgnores) {
+    optionals += "\nignores,";
+  }
+
+  if (options.includeLanguageOptions) {
+    optionals += "\nlanguageOptions,";
+  }
+
+  if (options.includeReactVersion && settings) {
+    optionals += `\nsettings: {
+  ${settings}
+},`;
+  }
+
+  config += `{
+    files: ["${getTypeFiles(type)}"],${optionals}
+    plugins: {
+      ${getListPlugins(list)}
+    },
+    rules: {
+      ${ruleJson}
+    },
+  },`;
+
+  return config;
+};

package/build/list-utils.mjs

@@ -0,0 +1,70 @@
+import { ruleList } from "./rule-list.mjs";
+
+export const getList = (type) => {
+  return ruleList
+    .filter((list) => list.type === type)
+    .sort((a, b) => a.order - b.order);
+};
+
+export const getListImportStrings = (list) => {
+  return list
+    .map((item) => {
+      return item.importString;
+    })
+    .filter(Boolean);
+};
+
+export const getTypeImportStrings = (type) => {
+  return ruleList
+    .filter((list) => list.type === type)
+    .map((item) => item.importString)
+    .filter(Boolean);
+};
+
+export const getListJson = (list) => {
+  return list
+    .map((list) => {
+      return JSON.stringify(list.list).slice(1, -1);
+    })
+    .join(",");
+};
+
+export const getTypeFiles = (type) => {
+  switch (type) {
+    case "core": {
+      return ["**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts}"];
+    }
+
+    case "markdown": {
+      return ["**/*.md"];
+    }
+
+    case "json": {
+      return ["**/*.{json,jsonc,json5}"];
+    }
+
+    case "react": {
+      return ["**/*.{jsx,tsx}"];
+    }
+
+    case "astro": {
+      return ["**/*.{astro}"];
+    }
+
+    case "solid": {
+      return ["**/*.{jsx,tsx}"];
+    }
+  }
+};
+
+export const getListPlugins = (list) => {
+  let pluginString = "";
+
+  for (const item of list) {
+    if (item.pluginName && item.pluginValue) {
+      pluginString += `"${item.pluginName}": ${item.pluginValue},`;
+    }
+  }
+
+  return pluginString;
+};

package/build/rule-list.mjs

@@ -0,0 +1,240 @@
+import { dependRules } from "../setup/depend.js";
+import { barrelRules } from "../setup/barrel.js";
+import { compatRules } from "../setup/compat.js";
+import { eslintRules } from "../setup/eslint.js";
+import { nRules } from "../setup/n.js";
+import { typescriptRules } from "../setup/typescript-eslint.js";
+import { unicornRules } from "../setup/unicorn.js";
+import { lodashRules } from "../setup/lodash.js";
+import { sonarRules } from "../setup/sonar.js";
+import { tanstackQueryRules } from "../setup/tanstack-query.js";
+import { tailwindRules } from "../setup/tailwind.js";
+import { stylisticRules } from "../setup/stylistic.js";
+import { perfectionistRules } from "../setup/perfectionist.js";
+import { a11yRules } from "../setup/a11y.js";
+import { markdownRules } from "../setup/markdown.js";
+import { jsonRules } from "../setup/json.js";
+import { ethangRules } from "../setup/ethang.js";
+import { astroRules } from "../setup/astro.js";
+import { reactHookRules, reactRules } from "../setup/react.js";
+import { solidRules } from "../setup/solid.js";
+import { deprecatedRules } from "../setup/deprecated.js";
+
+export const ruleList = [
+  {
+    list: dependRules,
+    name: "eslint-plugin-depend",
+    url: "https://github.com/es-tooling/eslint-plugin-depend/tree/main",
+    type: "core",
+    importString: 'import depend from "eslint-plugin-depend";',
+    order: 0,
+    pluginName: "depend",
+    pluginValue: "depend",
+  },
+  {
+    list: barrelRules,
+    name: "eslint-plugin-barrel-files",
+    url: "https://github.com/thepassle/eslint-plugin-barrel-files",
+    type: "core",
+    importString: 'import barrel from "eslint-plugin-barrel-files";',
+    order: 1,
+    pluginName: "barrel",
+    pluginValue: "barrel",
+  },
+  {
+    list: compatRules,
+    name: "eslint-plugin-compat",
+    url: "https://github.com/amilajack/eslint-plugin-compat",
+    type: "core",
+    importString: 'import compat from "eslint-plugin-compat";',
+    order: 2,
+    pluginName: "compat",
+    pluginValue: "compat",
+  },
+  {
+    list: eslintRules,
+    name: "@eslint/js",
+    url: "https://github.com/eslint/eslint/tree/main/packages/js",
+    type: "core",
+    importString: undefined,
+    order: 3,
+    pluginName: undefined,
+    pluginValue: undefined,
+  },
+  {
+    list: nRules,
+    name: "eslint-plugin-n",
+    url: "https://github.com/eslint-community/eslint-plugin-n",
+    type: "core",
+    importString: 'import n from "eslint-plugin-n";',
+    order: 4,
+    pluginName: "n",
+    pluginValue: "n",
+  },
+  {
+    list: typescriptRules,
+    name: "@typescript/eslint",
+    url: "https://github.com/typescript-eslint/typescript-eslint",
+    type: "core",
+    importString: 'import tseslint from "typescript-eslint";',
+    order: 5,
+    pluginName: "@typescript-eslint",
+    pluginValue: "tseslint.plugin",
+  },
+  {
+    list: unicornRules,
+    name: "sindresorhus/eslint-plugin-unicorn",
+    url: "https://github.com/sindresorhus/eslint-plugin-unicorn",
+    type: "core",
+    importString: 'import unicorn from "eslint-plugin-unicorn";',
+    order: 6,
+    pluginName: "unicorn",
+    pluginValue: "unicorn",
+  },
+  {
+    list: lodashRules,
+    name: "eslint-plugin-lodash",
+    url: "https://github.com/wix-incubator/eslint-plugin-lodash",
+    type: "core",
+    importString: 'import lodashConfig from "eslint-plugin-lodash";',
+    order: 7,
+    pluginName: "lodash",
+    pluginValue: "lodashConfig",
+  },
+  {
+    list: sonarRules,
+    name: "eslint-plugin-sonarjs",
+    url: "https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md",
+    type: "core",
+    importString: 'import sonar from "eslint-plugin-sonarjs";',
+    order: 8,
+    pluginName: "sonar",
+    pluginValue: "sonar",
+  },
+  {
+    list: ethangRules,
+    name: "@ethang/eslint-plugin",
+    url: "https://github.com/eglove/eslint-plugin",
+    type: "core",
+    importString: 'import ethang from "@ethang/eslint-plugin";',
+    order: 9,
+    pluginName: "ethang",
+    pluginValue: "ethang",
+  },
+  {
+    list: tanstackQueryRules,
+    name: "@tanstack/eslint-plugin-query",
+    url: "https://tanstack.com/query/latest/docs/eslint/eslint-plugin-query",
+    type: "core",
+    importString: 'import tanstack from "@tanstack/eslint-plugin-query";',
+    order: 10,
+    pluginName: "@tanstack/query",
+    pluginValue: "tanstack",
+  },
+  {
+    list: tailwindRules,
+    name: "eslint-plugin-tailwindcss",
+    url: "https://github.com/francoismassart/eslint-plugin-tailwindcss",
+    type: "core",
+    importString: 'import tailwind from "eslint-plugin-tailwindcss";',
+    order: 11,
+    pluginName: "tailwind",
+    pluginValue: "tailwind",
+  },
+  {
+    list: stylisticRules,
+    name: "@stylistic/eslint-plugin",
+    url: "https://eslint.style/",
+    type: "core",
+    importString: 'import stylistic from "@stylistic/eslint-plugin";',
+    order: 12,
+    pluginName: "stylistic",
+    pluginValue: "stylistic",
+  },
+  {
+    list: perfectionistRules,
+    name: "eslint-plugin-perfectionist",
+    url: "https://github.com/azat-io/eslint-plugin-perfectionist",
+    type: "core",
+    importString: 'import perfectionist from "eslint-plugin-perfectionist";',
+    order: 13,
+    pluginName: "perfectionist",
+    pluginValue: "perfectionist",
+  },
+  {
+    list: a11yRules,
+    name: "jsx-a11y",
+    url: "https://github.com/jsx-eslint/eslint-plugin-jsx-a11y",
+    type: "core",
+    importString: 'import a11y from "eslint-plugin-jsx-a11y/lib/index.js";',
+    order: 14,
+    pluginName: "a11y",
+    pluginValue: "a11y",
+  },
+  {
+    list: deprecatedRules,
+    name: "@eslint/js",
+    url: "https://github.com/eslint/eslint/tree/main/packages/js",
+    type: "core",
+    importString: undefined,
+    order: 15,
+    pluginName: undefined,
+    pluginValue: undefined,
+  },
+  {
+    list: markdownRules,
+    name: "@eslint/markdown",
+    url: "https://github.com/eslint/markdown",
+    type: "markdown",
+    importString: 'import markdown from "@eslint/markdown";',
+    order: 0,
+    pluginName: "markdown",
+    pluginValue: "markdown",
+  },
+  {
+    list: jsonRules,
+    name: "@eslint/json",
+    url: "https://github.com/eslint/json",
+    type: "json",
+    importString: 'import json from "@eslint/json";',
+    order: 0,
+    pluginName: "json",
+    pluginValue: "json",
+  },
+  {
+    list: astroRules,
+    name: "eslint-plugin-astro",
+    url: "https://github.com/ota-meshi/eslint-plugin-astro",
+    type: "astro",
+    importString: 'import astro from "eslint-plugin-astro";',
+    pluginName: "astro",
+    pluginValue: "astro",
+  },
+  {
+    list: reactRules,
+    name: "@eslint-react/eslint-plugin",
+    url: "https://eslint-react.xyz/",
+    type: "react",
+    importString: 'import react from "@eslint-react/eslint-plugin";',
+    pluginName: "react",
+    pluginValue: "react",
+  },
+  {
+    list: reactHookRules,
+    name: "eslint-plugin-react-hooks",
+    url: "https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks",
+    type: "react",
+    importString: 'import reactHooks from "eslint-plugin-react-hooks";',
+    pluginName: "react-hooks",
+    pluginValue: "reactHooks",
+  },
+  {
+    list: solidRules,
+    name: "eslint-plugin-solid",
+    url: "https://github.com/solidjs-community/eslint-plugin-solid",
+    type: "solid",
+    importString: 'import solid from "eslint-plugin-solid";',
+    pluginName: "solid",
+    pluginValue: "solid",
+  },
+];

package/build/update-readme.js

@@ -1,26 +1,7 @@
-import { dependRules } from "../setup/depend.js";
-import { barrelRules } from "../setup/barrel.js";
-import { compatRules } from "../setup/compat.js";
-import { eslintRules } from "../setup/eslint.js";
-import { nRules } from "../setup/n.js";
-import { typescriptRules } from "../setup/typescript-eslint.js";
-import { unicornRules } from "../setup/unicorn.js";
-import { lodashRules } from "../setup/lodash.js";
-import { sonarRules } from "../setup/sonar.js";
-import { tanstackQueryRules } from "../setup/tanstack-query.js";
-import { tailwindRules } from "../setup/tailwind.js";
-import { stylisticRules } from "../setup/stylistic.js";
-import { perfectionistRules } from "../setup/perfectionist.js";
-import { a11yRules } from "../setup/a11y.js";
 import { writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { MarkdownGenerator } from "@ethang/markdown-generator/markdown-generator.js";
-import { markdownRules } from "../setup/markdown.js";
-import { jsonRules } from "../setup/json.js";
-import { astroRules } from "../setup/astro.js";
-import { reactRules } from "../setup/react.js";
-import { solidRules } from "../setup/solid.js";
-import { ethangRules } from "../setup/ethang.js";
+import { getList } from "./list-utils.mjs";
 
 export const updateReadme = () => {
   const md = new MarkdownGenerator();
@@ -43,114 +24,51 @@ export const updateReadme = () => {
     return count;
   };
 
-  const ruleList = [
-    {
-      list: dependRules,
-      name: "eslint-plugin-depend",
-      url: "https://github.com/es-tooling/eslint-plugin-depend/tree/main",
-    },
-    {
-      list: barrelRules,
-      name: "eslint-plugin-barrel-files",
-      url: "https://github.com/thepassle/eslint-plugin-barrel-files",
-    },
-    {
-      list: compatRules,
-      name: "eslint-plugin-compat",
-      url: "https://github.com/amilajack/eslint-plugin-compat",
-    },
-    {
-      list: eslintRules,
-      name: "@eslint/js",
-      url: "https://github.com/eslint/eslint/tree/main/packages/js",
-    },
-    {
-      list: nRules,
-      name: "eslint-plugin-n",
-      url: "https://github.com/eslint-community/eslint-plugin-n",
-    },
-    {
-      list: typescriptRules,
-      name: "@typescript/eslint",
-      url: "https://github.com/typescript-eslint/typescript-eslint",
-    },
-    {
-      list: unicornRules,
-      name: "sindresorhus/eslint-plugin-unicorn",
-      url: "https://github.com/sindresorhus/eslint-plugin-unicorn",
-    },
-    {
-      list: lodashRules,
-      name: "eslint-plugin-lodash",
-      url: "https://github.com/wix-incubator/eslint-plugin-lodash",
-    },
-    {
-      list: sonarRules,
-      name: "eslint-plugin-sonarjs",
-      url: "https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md",
-    },
-    {
-      list: tanstackQueryRules,
-      name: "@tanstack/eslint-plugin-query",
-      url: "https://tanstack.com/query/latest/docs/eslint/eslint-plugin-query",
-    },
-    {
-      list: tailwindRules,
-      name: "eslint-plugin-tailwindcss",
-      url: "https://github.com/francoismassart/eslint-plugin-tailwindcss",
-    },
-    {
-      list: stylisticRules,
-      name: "@stylistic/eslint-plugin",
-      url: "https://eslint.style/",
-    },
-    {
-      list: perfectionistRules,
-      name: "eslint-plugin-perfectionist",
-      url: "https://github.com/azat-io/eslint-plugin-perfectionist",
-    },
-    {
-      list: a11yRules,
-      name: "jsx-a11y",
-      url: "https://github.com/jsx-eslint/eslint-plugin-jsx-a11y",
-    },
-    {
-      list: markdownRules,
-      name: "@eslint/markdown",
-      url: "https://github.com/eslint/markdown",
-    },
-    {
-      list: jsonRules,
-      name: "@eslint/json",
-      url: "https://github.com/eslint/json",
-    },
-    {
-      list: ethangRules,
-      name: "@ethang/eslint-plugin",
-      url: "https://github.com/eglove/eslint-plugin",
-    },
+  const coreRules = [
+    ...getList("core"),
+    ...getList("json"),
+    ...getList("markdown"),
   ];
 
   let total = 0;
-  for (const list of ruleList) {
+  for (const list of coreRules) {
     const count = getRuleCount(list.list);
     total += count;
     list["count"] = count;
   }
-  ruleList.sort((a, b) => {
+  coreRules.sort((a, b) => {
     return b.count - a.count;
   });
 
   const ruleDocs = [`${total} errored rules.`];
-  for (const list of ruleList) {
+  for (const list of coreRules) {
+    if (list.count < 1) {
+      continue;
+    }
+
     ruleDocs.push(
       `${list.count} ${list.count <= 1 ? "rule" : "rules"} from [${list.name}](${list.url})`,
     );
   }
 
-  const astroCount = getRuleCount(astroRules);
-  const reactCount = getRuleCount(reactRules);
-  const solidCount = getRuleCount(solidRules);
+  const astroRules = getList("astro");
+  const reactRules = getList("react");
+  const solidRules = getList("solid");
+
+  let astroCount = 0;
+  for (const astroRule of astroRules) {
+    astroCount += getRuleCount(astroRule.list);
+  }
+
+  let reactCount = 0;
+  for (const reactRule of reactRules) {
+    reactCount += getRuleCount(reactRule.list);
+  }
+
+  let solidCount = 0;
+  for (const solidRule of solidRules) {
+    solidCount += getRuleCount(solidRule.list);
+  }
 
   md.unorderedList(ruleDocs);
   md.newLine();
@@ -159,17 +77,29 @@ export const updateReadme = () => {
     `${astroCount} rules for **Astro**`,
     [
       '`import astroConfig from "@ethang/eslint-config/config.astro.js";`',
-      `${astroCount} rules from [eslint-plugin-astro](https://github.com/ota-meshi/eslint-plugin-astro)`,
+      ...astroRules
+        .filter((rule) => getRuleCount(rule.list) > 0)
+        .map((rule) => {
+          return `${getRuleCount(rule.list)} rules from [${rule.name}](${rule.url})`;
+        }),
     ],
     `${reactCount} rules for **React**`,
     [
       '`import reactConfig from "@ethang/eslint-config/config.react.js";`',
-      `${reactCount} rules from [@eslint-react/eslint-plugin](https://eslint-react.xyz/)`,
+      ...reactRules
+        .filter((rule) => getRuleCount(rule.list) > 0)
+        .map((rule) => {
+          return `${getRuleCount(rule.list)} rules from [${rule.name}](${rule.url})`;
+        }),
     ],
     `${solidCount} rules for **Solid**`,
     [
       '`import solidConfig from "@ethang/eslint-config/config.solid.js";`',
-      `${solidCount} rules from [eslint-plugin-solid](https://github.com/solidjs-community/eslint-plugin-solid)`,
+      ...solidRules
+        .filter((rule) => getRuleCount(rule.list) > 0)
+        .map((rule) => {
+          return `${getRuleCount(rule.list)} rules from [${rule.name}](${rule.url})`;
+        }),
     ],
   ]);
   md.newLine();

package/build/update-rules.js

@@ -1,139 +1,83 @@
-import { dependRules } from "../setup/depend.js";
-import { barrelRules } from "../setup/barrel.js";
-import { compatRules } from "../setup/compat.js";
-import { eslintRules } from "../setup/eslint.js";
-import { nRules } from "../setup/n.js";
-import { typescriptRules } from "../setup/typescript-eslint.js";
-import { unicornRules } from "../setup/unicorn.js";
-import { lodashRules } from "../setup/lodash.js";
-import { sonarRules } from "../setup/sonar.js";
-import { tanstackQueryRules } from "../setup/tanstack-query.js";
-import { tailwindRules } from "../setup/tailwind.js";
-import { stylisticRules } from "../setup/stylistic.js";
-import { perfectionistRules } from "../setup/perfectionist.js";
-import { a11yRules } from "../setup/a11y.js";
-import { writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { deprecatedRules } from "../setup/deprecated.js";
-import { markdownRules } from "../setup/markdown.js";
-import { jsonRules } from "../setup/json.js";
-import { getLatestReact } from "./get-react-version.mjs";
-import { ethangRules } from "../setup/ethang.js";
+import { createConfigFile } from "./create-config-file.js";
 
-export const updateRules = async () => {
-  let configFile = "";
-  const react = await getLatestReact();
-  const settings = JSON.stringify({
-    react: { version: react.version },
-  }).slice(1, -1);
-
-  const jsRules = {
-    ...dependRules,
-    ...barrelRules,
-    ...compatRules,
-    ...eslintRules,
-    ...nRules,
-    ...typescriptRules,
-    ...unicornRules,
-    ...lodashRules,
-    ...sonarRules,
-    ...ethangRules,
-    ...tanstackQueryRules,
-    ...tailwindRules,
-    ...stylisticRules,
-    ...perfectionistRules,
-    ...a11yRules,
-    ...deprecatedRules,
-  };
-
-  const jsRulesJon = JSON.stringify(jsRules).slice(1, -1);
-  const markdownRulesJson = JSON.stringify(markdownRules).slice(1, -1);
-  const jsonRulesJson = JSON.stringify(jsonRules).slice(1, -1);
-
-  const importList = [
-    'import parser from "@typescript-eslint/parser";',
-    'import a11y from "eslint-plugin-jsx-a11y/lib/index.js";',
-    'import n from "eslint-plugin-n";',
-    'import unicorn from "eslint-plugin-unicorn";',
-    'import tseslint from "typescript-eslint";',
-    'import sonar from "eslint-plugin-sonarjs";',
-    'import tanstack from "@tanstack/eslint-plugin-query";',
-    'import perfectionist from "eslint-plugin-perfectionist";',
-    'import depend from "eslint-plugin-depend";',
-    'import barrel from "eslint-plugin-barrel-files";',
-    'import compat from "eslint-plugin-compat";',
-    'import lodashConfig from "eslint-plugin-lodash";',
-    'import tailwind from "eslint-plugin-tailwindcss";',
-    'import stylistic from "@stylistic/eslint-plugin";',
-    'import markdown from "@eslint/markdown";',
-    'import json from "@eslint/json";',
-    'import { ignores } from "./constants.js";',
-    'import ethang from "@ethang/eslint-plugin";',
-  ].sort((a, b) => {
-    return a.localeCompare(b);
-  });
-
-  importList.forEach((item) => {
-    configFile += `${item}\n`;
-  });
-
-  configFile += `\nexport const languageOptions = {
-  parser,
-  parserOptions: {
-    project: true,
-    tsconfigRootDir: import.meta.dirname,
+export const coreFile = [
+  {
+    name: "core",
+    label: "Core",
+    importString: 'import config from "@ethang/eslint-config/eslint.config.js',
+    options: {
+      includeReactVersion: true,
+      includeLanguageOptions: true,
+      includeIgnores: true,
+    },
   },
-};
+  {
+    name: "markdown",
+  },
+  {
+    name: "json",
+  },
+];
 
-export default tseslint.config(
+const astroFile = [
   {
-    files: ["**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts}"],
-    ignores,
-    languageOptions,
-    settings: {
-      ${settings}
-    },
-    plugins: {
-      "@tanstack/query": tanstack,
-      "@typescript-eslint": tseslint.plugin,
-      a11y,
-      barrel,
-      compat,
-      depend,
-      ethang,
-      lodash: lodashConfig,
-      n,
-      perfectionist,
-      sonar,
-      stylistic,
-      tailwind,
-      unicorn,
-    },
-    rules: {
-      ${jsRulesJon}
+    name: "astro",
+    label: "Astro",
+    importString:
+      'import astroConfig from "@ethang/eslint-config/config.astro.js',
+    options: {
+      includeIgnores: true,
+      includeLanguageOptions: true,
+      extraImports: ['import tseslint from "typescript-eslint";'],
     },
   },
+];
+
+const reactFile = [
   {
-    files: ["**/*.md"],
-    plugins: {
-      markdown,
-    },
-    rules: {
-      ${markdownRulesJson}
+    name: "react",
+    label: "React",
+    importString:
+      'import reactConfig from "@ethang/eslint-config/config.react.js',
+    options: {
+      includeReactVersion: true,
+      includeIgnores: true,
+      includeLanguageOptions: true,
+      extraImports: ['import tseslint from "typescript-eslint";'],
     },
   },
+];
+
+const solidFile = [
   {
-    files: ["**/*.{json,jsonc,json5}"],
-    plugins: { json },
-    rules: {
-      ${jsonRulesJson}
+    name: "solid",
+    label: "Solid",
+    importString:
+      'import reactConfig from "@ethang/eslint-config/config.solid.js',
+    options: {
+      includeIgnores: true,
+      includeLanguageOptions: true,
+      extraImports: ['import tseslint from "typescript-eslint";'],
     },
   },
-);\n`;
+];
 
-  writeFileSync(
-    join(import.meta.dirname, "../eslint.config.js"),
-    configFile,
-    "utf8",
-  );
+export const secondaryRules = {
+  astro: astroFile,
+  react: reactFile,
+  solid: solidFile,
+};
+
+export const allRules = {
+  core: coreFile,
+  ...secondaryRules,
+};
+
+export const updateRules = async () => {
+  await Promise.all([
+    createConfigFile(coreFile, "eslint.config.js"),
+    createConfigFile(astroFile, "config.astro.js"),
+    createConfigFile(reactFile, "config.react.js"),
+    createConfigFile(solidFile, "config.solid.js"),
+  ]);
 };

package/build.mjs

@@ -2,9 +2,6 @@
 import { projectBuilder } from "@ethang/project-builder/project-builder.js";
 import { updateRules } from "./build/update-rules.js";
 import { updateReadme } from "./build/update-readme.js";
-import { updateReactRules } from "./build/update-react-rules.js";
-import { updateSolidRules } from "./build/update-solid-rules.js";
-import { updateAstroRules } from "./build/update-astro-rules.js";
 
 await projectBuilder("eslint-config-ethang", "master", {
   isLibrary: true,
@@ -12,9 +9,6 @@ await projectBuilder("eslint-config-ethang", "master", {
   postInstall: async () => {
     console.log("Updating Rules...");
     await updateRules();
-    await updateReactRules();
-    updateSolidRules();
-    updateAstroRules();
     updateReadme();
   },
   tsupOptions: {

package/config.astro.js

@@ -1,5 +1,4 @@
-import { ignores } from "./constants.js";
-import { languageOptions } from "./eslint.config.js";
+import { ignores, languageOptions } from "./constants.js";
 import astro from "eslint-plugin-astro";
 import tseslint from "typescript-eslint";
 
@@ -7,7 +6,9 @@ export default tseslint.config({
   files: ["**/*.{astro}"],
   ignores,
   languageOptions,
-  plugins: { astro },
+  plugins: {
+    astro: astro,
+  },
   rules: {
     "astro/missing-client-only-directive-value": "error",
     "astro/no-conflict-set-directives": "error",

package/config.react.js

@@ -1,5 +1,4 @@
-import { ignores } from "./constants.js";
-import { languageOptions } from "./eslint.config.js";
+import { ignores, languageOptions } from "./constants.js";
 import react from "@eslint-react/eslint-plugin";
 import reactHooks from "eslint-plugin-react-hooks";
 import tseslint from "typescript-eslint";
@@ -8,16 +7,14 @@ export default tseslint.config({
   files: ["**/*.{jsx,tsx}"],
   ignores,
   languageOptions,
-  plugins: {
-    react,
-    "react-hooks": reactHooks,
-  },
   settings: {
     react: { version: "18.3.1" },
   },
+  plugins: {
+    react: react,
+    "react-hooks": reactHooks,
+  },
   rules: {
-    "react-hooks/rules-of-hooks": "off",
-    "react-hooks/exhaustive-deps": "off",
     "react/avoid-shorthand-boolean": "off",
     "react/avoid-shorthand-fragment": "off",
     "react/ensure-forward-ref-using-ref": "error",
@@ -92,5 +89,7 @@ export default tseslint.config({
     "react/debug/function-component": "off",
     "react/debug/is-from-react": "off",
     "react/debug/react-hooks": "off",
+    "react-hooks/rules-of-hooks": "off",
+    "react-hooks/exhaustive-deps": "off",
   },
 });

package/config.solid.js

@@ -1,5 +1,4 @@
-import { ignores } from "./constants.js";
-import { languageOptions } from "./eslint.config.js";
+import { ignores, languageOptions } from "./constants.js";
 import solid from "eslint-plugin-solid";
 import tseslint from "typescript-eslint";
 
@@ -7,7 +6,9 @@ export default tseslint.config({
   files: ["**/*.{jsx,tsx}"],
   ignores,
   languageOptions,
-  plugins: { solid },
+  plugins: {
+    solid: solid,
+  },
   rules: {
     "solid/components-return-once": "error",
     "solid/event-handlers": "error",

package/constants.js

@@ -1 +1,11 @@
+import { parser } from "typescript-eslint";
+
 export const ignores = ["eslint.config.js", "node_modules", "dist"];
+
+export const languageOptions = {
+  parser,
+  parserOptions: {
+    project: true,
+    tsconfigRootDir: import.meta.dirname,
+  },
+};

package/eslint.config.js

@@ -1,4 +1,4 @@
-import { ignores } from "./constants.js";
+import { ignores, languageOptions } from "./constants.js";
 import a11y from "eslint-plugin-jsx-a11y/lib/index.js";
 import barrel from "eslint-plugin-barrel-files";
 import compat from "eslint-plugin-compat";
@@ -8,7 +8,6 @@ import json from "@eslint/json";
 import lodashConfig from "eslint-plugin-lodash";
 import markdown from "@eslint/markdown";
 import n from "eslint-plugin-n";
-import parser from "@typescript-eslint/parser";
 import perfectionist from "eslint-plugin-perfectionist";
 import sonar from "eslint-plugin-sonarjs";
 import stylistic from "@stylistic/eslint-plugin";
@@ -17,14 +16,6 @@ import tanstack from "@tanstack/eslint-plugin-query";
 import tseslint from "typescript-eslint";
 import unicorn from "eslint-plugin-unicorn";
 
-export const languageOptions = {
-  parser,
-  parserOptions: {
-    project: true,
-    tsconfigRootDir: import.meta.dirname,
-  },
-};
-
 export default tseslint.config(
   {
     files: ["**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts}"],
@@ -34,20 +25,20 @@ export default tseslint.config(
       react: { version: "18.3.1" },
     },
     plugins: {
-      "@tanstack/query": tanstack,
+      depend: depend,
+      barrel: barrel,
+      compat: compat,
+      n: n,
       "@typescript-eslint": tseslint.plugin,
-      a11y,
-      barrel,
-      compat,
-      depend,
-      ethang,
+      unicorn: unicorn,
       lodash: lodashConfig,
-      n,
-      perfectionist,
-      sonar,
-      stylistic,
-      tailwind,
-      unicorn,
+      sonar: sonar,
+      ethang: ethang,
+      "@tanstack/query": tanstack,
+      tailwind: tailwind,
+      stylistic: stylistic,
+      perfectionist: perfectionist,
+      a11y: a11y,
     },
     rules: {
       "depend/ban-dependencies": ["error", { allowed: ["lodash"] }],
@@ -118,7 +109,7 @@ export default tseslint.config(
       "no-dupe-else-if": "error",
       "no-dupe-keys": "error",
       "no-duplicate-case": "error",
-      "no-duplicate-imports": "off",
+      "no-duplicate-imports": "error",
       "no-else-return": "error",
       "no-empty": "error",
       "no-empty-character-class": "error",
@@ -309,7 +300,10 @@ export default tseslint.config(
       "@typescript-eslint/consistent-type-assertions": "error",
       "@typescript-eslint/consistent-type-definitions": ["error", "type"],
       "@typescript-eslint/consistent-type-exports": "error",
-      "@typescript-eslint/consistent-type-imports": "error",
+      "@typescript-eslint/consistent-type-imports": [
+        "error",
+        { fixStyle: "inline-type-imports" },
+      ],
       "@typescript-eslint/default-param-last": "error",
       "@typescript-eslint/dot-notation": "error",
       "@typescript-eslint/explicit-function-return-type": "off",
@@ -1260,7 +1254,7 @@ export default tseslint.config(
   {
     files: ["**/*.md"],
     plugins: {
-      markdown,
+      markdown: markdown,
     },
     rules: {
       "markdown/fenced-code-language": "error",
@@ -1274,7 +1268,9 @@ export default tseslint.config(
   },
   {
     files: ["**/*.{json,jsonc,json5}"],
-    plugins: { json },
+    plugins: {
+      json: json,
+    },
     rules: {
       "json/no-duplicate-keys": "error",
       "json/no-empty-keys": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethang/eslint-config",
-  "version": "19.2.8",
+  "version": "19.2.10",
   "repository": {
     "url": "git+https://github.com/eglove/eslint-config-ethang.git"
   },

package/setup/eslint.js

@@ -30,7 +30,6 @@ const changedRules = [
   { name: "max-params", rule: "off" },
   { name: "new-cap", rule: "off" },
   { name: "no-array-constructor", rule: "off" },
-  { name: "no-duplicate-imports", rule: "off" },
   { name: "no-empty-function", rule: "off" },
   { name: "no-implicit-globals", rule: "off" },
   { name: "no-implied-eval", rule: "off" },

package/setup/react.js

@@ -25,6 +25,9 @@ const customHookRules = [
 const hookGen = genRules(reactHookRuleNames, customHookRules, "react-hooks");
 
 export const reactRules = {
-  ...hookGen,
   ...reactGen,
 };
+
+export const reactHookRules = {
+  ...hookGen,
+};

package/setup/typescript-eslint.js

@@ -20,6 +20,10 @@ const customRules = [
     name: "consistent-type-definitions",
     rule: ["error", "type"],
   },
+  {
+    name: "consistent-type-imports",
+    rule: ["error", { fixStyle: "inline-type-imports" }],
+  },
   {
     name: "explicit-function-return-type",
     rule: "off",

package/build/update-astro-rules.js

@@ -1,39 +0,0 @@
-import { writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { astroRules } from "../setup/astro.js";
-
-export const updateAstroRules = () => {
-  let configFile = "";
-
-  const rulesJson = JSON.stringify(astroRules).slice(1, -1);
-
-  const importList = [
-    'import astro from "eslint-plugin-astro";',
-    'import tseslint from "typescript-eslint";',
-    'import { languageOptions } from "./eslint.config.js";',
-    'import { ignores } from "./constants.js";',
-  ].sort((a, b) => {
-    return a.localeCompare(b);
-  });
-
-  importList.forEach((item) => {
-    configFile += `${item}\n`;
-  });
-
-  configFile += `\nexport default tseslint.config({
-  files: ["**/*.{astro}"],
-  ignores,
-  languageOptions,
-  plugins: { astro },
-  rules: {
-    ${rulesJson}
-  },
-});
-`;
-
-  writeFileSync(
-    join(import.meta.dirname, "../config.astro.js"),
-    configFile,
-    "utf8",
-  );
-};

package/build/update-react-rules.js

@@ -1,51 +0,0 @@
-import { reactRules } from "../setup/react.js";
-import { writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { getLatestReact } from "./get-react-version.mjs";
-
-export const updateReactRules = async () => {
-  let configFile = "";
-  const react = await getLatestReact();
-  const settings = JSON.stringify({
-    react: { version: react.version },
-  }).slice(1, -1);
-
-  const rulesJson = JSON.stringify(reactRules).slice(1, -1);
-
-  const importList = [
-    'import react from "@eslint-react/eslint-plugin";',
-    'import reactHooks from "eslint-plugin-react-hooks";',
-    'import tseslint from "typescript-eslint";',
-    'import { languageOptions } from "./eslint.config.js";',
-    'import { ignores } from "./constants.js";',
-  ].sort((a, b) => {
-    return a.localeCompare(b);
-  });
-
-  importList.forEach((item) => {
-    configFile += `${item}\n`;
-  });
-
-  configFile += `\nexport default tseslint.config({
-  files: ["**/*.{jsx,tsx}"],
-  ignores,
-  languageOptions,
-  plugins: {
-    react,
-    "react-hooks": reactHooks,
-  },
-  settings: {
-    ${settings}
-  },
-  rules: {
-    ${rulesJson}
-  },
-});
-`;
-
-  writeFileSync(
-    join(import.meta.dirname, "../config.react.js"),
-    configFile,
-    "utf8",
-  );
-};

package/build/update-solid-rules.js

@@ -1,39 +0,0 @@
-import { solidRules } from "../setup/solid.js";
-import { writeFileSync } from "node:fs";
-import { join } from "node:path";
-
-export const updateSolidRules = () => {
-  let configFile = "";
-
-  const rulesJson = JSON.stringify(solidRules).slice(1, -1);
-
-  const importList = [
-    'import solid from "eslint-plugin-solid";',
-    'import tseslint from "typescript-eslint";',
-    'import { languageOptions } from "./eslint.config.js";',
-    'import { ignores } from "./constants.js";',
-  ].sort((a, b) => {
-    return a.localeCompare(b);
-  });
-
-  importList.forEach((item) => {
-    configFile += `${item}\n`;
-  });
-
-  configFile += `\nexport default tseslint.config({
-  files: ["**/*.{jsx,tsx}"],
-  ignores,
-  languageOptions,
-  plugins: { solid },
-  rules: {
-    ${rulesJson},
-  },
-});
-`;
-
-  writeFileSync(
-    join(import.meta.dirname, "../config.solid.js"),
-    configFile,
-    "utf8",
-  );
-};

package/update-rules.mjs

@@ -1,11 +0,0 @@
-import { updateRules } from "./build/update-rules.js";
-import { updateReactRules } from "./build/update-react-rules.js";
-import { updateSolidRules } from "./build/update-solid-rules.js";
-import { updateAstroRules } from "./build/update-astro-rules.js";
-import { updateReadme } from "./build/update-readme.js";
-
-await updateRules();
-await updateReactRules();
-updateSolidRules();
-updateAstroRules();
-updateReadme();