@ethang/eslint-config 19.11.3 → 19.11.5

package/README.md

@@ -5,14 +5,14 @@
 > [!CAUTION]
 > Do not use this with Prettier! Styling rules are included.
 
-- 895 errored rules.
+- 885 errored rules.
 - 294 rules from [eslint-plugin-sonarjs](https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md)
 - 144 rules from [@eslint/js](https://github.com/eslint/eslint/tree/main/packages/js)
 - 116 rules from [sindresorhus/eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn)
 - 103 rules from [@typescript/eslint](https://github.com/typescript-eslint/typescript-eslint)
 - 68 rules from [@stylistic/eslint-plugin](https://eslint.style/)
-- 42 rules from [eslint-plugin-lodash](https://github.com/wix-incubator/eslint-plugin-lodash)
 - 34 rules from [jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y)
+- 32 rules from [eslint-plugin-lodash](https://github.com/wix-incubator/eslint-plugin-lodash)
 - 25 rules from [@stylistic/eslint-plugin-ts](https://eslint.style/)
 - 20 rules from [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n)
 - 20 rules from [eslint-plugin-perfectionist](https://github.com/azat-io/eslint-plugin-perfectionist)

package/build/rule-list.ts

@@ -255,7 +255,7 @@ export const ruleList = [
     list: reactHookRules,
     name: "eslint-plugin-react-hooks",
     pluginName: "react-hooks",
-    pluginValue: "fixupPluginRules(reactHooks)", // TODO remove with v9 compat
+    pluginValue: "reactHooks",
     type: "react",
     url: "https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks",
   },

package/build/update-rules.ts

@@ -56,10 +56,7 @@ const reactFile = [
     label: "React",
     name: "react",
     options: {
-      extraImports: [
-        'import tseslint from "typescript-eslint";',
-        'import { fixupPluginRules } from "@eslint/compat";', // TODO remove with v9 compat
-      ],
+      extraImports: ['import tseslint from "typescript-eslint";'],
       includeIgnores: true,
       includeLanguageOptions: true,
       includeReactVersion: true,

package/config.react.js

@@ -1,4 +1,3 @@
-import { fixupPluginRules } from "@eslint/compat";
 import { ignores, languageOptions } from "./constants.js";
 import react from "@eslint-react/eslint-plugin";
 import reactHooks from "eslint-plugin-react-hooks";
@@ -13,7 +12,7 @@ export default tseslint.config({
   },
   plugins: {
     react: react,
-    "react-hooks": fixupPluginRules(reactHooks),
+    "react-hooks": reactHooks,
   },
   rules: {
     "react/avoid-shorthand-boolean": "off",

package/eslint.config.js

@@ -590,21 +590,21 @@ export default tseslint.config(
       "unicorn/text-encoding-identifier-case": "error",
       "unicorn/throw-new-error": "error",
       "lodash/callback-binding": "error",
-      "lodash/chain-style": ["error", "as-needed"],
+      "lodash/chain-style": [2, "as-needed"],
       "lodash/chaining": "error",
       "lodash/collection-method-value": "error",
       "lodash/collection-ordering": "error",
       "lodash/collection-return": "error",
-      "lodash/consistent-compose": ["error", "flow"],
-      "lodash/identity-shorthand": ["error", "always"],
-      "lodash/import-scope": ["error", "method"],
-      "lodash/matches-prop-shorthand": ["error", "always"],
-      "lodash/matches-shorthand": ["error", "always", 3],
+      "lodash/consistent-compose": [2, "flow"],
+      "lodash/identity-shorthand": [2, "always"],
+      "lodash/import-scope": [2, "method"],
+      "lodash/matches-prop-shorthand": [2, "always"],
+      "lodash/matches-shorthand": [2, "always", 3],
       "lodash/no-commit": "error",
       "lodash/no-double-unwrap": "error",
       "lodash/no-extra-args": "error",
       "lodash/no-unbound-this": "error",
-      "lodash/path-style": ["error", "array"],
+      "lodash/path-style": [2, "array"],
       "lodash/prefer-compact": "error",
       "lodash/prefer-constant": "error",
       "lodash/prefer-filter": "error",
@@ -612,7 +612,7 @@ export default tseslint.config(
       "lodash/prefer-flat-map": "error",
       "lodash/prefer-get": "error",
       "lodash/prefer-immutable-method": "error",
-      "lodash/prefer-includes": ["error", { includeNative: true }],
+      "lodash/prefer-includes": [2, { includeNative: true }],
       "lodash/prefer-invoke-map": "error",
       "lodash/prefer-is-nil": "error",
       "lodash/prefer-lodash-chain": "error",
@@ -623,13 +623,13 @@ export default tseslint.config(
       "lodash/prefer-noop": "error",
       "lodash/prefer-over-quantifier": "error",
       "lodash/prefer-reject": "error",
-      "lodash/prefer-some": ["error", { includeNative: true }],
+      "lodash/prefer-some": [2, { includeNative: true }],
       "lodash/prefer-startswith": "error",
       "lodash/prefer-thru": "error",
       "lodash/prefer-times": "error",
       "lodash/prefer-wrapper-method": "error",
       "lodash/preferred-alias": "error",
-      "lodash/prop-shorthand": ["error", "always"],
+      "lodash/prop-shorthand": [2, "always"],
       "lodash/unwrap": "error",
       "sonar/accessor-pairs": "error",
       "sonar/alt-text": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethang/eslint-config",
-  "version": "19.11.3",
+  "version": "19.11.5",
   "repository": {
     "url": "git+https://github.com/eglove/eslint-config-ethang.git"
   },
@@ -13,7 +13,7 @@
     "lint": "prettier . -w"
   },
   "dependencies": {
-    "@cspell/eslint-plugin": "^8.14.4",
+    "@cspell/eslint-plugin": "^8.15.0",
     "@eslint-react/eslint-plugin": "^1.14.3",
     "@eslint/compat": "^1.2.0",
     "@eslint/js": "^9.12.0",
@@ -33,7 +33,7 @@
     "eslint-plugin-lodash": "^8.0.0",
     "eslint-plugin-n": "^17.11.1",
     "eslint-plugin-perfectionist": "^3.8.0",
-    "eslint-plugin-react-hooks": "^4.6.2",
+    "eslint-plugin-react-hooks": "^5.0.0",
     "eslint-plugin-solid": "^0.14.3",
     "eslint-plugin-sonarjs": "2.0.3",
     "eslint-plugin-tailwindcss": "^3.17.5",
@@ -53,7 +53,7 @@
     "prettier": "^3.3.3"
   },
   "peerDependencies": {
-    "@cspell/eslint-plugin": "^8.14.4",
+    "@cspell/eslint-plugin": "^8.15.0",
     "@eslint-react/eslint-plugin": "^1.14.3",
     "@eslint/compat": "^1.2.0",
     "@eslint/js": "^9.12.0",
@@ -73,7 +73,7 @@
     "eslint-plugin-lodash": "^8.0.0",
     "eslint-plugin-n": "^17.11.1",
     "eslint-plugin-perfectionist": "^3.8.0",
-    "eslint-plugin-react-hooks": "^4.6.2",
+    "eslint-plugin-react-hooks": "^5.0.0",
     "eslint-plugin-solid": "^0.14.3",
     "eslint-plugin-sonarjs": "2.0.3",
     "eslint-plugin-tailwindcss": "^3.17.5",

package/setup/deprecated.ts

@@ -1,100 +1,13 @@
 import { type CustomRules, genRules } from "./gen-rules.ts";
+import { builtinRules } from "eslint/use-at-your-own-risk";
+
+let ruleNames: string[] = [];
+[...builtinRules.entries()].forEach(([key, rule]) => {
+  if (rule.meta?.deprecated === true) {
+    ruleNames.push(key);
+  }
+});
 
-const ruleNames = [
-  "array-bracket-newline",
-  "array-bracket-spacing",
-  "array-element-newline",
-  "arrow-parens",
-  "arrow-spacing",
-  "block-spacing",
-  "brace-style",
-  "callback-return",
-  "comma-dangle",
-  "comma-spacing",
-  "comma-style",
-  "computed-property-spacing",
-  "dot-location",
-  "eol-last",
-  "func-call-spacing",
-  "function-call-argument-newline",
-  "function-paren-newline",
-  "generator-star-spacing",
-  "global-require",
-  "handle-callback-err",
-  "id-blacklist",
-  "implicit-arrow-linebreak",
-  "indent",
-  "indent-legacy",
-  "jsx-quotes",
-  "key-spacing",
-  "keyword-spacing",
-  "line-comment-position",
-  "linebreak-style",
-  "lines-around-comment",
-  "lines-around-directive",
-  "lines-between-class-members",
-  "max-len",
-  "max-statements-per-line",
-  "multiline-comment-style",
-  "multiline-ternary",
-  "new-parens",
-  "newline-after-var",
-  "newline-before-return",
-  "newline-per-chained-call",
-  "no-buffer-constructor",
-  "no-catch-shadow",
-  "no-confusing-arrow",
-  "no-extra-parens",
-  "no-extra-semi",
-  "no-floating-decimal",
-  "no-mixed-operators",
-  "no-mixed-requires",
-  "no-mixed-spaces-and-tabs",
-  "no-multi-spaces",
-  "no-multiple-empty-lines",
-  "no-native-reassign",
-  "no-negated-in-lhs",
-  "no-new-object",
-  "no-new-require",
-  "no-new-symbol",
-  "no-path-concat",
-  "no-process-env",
-  "no-process-exit",
-  "no-restricted-modules",
-  "no-return-await",
-  "no-spaced-func",
-  "no-sync",
-  "no-tabs",
-  "no-trailing-spaces",
-  "no-whitespace-before-property",
-  "nonblock-statement-body-position",
-  "object-curly-newline",
-  "object-curly-spacing",
-  "object-property-newline",
-  "one-var-declaration-per-line",
-  "operator-linebreak",
-  "padded-blocks",
-  "padding-line-between-statements",
-  "prefer-reflect",
-  "quote-props",
-  "quotes",
-  "rest-spread-spacing",
-  "semi",
-  "semi-spacing",
-  "semi-style",
-  "space-before-blocks",
-  "space-before-function-paren",
-  "space-in-parens",
-  "space-infix-ops",
-  "space-unary-ops",
-  "spaced-comment",
-  "switch-colon-spacing",
-  "template-curly-spacing",
-  "template-tag-spacing",
-  "wrap-iife",
-  "wrap-regex",
-  "yield-star-spacing",
-];
 const customRules: CustomRules = [];
 
 export const deprecatedRules = genRules(

package/setup/lodash.ts

@@ -7,43 +7,43 @@ const ruleNames = Object.keys(getNonDeprecatedRules(lodash.rules));
 const customRules = [
   {
     name: "chain-style",
-    rule: ["error", "as-needed"],
+    rule: [2, "as-needed"],
   },
   {
     name: "consistent-compose",
-    rule: ["error", "flow"],
+    rule: [2, "flow"],
   },
   {
     name: "identity-shorthand",
-    rule: ["error", "always"],
+    rule: [2, "always"],
   },
   {
     name: "import-scope",
-    rule: ["error", "method"],
+    rule: [2, "method"],
   },
   {
     name: "matches-prop-shorthand",
-    rule: ["error", "always"],
+    rule: [2, "always"],
   },
   {
     name: "matches-shorthand",
-    rule: ["error", "always", 3],
+    rule: [2, "always", 3],
   },
   {
     name: "path-style",
-    rule: ["error", "array"],
+    rule: [2, "array"],
   },
   {
     name: "prefer-includes",
-    rule: ["error", { includeNative: true }],
+    rule: [2, { includeNative: true }],
   },
   {
     name: "prefer-some",
-    rule: ["error", { includeNative: true }],
+    rule: [2, { includeNative: true }],
   },
   {
     name: "prop-shorthand",
-    rule: ["error", "always"],
+    rule: [2, "always"],
   },
 ];
 

package/setup/react.ts

@@ -4,6 +4,7 @@ import reactHooks from "eslint-plugin-react-hooks";
 
 import { genRules, getNonDeprecatedRules } from "./gen-rules.ts";
 
+// @ts-expect-error ignore types
 const reactRuleNames = Object.keys(getNonDeprecatedRules(react.rules));
 const customReactRules = [
   {