@ethang/eslint-config 19.0.10 → 19.0.11

package/build/update-rules.js

@@ -14,6 +14,7 @@ import { perfectionistRules } from "../setup/perfectionist.js";
 import { a11yRules } from "../setup/a11y.js";
 import { readFileSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
+import { deprecatedRules } from "../setup/deprecated.js";
 
 export const updateRules = () => {
   const rules = {
@@ -31,6 +32,7 @@ export const updateRules = () => {
     ...stylisticRules,
     ...perfectionistRules,
     ...a11yRules,
+    ...deprecatedRules,
   };
 
   let jsonified = JSON.stringify(rules);

package/config.astro.js

@@ -1,7 +1,9 @@
 import astro from "eslint-plugin-astro";
 import tseslint from "typescript-eslint";
 
-import { ignores, languageOptions } from "./eslint.config.js";
+import { languageOptions } from "./eslint.config.js";
+import { ignores } from "./constants.js";
+import { astroRules } from "./setup/astro.js";
 
 export default tseslint.config({
   files: ["**/*.{astro}"],
@@ -9,56 +11,6 @@ export default tseslint.config({
   languageOptions,
   plugins: { astro },
   rules: {
-    "astro/jsx-a11y/alt-text": "error",
-    "astro/jsx-a11y/anchor-ambiguous-text": "error",
-    "astro/jsx-a11y/anchor-has-content": "error",
-    "astro/jsx-a11y/anchor-is-valid": "error",
-    "astro/jsx-a11y/aria-activedescendant-has-tabindex": "error",
-    "astro/jsx-a11y/aria-props": "error",
-    "astro/jsx-a11y/aria-proptypes": "error",
-    "astro/jsx-a11y/aria-role": "error",
-    "astro/jsx-a11y/aria-unsupported-elements": "error",
-    "astro/jsx-a11y/autocomplete-valid": "error",
-    "astro/jsx-a11y/click-events-have-key-events": "error",
-    "astro/jsx-a11y/control-has-associated-label": "error",
-    "astro/jsx-a11y/heading-has-content": "error",
-    "astro/jsx-a11y/html-has-lang": "error",
-    "astro/jsx-a11y/iframe-has-title": "error",
-    "astro/jsx-a11y/img-redundant-alt": "error",
-    "astro/jsx-a11y/interactive-supports-focus": "error",
-    "astro/jsx-a11y/label-has-associated-control": "error",
-    "astro/jsx-a11y/lang": "error",
-    "astro/jsx-a11y/media-has-caption": "error",
-    "astro/jsx-a11y/mouse-events-have-key-events": "error",
-    "astro/jsx-a11y/no-access-key": "error",
-    "astro/jsx-a11y/no-aria-hidden-on-focusable": "error",
-    "astro/jsx-a11y/no-autofocus": "error",
-    "astro/jsx-a11y/no-distracting-elements": "error",
-    "astro/jsx-a11y/no-interactive-element-to-noninteractive-role": "error",
-    "astro/jsx-a11y/no-noninteractive-element-interactions": "error",
-    "astro/jsx-a11y/no-noninteractive-element-to-interactive-role": "error",
-    "astro/jsx-a11y/no-noninteractive-tabindex": "error",
-    "astro/jsx-a11y/no-redundant-roles": "error",
-    "astro/jsx-a11y/no-static-element-interactions": "error",
-    "astro/jsx-a11y/prefer-tag-over-role": "error",
-    "astro/jsx-a11y/role-has-required-aria-props": "error",
-    "astro/jsx-a11y/role-supports-aria-props": "error",
-    "astro/jsx-a11y/scope": "error",
-    "astro/jsx-a11y/tabindex-no-positive": "error",
-    "astro/missing-client-only-directive-value": "error",
-    "astro/no-conflict-set-directives": "error",
-    "astro/no-deprecated-astro-canonicalurl": "error",
-    "astro/no-deprecated-astro-fetchcontent": "error",
-    "astro/no-deprecated-astro-resolve": "error",
-    "astro/no-deprecated-getentrybyslug": "error",
-    "astro/no-exports-from-components": "error",
-    "astro/no-set-text-directive": "error",
-    "astro/no-unused-css-selector": "error",
-    "astro/no-unused-define-vars-in-style": "error",
-    "astro/prefer-class-list-directive": "error",
-    "astro/prefer-object-class-list": "error",
-    "astro/prefer-split-class-list": "error",
-    "astro/semi": "error",
-    "astro/valid-compile": "error",
+    ...astroRules,
   },
 });

package/config.react.js

@@ -2,7 +2,9 @@ import react from "@eslint-react/eslint-plugin";
 import reactHooks from "eslint-plugin-react-hooks";
 import tseslint from "typescript-eslint";
 
-import { ignores, languageOptions } from "./eslint.config.js";
+import { languageOptions } from "./eslint.config.js";
+import { ignores } from "./constants.js";
+import { reactRules } from "./setup/react.js";
 
 export default tseslint.config({
   files: ["**/*.{jsx,tsx}"],
@@ -10,79 +12,9 @@ export default tseslint.config({
   languageOptions,
   plugins: {
     react,
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     "react-hooks": reactHooks,
   },
   rules: {
-    "react-hooks/exhaustive-deps": "off", // TODO fix w/ v9 compatibility
-    "react-hooks/rules-of-hooks": "off", // TODO fix w/ v9 compatibility
-    "react/dom/no-children-in-void-dom-elements": "error",
-    "react/dom/no-dangerously-set-innerhtml": "error",
-    "react/dom/no-dangerously-set-innerhtml-with-children": "error",
-    "react/dom/no-find-dom-node": "error",
-    "react/dom/no-missing-button-type": "error",
-    "react/dom/no-missing-iframe-sandbox": "error",
-    "react/dom/no-namespace": "error",
-    "react/dom/no-render-return-value": "error",
-    "react/dom/no-script-url": "error",
-    "react/dom/no-unsafe-iframe-sandbox": "error",
-    "react/dom/no-unsafe-target-blank": "error",
-    "react/ensure-forward-ref-using-ref": "error",
-    "react/hooks-extra/ensure-custom-hooks-using-other-hooks": "error",
-    "react/hooks-extra/ensure-use-callback-has-non-empty-deps": "error",
-    "react/hooks-extra/ensure-use-memo-has-non-empty-deps": "error",
-    "react/hooks-extra/no-direct-set-state-in-use-effect": "error",
-    "react/hooks-extra/no-direct-set-state-in-use-layout-effect": "error",
-    "react/hooks-extra/prefer-use-state-lazy-initialization": "error",
-    "react/naming-convention/component-name": "error",
-    "react/naming-convention/filename": ["error", { rule: "kebab-case" }],
-    "react/naming-convention/filename-extension": "error",
-    "react/naming-convention/use-state": "error",
-    "react/no-access-state-in-setstate": "error",
-    "react/no-array-index-key": "error",
-    "react/no-children-count": "error",
-    "react/no-children-for-each": "error",
-    "react/no-children-map": "error",
-    "react/no-children-only": "error",
-    "react/no-children-prop": "error",
-    "react/no-children-to-array": "error",
-    "react/no-class-component": "error",
-    "react/no-clone-element": "error",
-    "react/no-comment-textnodes": "error",
-    "react/no-complex-conditional-rendering": "error",
-    "react/no-complicated-conditional-rendering": "error",
-    "react/no-component-will-mount": "error",
-    "react/no-component-will-receive-props": "error",
-    "react/no-component-will-update": "error",
-    "react/no-create-ref": "error",
-    "react/no-default-props": "error",
-    "react/no-direct-mutation-state": "error",
-    "react/no-duplicate-key": "error",
-    "react/no-implicit-key": "error",
-    "react/no-leaked-conditional-rendering": "error",
-    "react/no-missing-component-display-name": "error",
-    "react/no-missing-key": "error",
-    "react/no-nested-components": "error",
-    "react/no-prop-types": "error",
-    "react/no-redundant-should-component-update": "error",
-    "react/no-set-state-in-component-did-mount": "error",
-    "react/no-set-state-in-component-did-update": "error",
-    "react/no-set-state-in-component-will-update": "error",
-    "react/no-string-refs": "error",
-    "react/no-unsafe-component-will-mount": "error",
-    "react/no-unsafe-component-will-receive-props": "error",
-    "react/no-unsafe-component-will-update": "error",
-    "react/no-unstable-context-value": "error",
-    "react/no-unstable-default-props": "error",
-    "react/no-unused-class-component-members": "error",
-    "react/no-unused-state": "error",
-    "react/no-useless-fragment": "error",
-    "react/prefer-destructuring-assignment": "error",
-    "react/prefer-read-only-props": "error",
-    "react/prefer-shorthand-boolean": "error",
-    "react/prefer-shorthand-fragment": "error",
-    "react/web-api/no-leaked-event-listener": "error",
-    "react/web-api/no-leaked-interval": "error",
-    "react/web-api/no-leaked-timeout": "error",
+    ...reactRules,
   },
 });

package/config.solid.js

@@ -1,7 +1,9 @@
 import solid from "eslint-plugin-solid";
 import tseslint from "typescript-eslint";
 
-import { ignores, languageOptions } from "./eslint.config.js";
+import { languageOptions } from "./eslint.config.js";
+import { ignores } from "./constants.js";
+import { solidRules } from "./setup/solid.js";
 
 export default tseslint.config({
   files: ["**/*.{jsx,tsx}"],
@@ -9,23 +11,6 @@ export default tseslint.config({
   languageOptions,
   plugins: { solid },
   rules: {
-    "solid/components-return-once": "error",
-    "solid/event-handlers": "error",
-    "solid/imports": "error",
-    "solid/jsx-no-duplicate-props": "error",
-    "solid/jsx-no-script-url": "error",
-    "solid/jsx-no-undef": "error",
-    "solid/jsx-uses-vars": "error",
-    "solid/no-array-handlers": "error",
-    "solid/no-destructure": "error",
-    "solid/no-innerhtml": "error",
-    "solid/no-react-deps": "error",
-    "solid/no-react-specific-props": "error",
-    "solid/no-unknown-namespaces": "error",
-    "solid/prefer-for": "error",
-    "solid/prefer-show": "error",
-    "solid/reactivity": "error",
-    "solid/self-closing-comp": "error",
-    "solid/style-prop": "error",
+    ...solidRules,
   },
 });

package/constants.js

@@ -0,0 +1 @@
+export const ignores = ["eslint.config.js", "node_modules", "dist"];

package/eslint.config.js

@@ -13,6 +13,7 @@ import compat from "eslint-plugin-compat";
 import lodashConfig from "eslint-plugin-lodash";
 import tailwind from "eslint-plugin-tailwindcss";
 import stylistic from "@stylistic/eslint-plugin";
+import { ignores } from "./constants.js";
 
 export const languageOptions = {
   parser,
@@ -22,8 +23,6 @@ export const languageOptions = {
   },
 };
 
-export const ignores = ["eslint.config.js", "node_modules", "dist"];
-
 export default tseslint.config({
   files: ["**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts}"],
   ignores,
@@ -1584,5 +1583,98 @@ export default tseslint.config({
     "a11y/role-supports-aria-props": "error",
     "a11y/scope": "error",
     "a11y/tabindex-no-positive": "error",
+    "array-bracket-newline": "off",
+    "array-bracket-spacing": "off",
+    "array-element-newline": "off",
+    "arrow-parens": "off",
+    "arrow-spacing": "off",
+    "block-spacing": "off",
+    "brace-style": "off",
+    "callback-return": "off",
+    "comma-dangle": "off",
+    "comma-spacing": "off",
+    "comma-style": "off",
+    "computed-property-spacing": "off",
+    "dot-location": "off",
+    "eol-last": "off",
+    "func-call-spacing": "off",
+    "function-call-argument-newline": "off",
+    "function-paren-newline": "off",
+    "generator-star-spacing": "off",
+    "global-require": "off",
+    "handle-callback-err": "off",
+    "id-blacklist": "off",
+    "implicit-arrow-linebreak": "off",
+    indent: "off",
+    "indent-legacy": "off",
+    "jsx-quotes": "off",
+    "key-spacing": "off",
+    "keyword-spacing": "off",
+    "line-comment-position": "off",
+    "linebreak-style": "off",
+    "lines-around-comment": "off",
+    "lines-around-directive": "off",
+    "lines-between-class-members": "off",
+    "max-len": "off",
+    "max-statements-per-line": "off",
+    "multiline-comment-style": "off",
+    "multiline-ternary": "off",
+    "new-parens": "off",
+    "newline-after-var": "off",
+    "newline-before-return": "off",
+    "newline-per-chained-call": "off",
+    "no-buffer-constructor": "off",
+    "no-catch-shadow": "off",
+    "no-confusing-arrow": "off",
+    "no-extra-parens": "off",
+    "no-extra-semi": "off",
+    "no-floating-decimal": "off",
+    "no-mixed-operators": "off",
+    "no-mixed-requires": "off",
+    "no-mixed-spaces-and-tabs": "off",
+    "no-multi-spaces": "off",
+    "no-multiple-empty-lines": "off",
+    "no-native-reassign": "off",
+    "no-negated-in-lhs": "off",
+    "no-new-object": "off",
+    "no-new-require": "off",
+    "no-new-symbol": "off",
+    "no-path-concat": "off",
+    "no-process-env": "off",
+    "no-process-exit": "off",
+    "no-restricted-modules": "off",
+    "no-return-await": "off",
+    "no-spaced-func": "off",
+    "no-sync": "off",
+    "no-tabs": "off",
+    "no-trailing-spaces": "off",
+    "no-whitespace-before-property": "off",
+    "nonblock-statement-body-position": "off",
+    "object-curly-newline": "off",
+    "object-curly-spacing": "off",
+    "object-property-newline": "off",
+    "one-var-declaration-per-line": "off",
+    "operator-linebreak": "off",
+    "padded-blocks": "off",
+    "padding-line-between-statements": "off",
+    "prefer-reflect": "off",
+    "quote-props": "off",
+    quotes: "off",
+    "rest-spread-spacing": "off",
+    semi: "off",
+    "semi-spacing": "off",
+    "semi-style": "off",
+    "space-before-blocks": "off",
+    "space-before-function-paren": "off",
+    "space-in-parens": "off",
+    "space-infix-ops": "off",
+    "space-unary-ops": "off",
+    "spaced-comment": "off",
+    "switch-colon-spacing": "off",
+    "template-curly-spacing": "off",
+    "template-tag-spacing": "off",
+    "wrap-iife": "off",
+    "wrap-regex": "off",
+    "yield-star-spacing": "off",
   },
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethang/eslint-config",
-  "version": "19.0.10",
+  "version": "19.0.11",
   "repository": {
     "url": "git+https://github.com/eglove/eslint-config-ethang.git"
   },

package/setup/astro.js

@@ -0,0 +1,7 @@
+import astro from "eslint-plugin-astro";
+import { genRules } from "./gen-rules.js";
+
+const ruleNames = Object.keys(astro.rules);
+const customRules = [{ name: "no-set-html-directive", rule: 'off"' }];
+
+export const astroRules = genRules(ruleNames, customRules, "astro");

package/setup/deprecated.js

@@ -0,0 +1,105 @@
+import { genRules } from "./gen-rules.js";
+
+const ruleNames = [
+  "array-bracket-newline",
+  "array-bracket-spacing",
+  "array-element-newline",
+  "arrow-parens",
+  "arrow-spacing",
+  "block-spacing",
+  "brace-style",
+  "callback-return",
+  "comma-dangle",
+  "comma-spacing",
+  "comma-style",
+  "computed-property-spacing",
+  "dot-location",
+  "eol-last",
+  "func-call-spacing",
+  "function-call-argument-newline",
+  "function-paren-newline",
+  "generator-star-spacing",
+  "global-require",
+  "handle-callback-err",
+  "id-blacklist",
+  "implicit-arrow-linebreak",
+  "indent",
+  "indent-legacy",
+  "jsx-quotes",
+  "key-spacing",
+  "keyword-spacing",
+  "line-comment-position",
+  "linebreak-style",
+  "lines-around-comment",
+  "lines-around-directive",
+  "lines-between-class-members",
+  "max-len",
+  "max-statements-per-line",
+  "multiline-comment-style",
+  "multiline-ternary",
+  "new-parens",
+  "newline-after-var",
+  "newline-before-return",
+  "newline-per-chained-call",
+  "no-buffer-constructor",
+  "no-catch-shadow",
+  "no-confusing-arrow",
+  "no-extra-parens",
+  "no-extra-semi",
+  "no-floating-decimal",
+  "no-mixed-operators",
+  "no-mixed-requires",
+  "no-mixed-spaces-and-tabs",
+  "no-multi-spaces",
+  "no-multiple-empty-lines",
+  "no-native-reassign",
+  "no-negated-in-lhs",
+  "no-new-object",
+  "no-new-require",
+  "no-new-symbol",
+  "no-path-concat",
+  "no-process-env",
+  "no-process-exit",
+  "no-restricted-modules",
+  "no-return-await",
+  "no-spaced-func",
+  "no-sync",
+  "no-tabs",
+  "no-trailing-spaces",
+  "no-whitespace-before-property",
+  "nonblock-statement-body-position",
+  "object-curly-newline",
+  "object-curly-spacing",
+  "object-property-newline",
+  "one-var-declaration-per-line",
+  "operator-linebreak",
+  "padded-blocks",
+  "padding-line-between-statements",
+  "prefer-reflect",
+  "quote-props",
+  "quotes",
+  "rest-spread-spacing",
+  "semi",
+  "semi-spacing",
+  "semi-style",
+  "space-before-blocks",
+  "space-before-function-paren",
+  "space-in-parens",
+  "space-infix-ops",
+  "space-unary-ops",
+  "spaced-comment",
+  "switch-colon-spacing",
+  "template-curly-spacing",
+  "template-tag-spacing",
+  "wrap-iife",
+  "wrap-regex",
+  "yield-star-spacing",
+];
+const customRules = [];
+
+export const deprecatedRules = genRules(
+  ruleNames,
+  customRules,
+  undefined,
+  "off",
+);

package/setup/gen-rules.js

@@ -2,16 +2,17 @@
  * @param {Array<String>} ruleNames
  * @param {Array<{name: string, rule: unknown}>} customRules
  * @param {string?} prefix
+ * @param {string?} defaultOverride
  * @return {Object}
  */
-export const genRules = (ruleNames, customRules, prefix) => {
+export const genRules = (ruleNames, customRules, prefix, defaultOverride) => {
   const rules = {};
 
   for (const rule of ruleNames) {
     if (prefix === undefined) {
-      rules[rule] = "error";
+      rules[rule] = defaultOverride ?? "error";
     } else {
-      rules[`${prefix}/${rule}`] = "error";
+      rules[`${prefix}/${rule}`] = defaultOverride ?? "error";
     }
   }
 

package/setup/react.js

@@ -0,0 +1,30 @@
+import react from "@eslint-react/eslint-plugin";
+import reactHooks from "eslint-plugin-react-hooks";
+import { genRules } from "./gen-rules.js";
+
+const reactRuleNames = Object.keys(react.rules);
+const customReactRules = [
+  { name: "avoid-shorthand-boolean", rule: "off" },
+  { name: "avoid-shorthand-fragment", rule: "off" },
+  { name: "debug/class-component", rule: "off" },
+  { name: "debug/function-component", rule: "off" },
+  { name: "debug/is-from-react", rule: "off" },
+  { name: "debug/react-hooks", rule: "off" },
+  {
+    name: "naming-convention/filename",
+    rule: ["error", { rule: "kebab-case" }],
+  },
+];
+const reactGen = genRules(reactRuleNames, customReactRules, "react");
+
+const reactHookRuleNames = Object.keys(reactHooks.rules);
+const customHookRules = [
+  { name: "exhaustive-deps", rule: "off" }, // TODO fix w/ v9 compatibility
+  { name: "rules-of-hooks", rule: "off" }, // TODO fix w/ v9 compatibility
+];
+const hookGen = genRules(reactHookRuleNames, customHookRules, "react-hooks");
+
+export const reactRules = {
+  ...hookGen,
+  ...reactGen,
+};

package/setup/solid.js

@@ -0,0 +1,10 @@
+import solid from "eslint-plugin-solid";
+import { genRules } from "./gen-rules.js";
+
+const ruleNames = Object.keys(solid.rules);
+const customRules = [
+  { name: "no-proxy-apis", rule: "off" },
+  { name: "prefer-classlist", rule: "off" },
+];
+
+export const solidRules = genRules(ruleNames, customRules, "solid");