@ethang/eslint-config 18.4.20 → 19.0.0

package/README.md

@@ -5,19 +5,19 @@
 Do **NOT** use this with Prettier! Styling rules are included.
 
 * 614 errored rules.
-* 142 rules from vanilla EsLint
+* 300 rules from [eslint-plugin-sonarjs](https://github.com/SonarSource/eslint-plugin-sonarjs)
+* 140 rules from vanilla EsLint
 * 113 rules from [sindresorhus/eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn)
-* 104 rules from [@typescript/eslint](https://github.com/typescript-eslint/typescript-eslint)
+* 103 rules from [@typescript/eslint](https://github.com/typescript-eslint/typescript-eslint)
 * 91 rules from [@stylistic/eslint-plugin](https://eslint.style/)
 * 42 rules from [eslint-plugin-lodash](https://github.com/wix-incubator/eslint-plugin-lodash)
 * 35 rules from [jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y)
-* 32 rules from [eslint-plugin-sonarjs](https://github.com/SonarSource/eslint-plugin-sonarjs)
 * 20 rules from [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n/tree/67bbfdf3c6862dcbfe455a4afbd83fa60f9d1ea4)
 * 20 rules from [eslint-plugin-github](https://github.com/github/eslint-plugin-github)
 * 19 rules from [eslint-plugin-perfectionist](https://github.com/azat-io/eslint-plugin-perfectionist)
 * 7 rules from [eslint-plugin-tailwindcss](https://github.com/francoismassart/eslint-plugin-tailwindcss)
 * 4 rules from [eslint-plugin-barrel-files](https://github.com/thepassle/eslint-plugin-barrel-files)
-* 3 rules from [@tanstack/eslint-plugin-query](https://tanstack.com/query/latest/docs/eslint/eslint-plugin-query)
+* 4 rules from [@tanstack/eslint-plugin-query](https://tanstack.com/query/latest/docs/eslint/eslint-plugin-query)
 * 1 rule from [eslint-plugin-depend](https://github.com/es-tooling/eslint-plugin-depend/tree/main)
 * 1 rule from [eslint-plugin-compat](https://github.com/amilajack/eslint-plugin-compat)
 

package/config.react.js

@@ -52,6 +52,8 @@ export default tseslint.config({
     "react/no-class-component": "error",
     "react/no-clone-element": "error",
     "react/no-comment-textnodes": "error",
+    "react/no-complex-conditional-rendering": "error",
+    "react/no-complicated-conditional-rendering": "error",
     "react/no-component-will-mount": "error",
     "react/no-component-will-receive-props": "error",
     "react/no-component-will-update": "error",
@@ -80,8 +82,10 @@ export default tseslint.config({
     "react/no-useless-fragment": "error",
     "react/prefer-destructuring-assignment": "error",
     "react/prefer-read-only-props": "error",
-
     "react/prefer-shorthand-boolean": "error",
     "react/prefer-shorthand-fragment": "error",
+    "react/web-api/no-leaked-event-listener": "error",
+    "react/web-api/no-leaked-interval": "error",
+    "react/web-api/no-leaked-timeout": "error",
   },
 });

package/eslint.config.js

@@ -25,7 +25,7 @@ export const languageOptions = {
 export const ignores = ["eslint.config.js", "node_modules", "dist"];
 
 export default tseslint.config({
-  files: ["**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts}"],
+  files: ["**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts,css,html}"],
   ignores,
   languageOptions,
   plugins: {
@@ -55,6 +55,8 @@ export default tseslint.config({
     "array-callback-return": "error",
     "arrow-body-style": ["error", "always"],
     "block-scoped-var": "error",
+    "camelcase": "off", // No
+    "capitalized-comments": "off", // No
     "constructor-super": "error",
     eqeqeq: "error",
     "for-direction": "error",
@@ -72,8 +74,8 @@ export default tseslint.config({
     "logical-assignment-operators": "error",
     "max-classes-per-file": "error",
     "max-depth": "error",
-    "max-lines": "error",
-    "max-lines-per-function": "error",
+    "max-lines": "off", // Handled by Sonar
+    "max-lines-per-function": "off", // Handled by Sonar
     "max-nested-callbacks": "error",
     "max-statements": "error",
     "no-alert": "error",
@@ -237,7 +239,7 @@ export default tseslint.config({
     "@typescript-eslint/default-param-last": "error",
     "@typescript-eslint/dot-notation": "error",
     "@typescript-eslint/explicit-member-accessibility": "error",
-    "@typescript-eslint/max-params": "error",
+    "@typescript-eslint/max-params": "off", // Handled by Sonar
     "@typescript-eslint/method-signature-style": "error",
     "@typescript-eslint/no-array-constructor": "error",
     "@typescript-eslint/no-array-delete": "error",
@@ -496,41 +498,315 @@ export default tseslint.config({
     "lodash/prop-shorthand": ["error", "always"],
     "lodash/unwrap": "error",
 
+    "sonar/accessor-pairs": "error",
+    "sonar/alt-text": "error",
+    "sonar/anchor-has-content": "error",
+    "sonar/anchor-is-valid": "error",
+    "sonar/anchor-precedence": "error",
+    "sonar/argument-type": "error",
+    "sonar/arguments-order": "error",
+    "sonar/arguments-usage": "error",
+    "sonar/array-callback-without-return": "error",
+    "sonar/array-constructor": "error",
+    "sonar/arrow-function-convention": "off", // Not handled by Sonar
+    "sonar/assertions-in-tests": "error",
+    "sonar/aws-apigateway-public-api": "error",
+    "sonar/aws-ec2-rds-dms-public": "error",
+    "sonar/aws-ec2-unencrypted-ebs-volume": "error",
+    "sonar/aws-efs-unencrypted": "error",
+    "sonar/aws-iam-all-privileges": "error",
+    "sonar/aws-iam-all-resources-accessible": "error",
+    "sonar/aws-iam-privilege-escalation": "error",
+    "sonar/aws-iam-public-access": "error",
+    "sonar/aws-opensearchservice-domain": "error",
+    "sonar/aws-rds-unencrypted-databases": "error",
+    "sonar/aws-restricted-ip-admin-access": "error",
+    "sonar/aws-s3-bucket-granted-access": "error",
+    "sonar/aws-s3-bucket-insecure-http": "error",
+    "sonar/aws-s3-bucket-public-access": "error",
+    "sonar/aws-s3-bucket-versioning": "error",
+    "sonar/aws-sagemaker-unencrypted-notebook": "error",
+    "sonar/aws-sns-unencrypted-topics": "error",
+    "sonar/aws-sqs-unencrypted-queue": "error",
+    "sonar/bitwise-operators": "error",
+    "sonar/bool-param-default": "error",
+    "sonar/call-argument-line": "error",
+    "sonar/certificate-transparency": "error",
+    "sonar/chai-determinate-assertion": "error",
+    "sonar/class-name": "error",
+    "sonar/class-prototype": "error",
+    "sonar/code-eval": "error",
     "sonar/cognitive-complexity": "error",
+    "sonar/comma-or-logical-or-case": "error",
+    "sonar/comment-regex": "off", // Rule template
+    "sonar/concise-regex": "error",
+    "sonar/confidential-information-logging": "error",
+    "sonar/constructor-for-side-effects": "error",
+    "sonar/content-length": "error",
+    "sonar/content-security-policy": "error",
+    "sonar/cookie-no-httponly": "error",
+    "sonar/cors": "error",
+    "sonar/csrf": "error",
+    "sonar/cyclomatic-complexity": "error",
+    "sonar/declarations-in-global-scope": "error",
+    "sonar/default-param-last": "error",
+    "sonar/deprecation": "error",
+    "sonar/destructuring-assignment-syntax": "error",
+    "sonar/different-types-comparison": "error",
+    "sonar/disabled-auto-escaping": "error",
+    "sonar/disabled-resource-integrity": "error",
+    "sonar/disabled-timeout": "error",
+    "sonar/duplicates-in-character-class": "error",
     "sonar/elseif-without-else": "error",
+    "sonar/empty-string-repetition": "error",
+    "sonar/encryption-secure-mode": "error",
+    "sonar/existing-groups": "error",
+    "sonar/expression-complexity": "error",
+    "sonar/file-header": "off", // No
+    "sonar/file-name-differ-from-class": "error",
+    "sonar/file-permissions": "error",
+    "sonar/file-uploads": "error",
+    "sonar/fixme-tag": "error",
+    "sonar/for-in": "error",
+    "sonar/for-loop-increment-sign": "error",
+    "sonar/frame-ancestors": "error",
+    "sonar/function-inside-loop": "error",
+    "sonar/function-name": "error",
+    "sonar/function-return-type": "error",
+    "sonar/future-reserved-words": "error",
+    "sonar/generator-without-yield": "error",
+    "sonar/hashing": "error",
+    "sonar/hidden-files": "error",
+    "sonar/hook-use-state": "error",
+    "sonar/html-has-lang": "error",
+    "sonar/in-operator-type-error": "error",
+    "sonar/inconsistent-function-call": "error",
+    "sonar/index-of-compare-to-positive-number": "error",
+    "sonar/insecure-cookie": "error",
+    "sonar/insecure-jwt-token": "error",
+    "sonar/inverted-assertion-arguments": "error",
+    "sonar/jsx-key": "error",
+    "sonar/jsx-no-constructed-context-values": "error",
+    "sonar/jsx-no-useless-fragment": "error",
+    "sonar/label-has-associated-control": "error",
+    "sonar/label-position": "error",
+    "sonar/link-with-target-blank": "error",
     "sonar/max-switch-cases": "error",
+    "sonar/max-union-size": "error",
+    "sonar/media-has-caption": "error",
+    "sonar/misplaced-loop-counter": "error",
+    "sonar/mouse-events-a11y": "error",
+    "sonar/nested-control-flow": "error",
+    "sonar/new-cap": "error",
+    "sonar/new-operator-misuse": "error",
+    "sonar/no-accessor-field-mismatch": "error",
     "sonar/no-all-duplicated-branches": "error",
+    "sonar/no-alphabetical-sort": "error",
+    "sonar/no-angular-bypass-sanitization": "error",
+    "sonar/no-array-delete": "error",
+    "sonar/no-array-index-key": "error",
+    "sonar/no-associative-arrays": "error",
+    "sonar/no-base-to-string": "error",
+    "sonar/no-built-in-override": "error",
+    "sonar/no-case-label-in-switch": "error",
+    "sonar/no-clear-text-protocols": "error",
+    "sonar/no-code-after-done": "error",
     "sonar/no-collapsible-if": "error",
     "sonar/no-collection-size-mischeck": "error",
+    "sonar/no-commented-code": "error",
+    "sonar/no-dead-store": "error",
+    "sonar/no-delete-var": "error",
+    "sonar/no-deprecated-react": "error",
     "sonar/no-duplicate-string": "error",
+    "sonar/no-duplicate-in-composite": "error",
     "sonar/no-duplicated-branches": "error",
     "sonar/no-element-overwrite": "error",
+    "sonar/no-empty-after-reluctant": "error",
+    "sonar/no-empty-alternatives": "error",
     "sonar/no-empty-collection": "error",
+    "sonar/no-empty-function": "error",
+    "sonar/no-empty-group": "error",
+    "sonar/no-empty-interface": "error",
+    "sonar/no-empty-test-file": "error",
+    "sonar/no-equals-in-for-termination": "error",
+    "sonar/no-exclusive-tests": "error",
+    "sonar/no-extend-native": "error",
     "sonar/no-extra-arguments": "error",
+    "sonar/no-find-dom-node": "error",
+    "sonar/no-for-in-iterable": "error",
+    "sonar/no-function-declaration-in-block": "error",
+    "sonar/no-global-this": "error",
+    "sonar/no-globals-shadowing": "error",
     "sonar/no-gratuitous-expressions": "error",
+    "sonar/no-hardcoded-credentials": "error",
+    "sonar/no-hardcoded-ip": "error",
+    "sonar/no-hook-setter-in-body": "error",
+    "sonar/no-ignored-exceptions": "error",
     "sonar/no-identical-conditions": "error",
     "sonar/no-identical-expressions": "error",
     "sonar/no-identical-functions": "error",
     "sonar/no-ignored-return": "error",
+    "sonar/no-implicit-dependencies": "off", // doesn't seem to work well, n/ can handle this
+    "sonar/no-implicit-global": "error",
+    "sonar/no-in-misuse": "error",
+    "sonar/no-incomplete-assertions": "error",
+    "sonar/no-inconsistent-returns": "error",
+    "sonar/no-incorrect-string-concat": "error",
+    "sonar/no-infinite-loop": "error",
+    "sonar/no-intrusive-permissions": "error",
+    "sonar/no-invalid-await": "error",
+    "sonar/no-invariant-returns": "error",
     "sonar/no-inverted-boolean-check": "error",
+    "sonar/no-ip-forward": "error",
+    "sonar/no-labels": "error",
+    "sonar/no-literal-call": "error",
+    "sonar/no-lonely-if": "error",
+    "sonar/no-mime-sniff": "error",
+    "sonar/no-misleading-array-reverse": "error",
+    "sonar/no-misused-promises": "error",
+    "sonar/no-mixed-content": "error",
+    "sonar/no-nested-assignment": "error",
+    "sonar/no-nested-conditional": "error",
+    "sonar/no-nested-functions": "error",
+    "sonar/no-nested-incdec": "error",
     "sonar/no-nested-switch": "error",
     "sonar/no-nested-template-literals": "error",
     "sonar/no-one-iteration-loop": "error",
+    "sonar/no-os-command-from-path": "error",
+    "sonar/no-parameter-reassignment": "error",
+    "sonar/no-primitive-wrappers": "error",
+    "sonar/no-redeclare": "error",
+    "sonar/no-redundant-assignments": "error",
     "sonar/no-redundant-boolean": "error",
     "sonar/no-redundant-jump": "error",
+    "sonar/no-redundant-optional": "error",
+    "sonar/no-redundant-type-constituents": "error",
+    "sonar/no-reference-error": "error",
+    "sonar/no-referrer-policy": "error",
+    "sonar/no-require-or-define": "error",
+    "sonar/no-return-type-any": "error",
+    "sonar/no-same-argument-assert": "error",
     "sonar/no-same-line-conditional": "error",
+    "sonar/no-self-compare": "error",
     "sonar/no-small-switch": "error",
+    "sonar/no-table-as-layout": "error",
+    "sonar/no-this-alias": "error",
+    "sonar/no-throw-literal": "error",
+    "sonar/no-try-promise": "error",
+    "sonar/no-undefined-argument": "error",
+    "sonar/no-undefined-assignment": "error",
+    "sonar/no-unenclosed-multiline-block": "error",
+    "sonar/no-uniq-key": "error",
+    "sonar/no-unknown-property": "error",
+    "sonar/no-unreachable": "error",
+    "sonar/no-unsafe": "error",
+    "sonar/no-unsafe-unzip": "error",
+    "sonar/no-unstable-nested-components": "error",
+    "sonar/no-unthrown-error": "error",
     "sonar/no-unused-collection": "error",
+    "sonar/no-unused-expressions": "error",
+    "sonar/no-unused-function-argument": "error",
+    "sonar/no-unused-private-class-members": "error",
     "sonar/no-use-of-empty-return-value": "error",
+    "sonar/no-useless-call": "error",
     "sonar/no-useless-catch": "error",
+    "sonar/no-useless-constructor": "error",
+    "sonar/no-useless-increment": "error",
+    "sonar/no-useless-intersection": "error",
+    "sonar/no-useless-react-setstate": "error",
+    "sonar/no-var": "error",
+    "sonar/no-variable-usage-before-declaration": "error",
+    "sonar/no-vue-bypass-sanitization": "error",
+    "sonar/no-weak-cipher": "error",
+    "sonar/no-weak-keys": "error",
+    "sonar/no-wildcard-import": "error",
     "sonar/non-existent-operator": "error",
+    "sonar/non-number-in-arithmetic-expression": "error",
+    "sonar/null-dereference": "error",
+    "sonar/object-alt-content": "error",
+    "sonar/object-shorthand": "error",
+    "sonar/operation-returning-nan": "error",
+    "sonar/os-command": "error",
+    "sonar/post-message": "error",
+    "sonar/prefer-default-last": "error",
+    "sonar/prefer-enum-initializers": "error",
+    "sonar/prefer-for-of": "error",
+    "sonar/prefer-function-type": "error",
     "sonar/prefer-immediate-return": "error",
+    "sonar/prefer-namespace-keyword": "error",
+    "sonar/prefer-nullish-coalescing": "error",
     "sonar/prefer-object-literal": "error",
+    "sonar/prefer-object-spread": "error",
+    "sonar/prefer-promise-shorthand": "error",
     "sonar/prefer-single-boolean-return": "error",
+    "sonar/prefer-spread": "error",
+    "sonar/prefer-string-starts-ends-with": "error",
+    "sonar/prefer-template": "error",
+    "sonar/prefer-type-guard": "error",
     "sonar/prefer-while": "error",
+    "sonar/production-debug": "error",
+    "sonar/pseudo-random": "error",
+    "sonar/public-static-readonly": "error",
+    "sonar/publicly-writable-directories": "error",
+    "sonar/reduce-initial-value": "error",
+    "sonar/redundant-type-aliases": "error",
+    "sonar/regex-complexity": "error",
+    "sonar/rules-of-hooks": "error",
+    "sonar/session-regeneration": "error",
+    "sonar/shorthand-property-grouping": "off", // Conflicts with perfectionist sorting
+    "sonar/single-char-in-character-classes": "error",
+    "sonar/single-character-alternation": "error",
+    "sonar/slow-regex": "error",
+    "sonar/sonar-block-scoped-var": "error",
+    "sonar/sonar-jsx-no-leaked-render": "error",
+    "sonar/sonar-max-lines": "error",
+    "sonar/sonar-max-lines-per-function": "error",
+    "sonar/sonar-max-params": "error",
+    "sonar/sonar-no-control-regex": "error",
+    "sonar/sonar-no-dupe-keys": "error",
+    "sonar/sonar-no-empty-character-class": "error",
+    "sonar/sonar-no-fallthrough": "error",
+    "sonar/sonar-no-invalid-regexp": "error",
+    "sonar/sonar-no-magic-numbers": "error",
+    "sonar/sonar-no-misleading-character-class": "error",
+    "sonar/sonar-no-regex-spaces": "error",
+    "sonar/sonar-no-unused-class-component-methods": "error",
+    "sonar/sonar-no-unused-vars": "error",
+    "sonar/sonar-prefer-optional-chain": "error",
+    "sonar/sonar-prefer-read-only-props": "error",
+    "sonar/sonar-prefer-regexp-exec": "error",
+    "sonar/sql-queries": "error",
+    "sonar/stable-tests": "error",
+    "sonar/stateful-regex": "error",
+    "sonar/strict-transport-security": "error",
+    "sonar/strings-comparison": "error",
+    "sonar/super-invocation": "error",
+    "sonar/switch-without-default": "error",
+    "sonar/table-header": "error",
+    "sonar/table-header-reference": "error",
+    "sonar/test-check-exception": "error",
+    "sonar/todo-tag": "error",
+    "sonar/too-many-break-or-continue-in-loop": "error",
+    "sonar/unicode-aware-regex": "error",
+    "sonar/unnecessary-character-escapes": "error",
+    "sonar/unused-import": "error",
+    "sonar/unused-named-groups": "error",
+    "sonar/unverified-certificate": "error",
+    "sonar/unverified-hostname": "error",
+    "sonar/updated-const-var": "error",
+    "sonar/updated-loop-counter": "error",
+    "sonar/use-isnan": "error",
+    "sonar/use-type-alias": "error",
+    "sonar/values-not-convertible-to-numbers": "error",
+    "sonar/variable-name": "error",
+    "sonar/void-use": "error",
+    "sonar/weak-ssl": "error",
+    "sonar/x-powered-by": "error",
+    "sonar/xml-parser-xxe": "error",
 
     "@tanstack/query/exhaustive-deps": "error",
     "@tanstack/query/no-rest-destructuring": "error",
+    "@tanstack/query/no-unstable-deps": "error",
     "@tanstack/query/stable-query-client": "error",
 
     "tailwind/classnames-order": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ethang/eslint-config",
-  "version": "18.4.20",
+  "version": "19.0.0",
   "repository": {
     "url": "git+https://github.com/eglove/eslint-config-ethang.git"
   },
@@ -16,10 +16,10 @@
   "author": "Ethan Glover",
   "license": "ISC",
   "peerDependencies": {
-    "@eslint-react/eslint-plugin": "^1.10.1",
+    "@eslint-react/eslint-plugin": "^1.12.1",
     "@eslint/js": "^9.9.0",
     "@stylistic/eslint-plugin": "^2.6.4",
-    "@tanstack/eslint-plugin-query": "^5.51.15",
+    "@tanstack/eslint-plugin-query": "^5.52.0",
     "@typescript-eslint/parser": "^8.2.0",
     "eslint": "^9.9.0",
     "eslint-plugin-astro": "^1.2.3",
@@ -32,17 +32,17 @@
     "eslint-plugin-perfectionist": "^3.2.0",
     "eslint-plugin-react-hooks": "^4.6.2",
     "eslint-plugin-solid": "^0.14.2",
-    "eslint-plugin-sonarjs": "1.0.4",
+    "eslint-plugin-sonarjs": "2.0.0",
     "eslint-plugin-tailwindcss": "^3.17.4",
     "eslint-plugin-unicorn": "^55.0.0",
     "typescript": "^5.5.4",
     "typescript-eslint": "^8.2.0"
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "^1.10.1",
+    "@eslint-react/eslint-plugin": "^1.12.1",
     "@eslint/js": "^9.9.0",
     "@stylistic/eslint-plugin": "^2.6.4",
-    "@tanstack/eslint-plugin-query": "^5.51.15",
+    "@tanstack/eslint-plugin-query": "^5.52.0",
     "@typescript-eslint/parser": "^8.2.0",
     "eslint": "^9.9.0",
     "eslint-plugin-astro": "^1.2.3",
@@ -55,7 +55,7 @@
     "eslint-plugin-perfectionist": "^3.2.0",
     "eslint-plugin-react-hooks": "^4.6.2",
     "eslint-plugin-solid": "^0.14.2",
-    "eslint-plugin-sonarjs": "1.0.4",
+    "eslint-plugin-sonarjs": "2.0.0",
     "eslint-plugin-tailwindcss": "^3.17.4",
     "eslint-plugin-unicorn": "^55.0.0",
     "typescript": "^5.5.4",