@estiva-app/ui 0.69.0 → 0.69.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@estiva-app/ui",
-  "version": "0.69.0",
+  "version": "0.69.1",
   "description": "Estiva's design tokens (the contract) and a small set of primitives (a convenience) for every Estiva app.",
   "type": "module",
   "license": "MIT",

package/registry.json

@@ -4,7 +4,7 @@
     "kind": "package",
     "repo": "estiva-ui",
     "package": "@estiva-app/ui",
-    "packageVersion": "0.69.0",
+    "packageVersion": "0.69.1",
     "exports": 162,
     "typeExports": 152,
     "files": null

package/src/LinkChips.mdx

@@ -48,7 +48,8 @@ LinkChips.configure({
   is asked about and becomes its chip at once, with the caret at its end, so
   **ReferenceMenu** can open its menu.
 - A URL in code or in a code block stays text, and so does a link on words.
-- Each URL is asked about once, and one editor asks about at most `limit`
+- Each URL is asked about once while the document holds it, and one editor
+  asks about at most `limit` of the URLs it holds unanswered at a time
   (24 by default), the first ones: an answer can cost the app a query.
 - A pasted URL's chip is its own undo step: undo gives the URL back, and a
   second undo takes the paste away. A typed URL's chip is not a step: undo

package/src/LinkChips.test.tsx

@@ -83,6 +83,23 @@ describe('LinkChips', () => {
     expect(asked).toEqual([['https://a.example/1', 'https://a.example/2']])
   })
 
+  it('counts its limit over the URLs the document holds: a message box keeps asking after the last message is sent', async () => {
+    const asked: string[][] = []
+    editor = new Editor({
+      extensions: [
+        StarterKit.configure({ link: false }),
+        BlockId,
+        ReferenceNode,
+        LinkChips.configure({ referenceOf: () => undefined, ask: (urls) => void asked.push(urls), limit: 2 }),
+      ],
+      content: para({ type: 'text', text: 'https://a.example/1 https://a.example/2 ' }),
+    })
+    await tick()
+    // Sent: the box is emptied, and the next message's links are asked about.
+    editor.commands.setContent(para({ type: 'text', text: 'https://a.example/3 ' }))
+    expect(asked).toEqual([['https://a.example/1', 'https://a.example/2'], ['https://a.example/3']])
+  })
+
   it('turns the URL into its chip once the answer comes back', async () => {
     const known = new Map<string, string>()
     const ed = make(para({ type: 'text', text: `See ${URL_} now` }), known)

package/src/LinkChips.ts

@@ -215,6 +215,10 @@ export const LinkChips = Extension.create<LinkChipsOptions>({
           const look = (state: EditorState) => {
             if (!options.ask) return
             const { open } = findLinkChips(state.doc, state.selection, options.referenceOf, key.getState(state)?.pasted)
+            // The limit counts the URLs the document still holds unanswered: a message box lives across many messages,
+            // and one that counted every URL it was ever asked would stop making chips after a day's links (OPT-19).
+            const waiting = new Set(open)
+            for (const url of asked) if (!waiting.has(url)) asked.delete(url)
             const fresh = open.filter((url) => !asked.has(url)).slice(0, Math.max(0, options.limit - asked.size))
             if (!fresh.length) return
             for (const url of fresh) asked.add(url)