@estebanforge/pi-ask-antigravity 1.3.3 → 1.3.4

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.3.4] - 2026-11-10
+
+### Added
+
+- **The AskAntigravity defaults dialog reports blocked-on-user-input while open.** Pi 1.5.1 lets overlay dialogs declare a blocked program status (OSC 7501); the dialog now passes it, so terminal automation watching the session sees pi waiting on input instead of idle. Pi dependency floor moved to ^1.5.1.
+
+### Changed
+- The finishing-window stop guard now reads the run's registry status instead of a wall-clock-aligned side set: same refusal behavior, and the test awaits the lifecycle transition instead of a fixed 250ms delay (flaked under full-suite load). Shared dependency floor moves to ^0.1.5 (`markFinishing`) once shared publishes.
+
+### Fixed
+- Windows: `agy models` discovery now resolves the binary like the shared runner does (native `.exe`/`.com` on `PATH`, explicit `AGY_BIN` paths honored, npm shims reported as unavailable instead of a cryptic spawn failure), and every run kills its process tree via `taskkill` instead of POSIX group signals that never fire on Windows.
+
 ## [1.3.3] - 2026-11-02
 
 ### Fixed

package/extensions/index.ts

@@ -41,7 +41,7 @@ import {
 } from "@earendil-works/pi-coding-agent";
 
 import { Text } from "@earendil-works/pi-tui";
-import { DIALOG_OPTIONS, DialogMenu, type DialogRow } from "@estebanforge/pi-tui-dialogs";
+import { DIALOG_OPTIONS, DialogMenu, dialogBlocked, type DialogRow } from "@estebanforge/pi-tui-dialogs";
 import { contentText } from "@earendil-works/pi-ai";
 import { Type } from "typebox";
 import {
@@ -65,6 +65,7 @@ import {
 	newConversationId,
 	parseModelLine,
 	resolveAgyModel,
+	resolveSpawnTarget,
 	RunSpawnError,
 	runProcess,
 	saveLayeredConfig,
@@ -350,9 +351,11 @@ const sleep = (ms: number) => new Promise<void>((r) => setTimeout(r, ms));
 
 /** Query `agy models`. Returns [] on any failure (non-fatal). */
 async function discoverModels(binary: string): Promise<ModelEntry[]> {
+	const target = resolveSpawnTarget(binary);
+	if (target.kind === "unavailable") return [];
 	try {
 		const text = await new Promise<string>((resolve, reject) => {
-			const proc = spawn(binary, ["models"], {
+			const proc = spawn(target.file, ["models"], {
 				stdio: ["ignore", "pipe", "ignore"],
 				shell: false,
 			});
@@ -691,7 +694,11 @@ function shapeFinalText(details: AgyDetails, outcome: ProcessRunOutcome, timeout
 	return text + footer;
 }
 
-export default async function (pi: ExtensionAPI) {
+export default async function (
+	pi: ExtensionAPI,
+	// Injectable so tests can await lifecycle phases; production uses the default.
+	registry: BackgroundRunRegistry = new BackgroundRunRegistry({ toolName: "ask-antigravity" }),
+) {
 	// If pi-antigravity-bridge is installed, it owns the AskAntigravity tool
 	// (and the provider). Stay silent and register nothing to avoid a
 	// duplicate-tool clash. Without the bridge, this extension behaves as
@@ -718,7 +725,6 @@ export default async function (pi: ExtensionAPI) {
 	// Pi wipes module state on /new, /resume, /fork and /reload: an in-flight
 	// background run is killed and its result is never delivered. Accepted
 	// trade-off, documented in the README.
-	const registry = new BackgroundRunRegistry({ toolName: "ask-antigravity" });
 	const kills = new Map<string, () => void>();
 	// Staged-artifact cleanup (contextFile + reviewer agent dir), keyed by run:
 	// the session_shutdown backstop runs these when a hard exit would skip the
@@ -727,10 +733,6 @@ export default async function (pi: ExtensionAPI) {
 	// One background run per conversationId at a time: two runs resuming the
 	// same conversation interleave their turns inside agy's SQLite state.
 	const busyHandles = new Set<string>();
-	// The child closed but the answer is not settled yet (discovery +
-	// classification): a stop in this window must refuse instead of settling
-	// failed and discarding a computed answer.
-	const finishing = new Set<string>();
 	const sendWake = createWakeSender(pi, {
 		customType: "ask-antigravity-result",
 		isDisposed: () => registry.isDisposed(),
@@ -746,9 +748,13 @@ export default async function (pi: ExtensionAPI) {
 				error: "stopped via /agy-stop",
 			}),
 		// The guard keeps /agy-stop from discarding an answer that already
-		// finished computing and is riding discovery to its wake.
+		// finished computing and is riding discovery to its wake. `finishing`
+		// lives in the registry (status set at child close), so the window is
+		// observable instead of wall-clock aligned.
 		guard: (run) =>
-			finishing.has(run.runId) ? `Run ${run.runId} already finished; its result is being delivered.` : null,
+			registry.get(run.runId)?.status === "finishing"
+				? `Run ${run.runId} already finished; its result is being delivered.`
+				: null,
 	});
 	pi.on("session_shutdown", () => {
 		// Latch first so close-handler wakes stay silent, then kill children,
@@ -858,7 +864,7 @@ export default async function (pi: ExtensionAPI) {
 						},
 					};
 				},
-				DIALOG_OPTIONS,
+				{ ...DIALOG_OPTIONS, blocked: dialogBlocked("AskAntigravity defaults") },
 			);
 
 			if (Object.keys(pending).length === 0) return;
@@ -993,7 +999,7 @@ export default async function (pi: ExtensionAPI) {
 			if (args.includeContext) tags.push("context=full");
 			if (args.background) tags.push("bg");
 
-			let text = theme.fg("mdLink", theme.bold("AskAntigravity "));
+			let text = theme.fg("success", theme.bold("AskAntigravity "));
 			text += `${theme.fg("accent", `[${tags.join(", ")}]`)} `;
 
 			const prompt = String(args.prompt ?? "");
@@ -1009,7 +1015,7 @@ export default async function (pi: ExtensionAPI) {
 			const d = result.details as AgyDetails | undefined;
 			if (isPartial) {
 				const status = result.content[0]?.type === "text" ? result.content[0].text : "working...";
-				return new Text(theme.fg("mdLink", "◉ AskAntigravity ") + theme.fg("muted", status), 0, 0);
+				return new Text(theme.fg("success", "◉ AskAntigravity ") + theme.fg("muted", status), 0, 0);
 			}
 
 			const body = result.content[0]?.type === "text" ? result.content[0].text : "";
@@ -1018,7 +1024,7 @@ export default async function (pi: ExtensionAPI) {
 
 			let text = errored
 				? theme.fg("error", "✗ AskAntigravity error")
-				: theme.fg("mdLink", "✓ AskAntigravity");
+				: theme.fg("success", "✓ AskAntigravity");
 
 			const rTags: string[] = [];
 			if (d?.resolvedModel || d?.model) rTags.push(`model=${d?.resolvedModel ?? d?.model}`);
@@ -1469,7 +1475,7 @@ export default async function (pi: ExtensionAPI) {
 			onSpawn: (kill) => {
 				kills.set(runId, kill);
 			},
-			onClose: () => finishing.add(runId),
+			onClose: () => registry.markFinishing(runId),
 		})
 			.then((outcome) => {
 				kills.delete(runId);
@@ -1514,7 +1520,6 @@ export default async function (pi: ExtensionAPI) {
 			})
 			.finally(() => {
 				cleanups.delete(runId);
-				finishing.delete(runId);
 				cleanupStaging();
 				if (o.conversationId) busyHandles.delete(o.conversationId);
 			});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@estebanforge/pi-ask-antigravity",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "Pi tool that delegates a self-contained sub-task to Google Antigravity's agy CLI (the CLI for Gemini). Friendly model aliases (flash/pro/gemini), configurable default model + thinking, and the AskAntigravity delegation tool.",
   "keywords": [
     "pi-package",
@@ -28,8 +28,8 @@
   },
   "type": "module",
   "dependencies": {
-    "@estebanforge/pi-ask-shared": "^0.1.3",
-    "@estebanforge/pi-tui-dialogs": "^0.1.1"
+    "@estebanforge/pi-ask-shared": "^0.1.5",
+    "@estebanforge/pi-tui-dialogs": "^0.1.3"
   },
   "files": [
     "extensions",
@@ -43,7 +43,7 @@
     ]
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "^1.5.0"
+    "@earendil-works/pi-coding-agent": "^1.5.1"
   },
   "peerDependenciesMeta": {
     "@earendil-works/pi-coding-agent": {